101103 2012-11-02 14:34:35 -0700 memory-instrumentation-cached-images.html is crashing 2012-11-02 14:55:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboxhall abarth abarth haraken japhet loislo pfeldman webkit.review.bot oldest_to_newest 757600 0 aboxhall 2012-11-02 14:34:35 -0700 It looks like one of these changes http://trac.webkit.org/log/?verbose=on&rev=133331&stop_rev=133330, most likely http://trac.webkit.org/changeset/133331, has caused inspector/profiler/memory-instrumentation-cached-images.html to start crashing. 757601 1 aboxhall 2012-11-02 14:35:05 -0700 Dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fprofiler%2Fmemory-instrumentation-cached-images.html 757614 2 abarth 2012-11-02 14:43:15 -0700 Thanks. I'll investigate now. 757620 3 172145 abarth 2012-11-02 14:50:41 -0700 Created attachment 172145 Patch 757623 4 abarth 2012-11-02 14:51:50 -0700 The UNUSED_PARAM macro is an attempt to avoid causing https://bugs.webkit.org/show_bug.cgi?id=100973#c9 757628 5 abarth 2012-11-02 14:55:06 -0700 Committed r133354: <http://trac.webkit.org/changeset/133354> 757630 6 172145 abarth 2012-11-02 14:55:48 -0700 Comment on attachment 172145 Patch I landed this patch without review because it just contains a line of code that was removed in a previous patch, so it's something of a partial rollout. 172145 2012-11-02 14:50:41 -0700 2012-11-02 14:55:48 -0700 Patch bug-101103-20121102144944.patch text/plain 1234 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzM1MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTAyICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgbWVtb3J5LWluc3RydW1lbnRhdGlv bi1jYWNoZWQtaW1hZ2VzLmh0bWwgaXMgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTEwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc3RvcmUgY29kZSBkZWxldGVkIGluIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEzMzMzMS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4 L0ludHJ1c2l2ZURPTVdyYXBwZXJNYXAuaDoKKwogMjAxMi0xMS0wMiAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgU1VCUElYRUxfTEFZT1VU IG9uIE1hYwpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvSW50cnVzaXZlRE9NV3Jh cHBlck1hcC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0ludHJ1 c2l2ZURPTVdyYXBwZXJNYXAuaAkocmV2aXNpb24gMTMzMzUyKQorKysgU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvSW50cnVzaXZlRE9NV3JhcHBlck1hcC5oCSh3b3JraW5nIGNvcHkpCkBAIC01 Nyw3ICs1Nyw4IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgdm9pZCByZXBvcnRNZW1vcnlVc2Fn ZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdCBPVkVSUklERQogICAg IHsKLSAgICAgICAgLy8gVGhpcyB0eXBlIG9mIHdyYXBwZXIgbWFwIGRvZXMgbm90IHVzZSBhbnkg YWRkaXRpb25hbCBtZW1vcnkuCisgICAgICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9i amVjdEluZm8sIHRoaXMsIFdlYkNvcmVNZW1vcnlUeXBlczo6QmluZGluZyk7CisgICAgICAgIFVO VVNFRF9QQVJBTShpbmZvKTsKICAgICB9CiAKIHByaXZhdGU6Cg==