101095 2012-11-02 13:36:20 -0700 [BlackBerry] Fix compile-time warning of a possible empty-body if statement 2012-11-02 14:32:26 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 757531 0 nima.ghanavatian 2012-11-02 13:36:20 -0700 SSIA 757542 1 172129 nima.ghanavatian 2012-11-02 13:48:53 -0700 Created attachment 172129 Patch 757552 2 172129 yong.li.webkit 2012-11-02 13:57:31 -0700 Comment on attachment 172129 Patch OK. but we really should fix BBLOG 757596 3 172129 webkit.review.bot 2012-11-02 14:32:23 -0700 Comment on attachment 172129 Patch Clearing flags on attachment: 172129 Committed r133348: <http://trac.webkit.org/changeset/133348> 757597 4 webkit.review.bot 2012-11-02 14:32:26 -0700 All reviewed patches have been landed. Closing bug. 172129 2012-11-02 13:48:53 -0700 2012-11-02 14:32:23 -0700 Patch bug-101095-20121102164209.patch text/plain 3393 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMzM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0MzJiMGNkNDVhMzc2OTg4NTA0ZTZhZGNmNjA4ZGRiOTRhNmI5NWM3Li42YzM3NTg5MGQ3 N2U3N2E2ZmIyYTllNjJhY2IxMGJhYzljNWIwOGYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyNCBAQAogMjAxMi0xMS0wMiAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgogCisgICAgICAgIFtCbGFja0JlcnJ5XSBGaXggY29tcGlsZS10 aW1lIHdhcm5pbmcgb2YgYSBwb3NzaWJsZSBlbXB0eS1ib2R5IGlmIHN0YXRlbWVudAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMDk1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIEludGVybmFsbHkgcmV2aWV3 ZWQgYnkgSmVmZiBSb2dlcnMuCisKKyAgICAgICAgQkJMT0cgbWlnaHQgYmUgY29tcGlsZWQgb3V0 IGxlYXZpbmcgYW4gaWYgc3RhdGVtZW50IHdpdGggYW4gZW1wdHkKKyAgICAgICAgYm9keS4gVGhp cyBpcyBnaXZpbmcgdXMgYSB3YXJuaW5nIGF0IHRoZSBtb21lbnQuIFNpbXBseSBwdXR0aW5nIGJy YWNlcworICAgICAgICBhcm91bmQgaXQgd2lsbCBmYWlsIGFzIHdlbGwgYmVjYXVzZSB0aGVuIHdl J2QgaGF2ZSBicmFjZXMgYXJvdW5kIGEKKyAgICAgICAgc2luZ2xlLWxpbmUgaWYuIFNvLCBpbiBm b2xsb3dpbmcgd2l0aCB0aGUgc3R5bGUgb2JzZXJ2ZWQgaW4gb3RoZXIgcGFydHMKKyAgICAgICAg b2YgQmFja2luZ1N0b3JlLmNwcCwgYnJlYWsgdXAgdGhlIGxvZyBtZXNzYWdlIGFuZCBhZGQgYnJh Y2VzLgorCisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChCbGFja0Jl cnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OmJsaXRUb1dpbmRvdyk6CisgICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVByaXZhdGU6OmZpbGxXaW5kb3cpOgor ICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpjbGVhcldp bmRvdyk6CisKKzIwMTItMTEtMDIgIE5pbWEgR2hhbmF2YXRpYW4gIDxuZ2hhbmF2YXRpYW5Acmlt LmNvbT4KKwogICAgICAgICBbQmxhY2tCZXJyeV0gT3B0aW1pemUgYmFja3NwYWNlIGtleSBoYW5k bGluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx MDgzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0 b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcApp bmRleCAzN2ZlNjA4YmZmYjI5OGE1YWMzNjI4NWY2YTM2ZDAzMzNiZDAxYTUxLi4wZGFjOWNiMzEy ZWU4YWViMDhhNGZmNTQ3Y2EwN2QxZTM3MTg0ZjNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCkBAIC0yMzMwLDggKzIzMzAsMTAgQEAgdm9pZCBC YWNraW5nU3RvcmVQcml2YXRlOjpibGl0VG9XaW5kb3coY29uc3QgUGxhdGZvcm06OkludFJlY3Qm IGRzdFJlY3QsCiAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIGRz dEJ1ZmZlciA9IGJ1ZmZlcigpOwogICAgIEFTU0VSVChkc3RCdWZmZXIpOwogICAgIEFTU0VSVChz cmNCdWZmZXIpOwotICAgIGlmICghZHN0QnVmZmVyKQotICAgICAgICBCQkxPRyhCbGFja0JlcnJ5 OjpQbGF0Zm9ybTo6TG9nTGV2ZWxXYXJuLCAiRW1wdHkgd2luZG93IGJ1ZmZlciwgY291bGRuJ3Qg YmxpdFRvV2luZG93Iik7CisgICAgaWYgKCFkc3RCdWZmZXIpIHsKKyAgICAgICAgQkJMT0coQmxh Y2tCZXJyeTo6UGxhdGZvcm06OkxvZ0xldmVsV2FybiwKKyAgICAgICAgICAgICJFbXB0eSB3aW5k b3cgYnVmZmVyLCBjb3VsZG4ndCBibGl0VG9XaW5kb3ciKTsKKyAgICB9CiAKICAgICBCbGFja0Jl cnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OkJsZW5kTW9kZSBibGVuZE1vZGUgPSBibGVuZAogICAg ICAgICA/IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGljczo6U291cmNlT3ZlcgpAQCAtMjM1 OSw4ICsyMzYxLDEwIEBAIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6ZmlsbFdpbmRvdyhQbGF0 Zm9ybTo6R3JhcGhpY3M6OkZpbGxQYXR0ZXJuIHBhdHRlcm4sCiAKICAgICBCbGFja0JlcnJ5OjpQ bGF0Zm9ybTo6R3JhcGhpY3M6OkJ1ZmZlciogZHN0QnVmZmVyID0gYnVmZmVyKCk7CiAgICAgQVNT RVJUKGRzdEJ1ZmZlcik7Ci0gICAgaWYgKCFkc3RCdWZmZXIpCi0gICAgICAgIEJCTE9HKEJsYWNr QmVycnk6OlBsYXRmb3JtOjpMb2dMZXZlbFdhcm4sICJFbXB0eSB3aW5kb3cgYnVmZmVyLCBjb3Vs ZG4ndCBmaWxsV2luZG93Iik7CisgICAgaWYgKCFkc3RCdWZmZXIpIHsKKyAgICAgICAgQkJMT0co QmxhY2tCZXJyeTo6UGxhdGZvcm06OkxvZ0xldmVsV2FybiwKKyAgICAgICAgICAgICJFbXB0eSB3 aW5kb3cgYnVmZmVyLCBjb3VsZG4ndCBmaWxsV2luZG93Iik7CisgICAgfQogCiAgICAgQmxhY2tC ZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpmaWxsQnVmZmVyKGRzdEJ1ZmZlciwgcGF0dGVybiwg ZHN0UmVjdCwgY29udGVudHNPcmlnaW4sIGNvbnRlbnRzU2NhbGUpOwogfQpAQCAtMjQ0NCw4ICsy NDQ4LDEwIEBAIHZvaWQgQmFja2luZ1N0b3JlUHJpdmF0ZTo6Y2xlYXJXaW5kb3coY29uc3QgUGxh dGZvcm06OkludFJlY3QmIHJlY3QsCiAKICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhp Y3M6OkJ1ZmZlciogZHN0QnVmZmVyID0gYnVmZmVyKCk7CiAgICAgQVNTRVJUKGRzdEJ1ZmZlcik7 Ci0gICAgaWYgKCFkc3RCdWZmZXIpCi0gICAgICAgIEJCTE9HKEJsYWNrQmVycnk6OlBsYXRmb3Jt OjpMb2dMZXZlbFdhcm4sICJFbXB0eSB3aW5kb3cgYnVmZmVyLCBjb3VsZG4ndCBjbGVhcldpbmRv dyIpOworICAgIGlmICghZHN0QnVmZmVyKSB7CisgICAgICAgIEJCTE9HKEJsYWNrQmVycnk6OlBs YXRmb3JtOjpMb2dMZXZlbFdhcm4sCisgICAgICAgICAgICAiRW1wdHkgd2luZG93IGJ1ZmZlciwg Y291bGRuJ3QgY2xlYXJXaW5kb3ciKTsKKyAgICB9CiAKICAgICB3aW5kb3dGcm9udEJ1ZmZlclN0 YXRlKCktPmNsZWFyQmxpdHRlZFJlZ2lvbihyZWN0KTsKICAgICB3aW5kb3dCYWNrQnVmZmVyU3Rh dGUoKS0+YWRkQmxpdHRlZFJlZ2lvbihyZWN0KTsK