101082 2012-11-02 12:05:36 -0700 [BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null. 2012-11-02 14:08:18 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 liachen webkit-unassigned joenotcharles mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 757437 0 liachen 2012-11-02 12:05:36 -0700 In ResourceHandleBlackBerry, ResourceHandle::cancel() doesn't call setClient(0), which could leave a window that its client can still be called, after it is cancelled. This should be avoided. 757508 1 172120 liachen 2012-11-02 13:02:42 -0700 Created attachment 172120 patch for 101082 757510 2 liachen 2012-11-02 13:03:42 -0700 + Yong, Joe, Rob. 757527 3 172120 yong.li.webkit 2012-11-02 13:31:30 -0700 Comment on attachment 172120 patch for 101082 I think it is good. ResourceLoader doesn't do this when it cancels the job: if (m_handle) { m_handle->cancel(); m_handle = 0; } 757560 4 172120 webkit.review.bot 2012-11-02 14:08:14 -0700 Comment on attachment 172120 patch for 101082 Clearing flags on attachment: 172120 Committed r133341: <http://trac.webkit.org/changeset/133341> 757561 5 webkit.review.bot 2012-11-02 14:08:18 -0700 All reviewed patches have been landed. Closing bug. 172120 2012-11-02 13:02:42 -0700 2012-11-02 14:08:14 -0700 patch for 101082 101082.patch text/plain 1748 liachen ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MGFmNWIxLi5kNTY0ZDQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMTEtMDIgIExpYW5naHVpIENoZW4gIDxsaWFjaGVuQHJpbS5jb20+CisKKyAgICAg ICAgW0JsYWNrQmVycnldIFJlc291cmNlSGFuZGxlOjpjYW5jZWwoKSBpbiBSZXNvdXJjZUhhbmRs ZUJsYWNrQmVycnkgc2hvdWxkIHNldENsaWVudCB0byBudWxsLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMDgyCisKKyAgICAgICAgSW50ZXJuYWwg UFI6IDIzNTQxMC4KKyAgICAgICAgUGF0Y2ggc3VnZ2VzdGVkIGJ5IEdlb3JnZSBTdGFpa29zLCBw cmVwYXJlZCBieSBMeW9uIENoZW4uCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFJlc291cmNlSGFuZGxlOjpjYW5jZWwoKSBzaG91bGQgY2FsbCBzZXRDbGll bnQoMCkgdG8gY2xvc2UgdGhlIHdpbmRvdworICAgICAgICBkdXJpbmcgd2hpY2ggaXQgaGFzIGJl ZW4gY2FuY2VsbGVkIGJ1dCBpdHMgY2xpZW50IGlzIHN0aWxsIHRoZXJlIGFuZCBjYW4KKyAgICAg ICAgYmUgY2FsbGVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyBpdCdzIGEgY29kZSBpbXBy b3ZlbWVudCB3aXRob3V0IG9idmlvdXMgYnVnLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L1Jlc291cmNlSGFuZGxlQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSZXNvdXJjZUhhbmRsZTo6Y2FuY2VsKToKKwogMjAxMi0xMS0wMiAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtWOF0gR2VuZXJhbGl6ZSBOb2RlV3JhcHBl ck1hcCB0byBiZSBhYmxlIHRvIGhhbmRsZSBvdGhlciBzb3J0cyBvZiBrZXlzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvUmVzb3VyY2VIYW5k bGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2ti ZXJyeS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnkuY3BwCmluZGV4IGZlMGRmNGUuLjJhNDA0NDUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9S ZXNvdXJjZUhhbmRsZUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZUhhbmRsZUJsYWNrQmVycnkuY3BwCkBAIC0xMzUs NiArMTM1LDcgQEAgYm9vbCBSZXNvdXJjZUhhbmRsZTo6d2lsbExvYWRGcm9tQ2FjaGUoUmVzb3Vy Y2VSZXF1ZXN0JiwgRnJhbWUqKQogdm9pZCBSZXNvdXJjZUhhbmRsZTo6Y2FuY2VsKCkKIHsKICAg ICBOZXR3b3JrTWFuYWdlcjo6aW5zdGFuY2UoKS0+c3RvcEpvYih0aGlzKTsKKyAgICBzZXRDbGll bnQoMCk7CiB9CiAKIHZvaWQgUmVzb3VyY2VIYW5kbGU6OmxvYWRSZXNvdXJjZVN5bmNocm9ub3Vz bHkoTmV0d29ya2luZ0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVx dWVzdCwgU3RvcmVkQ3JlZGVudGlhbHMsIFJlc291cmNlRXJyb3ImIGVycm9yLCBSZXNvdXJjZVJl c3BvbnNlJiByZXNwb25zZSwgVmVjdG9yPGNoYXI+JiBkYXRhKQo=