101070 2012-11-02 09:56:41 -0700 Move m_element checks out of canShareStyle into locateSharedStyle 2012-11-02 16:02:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric kling koivisto webkit.review.bot oldest_to_newest 757281 0 ojan 2012-11-02 09:56:41 -0700 Move m_element checks out of canShareStyle into locateSharedStyle 757284 1 172082 ojan 2012-11-02 09:59:05 -0700 Created attachment 172082 Patch 757288 2 ojan 2012-11-02 09:59:43 -0700 Just stumbled across this as I was looking at canShareStyleWithElement earlier today. 757289 3 172082 darin 2012-11-02 10:01:20 -0700 Comment on attachment 172082 Patch Looks logical. Ideally we would measure the performance improvement to also make sure there is no performance loss. It’s conceivable that this could make things slower in some cases even though it should make most things faster. 757291 4 eric 2012-11-02 10:05:53 -0700 canShareStyle* is quite hot (on the bechnmarks where we've gotten rid of more egregiously slow code. So anything we can do to make it faster is good. :) I trust our perf bots (http://webkit-perf.appspot.com/ and http://build.chromium.org/f/chromium/perf/dashboard/overview.html) will tell us if we did anything wrong. :) 757301 5 ojan 2012-11-02 10:19:35 -0700 Yeah. I don't actually expect this to have a meaningful performance impact in practice. I'll monitor the chromium perf dashboards though to be sure. 757336 6 ojan 2012-11-02 10:54:20 -0700 Committed r133315: <http://trac.webkit.org/changeset/133315> 757703 7 172082 darin 2012-11-02 16:01:39 -0700 Comment on attachment 172082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172082&action=review > Source/WebCore/css/StyleResolver.cpp:1217 > - if (!m_element->hasTagName(progressTag)) > - return false; > - > + ASSERT(!m_element->hasTagName(progressTag)); Wait, what? Is this assertion backwards? 757705 8 172082 darin 2012-11-02 16:02:21 -0700 Comment on attachment 172082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172082&action=review >> Source/WebCore/css/StyleResolver.cpp:1217 >> + ASSERT(!m_element->hasTagName(progressTag)); > > Wait, what? Is this assertion backwards? Oh, I see you noticed and fixed this later. 172082 2012-11-02 09:59:05 -0700 2012-11-02 16:02:21 -0700 Patch bug-101070-20121102165725.patch text/plain 3231 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMzA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRlMjRkOGRhZTE3Nzll OWM0ZDhkNWZlOThhNzRhMTcwYzZmYjY0Yy4uODhiOThiMjc2YmQyMjQ3Yzg1MjE4ODExN2M5MDlm OWNjNGQ3OTUzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTAyICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTW92ZSBtX2VsZW1lbnQgY2hl Y2tzIG91dCBvZiBjYW5TaGFyZVN0eWxlIGludG8gbG9jYXRlU2hhcmVkU3R5bGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTA3MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbiBzaGFyZVN0eWxlV2l0 aEVsZW1lbnQgaXMgY2FsbGVkIGZvciBlYWNoIHNpYmxpbmcgYXMgd2UgbG9vayBmb3IgYQorICAg ICAgICBzaGFyZUVsZW1lbnQuIGxvY2F0ZVNoYXJlZFN0eWxlIGlzIGNhbGxlZCBvbmNlIGZvciB0 aGUgZWxlbWVudCB3ZSdyZQorICAgICAgICB0cnlpbmcgdG8gZmluZCBhIHN0eWxlIGZvci4gQ2hl Y2tzIHRoYXQgb25seSBkZXBlbmQgb24gdGhlIGxhdHRlcgorICAgICAgICBlbGVtZW50IHNob3Vs ZCwgdGh1cyBiZSBpbiBsb2NhdGVTaGFyZWRTdHlsZS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IFRoZXJlIHNob3VsZCBiZSBubyBjaGFuZ2UgaW4gYmVoYXZpb3IsIGV4Y2VwdCBwb3NzaWJseQor ICAgICAgICBhIHBlcmZvcm1hbmNlIGltcHJvdmVtZW50IGluIHNvbWUgY2FzZXMuCisKKyAgICAg ICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZVJlc29s dmVyOjpjYW5TaGFyZVN0eWxlV2l0aEVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGVS ZXNvbHZlcjo6bG9jYXRlU2hhcmVkU3R5bGUpOgorCiAyMDEyLTExLTAyICBCYWxhenMgS2VsZW1l biAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdW1dLMl0gc2V0UGxhdGZvcm1T dHJhdGVnaWVzIGFsd2F5cyBhc3NlcnRzIGFmdGVyIHIxMzI3NDQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmNwcAppbmRleCAxYjcyZjJmZmRmNGRjNmEwNTg4NjE5ZTA4NmE1OTcyMGFhMGJk NWM1Li43Zjc5ODAyNzRjNDMxNzM5OGI3YWIyMTZmNzY1OTE4M2Y1ZjFlN2RkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCkBAIC0xMTk5LDggKzExOTksNiBAQCBib29sIFN0eWxl UmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRoRWxlbWVudChTdHlsZWRFbGVtZW50KiBlbGVtZW50 KSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKGVsZW1lbnQgPT0gZWxlbWVu dC0+ZG9jdW1lbnQoKS0+Y3NzVGFyZ2V0KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBp ZiAobV9lbGVtZW50ID09IG1fZWxlbWVudC0+ZG9jdW1lbnQoKS0+Y3NzVGFyZ2V0KCkpCi0gICAg ICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShYTUxO YW1lczo6bGFuZ0F0dHIpICE9IG1fZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShYTUxOYW1lczo6 bGFuZ0F0dHIpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKGVsZW1lbnQtPmZhc3RH ZXRBdHRyaWJ1dGUobGFuZ0F0dHIpICE9IG1fZWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShsYW5n QXR0cikpCkBAIC0xMjE2LDkgKzEyMTQsNyBAQCBib29sIFN0eWxlUmVzb2x2ZXI6OmNhblNoYXJl U3R5bGVXaXRoRWxlbWVudChTdHlsZWRFbGVtZW50KiBlbGVtZW50KSBjb25zdAogCiAjaWYgRU5B QkxFKFBST0dSRVNTX0VMRU1FTlQpCiAgICAgaWYgKGVsZW1lbnQtPmhhc1RhZ05hbWUocHJvZ3Jl c3NUYWcpKSB7Ci0gICAgICAgIGlmICghbV9lbGVtZW50LT5oYXNUYWdOYW1lKHByb2dyZXNzVGFn KSkKLSAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLQorICAgICAgICBBU1NFUlQoIW1fZWxlbWVu dC0+aGFzVGFnTmFtZShwcm9ncmVzc1RhZykpOwogICAgICAgICBIVE1MUHJvZ3Jlc3NFbGVtZW50 KiB0aGlzUHJvZ3Jlc3NFbGVtZW50ID0gc3RhdGljX2Nhc3Q8SFRNTFByb2dyZXNzRWxlbWVudCo+ KGVsZW1lbnQpOwogICAgICAgICBIVE1MUHJvZ3Jlc3NFbGVtZW50KiBvdGhlclByb2dyZXNzRWxl bWVudCA9IHN0YXRpY19jYXN0PEhUTUxQcm9ncmVzc0VsZW1lbnQqPihtX2VsZW1lbnQpOwogICAg ICAgICBpZiAodGhpc1Byb2dyZXNzRWxlbWVudC0+aXNEZXRlcm1pbmF0ZSgpICE9IG90aGVyUHJv Z3Jlc3NFbGVtZW50LT5pc0RldGVybWluYXRlKCkpCkBAIC0xMjU1LDcgKzEyNTEsNyBAQCBib29s IFN0eWxlUmVzb2x2ZXI6OmNhblNoYXJlU3R5bGVXaXRoRWxlbWVudChTdHlsZWRFbGVtZW50KiBl bGVtZW50KSBjb25zdAogICAgICAgICByZXR1cm4gZmFsc2U7CiAjZW5kaWYKIAotICAgIGlmIChl bGVtZW50SGFzRGlyZWN0aW9uQXV0byhlbGVtZW50KSB8fCBlbGVtZW50SGFzRGlyZWN0aW9uQXV0 byhtX2VsZW1lbnQpKQorICAgIGlmIChlbGVtZW50SGFzRGlyZWN0aW9uQXV0byhlbGVtZW50KSkK ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgaWYgKGVsZW1lbnQtPmhhc0NsYXNzKCkpIHsK QEAgLTEzMjEsNiArMTMxNywxMCBAQCBSZW5kZXJTdHlsZSogU3R5bGVSZXNvbHZlcjo6bG9jYXRl U2hhcmVkU3R5bGUoKQogICAgICAgICByZXR1cm4gMDsKICAgICBpZiAobV9zdHlsZWRFbGVtZW50 LT5oYXNTY29wZWRIVE1MU3R5bGVDaGlsZCgpKQogICAgICAgICByZXR1cm4gMDsKKyAgICBpZiAo bV9lbGVtZW50ID09IG1fZWxlbWVudC0+ZG9jdW1lbnQoKS0+Y3NzVGFyZ2V0KCkpCisgICAgICAg IHJldHVybiAwOworICAgIGlmIChlbGVtZW50SGFzRGlyZWN0aW9uQXV0byhtX2VsZW1lbnQpKQor ICAgICAgICByZXR1cm4gMDsKIAogICAgIC8vIENoZWNrIHByZXZpb3VzIHNpYmxpbmdzIGFuZCB0 aGVpciBjb3VzaW5zLgogICAgIHVuc2lnbmVkIGNvdW50ID0gMDsK