101061 2012-11-02 08:39:35 -0700 [EFL][WK2]Minibrowser forgets http variables when url includes ampersand 2012-11-06 04:15:00 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jussi.kukkonen jussi.kukkonen cdumez gyuyoung.kim jussi.kukkonen kenneth webkit.review.bot oldest_to_newest 757216 0 jussi.kukkonen 2012-11-02 08:39:35 -0700 It seems Elementary entry thinks it's supposed to mangle input and output. If user inputs an ampersand sign, that is turned into "&amp;" in the elm_entry_entry_get() output. This will in effect drop every http variable after the first. I'll attach a patch. 757227 1 172068 jussi.kukkonen 2012-11-02 08:51:27 -0700 Created attachment 172068 Patch 757231 2 jussi.kukkonen 2012-11-02 08:57:23 -0700 It seems it's not possible to tell the entry we don't need this entry processing: I just asked on #e and using markup_to_utf8 is apparently the correct way to handle this. 757244 3 172068 cdumez 2012-11-02 09:06:55 -0700 Comment on attachment 172068 Patch Have you tried: elm_object_part_text_get(entry, "default") / elm_object_part_text_set(entry, "default", url) ? 758320 4 jussi.kukkonen 2012-11-05 01:17:35 -0800 (In reply to comment #3) > (From update of attachment 172068 [details]) > Have you tried: > elm_object_part_text_get(entry, "default") / elm_object_part_text_set(entry, "default", url) ? This feature is actually implemented in elm_object IIRC so that probably won't help. I'll test anyway. 758418 5 jussi.kukkonen 2012-11-05 04:20:46 -0800 (In reply to comment #4) > This feature is actually implemented in elm_object IIRC so that probably won't help. Confirming that elm_object_part_text_get/set works the same way, it returns the escaped string which we do not want. 758420 6 cdumez 2012-11-05 04:24:18 -0800 (In reply to comment #5) > (In reply to comment #4) > > This feature is actually implemented in elm_object IIRC so that probably won't help. > > Confirming that elm_object_part_text_get/set works the same way, it returns the escaped string which we do not want. Ok, thanks for checking. LGTM then. 759515 7 172068 webkit.review.bot 2012-11-06 04:14:56 -0800 Comment on attachment 172068 Patch Clearing flags on attachment: 172068 Committed r133585: <http://trac.webkit.org/changeset/133585> 759516 8 webkit.review.bot 2012-11-06 04:15:00 -0800 All reviewed patches have been landed. Closing bug. 172068 2012-11-02 08:51:27 -0700 2012-11-06 04:14:56 -0800 Patch bug-101061-20121102174946.patch text/plain 2111 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzAwMjNjYzZhYTNlYmQ3YTA2YTA2OTczM2M2NjVkNTg2 MGMxZjIzYi4uYWQxOTk2ZmRiNTQ0YzAzNTNjOWRlNWRiYzFkMjJkYTRhYzc5ZDBjMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTExLTAyICBKdXNzaSBLdWtrb25lbiAgPGp1c3NpLmt1a2tvbmVuQGludGVsLmNv bT4KKworICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93c2VyIGZvcmdldHMgaHR0cCB2YXJpYWJs ZXMgd2hlbiB1cmwgaW5jbHVkZXMgYW1wZXJzYW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEwNjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBFbGVtZW50YXJ5IGVudHJ5IG9ubHkgcmV0dXJucyAnbWFy a3VwJyB0ZXh0LCBtZWFuaW5nIGFtcGVyc2FuZHMKKyAgICAgICAgaW4gYSB1cmwgd2lsbCBiZWNv bWUgIiZhbXA7Ii4gVXNlIGVsbV9lbnRyeV9tYXJrdXBfdG9fdXRmOCgpIGFuZAorICAgICAgICBl bG1fZW50cnlfdXRmOF90b19tYXJrdXAoKSB3aGVuIGludGVyYWN0aW5nIHdpdGggdGhlIGVudHJ5 LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKG9uX3VybF9j aGFuZ2VkKToKKyAgICAgICAgKG9uX3VybF9iYXJfYWN0aXZhdGVkKToKKwogMjAxMi0xMS0wMiAg Sm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAZGlnaWEuY29tPgogCiAgICAgICAg IFtRdF0gV1RSOiBNYWtlIHN1cmUgdGhhdCBldmVudFNlbmRlci5tb3VzZURvd24gc2VuZHMgYSBw cmVzcyBldmVudCBmb3IgdGhlIHNlY29uZCBwcmVzcwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJy b3dzZXIvZWZsL21haW4uYyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKaW5kZXggNzUz YWE2ZWIxOWQ0ZmE0OTcyYTRiNjc5YmVlMGZkNTEyYzRjNjlkMC4uNjBjN2Q5M2E5ZjZiMTMzY2Zh OGY2OGYwN2ZiODk4ZGFhYjIxYzMyMCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYworKysgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC0yMzEsNyArMjMx LDExIEBAIHN0YXRpYyB2b2lkCiBvbl91cmxfY2hhbmdlZCh2b2lkICp1c2VyX2RhdGEsIEV2YXNf T2JqZWN0ICp3ZWJ2aWV3LCB2b2lkICpldmVudF9pbmZvKQogewogICAgIEJyb3dzZXJfV2luZG93 ICp3aW5kb3cgPSAoQnJvd3Nlcl9XaW5kb3cgKil1c2VyX2RhdGE7Ci0gICAgZWxtX2VudHJ5X2Vu dHJ5X3NldCh3aW5kb3ctPnVybF9iYXIsIGV3a192aWV3X3VybF9nZXQod2luZG93LT53ZWJ2aWV3 KSk7CisKKyAgICBjaGFyICp1cmwgPSBlbG1fZW50cnlfdXRmOF90b19tYXJrdXAoZXdrX3ZpZXdf dXJsX2dldCh3aW5kb3ctPndlYnZpZXcpKTsKKyAgICBlbG1fZW50cnlfZW50cnlfc2V0KHdpbmRv dy0+dXJsX2JhciwgdXJsKTsKKworICAgIGZyZWUodXJsKTsKIH0KIAogc3RhdGljIHZvaWQKQEAg LTQ1Myw5ICs0NTcsMTIgQEAgb25fdXJsX2Jhcl9hY3RpdmF0ZWQodm9pZCAqdXNlcl9kYXRhLCBF dmFzX09iamVjdCAqdXJsX2Jhciwgdm9pZCAqZXZlbnRfaW5mbykKIHsKICAgICBCcm93c2VyX1dp bmRvdyAqYXBwX2RhdGEgPSAoQnJvd3Nlcl9XaW5kb3cgKil1c2VyX2RhdGE7CiAKLSAgICBjb25z dCBjaGFyICp1c2VyX3VybCA9IGVsbV9lbnRyeV9lbnRyeV9nZXQodXJsX2Jhcik7CisgICAgY29u c3QgY2hhciAqbWFya3VwX3VybCA9IGVsbV9lbnRyeV9lbnRyeV9nZXQodXJsX2Jhcik7CisgICAg Y2hhciAqdXNlcl91cmwgPSBlbG1fZW50cnlfbWFya3VwX3RvX3V0ZjgobWFya3VwX3VybCk7CiAg ICAgY2hhciAqdXJsID0gdXJsX2Zyb21fdXNlcl9pbnB1dCh1c2VyX3VybCk7CiAgICAgZXdrX3Zp ZXdfdXJsX3NldChhcHBfZGF0YS0+d2VidmlldywgdXJsKTsKKworICAgIGZyZWUodXNlcl91cmwp OwogICAgIGZyZWUodXJsKTsKIAogICAgIC8qIEdpdmUgZm9jdXMgYmFjayB0byB0aGUgdmlldyAq Lwo=