101054 2012-11-02 08:12:30 -0700 [V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields 2012-11-12 23:00:03 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 101078 101190 101212 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 757201 0 haraken 2012-11-02 08:12:30 -0700 I'm investigating a Chromium crash bug: http://code.google.com/p/chromium/issues/detail?id=155942 I've not yet identified the root cause (because I can't reproduce it), but it looks like we are storing NULL pointers to V8 internal fields. Just in case, we can add an ASSERT() to guarantee that NULL pointers are never stored. (Also I'm hoping that this ASSERT() will give me more debug information.) 757204 1 172063 haraken 2012-11-02 08:16:53 -0700 Created attachment 172063 Patch 757320 2 172063 webkit.review.bot 2012-11-02 10:43:13 -0700 Comment on attachment 172063 Patch Clearing flags on attachment: 172063 Committed r133313: <http://trac.webkit.org/changeset/133313> 757321 3 webkit.review.bot 2012-11-02 10:43:16 -0700 All reviewed patches have been landed. Closing bug. 757400 4 webkit.review.bot 2012-11-02 11:37:10 -0700 Re-opened since this is blocked by bug 101078 757450 5 haraken 2012-11-02 12:15:56 -0700 Looks strange... I'm heading for a hotel, will take a look in the weekend. 758303 6 172285 haraken 2012-11-05 00:45:04 -0800 Created attachment 172285 Patch 764049 7 173558 haraken 2012-11-11 22:34:24 -0800 Created attachment 173558 Patch 764051 8 haraken 2012-11-11 22:34:53 -0800 I think now it's safe to add the ASSERT()s. 764493 9 173558 abarth 2012-11-12 09:33:23 -0800 Comment on attachment 173558 Patch ok 764975 10 173558 webkit.review.bot 2012-11-12 16:53:45 -0800 Comment on attachment 173558 Patch Rejecting attachment 173558 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: h']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/V8DOMWrapper.h Hunk #1 FAILED at 66. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/V8DOMWrapper.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue Full output: http://queues.webkit.org/results/14820316 765195 11 173808 haraken 2012-11-12 21:14:43 -0800 Created attachment 173808 patch for landing 765281 12 173808 webkit.review.bot 2012-11-12 22:59:59 -0800 Comment on attachment 173808 patch for landing Clearing flags on attachment: 173808 Committed r134369: <http://trac.webkit.org/changeset/134369> 765282 13 webkit.review.bot 2012-11-12 23:00:03 -0800 All reviewed patches have been landed. Closing bug. 172063 2012-11-02 08:16:53 -0700 2012-11-05 00:45:01 -0800 Patch bug-101054-20121102161512.patch text/plain 1978 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWY5MjIwNjhjNjA2NWVh MGVmOGRjOGYwZjk1Njg5OWZmZDg4YmY3Yy4uMTMzODQ2Y2NjNzQwOTNiYmE3Zjk4NTJmMjA4Yjg2 NGY2MzY0YjEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTAyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEFkZCBBU1NF UlQoKSB0byBndWFyYW50ZWUgdGhhdCB3ZSBkb24ndCBzdG9yZSBOVUxMIHBvaW50ZXJzIHRvIFY4 IGludGVybmFsIGZpZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxMDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSSdtIGludmVzdGlnYXRpbmcgYSBDaHJvbWl1bSBjcmFzaCBidWc6CisgICAgICAg IGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMvZGV0YWlsP2lkPTE1NTk0 MgorCisgICAgICAgIEkndmUgbm90IHlldCBpZGVudGlmaWVkIHRoZSByb290IGNhdXNlIChiZWNh dXNlIEkgY2FuJ3QgcmVwcm9kdWNlCisgICAgICAgIHRoZSBjcmFzaCksIGJ1dCBpdCBsb29rcyBs aWtlIHdlIGFyZSBzdG9yaW5nIE5VTEwgcG9pbnRlcnMgdG8KKyAgICAgICAgVjggaW50ZXJuYWwg ZmllbGRzLiBKdXN0IGluIGNhc2UsIHdlIGNhbiBhZGQgYW4gQVNTRVJUKCkgdG8KKyAgICAgICAg Z3VhcmFudGVlIHRoYXQgTlVMTCBwb2ludGVycyBhcmUgbmV2ZXIgc3RvcmVkLiAoQWxzbyBJJ20g aG9waW5nCisgICAgICAgIHRoYXQgdGhpcyBBU1NFUlQoKSB3aWxsIGdpdmUgbWUgbW9yZSBkZWJ1 ZyBpbmZvcm1hdGlvbi4pCisKKyAgICAgICAgTm8gdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oOgorICAgICAgICAoV2Vi Q29yZTo6VjhET01XcmFwcGVyOjpzZXRET01XcmFwcGVyKToKKwogMjAxMi0xMS0wMSAgS2lob25n IEt3b24gIDxraWhvbmcua3dvbkBzYW1zdW5nLmNvbT4KIAogICAgICAgICBBZGQgRGV2aWNlQ29u dHJvbGxlciBiYXNlLWNsYXNzIHRvIHJlbW92ZSBkdXBsaWNhdGlvbiBvZiBEZXZpY2VYWFhDb250 cm9sZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBl ci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKaW5kZXggYTUy OTIzYjViMjNmNWU0YjhjNDQ4NGU2ZmIxYjg4ZDQ5MTZhMGMxMS4uYjMyZjQ5MjQ0MWI5NDBiMTkz NGFhODQ5ZmNhNjYyM2MwM2U2OWQ2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhE T01XcmFwcGVyLmgKQEAgLTcxLDYgKzcxLDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAg ICBzdGF0aWMgdm9pZCBzZXRET01XcmFwcGVyKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0 LCBXcmFwcGVyVHlwZUluZm8qIHR5cGUsIHZvaWQqIGNwdHIpCiAgICAgICAgIHsKICAgICAgICAg ICAgIEFTU0VSVChvYmplY3QtPkludGVybmFsRmllbGRDb3VudCgpID49IDIpOworICAgICAgICAg ICAgQVNTRVJUKHR5cGUpOworICAgICAgICAgICAgQVNTRVJUKGNwdHIpOwogICAgICAgICAgICAg b2JqZWN0LT5TZXRQb2ludGVySW5JbnRlcm5hbEZpZWxkKHY4RE9NV3JhcHBlck9iamVjdEluZGV4 LCBjcHRyKTsKICAgICAgICAgICAgIG9iamVjdC0+U2V0UG9pbnRlckluSW50ZXJuYWxGaWVsZCh2 OERPTVdyYXBwZXJUeXBlSW5kZXgsIHR5cGUpOwogICAgICAgICB9Cg== 172285 2012-11-05 00:45:04 -0800 2012-11-11 22:34:20 -0800 Patch bug-101054-20121105094319.patch text/plain 1658 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzNDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDdkZWUwMjI1NGI1YmU3 NWJhNTNiMzczZDZjNDAyOTUxMDYxMDQwOS4uODUyYWI5ZjVkM2RkMjE5NjllYTRkN2VhYzcwYzI3 NjI2NDJiNmM1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTA1ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEFkZCBBU1NF UlQoKSB0byBndWFyYW50ZWUgdGhhdCB3ZSBkb24ndCBzdG9yZSAwIHRvIFY4IGludGVybmFsIGZp ZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx MDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ug d2FudCB0byBhZGQgQVNTRVJUKHR5cGUpIGFuZCBBU1NFUlQoY3B0cikuCisgICAgICAgIEhvd2V2 ZXIsIGl0IGxvb2tzIGxpa2UgdGhhdCBBU1NFUlQoY3B0cikgaGl0cyBpbiBzb21lIGNhc2VzCisg ICAgICAgIChJJ20gZml4aW5nIHRob3NlIGNhc2VzKS4gVG8gbGFuZCB0aGluZ3MgaW5jcmVtZW50 YWxseSwKKyAgICAgICAgdGhpcyBwYXRjaCBhZGRzIEFTU0VSVCh0eXBlKSBvbmx5LgorCisgICAg ICAgIE5vIHRlc3RzLiBObyBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBiaW5kaW5ncy92 OC9WOERPTVdyYXBwZXIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3JhcHBlcjo6c2V0RE9N V3JhcHBlcik6CisKIDIwMTItMTEtMDQgIEhhbHRvbiBIdW8gIDxoYWx0b24uaHVvQGludGVsLmNv bT4KIAogICAgICAgICBbRUZMXSBVc2UgX0xJQlJBUklFUyBpbnN0ZWFkIG9mIF9MSUJSQVJZCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oCmluZGV4IDcyMWQyOTVhNzdh OWI0ZTU4MjZhZjAwZjRjYTQ0ZjAxZjRkZWUzOTQuLmI1ZjQ5MmMxYTc4NWQ5NzdhYjFjNjIwNDcz NmE2YjYzYTczNDRlM2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 RE9NV3JhcHBlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBl ci5oCkBAIC03MSw2ICs3MSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgc3RhdGlj IHZvaWQgc2V0RE9NV3JhcHBlcih2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IG9iamVjdCwgV3JhcHBl clR5cGVJbmZvKiB0eXBlLCB2b2lkKiBjcHRyKQogICAgICAgICB7CiAgICAgICAgICAgICBBU1NF UlQob2JqZWN0LT5JbnRlcm5hbEZpZWxkQ291bnQoKSA+PSAyKTsKKyAgICAgICAgICAgIEFTU0VS VCh0eXBlKTsKICAgICAgICAgICAgIG9iamVjdC0+U2V0UG9pbnRlckluSW50ZXJuYWxGaWVsZCh2 OERPTVdyYXBwZXJPYmplY3RJbmRleCwgY3B0cik7CiAgICAgICAgICAgICBvYmplY3QtPlNldFBv aW50ZXJJbkludGVybmFsRmllbGQodjhET01XcmFwcGVyVHlwZUluZGV4LCB0eXBlKTsKICAgICAg ICAgfQo= 173558 2012-11-11 22:34:24 -0800 2012-11-12 21:14:39 -0800 Patch bug-101054-20121112153227.patch text/plain 2187 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MTc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IzZDBmMGRiOWNmYTE5 N2M1NzU4MWRlZjQ0ZDI5ODRlMmRjOWFkOC4uYmQzZGUyOTViNTE2NjY2NjU2NGY2YzkyYjNlNTY4 MGFkZmUwY2E4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTExICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEFkZCBBU1NF UlQoKSB0byBndWFyYW50ZWUgdGhhdCB3ZSBkb24ndCBzdG9yZSBOVUxMIHBvaW50ZXJzIHRvIFY4 IGludGVybmFsIGZpZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxMDU0CisKKyAgICAgICAgSSdtIGludmVzdGlnYXRpbmcgYSBDaHJvbWl1bSBj cmFzaCBidWc6CisgICAgICAgIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1 ZXMvZGV0YWlsP2lkPTE1NTk0MgorCisgICAgICAgIEkndmUgbm90IHlldCBpZGVudGlmaWVkIHRo ZSByb290IGNhdXNlIChiZWNhdXNlIEkgY2FuJ3QgcmVwcm9kdWNlCisgICAgICAgIHRoZSBjcmFz aCksIGJ1dCBpdCBsb29rcyBsaWtlIHdlIGFyZSBzdG9yaW5nIE5VTEwgcG9pbnRlcnMgdG8KKyAg ICAgICAgVjggaW50ZXJuYWwgZmllbGRzLiBKdXN0IGluIGNhc2UsIHdlIGNhbiBhZGQgYW4gQVNT RVJUKCkgdG8KKyAgICAgICAgZ3VhcmFudGVlIHRoYXQgTlVMTCBwb2ludGVycyBhcmUgbmV2ZXIg c3RvcmVkLiAoQWxzbyBJJ20gaG9waW5nCisgICAgICAgIHRoYXQgdGhpcyBBU1NFUlQoKSB3aWxs IGdpdmUgbWUgbW9yZSBkZWJ1ZyBpbmZvcm1hdGlvbi4pCisKKyAgICAgICAgTm8gdGVzdHMuIE5v IGNoYW5nZSBpbiBiZWhhdmlvci4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBl ci5oOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpzZXRET01XcmFwcGVyKToKKwog MjAxMi0xMS0xMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAg ICAgICBTYXZlIG9uZSBjYWxsIHRvIGNvbnRhaW5lckZvclJlcGFpbnQoKSB3aGVuIHVwZGF0aW5n IGxheWVyIHBvc2l0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhET01XcmFwcGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu aAppbmRleCBlMDQyNGU4MTczZjY2YWY2Y2UzMTY4Mzk1M2RmYTBlYjViNzE0Njg3Li41OGI3NGFj ODM0NjlkMWVhMmRkZjU2ZmFlMDc3NDdjMzQ3M2NjMWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuaApAQCAtNjYsMTAgKzY2LDEyIEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgc3RhdGljIGJvb2wgbWF5YmVET01XcmFwcGVyKHY4OjpIYW5kbGU8djg6 OlZhbHVlPik7CiAjZW5kaWYKIAotICAgICAgICBzdGF0aWMgdm9pZCBzZXRET01XcmFwcGVyKHY4 OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0LCBXcmFwcGVyVHlwZUluZm8qIHR5cGUsIHZvaWQq IGNwdHIpCisgICAgICAgIHN0YXRpYyB2b2lkIHNldERPTVdyYXBwZXIodjg6OkhhbmRsZTx2ODo6 T2JqZWN0PiBvYmplY3QsIFdyYXBwZXJUeXBlSW5mbyogdHlwZSwgdm9pZCogaW1wbCkKICAgICAg ICAgewogICAgICAgICAgICAgQVNTRVJUKG9iamVjdC0+SW50ZXJuYWxGaWVsZENvdW50KCkgPj0g Mik7Ci0gICAgICAgICAgICBvYmplY3QtPlNldFBvaW50ZXJJbkludGVybmFsRmllbGQodjhET01X cmFwcGVyT2JqZWN0SW5kZXgsIGNwdHIpOworICAgICAgICAgICAgQVNTRVJUKGltcGwpOworICAg ICAgICAgICAgQVNTRVJUKHR5cGUpOworICAgICAgICAgICAgb2JqZWN0LT5TZXRQb2ludGVySW5J bnRlcm5hbEZpZWxkKHY4RE9NV3JhcHBlck9iamVjdEluZGV4LCBpbXBsKTsKICAgICAgICAgICAg IG9iamVjdC0+U2V0UG9pbnRlckluSW50ZXJuYWxGaWVsZCh2OERPTVdyYXBwZXJUeXBlSW5kZXgs IHR5cGUpOwogICAgICAgICB9CiAK 173808 2012-11-12 21:14:43 -0800 2012-11-12 22:59:58 -0800 patch for landing bug-101054-20121113141244.patch text/plain 2220 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0MzMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTcyODM1ZTFiNmQxMGFh Nzg1MDkwZDg1NWEyZTI1YWU3NzE4NGE0NC4uN2I1ZGVlMmM4ZTNlZjZjOTkwNjk4MjYwOTIxZDEz NjVlYWI5OTgyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTExLTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIEFkZCBBU1NF UlQoKSB0byBndWFyYW50ZWUgdGhhdCB3ZSBkb24ndCBzdG9yZSBOVUxMIHBvaW50ZXJzIHRvIFY4 IGludGVybmFsIGZpZWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAxMDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAg ICAgICBJJ20gaW52ZXN0aWdhdGluZyBhIENocm9taXVtIGNyYXNoIGJ1ZzoKKyAgICAgICAgaHR0 cDovL2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MTU1OTQyCisK KyAgICAgICAgSSd2ZSBub3QgeWV0IGlkZW50aWZpZWQgdGhlIHJvb3QgY2F1c2UgKGJlY2F1c2Ug SSBjYW4ndCByZXByb2R1Y2UKKyAgICAgICAgdGhlIGNyYXNoKSwgYnV0IGl0IGxvb2tzIGxpa2Ug d2UgYXJlIHN0b3JpbmcgTlVMTCBwb2ludGVycyB0bworICAgICAgICBWOCBpbnRlcm5hbCBmaWVs ZHMuIEp1c3QgaW4gY2FzZSwgd2UgY2FuIGFkZCBhbiBBU1NFUlQoKSB0bworICAgICAgICBndWFy YW50ZWUgdGhhdCBOVUxMIHBvaW50ZXJzIGFyZSBuZXZlciBzdG9yZWQuIChBbHNvIEknbSBob3Bp bmcKKyAgICAgICAgdGhhdCB0aGlzIEFTU0VSVCgpIHdpbGwgZ2l2ZSBtZSBtb3JlIGRlYnVnIGlu Zm9ybWF0aW9uLikKKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgor CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmg6CisgICAgICAgIChXZWJDb3Jl OjpWOERPTVdyYXBwZXI6OnNldERPTVdyYXBwZXIpOgorCiAyMDEyLTExLTEyICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmaWx0ZXIgZGlydHkg cmVjdCByZWdyZXNzaW9uIGZyb20gcjEzNDMxMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OERPTVdyYXBwZXIuaAppbmRleCBiYzRhOWZiNDEyMTM5ZWMwNzE0OGViNzlkMGNiZTBjYmQwYTk2 NDUzLi42YzgxNTgxZmU1YWIxMDA4ZDY1MDE1NjQ2YmU2NTg1ODk5MDdjNjBhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaApAQCAtNjYsMTAgKzY2LDEyIEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgc3RhdGljIGJvb2wgbWF5YmVET01XcmFwcGVyKHY4 OjpIYW5kbGU8djg6OlZhbHVlPik7CiAjZW5kaWYKIAotICAgICAgICBzdGF0aWMgdm9pZCBzZXRE T01XcmFwcGVyKHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0LCBXcmFwcGVyVHlwZUluZm8q IHR5cGUsIHZvaWQqIGNwdHIpCisgICAgICAgIHN0YXRpYyB2b2lkIHNldERPTVdyYXBwZXIodjg6 OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmplY3QsIFdyYXBwZXJUeXBlSW5mbyogdHlwZSwgdm9pZCog aW1wbCkKICAgICAgICAgewogICAgICAgICAgICAgQVNTRVJUKG9iamVjdC0+SW50ZXJuYWxGaWVs ZENvdW50KCkgPj0gMik7Ci0gICAgICAgICAgICBvYmplY3QtPlNldEFsaWduZWRQb2ludGVySW5J bnRlcm5hbEZpZWxkKHY4RE9NV3JhcHBlck9iamVjdEluZGV4LCBjcHRyKTsKKyAgICAgICAgICAg IEFTU0VSVChpbXBsKTsKKyAgICAgICAgICAgIEFTU0VSVCh0eXBlKTsKKyAgICAgICAgICAgIG9i amVjdC0+U2V0QWxpZ25lZFBvaW50ZXJJbkludGVybmFsRmllbGQodjhET01XcmFwcGVyT2JqZWN0 SW5kZXgsIGltcGwpOwogICAgICAgICAgICAgb2JqZWN0LT5TZXRBbGlnbmVkUG9pbnRlckluSW50 ZXJuYWxGaWVsZCh2OERPTVdyYXBwZXJUeXBlSW5kZXgsIHR5cGUpOwogICAgICAgICB9CiAK