101046 2012-11-02 06:09:03 -0700 Imrpove scoring in touch adjustment to address bias towards smaller targets. 2012-11-02 10:19:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kevers kevers allan.jensen rjkroege tonikitoo webkit.review.bot oldest_to_newest 757137 0 kevers 2012-11-02 06:09:03 -0700 Imrpove scoring in touch adjustment to address bias towards smaller targets. 757139 1 172047 kevers 2012-11-02 06:16:03 -0700 Created attachment 172047 Patch 757140 2 kevers 2012-11-02 06:26:55 -0700 The patch addresses problems with touch adjustment at the boundary of a flash plugin. Previously, we normalized the overlap score with respect to the size of the candidate element. The flash plugin being typically very large compared to the touch area resulted in a very poor overlap score even if the touch is entirely contained within the plugin boundary. 757142 3 172047 kevers 2012-11-02 06:32:44 -0700 Comment on attachment 172047 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172047&action=review > LayoutTests/touchadjustment/rotated-node.html:75 > + testTouchPoint(touchPoint(71, 0, 20), e.container); Original position clipped boundary due to rounding. Bumping the offset slightly addresses the overlap, while still ensuring that the bounds overlaps the rectilinear bounds of the target. Overlap of the rectilinear bounds is required to properly test that the candidate is rejected during touch adjustment. 757300 4 172047 webkit.review.bot 2012-11-02 10:19:33 -0700 Comment on attachment 172047 Patch Clearing flags on attachment: 172047 Committed r133312: <http://trac.webkit.org/changeset/133312> 757302 5 webkit.review.bot 2012-11-02 10:19:36 -0700 All reviewed patches have been landed. Closing bug. 172047 2012-11-02 06:16:03 -0700 2012-11-02 10:19:32 -0700 Patch bug-101046-20121102091423.patch text/plain 5003 kevers U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyOTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTUwM2E4OTAwZjkzZTZi YzJiNmIzZjM0ZDQ0YjRlMjIyMzY0MGU5MS4uYjI2MWVjM2VlYTQ1NDNmZjIyMmY0N2I4NDljYjlk M2E0ZjFiZjU5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTAyICBLZXZp biBFbGxpcyAgPGtldmVyc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW1ycG92ZSBzY29yaW5n IGluIHRvdWNoIGFkanVzdG1lbnQgdG8gYWRkcmVzcyBiaWFzIHRvd2FyZHMgc21hbGxlciB0YXJn ZXRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAx MDQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBk YXRlIHRoZSB0b3VjaCBvdmVybGFwIHNjb3JlIGZvciB0b3VjaCBhZGp1c3RtZXRuIHRvIG5vcm1h bGl6ZQorICAgICAgICB3aXRoIHJlc3BlY3QgdG8gdGhlIG1heGltdW0gcG9zc2libGUgb3Zlcmxh cCByYXRoZXIgdGhhbiB0aGUgc2l6ZQorICAgICAgICBvZiB0aGUgdGFyZ2V0IGVsZW1lbnQuICBU aGlzIGNoYW5nZSBlbmFibGVzIGdvb2Qgb3ZlcmxhcCBzY29yZXMgZm9yCisgICAgICAgIHNtYWxs IGFuZCBsYXJnZSB0YXJnZXRzIGFsaWtlLiAgUHJpb3IgdG8gdGhlIHBhdGNoIGl0IHdhcyBub3Qg cG9zc2libGUKKyAgICAgICAgdG8gZ2V0IGEgZ29vZCBvdmVybGFwIHNjb3JlIGZvciBhIHN1ZmZp Y2llbnRseSBsYXJnZXQgdGFyZ2V0LgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVz dHMsIHdoaWNoIGhhdmUgYmVlbiB1cGRhdGVkIHRvIHJlZmxlY3QgdGhlCisgICAgICAgIGludGVu ZGVkIGJlaGF2aW9yLgorCisgICAgICAgICogcGFnZS9Ub3VjaEFkanVzdG1lbnQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VG91Y2hBZGp1c3RtZW50OjpoeWJyaWREaXN0YW5jZUZ1bmN0aW9uKToK KwogMjAxMi0xMC0zMCAgS29uZGFwYWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRl bC5jb20+CiAKICAgICAgICAgW1F0XVtFRkxdW0FDXSBXaGlsZSBVc2luZyBXZWJHTCwgTWluaUJy b3dzZXIgc2VnZmF1bHRzIG9uIFJlZnJlc2hpbmcgdGhlIHBhZ2UuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL1RvdWNoQWRqdXN0bWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1RvdWNoQWRqdXN0bWVudC5jcHAKaW5kZXggYTc4YzAxYzdlMDAzYTIzY2IzNjBiMWM1NzI0OTM3 OWZkZDQ2NGEzZi4uM2E5NTY5NTZlNWZkNzU4N2ViMTYwZWVlNTdmZjdlOWRiM2M5MjYyOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9Ub3VjaEFkanVzdG1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvVG91Y2hBZGp1c3RtZW50LmNwcApAQCAtMzM5LDEwICszMzksMTIg QEAgZmxvYXQgaHlicmlkRGlzdGFuY2VGdW5jdGlvbihjb25zdCBJbnRQb2ludCYgdG91Y2hIb3Rz cG90LCBjb25zdCBJbnRSZWN0JiB0b3VjaFIKICAgICBmbG9hdCByYWRpdXNTcXVhcmVkID0gMC4y NWYgKiAodG91Y2hSZWN0LnNpemUoKS5kaWFnb25hbExlbmd0aFNxdWFyZWQoKSk7CiAgICAgZmxv YXQgZGlzdGFuY2VUb0FkanVzdFNjb3JlID0gcmVjdC5kaXN0YW5jZVNxdWFyZWRUb1BvaW50KHRv dWNoSG90c3BvdCkgLyByYWRpdXNTcXVhcmVkOwogCi0gICAgZmxvYXQgdGFyZ2V0QXJlYSA9IG1h eChyZWN0LnNpemUoKS5hcmVhKCksIDEpOworICAgIGludCBtYXhPdmVybGFwV2lkdGggPSBzdGQ6 Om1pbih0b3VjaFJlY3Qud2lkdGgoKSwgcmVjdC53aWR0aCgpKTsKKyAgICBpbnQgbWF4T3Zlcmxh cEhlaWdodCA9IHN0ZDo6bWluKHRvdWNoUmVjdC5oZWlnaHQoKSwgcmVjdC5oZWlnaHQoKSk7Cisg ICAgZmxvYXQgbWF4T3ZlcmxhcEFyZWEgPSBzdGQ6Om1heChtYXhPdmVybGFwV2lkdGggKiBtYXhP dmVybGFwSGVpZ2h0LCAxKTsKICAgICByZWN0LmludGVyc2VjdCh0b3VjaFJlY3QpOwogICAgIGZs b2F0IGludGVyc2VjdEFyZWEgPSByZWN0LnNpemUoKS5hcmVhKCk7Ci0gICAgZmxvYXQgaW50ZXJz ZWN0aW9uU2NvcmUgPSAxIC0gaW50ZXJzZWN0QXJlYSAvIHRhcmdldEFyZWE7CisgICAgZmxvYXQg aW50ZXJzZWN0aW9uU2NvcmUgPSAxIC0gaW50ZXJzZWN0QXJlYSAvIG1heE92ZXJsYXBBcmVhOwog CiAgICAgZmxvYXQgaHlicmlkU2NvcmUgPSBpbnRlcnNlY3Rpb25TY29yZSArIGRpc3RhbmNlVG9B ZGp1c3RTY29yZTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGRhMWMyYTRjNjE0MzM5ZTNhMTE5ZDlkZTcwOWRiYWNkNGM2 MzA4NmQuLmY5Yzg1YzM4OTlkY2Q5MDgwYTIyYmExMWY2NjE1ZjA2MzA4N2UwMmYgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyMCBAQAorMjAxMi0xMS0wMiAgS2V2aW4gRWxsaXMgIDxrZXZlcnNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIEltcnBvdmUgc2NvcmluZyBpbiB0b3VjaCBhZGp1c3RtZW50IHRvIGFk ZHJlc3MgYmlhcyB0b3dhcmRzIHNtYWxsZXIgdGFyZ2V0cy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTA0NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBtaXNzaW5nIG1vdXNlIGhhbmRsZXJzIHRv IGVuc3VyZSBwcm9wZXIgaGFuZGxpbmcgb2YgbmVzdGVkCisgICAgICAgIGVsZW1lbnRzLiAgTmVz dGVkIGVsZW1lbnRzIHdpdGggZXhwbGljaXQgaGFuZGxlcnMgYXJlIGZhdm9yZWQgb3ZlcgorICAg ICAgICBhbmNlc3RvciBlbGVtZW50cy4gIFRoZSBjaGFuZ2UgdG8gc2NvcmluZyBpbiB0b3VjaCBh ZGp1c3RtZW50LAorICAgICAgICB3aGljaCByZW1vdmVzIGJpYXMgdG93YXJkcyBzbWFsbCB0YXJn ZXRzLCBicm9rZSB0d28gb2YgdGhlIGxheW91dAorICAgICAgICB0ZXN0cy4gIFRoZSB1cGRhdGVk IHRlc3RzIG1vcmUgYWNjdXJhdGVseSByZWZsZWN0IGludGVuZGVkIAorICAgICAgICBiZWhhdmlv ci4gCisgCisgICAgICAgICogdG91Y2hhZGp1c3RtZW50L25lc3RlZC1zaGFkb3ctbm9kZS5odG1s OgorICAgICAgICAqIHRvdWNoYWRqdXN0bWVudC9yb3RhdGVkLW5vZGUuaHRtbDoKKwogMjAxMi0x MC0zMCAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW3N1Yml4 ZWxdIENoYW5nZSBMaW5lV2lkdGg6OnNocmlua0F2YWlsYWJsZVdpZHRoRm9yTmV3RmxvYXRJZk5l ZWRlZCB0byBub3QgcGl4ZWwgc25hcApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvdG91Y2hhZGp1 c3RtZW50L25lc3RlZC1zaGFkb3ctbm9kZS5odG1sIGIvTGF5b3V0VGVzdHMvdG91Y2hhZGp1c3Rt ZW50L25lc3RlZC1zaGFkb3ctbm9kZS5odG1sCmluZGV4IDMwYjgyZDZjNjVjYWJkMWI5NWM4OTM5 ZjRmODhiNTk4YmY3NjAxNzguLmY0MzU1ODgwOGZiNGVjNDk1ODNiZTVkY2ZmYWYwZjQwOTllN2M1 NDEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3RvdWNoYWRqdXN0bWVudC9uZXN0ZWQtc2hhZG93 LW5vZGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvbmVzdGVkLXNoYWRv dy1ub2RlLmh0bWwKQEAgLTQ2LDYgKzQ2LDcgQEAKICAgICAgICAgc2hhZG93RGl2LnN0eWxlLnBv c2l0aW9uID0gImFic29sdXRlIjsKICAgICAgICAgc2hhZG93RGl2LnN0eWxlLnJpZ2h0ID0gIjEw cHgiOwogICAgICAgICBzaGFkb3dEaXYuc3R5bGUudG9wID0gIjEwcHgiOworICAgICAgICBzaGFk b3dEaXYuYWRkRXZlbnRMaXN0ZW5lcignY2xpY2snLCBmdW5jdGlvbigpIHt9LCBmYWxzZSk7CiAg ICAgICAgIHJvb3QuYXBwZW5kQ2hpbGQoc2hhZG93RGl2KTsKICAgICB9CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3RvdWNoYWRqdXN0bWVudC9yb3RhdGVkLW5vZGUuaHRtbCBiL0xheW91dFRl c3RzL3RvdWNoYWRqdXN0bWVudC9yb3RhdGVkLW5vZGUuaHRtbAppbmRleCAzNzI1ODJmZDkxYjgw YmI0MDhlYTczMzM2MDkzNmZmNmVlYzAzMDlhLi4xOTIzMmJlMGRiNWI3ZDcxNGNjMzFmMDU0ODlj NjY1MzZlOTQyY2UxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy90b3VjaGFkanVzdG1lbnQvcm90 YXRlZC1ub2RlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvdG91Y2hhZGp1c3RtZW50L3JvdGF0ZWQt bm9kZS5odG1sCkBAIC00MSw2ICs0MSw3IEBACiAgICAgdmFyIGUgPSB7fTsKICAgICBbJ2NvbnRh aW5lcicsICdyb3RhdGVkJ10uZm9yRWFjaChmdW5jdGlvbihhKSB7CiAgICAgICAgIGVbYV0gPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZChhKTsKKyAgICAgICAgZVthXS5hZGRFdmVudExpc3RlbmVy KCdjbGljaycsIGZ1bmN0aW9uKCkge30sIGZhbHNlKTsKICAgICB9KTsKIAogICAgIGZ1bmN0aW9u IHRlc3REaXJlY3RUb3VjaGVzKCkKQEAgLTcxLDggKzcyLDggQEAKICAgICAgICAgZGVidWcoJ1xu TmVhciBNaXNzZXMnKTsKIAogICAgICAgICAvLyBUb3VjaCBvdmVybGFwcyBib3VuZGluZy1ib3gg b2YgZWxlbWVudCwgYnV0IG5vdCB0aGUgYWN0dWFsIGJvdW5kcy4KLSAgICAgICAgdGVzdFRvdWNo UG9pbnQodG91Y2hQb2ludCg3MCwgMCwgMjApLCBlLmNvbnRhaW5lcik7Ci0gICAgICAgIHRlc3RU b3VjaFBvaW50KHRvdWNoUG9pbnQoNzAsIDYwLCAyMCksIGUuY29udGFpbmVyKTsKKyAgICAgICAg dGVzdFRvdWNoUG9pbnQodG91Y2hQb2ludCg3MSwgMCwgMjApLCBlLmNvbnRhaW5lcik7CisgICAg ICAgIHRlc3RUb3VjaFBvaW50KHRvdWNoUG9pbnQoNzEsIDYwLCAyMCksIGUuY29udGFpbmVyKTsK ICAgICB9CiAKICAgICBmdW5jdGlvbiB0ZXN0QWRqdXN0ZWRQb2ludHMoKQo=