101016 2012-11-01 22:50:18 -0700 [chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas 2013-01-04 00:51:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth aelias dglazkov enne fishd peter+ews tkent+wkapi webkit.review.bot oldest_to_newest 756894 0 jamesr 2012-11-01 22:50:18 -0700 [chromium] Use const SkBitmap& parameter for WebLayerTreeView::setFontAtlas 756900 1 171988 jamesr 2012-11-01 22:55:12 -0700 Created attachment 171988 Patch 756901 2 jamesr 2012-11-01 22:56:52 -0700 https://codereview.chromium.org/11312058 has to land before this. 756903 3 webkit.review.bot 2012-11-01 22:59:37 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 756906 4 171988 peter+ews 2012-11-01 23:05:49 -0700 Comment on attachment 171988 Patch Attachment 171988 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14663744 756979 5 171988 webkit.review.bot 2012-11-02 01:41:11 -0700 Comment on attachment 171988 Patch Attachment 171988 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14663781 757270 6 171988 enne 2012-11-02 09:42:21 -0700 Comment on attachment 171988 Patch R=me. 758634 7 172354 jamesr 2012-11-05 10:02:56 -0800 Created attachment 172354 Patch 758803 8 jamesr 2012-11-05 12:49:22 -0800 Committed r133516: <http://trac.webkit.org/changeset/133516> 800016 9 172354 eric 2013-01-04 00:51:36 -0800 Comment on attachment 172354 Patch Cleared review? from attachment 172354 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 171988 2012-11-01 22:55:12 -0700 2012-11-05 10:02:52 -0800 Patch bug-101016-20121101225336.patch text/plain 2362 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBiZTYzM2Y4NmRlNmMx ZDg4ZWNjZmUxM2YyOTMzY2M1MDBjYjY0YzhhLi5kN2U5ZmY2NTU0NjRiNDc3YWY1NGY2MzZlNzlk YjgxZTU5NmMyODQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMS0wMSAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1 bV0gVXNlIGNvbnN0IFNrQml0bWFwJiBwYXJhbWV0ZXIgZm9yIFdlYkxheWVyVHJlZVZpZXc6OnNl dEZvbnRBdGxhcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTAxMDE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUGFzc2luZyBTa0JpdG1hcCBieSB2YWx1ZSByZXF1aXJlcyBpbmNsdWRpbmcgU2tCaXRtYXAu aCwgd2hpY2ggaXMgdHJpY2t5IGZvciBzb21lIGNsaWVudHMgdG8gZG8gc2luY2UgaXQKKyAgICAg ICAgcmVxdWlyZXMgaGF2aW5nIHRoZSByZXN0IG9mIHNraWEncyBoZWFkZXJzIG9uIHRoZSBpbmNs dWRlIHBhdGggYW5kIHNldHRpbmcgdXAgdGhlIGNvcnJlY3QgY29uZmlnIHRvIHNldAorICAgICAg ICBwcmVwcm9jZXNzb3IgZGVmaW5lcy4gIEFsc28gc2h1ZmZsZXMgdGhlIHBhcmFtZXRlciBvcmRl ciBhcm91bmQgdG8gbWFrZSByb2xsaW5nIGVhc2llciBzaW5jZSB5b3UgY2FuJ3Qgb3ZlcnJpZGUK KyAgICAgICAganVzdCBieSBjb25zdCByZWYtbmVzcy4KKworICAgICAgICAqIGNocm9taXVtL3B1 YmxpYy9XZWJMYXllclRyZWVWaWV3Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkxheWVyVHJlZVZp ZXc6OnNldEZvbnRBdGxhcyk6CisKIDIwMTItMTEtMDEgIFJvYmVydCBLcm9lZ2VyICA8cmprcm9l Z2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUHJvdmlkZSBXZWJLaXQgQVBJ IGludGVyZmFjZSBmb3IgcGxhdGZvcm0gZ2VzdHVyZSBjdXJ2ZXMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oIGIvU291cmNlL1Bs YXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKaW5kZXggZmY2ZDQyNTZi YzE0NGFiODUwNjRiNWQ0ZTA2MzA2MTUwMDk0NGNlNC4uMzQ1MDQ1YWQ0YzhmMmYzNTU2ZjlkZTAy MmQxZWNjMDFhMDA5M2MzNiAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1 YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKQEAgLTI2LDcgKzI2LDYgQEAKICNpZm5kZWYgV2ViTGF5 ZXJUcmVlVmlld19oCiAjZGVmaW5lIFdlYkxheWVyVHJlZVZpZXdfaAogCi0jaW5jbHVkZSAiU2tC aXRtYXAuaCIKICNpbmNsdWRlICJXZWJDb2xvci5oIgogI2luY2x1ZGUgIldlYkNvbW1vbi5oIgog I2luY2x1ZGUgIldlYkZsb2F0UG9pbnQuaCIKQEAgLTM0LDYgKzMzLDggQEAKICNpbmNsdWRlICJX ZWJQcml2YXRlT3duUHRyLmgiCiAjaW5jbHVkZSAiV2ViU2l6ZS5oIgogCitjbGFzcyBTa0JpdG1h cDsKKwogbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBXZWJHcmFwaGljc0NvbnRleHQzRDsKIGNs YXNzIFdlYkxheWVyOwpAQCAtMTcwLDcgKzE3MSw3IEBAIHB1YmxpYzoKIAogICAgIC8vIFByb3Zp ZGVzIGEgZm9udCBhdGxhcyB0byB1c2UgZm9yIGRlYnVnIHZpc3VhbGl6YXRpb25zLiBUaGUgYXRs YXMgbXVzdCBiZSBhIGJpdG1hcCBjb250YWluaW5nIGdseXBoIGRhdGEsIGEgdGFibGUgb2YKICAg ICAvLyBBU0NJSSBjaGFyYWN0ZXIgdmFsdWVzIHRvIGEgc3VicmVjdGFuZ2xlIG9mIHRoZSBhdGxh cyByZXByZXNlbnRpbmcgdGhlIGNvcnJlc3BvbmRpbmcgZ2x5cGgsIGFuZCB0aGUgZ2x5cGggaGVp Z2h0LgotICAgIHZpcnR1YWwgdm9pZCBzZXRGb250QXRsYXMoU2tCaXRtYXAsIFdlYlJlY3QgYXNj aWlUb1JlY3RUYWJsZVsxMjhdLCBpbnQgZm9udEhlaWdodCkgPSAwOworICAgIHZpcnR1YWwgdm9p ZCBzZXRGb250QXRsYXMoV2ViUmVjdCBhc2NpaVRvUmVjdFRhYmxlWzEyOF0sIGNvbnN0IFNrQml0 bWFwJiwgaW50IGZvbnRIZWlnaHQpIHsgfQogCiAgICAgLy8gU2ltdWxhdGVzIGEgbG9zdCBjb250 ZXh0LiBGb3IgdGVzdGluZyBvbmx5LgogICAgIHZpcnR1YWwgdm9pZCBsb3NlQ29tcG9zaXRvckNv bnRleHQoaW50IG51bVRpbWVzKSA9IDA7Cg== 172354 2012-11-05 10:02:56 -0800 2013-01-04 00:51:36 -0800 Patch bug-101016-20121105100110.patch text/plain 3197 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBiZTYzM2Y4NmRlNmMx ZDg4ZWNjZmUxM2YyOTMzY2M1MDBjYjY0YzhhLi4xZjQxNTRiMTcyZTRkMTkxZDY5Mjk3ZjYzNGEw ZGE3MmY4ZjRmYTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMS0wMiAg SmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1 bV0gVXNlIGNvbnN0IFNrQml0bWFwJiBwYXJhbWV0ZXIgZm9yIFdlYkxheWVyVHJlZVZpZXc6OnNl dEZvbnRBdGxhcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTAxMDE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRyaWVubmUgV2Fsa2VyLgorCisgICAg ICAgIFBhc3NpbmcgU2tCaXRtYXAgYnkgdmFsdWUgcmVxdWlyZXMgaW5jbHVkaW5nIFNrQml0bWFw LmgsIHdoaWNoIGlzIHRyaWNreSBmb3Igc29tZSBjbGllbnRzIHRvIGRvIHNpbmNlIGl0CisgICAg ICAgIHJlcXVpcmVzIGhhdmluZyB0aGUgcmVzdCBvZiBza2lhJ3MgaGVhZGVycyBvbiB0aGUgaW5j bHVkZSBwYXRoIGFuZCBzZXR0aW5nIHVwIHRoZSBjb3JyZWN0IGNvbmZpZyB0byBzZXQKKyAgICAg ICAgcHJlcHJvY2Vzc29yIGRlZmluZXMuICBBbHNvIHNodWZmbGVzIHRoZSBwYXJhbWV0ZXIgb3Jk ZXIgYXJvdW5kIHRvIG1ha2Ugcm9sbGluZyBlYXNpZXIgc2luY2UgeW91IGNhbid0IG92ZXJyaWRl CisgICAgICAgIGp1c3QgYnkgY29uc3QgcmVmLW5lc3MuCisKKyAgICAgICAgKiBjaHJvbWl1bS9w dWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oOgorICAgICAgICAoV2ViS2l0OjpXZWJMYXllclRyZWVW aWV3OjpzZXRGb250QXRsYXMpOgorCiAyMDEyLTExLTAxICBSb2JlcnQgS3JvZWdlciAgPHJqa3Jv ZWdlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIFByb3ZpZGUgV2ViS2l0IEFQ SSBpbnRlcmZhY2UgZm9yIHBsYXRmb3JtIGdlc3R1cmUgY3VydmVzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXcuaCBiL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCmluZGV4IGZmNmQ0MjU2 YmMxNDRhYjg1MDY0YjVkNGUwNjMwNjE1MDA5NDRjZTQuLjM0NTA0NWFkNGM4ZjJmMzU1NmY5ZGUw MjJkMWVjYzAxYTAwOTNjMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9w dWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCisrKyBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9w dWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oCkBAIC0yNiw3ICsyNiw2IEBACiAjaWZuZGVmIFdlYkxh eWVyVHJlZVZpZXdfaAogI2RlZmluZSBXZWJMYXllclRyZWVWaWV3X2gKIAotI2luY2x1ZGUgIlNr Qml0bWFwLmgiCiAjaW5jbHVkZSAiV2ViQ29sb3IuaCIKICNpbmNsdWRlICJXZWJDb21tb24uaCIK ICNpbmNsdWRlICJXZWJGbG9hdFBvaW50LmgiCkBAIC0zNCw2ICszMyw4IEBACiAjaW5jbHVkZSAi V2ViUHJpdmF0ZU93blB0ci5oIgogI2luY2x1ZGUgIldlYlNpemUuaCIKIAorY2xhc3MgU2tCaXRt YXA7CisKIG5hbWVzcGFjZSBXZWJLaXQgewogY2xhc3MgV2ViR3JhcGhpY3NDb250ZXh0M0Q7CiBj bGFzcyBXZWJMYXllcjsKQEAgLTE3MCw3ICsxNzEsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBQcm92 aWRlcyBhIGZvbnQgYXRsYXMgdG8gdXNlIGZvciBkZWJ1ZyB2aXN1YWxpemF0aW9ucy4gVGhlIGF0 bGFzIG11c3QgYmUgYSBiaXRtYXAgY29udGFpbmluZyBnbHlwaCBkYXRhLCBhIHRhYmxlIG9mCiAg ICAgLy8gQVNDSUkgY2hhcmFjdGVyIHZhbHVlcyB0byBhIHN1YnJlY3RhbmdsZSBvZiB0aGUgYXRs YXMgcmVwcmVzZW50aW5nIHRoZSBjb3JyZXNwb25kaW5nIGdseXBoLCBhbmQgdGhlIGdseXBoIGhl aWdodC4KLSAgICB2aXJ0dWFsIHZvaWQgc2V0Rm9udEF0bGFzKFNrQml0bWFwLCBXZWJSZWN0IGFz Y2lpVG9SZWN0VGFibGVbMTI4XSwgaW50IGZvbnRIZWlnaHQpID0gMDsKKyAgICB2aXJ0dWFsIHZv aWQgc2V0Rm9udEF0bGFzKFdlYlJlY3QgYXNjaWlUb1JlY3RUYWJsZVsxMjhdLCBjb25zdCBTa0Jp dG1hcCYsIGludCBmb250SGVpZ2h0KSB7IH0KIAogICAgIC8vIFNpbXVsYXRlcyBhIGxvc3QgY29u dGV4dC4gRm9yIHRlc3Rpbmcgb25seS4KICAgICB2aXJ0dWFsIHZvaWQgbG9zZUNvbXBvc2l0b3JD b250ZXh0KGludCBudW1UaW1lcykgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi Vmlld0ltcGwuY3BwCmluZGV4IGQ1ZjdjZGRjNmMzZjRmMmM3MzNiMjc3OWY1MWVkN2NhNGFlYmRm YTMuLjRlMzAxMmZmNWYxZGFmYzA1OGY0YTA1MDgxYzhkZDBlMGJkMzBiYjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTM5OTgsNyArMzk5OCw3IEBA IHZvaWQgV2ViVmlld0ltcGw6OnNldElzQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0FjdGl2ZShib29s IGFjdGl2ZSkKICAgICAgICAgICAgICAgICBXZWJSZWN0IGFzY2lpVG9SZWN0VGFibGVbMTI4XTsK ICAgICAgICAgICAgICAgICBpbnQgZm9udEhlaWdodDsKICAgICAgICAgICAgICAgICBTa0JpdG1h cCBiaXRtYXAgPSBXZWJDb3JlOjpDb21wb3NpdG9ySFVERm9udEF0bGFzOjpnZW5lcmF0ZUZvbnRB dGxhcyhhc2NpaVRvUmVjdFRhYmxlLCBmb250SGVpZ2h0KTsKLSAgICAgICAgICAgICAgICBtX2xh eWVyVHJlZVZpZXctPnNldEZvbnRBdGxhcyhiaXRtYXAsIGFzY2lpVG9SZWN0VGFibGUsIGZvbnRI ZWlnaHQpOworICAgICAgICAgICAgICAgIG1fbGF5ZXJUcmVlVmlldy0+c2V0Rm9udEF0bGFzKGFz Y2lpVG9SZWN0VGFibGUsIGJpdG1hcCwgZm9udEhlaWdodCk7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBtX25vbkNvbXBvc2l0ZWRDb250ZW50SG9zdC5jbGVh cigpOwo=