101008 2012-11-01 19:35:41 -0700 https://bugs.webkit.org/show_bug.cgi?id=99647 broke the Windows build 2012-11-02 22:37:37 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned eric.carlson feature-media-reviews fischman roger_fong webkit.review.bot oldest_to_newest 756838 0 roger_fong 2012-11-01 19:35:41 -0700 https://bugs.webkit.org/show_bug.cgi?id=99647 broke the Windows build. Submitting a patch for build fix. 756843 1 171977 roger_fong 2012-11-01 19:41:26 -0700 Created attachment 171977 patch 756847 2 171977 fischman 2012-11-01 19:44:28 -0700 Comment on attachment 171977 patch LGTM (but I can't r+ since I'm not a WK reviewer). 756856 3 roger_fong 2012-11-01 19:54:28 -0700 Committed: http://trac.webkit.org/changeset/133262 757695 4 171977 darin 2012-11-02 15:56:13 -0700 Comment on attachment 171977 patch View in context: https://bugs.webkit.org/attachment.cgi?id=171977&action=review > Source/WebCore/html/HTMLMediaElement.cpp:3712 > +void HTMLMediaElement::clearMediaPlayer(signed flags) We call this type int, not signed, in WebKit project source. 757898 5 roger_fong 2012-11-02 22:37:37 -0700 (In reply to comment #4) > (From update of attachment 171977 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171977&action=review > > > Source/WebCore/html/HTMLMediaElement.cpp:3712 > > +void HTMLMediaElement::clearMediaPlayer(signed flags) > > We call this type int, not signed, in WebKit project source. oops, will fix 171977 2012-11-01 19:41:26 -0700 2012-11-02 15:56:13 -0700 patch build_fix.patch text/plain 1760 roger_fong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzI1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTExLTAxICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQnVpbGQgZml4LiBodHRwOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xMzMyNTIgYnJva2UgdGhlIFdpbmRvd3MgYnVpbGQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEwMDgK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0bWwv SFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50 OjpjbGVhck1lZGlhUGxheWVyKToKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoK KyAgICAgICAgKEhUTUxNZWRpYUVsZW1lbnQpOgorCiAyMDEyLTExLTAxICBTdGVwaGVuIFdoaXRl ICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMzMyNDQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAJKHJldmlzaW9uIDEzMzI1NykKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3MDksNyArMzcwOSw3IEBAIHZvaWQgSFRN TE1lZGlhRWxlbWVudDo6dXNlckNhbmNlbGxlZExvYWQKICNlbmRpZgogfQogCi12b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OmNsZWFyTWVkaWFQbGF5ZXIodW5zaWduZWQgZmxhZ3MpCit2b2lkIEhUTUxN ZWRpYUVsZW1lbnQ6OmNsZWFyTWVkaWFQbGF5ZXIoc2lnbmVkIGZsYWdzKQogewogI2lmICFFTkFC TEUoUExVR0lOX1BST1hZX0ZPUl9WSURFTykKICAgICBtX3BsYXllci5jbGVhcigpOwpJbmRleDog U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgJKHJldmlzaW9uIDEzMzI1NykKKysr IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBA IC00NjQsNyArNDY0LDcgQEAgcHJpdmF0ZToKICAgICB2b2lkIHNjaGVkdWxlTmV4dFNvdXJjZUNo aWxkKCk7CiAgICAgdm9pZCBsb2FkTmV4dFNvdXJjZUNoaWxkKCk7CiAgICAgdm9pZCB1c2VyQ2Fu Y2VsbGVkTG9hZCgpOwotICAgIHZvaWQgY2xlYXJNZWRpYVBsYXllcih1bnNpZ25lZCBmbGFncyk7 CisgICAgdm9pZCBjbGVhck1lZGlhUGxheWVyKHNpZ25lZCBmbGFncyk7CiAgICAgYm9vbCBoYXZl UG90ZW50aWFsU291cmNlQ2hpbGQoKTsKICAgICB2b2lkIG5vbmVTdXBwb3J0ZWQoKTsKICAgICB2 b2lkIG1lZGlhRW5naW5lRXJyb3IoUGFzc1JlZlB0cjxNZWRpYUVycm9yPiBlcnIpOwo=