100994 2012-11-01 15:19:14 -0700 Ensure that AudioNode deletion is synchronized with a stable state of the rendering graph 2012-11-01 16:24:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 crogers crogers eric.carlson feature-media-reviews kbr webkit.review.bot oldest_to_newest 756674 0 crogers 2012-11-01 15:19:14 -0700 Ensure that AudioNode deletion is synchronized with a stable state of the rendering graph 756681 1 171944 crogers 2012-11-01 15:30:44 -0700 Created attachment 171944 Patch 756695 2 171944 kbr 2012-11-01 15:49:49 -0700 Comment on attachment 171944 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171944&action=review This fix looks OK but there's a comment that needs to be updated. Please do that before landing. r=me > Source/WebCore/Modules/webaudio/AudioContext.cpp:786 > + m_nodesToDelete.append(m_nodesMarkedForDeletion[i]); There is now a stale comment about m_nodesToDelete in AudioContext::deleteMarkedNodes() that needs to be adjusted. 756712 3 crogers 2012-11-01 16:24:13 -0700 Committed r133239: <http://trac.webkit.org/changeset/133239> 171944 2012-11-01 15:30:44 -0700 2012-11-01 15:49:49 -0700 Patch bug-100994-20121101152905.patch text/plain 3977 crogers U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWIzOWNmMjBkYjFiNTlj YWU0NWNkN2JhNjc2MzdkNmQxMmEwMDA0ZC4uMjg4NjAxYTZmOTQzMzg4ZmMxMmRiMTQ1YTg0NzVm OGE2OTQzYmE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTExLTAxICBDaHJp cyBSb2dlcnMgIDxjcm9nZXJzQGdvb2dsZS5jb20+CisKKyAgICAgICAgRW5zdXJlIHRoYXQgQXVk aW9Ob2RlIGRlbGV0aW9uIGlzIHN5bmNocm9uaXplZCB3aXRoIGEgc3RhYmxlIHN0YXRlIG9mIHRo ZSByZW5kZXJpbmcgZ3JhcGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMDk5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEluIHNvbWUgcmFyZSBjYXNlcyBpdCBoYXMgYmVlbiBvYnNlcnZlZCB0aGF0IG5v ZGVzIGFyZSBnZXR0aW5nIGRlbGV0ZWQgaW4gdGhlIG1haW4gdGhyZWFkCisgICAgICAgIGR1cmlu ZyBhbiBhdWRpbyByZW5kZXJpbmcgcXVhbnR1bSB3aGVyZSB0aGUgZGlydHkgaW5wdXRzIGFuZCBv dXRwdXRzIGhhdmUgbm90IHlldCBiZWVuIGNsZWFuZWQKKyAgICAgICAgdmlhIGNhbGxzIHRvIGhh bmRsZURpcnR5QXVkaW9TdW1taW5nSnVuY3Rpb25zKCkgYW5kIGhhbmRsZURpcnR5QXVkaW9Ob2Rl T3V0cHV0cygpLgorICAgICAgICBUaGlzIHdhcyBwb3NzaWJsZSBiZWNhdXNlIG5vZGVzIG1hcmtl ZCBmb3IgZGVsZXRpb24gd2l0aCBtYXJrRm9yRGVsZXRpb24oKSBjb3VsZCBiZSBwaWNrZWQKKyAg ICAgICAgdXAgaW4gYSBzdWJzZXF1ZW50IGNhbGwgdG8gZGVsZXRlTWFya2VkTm9kZXMoKSBiZWZv cmUgdGhlIHJlbmRlciBxdWFudHVtIGhhcyBmaW5pc2hlZCBhbmQKKyAgICAgICAgaGFuZGxlUG9z dFJlbmRlclRhc2tzKCkgaGFzIGhhZCBhIGNoYW5jZSB0byByZWNvbmNpbGUgdGhlc2UgbWFya2Vk IG5vZGVzIGFuZCBjbGVhbiB0aGUgZGlydHkgc3RhdGUuCisgICAgICAgIFRoZSBzb2x1dGlvbiBp cyB0byBtYW5hZ2UgdGhlIG1hcmtlZCBub2RlcyBpbiBhIHNlcGFyYXRlIHZlY3RvciB3aGljaCBv bmx5IGdldHMgY29waWVkIHRvIGFub3RoZXIKKyAgICAgICAgdmVjdG9yIHRydWx5IGVsaWdpYmxl IGZvciBkZWxldGlvbiB3aGljaCBpcyBzeW5jaHJvbml6ZWQgaW4gaGFuZGxlUG9zdFJlbmRlclRh c2tzKCkuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpBdWRpb0NvbnRleHQ6Om1hcmtGb3JEZWxldGlvbik6CisgICAgICAg IChXZWJDb3JlOjpBdWRpb0NvbnRleHQ6OnNjaGVkdWxlTm9kZURlbGV0aW9uKToKKyAgICAgICAg KiBNb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5oOgorICAgICAgICAoQXVkaW9Db250ZXh0 KToKKwogMjAxMi0xMC0zMSAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9z QGludGVsLmNvbT4KIAogICAgICAgICBBZGRlZCB2aWV3cG9ydCBhdC1ydWxlIHRvIHRoZSBDU1Mg cGFyc2VyIGFuZCB0b2tlbml6ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViYXVkaW8vQXVkaW9Db250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVk aW8vQXVkaW9Db250ZXh0LmNwcAppbmRleCBmY2VkZGYzZGViNTI4NWZlNGY3N2U2YmI0MGQyMGMx MGMzYmY2NmQxLi41OTU1N2U0OTc2OGU5NzMzNWU0Mjc5MzdmMWVlYzA2Y2M3YjRiYzYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvQ29udGV4dC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuY3BwCkBA IC03NjQsNyArNzY0LDcgQEAgdm9pZCBBdWRpb0NvbnRleHQ6OmhhbmRsZURlZmVycmVkRmluaXNo RGVyZWZzKCkKIHZvaWQgQXVkaW9Db250ZXh0OjptYXJrRm9yRGVsZXRpb24oQXVkaW9Ob2RlKiBu b2RlKQogewogICAgIEFTU0VSVChpc0dyYXBoT3duZXIoKSk7Ci0gICAgbV9ub2Rlc1RvRGVsZXRl LmFwcGVuZChub2RlKTsKKyAgICBtX25vZGVzTWFya2VkRm9yRGVsZXRpb24uYXBwZW5kKG5vZGUp OwogCiAgICAgLy8gVGhpcyBpcyBwcm9iYWJseSB0aGUgYmVzdCB0aW1lIGZvciB1cyB0byByZW1v dmUgdGhlIG5vZGUgZnJvbSBhdXRvbWF0aWMgcHVsbCBsaXN0LAogICAgIC8vIHNpbmNlIGFsbCBj b25uZWN0aW9ucyBhcmUgZ29uZSBhbmQgd2UgaG9sZCB0aGUgZ3JhcGggbG9jay4gVGhlbiB3aGVu IGhhbmRsZVBvc3RSZW5kZXJUYXNrcygpCkBAIC03ODEsNyArNzgxLDExIEBAIHZvaWQgQXVkaW9D b250ZXh0OjpzY2hlZHVsZU5vZGVEZWxldGlvbigpCiAgICAgICAgIHJldHVybjsKIAogICAgIC8v IE1ha2Ugc3VyZSB0byBjYWxsIGRlbGV0ZU1hcmtlZE5vZGVzKCkgb24gbWFpbiB0aHJlYWQuICAg IAotICAgIGlmIChtX25vZGVzVG9EZWxldGUuc2l6ZSgpICYmICFtX2lzRGVsZXRpb25TY2hlZHVs ZWQpIHsKKyAgICBpZiAobV9ub2Rlc01hcmtlZEZvckRlbGV0aW9uLnNpemUoKSAmJiAhbV9pc0Rl bGV0aW9uU2NoZWR1bGVkKSB7CisgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX25v ZGVzTWFya2VkRm9yRGVsZXRpb24uc2l6ZSgpOyArK2kpCisgICAgICAgICAgICBtX25vZGVzVG9E ZWxldGUuYXBwZW5kKG1fbm9kZXNNYXJrZWRGb3JEZWxldGlvbltpXSk7CisgICAgICAgIG1fbm9k ZXNNYXJrZWRGb3JEZWxldGlvbi5jbGVhcigpOworCiAgICAgICAgIG1faXNEZWxldGlvblNjaGVk dWxlZCA9IHRydWU7CiAKICAgICAgICAgLy8gRG9uJ3QgbGV0IG91cnNlbGYgZ2V0IGRlbGV0ZWQg YmVmb3JlIHRoZSBjYWxsYmFjay4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv d2ViYXVkaW8vQXVkaW9Db250ZXh0LmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlv L0F1ZGlvQ29udGV4dC5oCmluZGV4IDI2N2VlNDI2MjI1NjFkZDhhYjM1YjA0OTQ2MjBkMDgwZDUy MGI2YzMuLjMwOThkOGVjNmMxMGI3ZDY2YzViOTY4MmUwZDkyMDQxYmE4NjQxOTggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Db250ZXh0LmgKKysrIGIv U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0NvbnRleHQuaApAQCAtMjg2LDYg KzI4NiwxMSBAQCBwcml2YXRlOgogICAgIFZlY3RvcjxBdWRpb05vZGUqPiBtX3JlZmVyZW5jZWRO b2RlczsKIAogICAgIC8vIEFjY3VtdWxhdGUgbm9kZXMgd2hpY2ggbmVlZCB0byBiZSBkZWxldGVk IGhlcmUuCisgICAgLy8gVGhpcyBpcyBjb3BpZWQgdG8gbV9ub2Rlc1RvRGVsZXRlIGF0IHRoZSBl bmQgb2YgYSByZW5kZXIgY3ljbGUgaW4gaGFuZGxlUG9zdFJlbmRlclRhc2tzKCksIHdoZXJlIHdl J3JlIGFzc3VyZWQgb2YgYSBzdGFibGUgZ3JhcGgKKyAgICAvLyBzdGF0ZSB3aGljaCB3aWxsIGhh dmUgbm8gcmVmZXJlbmNlcyB0byBhbnkgb2YgdGhlIG5vZGVzIGluIG1fbm9kZXNUb0RlbGV0ZSBv bmNlIHRoZSBjb250ZXh0IGxvY2sgaXMgcmVsZWFzZWQKKyAgICAvLyAod2hlbiBoYW5kbGVQb3N0 UmVuZGVyVGFza3MoKSBoYXMgY29tcGxldGVkKS4KKyAgICBWZWN0b3I8QXVkaW9Ob2RlKj4gbV9u b2Rlc01hcmtlZEZvckRlbGV0aW9uOworCiAgICAgLy8gVGhleSB3aWxsIGJlIHNjaGVkdWxlZCBm b3IgZGVsZXRpb24gKG9uIHRoZSBtYWluIHRocmVhZCkgYXQgdGhlIGVuZCBvZiBhIHJlbmRlciBj eWNsZSAoaW4gcmVhbHRpbWUgdGhyZWFkKS4KICAgICBWZWN0b3I8QXVkaW9Ob2RlKj4gbV9ub2Rl c1RvRGVsZXRlOwogICAgIGJvb2wgbV9pc0RlbGV0aW9uU2NoZWR1bGVkOwo=