100988 2012-11-01 14:30:21 -0700 [chromium] Try to find ninja if it's not in the path already 2012-11-01 17:59:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis dbates rniwa webkit.review.bot oldest_to_newest 756617 0 thakis 2012-11-01 14:30:21 -0700 [chromium] Try to find ninja if it's not in the path already 756618 1 171931 thakis 2012-11-01 14:30:54 -0700 Created attachment 171931 Patch 756622 2 171931 rniwa 2012-11-01 14:34:22 -0700 Comment on attachment 171931 Patch Oosp, we still get an error: Source/WebKit/chromium/depot_tools/ninja: line 12: exec: ninja-mac: not found 756627 3 thakis 2012-11-01 14:40:13 -0700 that's not the same error, it's a different error. it now finds the ninja shell script in depot_tools, but that too assumes that depot_tools is in the path when it dispatches to ninja-mac. That will be fixed by https://codereview.chromium.org/11366044 Can you restore r+ please? 756628 4 rniwa 2012-11-01 14:40:36 -0700 I think we can put depot_tools in $PATH when we install one so that subprocesses will use that. 756629 5 171931 rniwa 2012-11-01 14:40:46 -0700 Comment on attachment 171931 Patch ok 756765 6 171931 webkit.review.bot 2012-11-01 17:59:28 -0700 Comment on attachment 171931 Patch Clearing flags on attachment: 171931 Committed r133246: <http://trac.webkit.org/changeset/133246> 756766 7 webkit.review.bot 2012-11-01 17:59:32 -0700 All reviewed patches have been landed. Closing bug. 171931 2012-11-01 14:30:54 -0700 2012-11-01 17:59:28 -0700 Patch bug-100988-20121101142915.patch text/plain 1547 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTQxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTI5MmZjYjgyYWI4MDVjMjVhMDViZDE0OTIyYTE1MTJk OTZiMjYxMS4uMzdlZmZkMDU3NWVlN2JkY2Y3MGZjYTVkZDBmNzE3ZDFmYjRiMWJkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTExLTAxICBOaWNvIFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIFRyeSB0byBmaW5kIG5pbmphIGlmIGl0J3Mgbm90IGluIHRoZSBwYXRo IGFscmVhZHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMDk4OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFNpbWlsYXIgdG8gdGhlIGdjbGllbnQgZGV0ZWN0aW9uIGxvZ2ljIGluIHVwZGF0ZS13ZWJraXQt Y2hyb21pdW0KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGJ1 aWxkQ2hyb21pdW1OaW5qYSk6CisKIDIwMTItMTAtMzEgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgTlJXVDogbGludCB3YXJuaW5ncyBkb24ndCBzaG93IHVw IGJ5IGRlZmF1bHQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCA4MzFlMzU2YTQzOWNlZmIxZjI3NDliMDI4 YmQ0NDUxMDA2NGVkZjIwLi5jMGU3M2MyNDY3ODkyNTllMTdjNzIwOGZiMzQ3YzA2YTdhMzk0Y2Rm IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yNDI5LDcgKzI0MjksMTcgQEAgc3ViIGJ1aWxkQ2hyb21p dW1OaW5qYSgkJEApCiAgICAgfQogICAgIG15ICRjb21tYW5kID0gIiI7CiAKLSAgICAkY29tbWFu ZCAuPSAibmluamEgLUMgb3V0LyRjb25maWcgJHRhcmdldCAkbWFrZUFyZ3MiOworICAgICMgRmlu ZCBuaW5qYS4KKyAgICBteSAkbmluamFQYXRoOworICAgIGlmIChjb21tYW5kRXhpc3RzKCduaW5q YScpKSB7CisgICAgICAgICRuaW5qYVBhdGggPSAnbmluamEnOworICAgIH0gZWxzaWYgKC1lICdT b3VyY2UvV2ViS2l0L2Nocm9taXVtL2RlcG90X3Rvb2xzL25pbmphJykgeworICAgICAgICAkbmlu amFQYXRoID0gJ1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZGVwb3RfdG9vbHMvbmluamEnOworICAg IH0gZWxzZSB7CisgICAgICAgIGRpZSAibmluamEgbm90IGZvdW5kLiBJbnN0YWxsIGNocm9taXVt J3MgZGVwb3RfdG9vbHMgYnkgcnVubmluZyB1cGRhdGUtd2Via2l0IGZpcnN0XG4iOworICAgIH0K KworICAgICRjb21tYW5kIC49ICIkbmluamFQYXRoIC1DIG91dC8kY29uZmlnICR0YXJnZXQgJG1h a2VBcmdzIjsKIAogICAgIHByaW50ICIkY29tbWFuZFxuIjsKICAgICByZXR1cm4gc3lzdGVtICRj b21tYW5kOwo=