100983 2012-11-01 13:33:11 -0700 [EFL][WK2][AC] Wrong translation of mouse events 2012-11-02 08:10:50 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned gyuyoung.kim kenneth lucas.de.marchi menard rakuco webkit.review.bot oldest_to_newest 756574 0 yael 2012-11-01 13:33:11 -0700 Translation of mouse events does not take the url bar into account correctly. To reproduce this error: 1. load the page www.aldaily.com 2. make the viewport narrower 3. scroll down 4. use the mouse to select text You will observe that the text selection is bellow where the mouse is. If you extend the width of the viewport until the scale factor becomes 1, and then the selection starts at the correct row. Tested with r133214. 756773 1 171962 yael 2012-11-01 18:08:55 -0700 Created attachment 171962 Patch 756992 2 171962 kenneth 2012-11-02 02:10:23 -0700 Comment on attachment 171962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171962&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:211 > > - transform.translate(-smartData->view.x, -smartData->view.y); > - > #if USE(TILED_BACKING_STORE) > + transform.translate(-smartData->view.x / impl->pageViewportControllerClient()->scaleFactor(), -smartData->view.y / impl->pageViewportControllerClient()->scaleFactor()); > IntPoint scrollPos = impl->pageViewportControllerClient()->scrollPosition(); > transform.translate(scrollPos.x(), scrollPos.y()); > transform.scale(1 / impl->pageViewportControllerClient()->scaleFactor()); > +#else > + transform.translate(-smartData->view.x, -smartData->view.y); > #endif why not just translate it after the scale is applied. That would turn the #else into an #endif 757109 3 172043 yael 2012-11-02 05:01:17 -0700 Created attachment 172043 Patch Address comment #2. 757117 4 172043 kenneth 2012-11-02 05:16:44 -0700 Comment on attachment 172043 Patch Much better! :-) 757198 5 yael 2012-11-02 08:10:25 -0700 Committed in r133297 <http://trac.webkit.org/changeset/133297> 757199 6 172043 yael 2012-11-02 08:10:50 -0700 Comment on attachment 172043 Patch Clearing flags. 171962 2012-11-01 18:08:55 -0700 2012-11-02 05:01:17 -0700 Patch 100983.patch text/plain 1802 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAJ KHJldmlzaW9uIDEzMzIxNCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAxLDEyICsyMDEsMTMgQEAKICAgICBBZmZp bmVUcmFuc2Zvcm0gdHJhbnNmb3JtOwogICAgIEVXS19WSUVXX0lNUExfR0VUX0JZX1NEX09SX1JF VFVSTihzbWFydERhdGEsIGltcGwsIHRyYW5zZm9ybSk7CiAKLSAgICB0cmFuc2Zvcm0udHJhbnNs YXRlKC1zbWFydERhdGEtPnZpZXcueCwgLXNtYXJ0RGF0YS0+dmlldy55KTsKLQogI2lmIFVTRShU SUxFRF9CQUNLSU5HX1NUT1JFKQorICAgIHRyYW5zZm9ybS50cmFuc2xhdGUoLXNtYXJ0RGF0YS0+ dmlldy54IC8gaW1wbC0+cGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudCgpLT5zY2FsZUZhY3Rv cigpLCAtc21hcnREYXRhLT52aWV3LnkgLyBpbXBsLT5wYWdlVmlld3BvcnRDb250cm9sbGVyQ2xp ZW50KCktPnNjYWxlRmFjdG9yKCkpOwogICAgIEludFBvaW50IHNjcm9sbFBvcyA9IGltcGwtPnBh Z2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnQoKS0+c2Nyb2xsUG9zaXRpb24oKTsKICAgICB0cmFu c2Zvcm0udHJhbnNsYXRlKHNjcm9sbFBvcy54KCksIHNjcm9sbFBvcy55KCkpOwogICAgIHRyYW5z Zm9ybS5zY2FsZSgxIC8gaW1wbC0+cGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudCgpLT5zY2Fs ZUZhY3RvcigpKTsKKyNlbHNlCisgICAgdHJhbnNmb3JtLnRyYW5zbGF0ZSgtc21hcnREYXRhLT52 aWV3LngsIC1zbWFydERhdGEtPnZpZXcueSk7CiAjZW5kaWYKIAogICAgIHJldHVybiB0cmFuc2Zv cm07CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzMyNDYpCisrKyBTb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0xMS0wMSAgWWFl bCBBaGFyb24gIDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXVtB Q10gV3JvbmcgdHJhbnNsYXRpb24gb2YgbW91c2UgZXZlbnRzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5ODMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgdHJhbnNmb3JtIHRoYXQgd2UgYnVpbGQg Zm9yIG1vdXNlIGV2ZW50cyBpcyBzY2FsZWQgYnkgdGhlIHNjYWxlIGZhY3Rvci4KKyAgICAgICAg VGhlIHVybCBiYXIgc2hvdWxkIG5vdCBiZSBzY2FsZWQsIHNvIGl0IHNob3VsZCBiZSBzY2FsZWQg aW4gdGhlIG9wb3NpdGUKKyAgICAgICAgZGlyZWN0aW9uIHRvIGNvbXBlbnNhdGUgZm9yIHRoYXQu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisgICAgICAgICh0 b1dlYkNvbnRlbnRUcmFuc2Zvcm0pOgorCiAyMDEyLTExLTAxICBBbGV4YW5kcnUgQ2hpY3VsaXRh ICA8YWNoaWN1QGFkb2JlLmNvbT4KIAogICAgICAgICBbQ1NTIFNoYWRlcnNdIE1vdmUgTWVzaEJv eFR5cGUgb3V0IG9mIEN1c3RvbUZpbHRlck9wZXJhdGlvbgo= 172043 2012-11-02 05:01:17 -0700 2012-11-02 08:10:50 -0700 Patch 100983.patch text/plain 1624 yael SW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAJ KHJldmlzaW9uIDEzMzIxNCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3 a192aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjAxLDEzICsyMDEsMTIgQEAKICAgICBBZmZp bmVUcmFuc2Zvcm0gdHJhbnNmb3JtOwogICAgIEVXS19WSUVXX0lNUExfR0VUX0JZX1NEX09SX1JF VFVSTihzbWFydERhdGEsIGltcGwsIHRyYW5zZm9ybSk7CiAKLSAgICB0cmFuc2Zvcm0udHJhbnNs YXRlKC1zbWFydERhdGEtPnZpZXcueCwgLXNtYXJ0RGF0YS0+dmlldy55KTsKLQogI2lmIFVTRShU SUxFRF9CQUNLSU5HX1NUT1JFKQogICAgIEludFBvaW50IHNjcm9sbFBvcyA9IGltcGwtPnBhZ2VW aWV3cG9ydENvbnRyb2xsZXJDbGllbnQoKS0+c2Nyb2xsUG9zaXRpb24oKTsKICAgICB0cmFuc2Zv cm0udHJhbnNsYXRlKHNjcm9sbFBvcy54KCksIHNjcm9sbFBvcy55KCkpOwogICAgIHRyYW5zZm9y bS5zY2FsZSgxIC8gaW1wbC0+cGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudCgpLT5zY2FsZUZh Y3RvcigpKTsKICNlbmRpZgorICAgIHRyYW5zZm9ybS50cmFuc2xhdGUoLXNtYXJ0RGF0YS0+dmll dy54LCAtc21hcnREYXRhLT52aWV3LnkpOwogCiAgICAgcmV0dXJuIHRyYW5zZm9ybTsKIH0KSW5k ZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMzI0NikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTAxICBZYWVsIEFoYXJv biAgPHlhZWwuYWhhcm9uQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdW0FDXSBXcm9u ZyB0cmFuc2xhdGlvbiBvZiBtb3VzZSBldmVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDk4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0cmFuc2Zvcm0gdGhhdCB3ZSBidWlsZCBmb3IgbW91 c2UgZXZlbnRzIGlzIHNjYWxlZCBieSB0aGUgc2NhbGUgZmFjdG9yLgorICAgICAgICBUaGUgdXJs IGJhciBzaG91bGQgbm90IGJlIHNjYWxlZCwgc28gaXQgc2hvdWxkIGJlIHNjYWxlZCBpbiB0aGUg b3Bvc2l0ZQorICAgICAgICBkaXJlY3Rpb24gdG8gY29tcGVuc2F0ZSBmb3IgdGhhdC4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKHRvV2ViQ29u dGVudFRyYW5zZm9ybSk6CisKIDIwMTItMTEtMDEgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hp Y3VAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgU2hhZGVyc10gTW92ZSBNZXNoQm94VHlwZSBv dXQgb2YgQ3VzdG9tRmlsdGVyT3BlcmF0aW9uCg==