100972 2012-11-01 11:17:05 -0700 [Mac] Crash in Range::editingStartPosition 2012-11-01 12:02:46 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa adele ap darin enrica mifenton webkit.review.bot oldest_to_newest 756467 0 rniwa 2012-11-01 11:17:05 -0700 http://trac.webkit.org/browser/trunk/Source/WebCore/editing/mac/EditorMac.mm#L165 165 RefPtr<Range> range = m_frame->selection()->toNormalizedRange(); 166 if (Node* startNode = adjustedSelectionStartForStyleComputation(m_frame->selection()->selection()).deprecatedNode()) { 167 Node* pastEnd = range->pastLastNode(); range could be null in the line 165, in which case, we blow up in the line 167. We've been getting crash reports in Safari. <rdar://problem/10227183> 756471 1 171898 rniwa 2012-11-01 11:20:59 -0700 Created attachment 171898 Fixes the bug 756519 2 171898 webkit.review.bot 2012-11-01 12:02:41 -0700 Comment on attachment 171898 Fixes the bug Clearing flags on attachment: 171898 Committed r133207: <http://trac.webkit.org/changeset/133207> 756520 3 webkit.review.bot 2012-11-01 12:02:46 -0700 All reviewed patches have been landed. Closing bug. 171898 2012-11-01 11:20:59 -0700 2012-11-01 12:02:41 -0700 Fixes the bug fix100972 text/plain 1793 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0VkaXRvck1hYy5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL21hYy9FZGl0b3JNYWMubW0JKHJldmlzaW9uIDEz MzA5NCkKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvbWFjL0VkaXRvck1hYy5tbQkod29ya2lu ZyBjb3B5KQpAQCAtMTYzLDcgKzE2Myw4IEBACiAKICAgICBjb25zdCBTaW1wbGVGb250RGF0YSog Zm9udCA9IDA7CiAgICAgUmVmUHRyPFJhbmdlPiByYW5nZSA9IG1fZnJhbWUtPnNlbGVjdGlvbigp LT50b05vcm1hbGl6ZWRSYW5nZSgpOwotICAgIGlmIChOb2RlKiBzdGFydE5vZGUgPSBhZGp1c3Rl ZFNlbGVjdGlvblN0YXJ0Rm9yU3R5bGVDb21wdXRhdGlvbihtX2ZyYW1lLT5zZWxlY3Rpb24oKS0+ c2VsZWN0aW9uKCkpLmRlcHJlY2F0ZWROb2RlKCkpIHsKKyAgICBOb2RlKiBzdGFydE5vZGUgPSBh ZGp1c3RlZFNlbGVjdGlvblN0YXJ0Rm9yU3R5bGVDb21wdXRhdGlvbihtX2ZyYW1lLT5zZWxlY3Rp b24oKS0+c2VsZWN0aW9uKCkpLmRlcHJlY2F0ZWROb2RlKCk7CisgICAgaWYgKHJhbmdlICYmIHN0 YXJ0Tm9kZSkgewogICAgICAgICBOb2RlKiBwYXN0RW5kID0gcmFuZ2UtPnBhc3RMYXN0Tm9kZSgp OwogICAgICAgICAvLyBJbiB0aGUgbG9vcCBiZWxvdywgbiBzaG91bGQgZXZlbnR1YWxseSBtYXRj aCBwYXN0RW5kIGFuZCBub3QgYmVjb21lIG5pbCwgYnV0IHdlJ3ZlIHNlZW4gYXQgbGVhc3Qgb25l CiAgICAgICAgIC8vIHVucmVwcm9kdWNpYmxlIGNhc2Ugd2hlcmUgdGhpcyBkaWRuJ3QgaGFwcGVu LCBzbyBjaGVjayBmb3IgbnVsbCBhbHNvLgpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzMTk2 KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTkgQEAKKzIwMTItMTEtMDEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW01hY10gQ3Jhc2ggaW4gUmFuZ2U6OmVkaXRpbmdTdGFydFBvc2l0aW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5NzIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBtaXNzaW5nIG51 bGwgcG9pbnRlciBjaGVjay4gdG9Ob3JtYWxpemVkUmFuZ2UoKSBjYW4gcmV0dXJuIG51bGwgaGVy ZSwgaW4gd2hpY2ggY2FzZSB0aGUgY2FsbCB0bworICAgICAgICBwYXN0TGFzdE5vZGUoKSB3aWxs IGNyYXNoLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSBkZXRlcm1pbmluZyB0aGUgZXhh Y3QgY29uZGl0aW9uIHVuZGVyIHdoaWNoIHdlIGdvIHRocm91Z2ggdGhlIHNhaWQgY29kZSBwYXRo IGFuZAorICAgICAgICB0b05vcm1hbFJhbmdlIHJldHVybnMgbnVsbCBpcyBoYXJkLgorCisgICAg ICAgICogZWRpdGluZy9tYWMvRWRpdG9yTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9y Ojpmb250Rm9yU2VsZWN0aW9uKToKKwogMjAxMi0xMS0wMSAgQWxlYyBGbGV0dCAgPGFsZWNmbGV0 dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBhZGQgbWV0aG9kcyB0byBzdXBw b3J0IGlkLWJhc2VkIGJhY2tlbmQgQVBJcwo=