100971 2012-11-01 11:16:12 -0700 Add RGB to supported destination formats of ImageBuffer::copyToPlatformTexture 2012-11-01 11:54:04 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 100714 100715 1 kbr kbr dino gman junov senorblanco webkit.review.bot zmo oldest_to_newest 756465 0 kbr 2012-11-01 11:16:12 -0700 In https://bugs.webkit.org/show_bug.cgi?id=100714 , ImageBuffer::copyToPlatformTexture was restricted to only work with RGBA/UNSIGNED_BYTE textures. It turns out this is too restrictive; it's necessary to allow RGB textures as well to allow existing applications to work without performance regressions. 756470 1 171897 kbr 2012-11-01 11:20:50 -0700 Created attachment 171897 Patch 756473 2 junov 2012-11-01 11:23:14 -0700 (In reply to comment #1) > Created an attachment (id=171897) [details] > Patch Does it resolve the problem described in comment 19 here: http://code.google.com/p/chromium/issues/detail?id=146219 756474 3 kbr 2012-11-01 11:23:44 -0700 Yes, I manually verified with his test case that the fast path is taken. 756475 4 171897 senorblanco 2012-11-01 11:24:42 -0700 Comment on attachment 171897 Patch OK. r=me 756507 5 171897 webkit.review.bot 2012-11-01 11:54:01 -0700 Comment on attachment 171897 Patch Clearing flags on attachment: 171897 Committed r133202: <http://trac.webkit.org/changeset/133202> 756508 6 webkit.review.bot 2012-11-01 11:54:04 -0700 All reviewed patches have been landed. Closing bug. 171897 2012-11-01 11:20:50 -0700 2012-11-01 11:54:00 -0700 Patch bug-100971-20121101111911.patch text/plain 3185 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQxYzM4Nzc2NzA5MDVl OGRhYjU0YWU1YWRiNDQwMTEzZjIwNmExMC4uN2FiN2E3NmJlMTJjNjY5ZmNhMGE1OTkxZTI0ZTI1 MTg2NGJmZGE5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTExLTAxICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBBZGQgUkdCIHRvIHN1cHBv cnRlZCBkZXN0aW5hdGlvbiBmb3JtYXRzIG9mIEltYWdlQnVmZmVyOjpjb3B5VG9QbGF0Zm9ybVRl eHR1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDk3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBJbWFnZUJ1ZmZlcjo6Y29weVRvUGxhdGZvcm1UZXh0dXJlIHJlc3RyaWN0aW9uIGFkZGVkIGlu CisgICAgICAgIHIxMzI5NjUgd2FzIHRvbyByZXN0cmljdGl2ZS4gQWxsb3cgUkdCIHRleHR1cmVz IHRvIHByZXZlbnQKKyAgICAgICAgcGVyZm9ybWFuY2UgcmVncmVzc2lvbnMuCisKKyAgICAgICAg KiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29y ZSk6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OnRleEltYWdlMkQp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmg6CisgICAgICAgIChJ bWFnZUJ1ZmZlcik6CisKIDIwMTItMTEtMDEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogVXBkYXRlIENvZGVNaXJyb3IgdG8g djMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuY3BwCmluZGV4IGM3MGY0MGZiNTIxZjQ0YjllNTk4MjRhMjAwNzBiNDU5MWYyYWFlMTgu LjViMWIwNWE1ZDQ4MGJiMzE4MTFkZjY0ZGExYWU5MGFkNjQ4NWYxYmYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcApAQCAt MzcwMCwxMCArMzcwMCwxMCBAQCB2b2lkIFdlYkdMUmVuZGVyaW5nQ29udGV4dDo6dGV4SW1hZ2Uy RChHQzNEZW51bSB0YXJnZXQsIEdDM0RpbnQgbGV2ZWwsIEdDM0RlbnVtCiAgICAgLy8gSWYgcG9z c2libGUsIGNvcHkgZnJvbSB0aGUgY2FudmFzIGVsZW1lbnQgZGlyZWN0bHkgdG8gdGhlIHRleHR1 cmUKICAgICAvLyB2aWEgdGhlIEdQVSwgd2l0aG91dCBhIHJlYWQtYmFjayB0byBzeXN0ZW0gbWVt b3J5LgogICAgIC8vCi0gICAgLy8gRklYTUU6IHJlc3RyaWN0aW9uIG9mIFJHQkEvVU5TSUdORURf QllURSBzaG91bGQgYmUgbGlmdGVkIHdoZW4KKyAgICAvLyBGSVhNRTogcmVzdHJpY3Rpb24gb2Yg KFJHQiB8fCBSR0JBKS9VTlNJR05FRF9CWVRFIHNob3VsZCBiZSBsaWZ0ZWQgd2hlbgogICAgIC8v IEltYWdlQnVmZmVyOjpjb3B5VG9QbGF0Zm9ybVRleHR1cmUgaW1wbGVtZW50YXRpb25zIGFyZSBm dWxseSBmdW5jdGlvbmFsLgogICAgIGlmIChHcmFwaGljc0NvbnRleHQzRDo6VEVYVFVSRV8yRCA9 PSB0YXJnZXQgJiYgdGV4dHVyZSAmJiB0eXBlID09IHRleHR1cmUtPmdldFR5cGUodGFyZ2V0LCBs ZXZlbCkKLSAgICAgICAgJiYgZm9ybWF0ID09IEdyYXBoaWNzQ29udGV4dDNEOjpSR0JBICYmIHR5 cGUgPT0gR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUpIHsKKyAgICAgICAgJiYgKGZv cm1hdCA9PSBHcmFwaGljc0NvbnRleHQzRDo6UkdCIHx8IGZvcm1hdCA9PSBHcmFwaGljc0NvbnRl eHQzRDo6UkdCQSkgJiYgdHlwZSA9PSBHcmFwaGljc0NvbnRleHQzRDo6VU5TSUdORURfQllURSkg ewogICAgICAgICBJbWFnZUJ1ZmZlciogYnVmZmVyID0gY2FudmFzLT5idWZmZXIoKTsKICAgICAg ICAgaWYgKGJ1ZmZlciAmJiBidWZmZXItPmNvcHlUb1BsYXRmb3JtVGV4dHVyZSgqbV9jb250ZXh0 LmdldCgpLCB0ZXh0dXJlLT5vYmplY3QoKSwgaW50ZXJuYWxmb3JtYXQsIG1fdW5wYWNrUHJlbXVs dGlwbHlBbHBoYSwgbV91bnBhY2tGbGlwWSkpIHsKICAgICAgICAgICAgIHRleHR1cmUtPnNldExl dmVsSW5mbyh0YXJnZXQsIGxldmVsLCBpbnRlcm5hbGZvcm1hdCwgY2FudmFzLT53aWR0aCgpLCBj YW52YXMtPmhlaWdodCgpLCB0eXBlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9JbWFnZUJ1ZmZlci5oCmluZGV4IDU4OGVmZDFmNTQzMjMxYmFkZjAwMWFmZGI2YmRlNGI2 ZDg4ZDgyNWYuLjRiNzFjMzU5MGRlZDY5OWE5YmI1NDRlYzJkZDhlNTRmZTMzZTdlYzkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VCdWZmZXIuaApAQCAtMTIw LDcgKzEyMCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICNlbmRpZgogCiAgICAgICAgIC8vIEZJ WE1FOiBjdXJyZW50IGltcGxlbWVudGF0aW9ucyBvZiB0aGlzIG1ldGhvZCBoYXZlIHRoZSByZXN0 cmljdGlvbiB0aGF0IHRoZXkgb25seSB3b3JrCi0gICAgICAgIC8vIHdpdGggdGV4dHVyZXMgdGhh dCBhcmUgUkdCQSBmb3JtYXQgYW5kIFVOU0lHTkVEX0JZVEUgdHlwZS4KKyAgICAgICAgLy8gd2l0 aCB0ZXh0dXJlcyB0aGF0IGFyZSBSR0Igb3IgUkdCQSBmb3JtYXQsIGFuZCBVTlNJR05FRF9CWVRF IHR5cGUuCiAgICAgICAgIGJvb2wgY29weVRvUGxhdGZvcm1UZXh0dXJlKEdyYXBoaWNzQ29udGV4 dDNEJiwgUGxhdGZvcm0zRE9iamVjdCwgR0MzRGVudW0sIGJvb2wsIGJvb2wpOwogCiAgICAgICAg IHZvaWQgcmVwb3J0TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyopIGNvbnN0Owo=