100969 2012-11-01 10:05:22 -0700 [EFL][WK2] Remove redundant internal function 2012-11-02 00:16:05 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 756387 0 jinwoo7.song 2012-11-01 10:05:22 -0700 ewk_view_text_found() in ewk_view.cpp is not used anymore, so we can remove it. 756392 1 171883 jinwoo7.song 2012-11-01 10:08:43 -0700 Created attachment 171883 Patch 756882 2 171883 gyuyoung.kim 2012-11-01 21:56:52 -0700 Comment on attachment 171883 Patch In ewk_view_text_matches_count(), there is below comment. Don't you need to send this signal rather than to remove this ? * The "text,found" callback will be called with the number of matched string. EAPI Eina_Bool ewk_view_text_matches_count(Evas_Object *o, const char *text, Ewk_Find_Options options, unsigned max_match_count); 756890 3 jinwoo7.song 2012-11-01 22:38:13 -0700 "text,found" callback is emitted from didFindString in FindClientEfl.cpp. void FindClientEfl::didFindString(WKPageRef, WKStringRef, unsigned matchCount, const void* clientInfo) { FindClientEfl* findClient = toFindClientEfl(clientInfo); findClient->m_viewImpl->smartCallback<TextFound>().call(&matchCount); } FindClientEfl::FindClientEfl(EwkViewImpl* viewImpl) : m_viewImpl(viewImpl) { ... findClient.didCountStringMatches = didFindString; ... } As you know, smart callback call has been refactored, so ewk_view_text_found() is not used anymore. 756892 4 171883 gyuyoung.kim 2012-11-01 22:45:57 -0700 Comment on attachment 171883 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171883&action=review Yes, right. Thanks. > Source/WebKit2/ChangeLog:8 > + Remove ewk_view_text_found() in ewk_view.cpp which is not used anymore. It would be good if you say this signal is emitted by DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned) in EwkViewCallback.h instead. 756893 5 171883 cdumez 2012-11-01 22:49:00 -0700 Comment on attachment 171883 Patch Right, we missed this one. Thanks. LGTM. 756896 6 jinwoo7.song 2012-11-01 22:53:51 -0700 (In reply to comment #4) > (From update of attachment 171883 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171883&action=review > > Yes, right. Thanks. > > > Source/WebKit2/ChangeLog:8 > > + Remove ewk_view_text_found() in ewk_view.cpp which is not used anymore. > > It would be good if you say this signal is emitted by DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned) in EwkViewCallback.h instead. I'll update the ChangeLog as your advice. 756897 7 171987 jinwoo7.song 2012-11-01 22:54:39 -0700 Created attachment 171987 Patch 756932 8 171987 webkit.review.bot 2012-11-02 00:16:00 -0700 Comment on attachment 171987 Patch Clearing flags on attachment: 171987 Committed r133269: <http://trac.webkit.org/changeset/133269> 756933 9 webkit.review.bot 2012-11-02 00:16:05 -0700 All reviewed patches have been landed. Closing bug. 171883 2012-11-01 10:08:43 -0700 2012-11-01 22:54:33 -0700 Patch bug-100969-20121102020703.patch text/plain 1562 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYmZiMmE2YmIyNjJkMTUy NGQ0ZDljMzUxNmMzMGVjMDcxYWY1YmZkYy4uMmFhNDkyYjE2MzlhNjE3ZjVhMGViZDY3Y2RmNmQz MTlkMDkzOThiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTAxICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFJlbW92ZSByZWR1bmRhbnQgaW50ZXJuYWwgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDk2OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBld2tfdmlld190ZXh0X2ZvdW5kKCkg aW4gZXdrX3ZpZXcuY3BwIHdoaWNoIGlzIG5vdCB1c2VkIGFueW1vcmUuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisKIDIwMTItMTEtMDEgIEh1YW5nIERvbmdz dW5nICA8bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgQ29vcmRpbmF0ZWQgR3Jh cGhpY3M6IENsZWFuIHVwIGhlYWRlcnMgb2YgQ29vcmRpbmF0ZWQgR3JhcGhpY3MuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKaW5kZXggNjlkY2E1Mzcz YzJjM2QwZmJhZGY5NTIyNmU1NWY5M2RkNThhNzgwMy4uMDBlYmM3ZDY1MDQzNDE1NmNjZGIwN2Y1 YWE3OTZjZmUxNDhiM2I3YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcApAQCAtNjU5LDE3ICs2NTksNiBAQCBjb25zdCBjaGFyKiBld2tfdmlld190 aXRsZV9nZXQoY29uc3QgRXZhc19PYmplY3QqIGV3a1ZpZXcpCiAgICAgcmV0dXJuIGltcGwtPnRp dGxlKCk7CiB9CiAKLS8qKgotICogQGludGVybmFsCi0gKiBSZXBvcnRzIHRoYXQgdGhlIHJlcXVl c3RlZCB0ZXh0IHdhcyBmb3VuZC4KLSAqCi0gKiBFbWl0cyBzaWduYWw6ICJ0ZXh0LGZvdW5kIiB3 aXRoIHRoZSBudW1iZXIgb2YgbWF0Y2hlcy4KLSAqLwotdm9pZCBld2tfdmlld190ZXh0X2ZvdW5k KEV2YXNfT2JqZWN0KiBld2tWaWV3LCB1bnNpZ25lZCBpbnQgbWF0Y2hDb3VudCkKLXsKLSAgICBl dmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKGV3a1ZpZXcsICJ0ZXh0LGZvdW5kIiwgJm1h dGNoQ291bnQpOwotfQotCiBkb3VibGUgZXdrX3ZpZXdfbG9hZF9wcm9ncmVzc19nZXQoY29uc3Qg RXZhc19PYmplY3QqIGV3a1ZpZXcpCiB7CiAgICAgRVdLX1ZJRVdfSU1QTF9HRVRfT1JfUkVUVVJO KGV3a1ZpZXcsIGltcGwsIC0xLjApOwo= 171987 2012-11-01 22:54:39 -0700 2012-11-02 00:16:00 -0700 Patch bug-100969-20121102145256.patch text/plain 1719 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDA0ODZiY2NjMDczMGU4 MWZhNDY2YTM2NDA5ODM1YzBhYmM1MGZmOC4uOWUxNjkxMDMyZjQ2MDJkNDNkNDc2N2Q2MzRhZjRk MzRjYmY3N2E1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTAxICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJd IFJlbW92ZSByZWR1bmRhbnQgaW50ZXJuYWwgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDk2OQorCisgICAgICAgIFJldmlld2VkIGJ5 IEd5dXlvdW5nIEtpbS4KKworICAgICAgICBSZW1vdmUgZXdrX3ZpZXdfdGV4dF9mb3VuZCgpIGlu IGV3a192aWV3LmNwcCB3aGljaCBpcyBub3QgdXNlZCBhbnltb3JlLgorICAgICAgICBOb3csICJ0 ZXh0LGZvdW5kIiBzaWduYWwgaXMgZW1pdHRlZCBieSBERUNMQVJFX0VXS19WSUVXX0NBTExCQUNL KFRleHRGb3VuZCwgInRleHQsZm91bmQiLCB1bnNpZ25lZCkgCisgICAgICAgIGluIEV3a1ZpZXdD YWxsYmFjay5oCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHA6CisK IDIwMTItMTEtMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZWZvcm1hdCB0aGUgYW5ub3RhdGlvblN0eWxlIGluaXRpYWxpemVyIHRvIGFwcGVhc2Ug dXBkYXRlLXdlYmtpdC1sb2NhbGl6YWJsZS1zdHJpbmdzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCmluZGV4IDY5ZGNhNTM3M2MyYzNkMGZiYWRmOTUy MjZlNTVmOTNkZDU4YTc4MDMuLjAwZWJjN2Q2NTA0MzQxNTZjY2RiMDdmNWFhNzk2Y2ZlMTQ4YjNi N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAK QEAgLTY1OSwxNyArNjU5LDYgQEAgY29uc3QgY2hhciogZXdrX3ZpZXdfdGl0bGVfZ2V0KGNvbnN0 IEV2YXNfT2JqZWN0KiBld2tWaWV3KQogICAgIHJldHVybiBpbXBsLT50aXRsZSgpOwogfQogCi0v KioKLSAqIEBpbnRlcm5hbAotICogUmVwb3J0cyB0aGF0IHRoZSByZXF1ZXN0ZWQgdGV4dCB3YXMg Zm91bmQuCi0gKgotICogRW1pdHMgc2lnbmFsOiAidGV4dCxmb3VuZCIgd2l0aCB0aGUgbnVtYmVy IG9mIG1hdGNoZXMuCi0gKi8KLXZvaWQgZXdrX3ZpZXdfdGV4dF9mb3VuZChFdmFzX09iamVjdCog ZXdrVmlldywgdW5zaWduZWQgaW50IG1hdGNoQ291bnQpCi17Ci0gICAgZXZhc19vYmplY3Rfc21h cnRfY2FsbGJhY2tfY2FsbChld2tWaWV3LCAidGV4dCxmb3VuZCIsICZtYXRjaENvdW50KTsKLX0K LQogZG91YmxlIGV3a192aWV3X2xvYWRfcHJvZ3Jlc3NfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBl d2tWaWV3KQogewogICAgIEVXS19WSUVXX0lNUExfR0VUX09SX1JFVFVSTihld2tWaWV3LCBpbXBs LCAtMS4wKTsK