100967 2012-11-01 09:52:14 -0700 Web Inspector: expose Inspector.detached event factory to the embedder. 2012-11-01 10:43:09 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth apavlov dglazkov fishd jamesr keishi loislo pfeldman pmuellr tkent+wkapi vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 756369 0 pfeldman 2012-11-01 09:52:14 -0700 That way embedder will be able to send messages on behalf of the backend being destructed. 756373 1 171878 pfeldman 2012-11-01 09:54:57 -0700 Created attachment 171878 Patch 756379 2 webkit.review.bot 2012-11-01 09:57:56 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 756432 3 171878 webkit.review.bot 2012-11-01 10:43:05 -0700 Comment on attachment 171878 Patch Clearing flags on attachment: 171878 Committed r133191: <http://trac.webkit.org/changeset/133191> 756433 4 webkit.review.bot 2012-11-01 10:43:09 -0700 All reviewed patches have been landed. Closing bug. 171878 2012-11-01 09:54:57 -0700 2012-11-01 10:43:04 -0700 Patch bug-100967-20121101205318.patch text/plain 4299 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBmYTdlMTFhYzE0OTZiZTRkZTQ4ZWI1ODg0Yzk1ZWVkYjM3ODEwNDguLjdhODc4YzA4Y2Q4N2Qx YTRkZDg0OGMzNWNkZmY5NmQ4ZjdkZjlkYjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMTEtMDEgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZXhwb3NlIEluc3BlY3Rvci5kZXRh Y2hlZCBldmVudCBmYWN0b3J5IHRvIHRoZSBlbWJlZGRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDk2NworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoYXQgd2F5IGVtYmVkZGVyIHdpbGwgYmUgYWJs ZSB0byBzZW5kIG1lc3NhZ2VzIG9uIGJlaGFsZiBvZiB0aGUgYmFja2VuZCBiZWluZyBkZXN0cnVj dGVkLgorCisgICAgICAgICogcHVibGljL1dlYkRldlRvb2xzQWdlbnQuaDoKKyAgICAgICAgKFdl YkRldlRvb2xzQWdlbnQpOgorICAgICAgICAqIHNyYy9XZWJEZXZUb29sc0FnZW50SW1wbC5jcHA6 CisgICAgICAgIChTZXJpYWxpemluZ0Zyb250ZW5kQ2hhbm5lbCk6CisgICAgICAgIChXZWJLaXQ6 OlNlcmlhbGl6aW5nRnJvbnRlbmRDaGFubmVsOjpzZW5kTWVzc2FnZVRvRnJvbnRlbmQpOgorICAg ICAgICAoV2ViS2l0OjpXZWJEZXZUb29sc0FnZW50OjppbnNwZWN0b3JEZXRhY2hlZEV2ZW50KToK KyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChXZWJLaXQ6OldlYkRldlRvb2xzQWdlbnQ6Ondv cmtlckRpc2Nvbm5lY3RlZEZyb21Xb3JrZXJFdmVudCk6CisgICAgICAgIChXZWJLaXQ6OldlYkRl dlRvb2xzQWdlbnQ6OmRpc2Nvbm5lY3RFdmVudEFzVGV4dCk6CisKIDIwMTItMTEtMDEgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEF2 b2lkIGF0dGVtcHRpbmcgdG8gZGVmZXIgY29tbWl0cyB3aGVuIHRoZXkgYXJlIGFscmVhZHkgZGVm ZXJyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRv b2xzQWdlbnQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdl bnQuaAppbmRleCA0ZjkwMzAyYzg1MDMyNjJmNGE3NmRlOTQ3NDdhNzg1ZGJkMTQ0NzIwLi5iNjEx MDVkMjdkMmJlNGY2ZWFjMWNkYTk3OWMwOGRkNGNkZmFjNzczIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50LmgKKysrIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9vbHNBZ2VudC5oCkBAIC04MCw4ICs4MCwxNCBA QCBwdWJsaWM6CiAgICAgV0VCS0lUX0VYUE9SVCBzdGF0aWMgYm9vbCBzaG91bGRJbnRlcnJ1cHRG b3JNZXNzYWdlKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIHZv aWQgcHJvY2Vzc1BlbmRpbmdNZXNzYWdlcygpOwogCi0gICAgLy8gUmV0dXJucyBhIGRpc2Nvbm5l Y3QgZXZlbnQgdGhhdCBjYW4gYmUgZGlzcGF0Y2hlZCBvbiB0aGUgZnJvbnQtZW5kCisgICAgLy8g UmV0dXJucyBhbiBJbnNwZWN0b3IuZGV0YWNoZWQgZXZlbnQgdGhhdCBjYW4gYmUgZGlzcGF0Y2hl ZCBvbiB0aGUgZnJvbnQtZW5kIGJ5IHRoZSBlbWJlZGRlci4KKyAgICBXRUJLSVRfRVhQT1JUIHN0 YXRpYyBXZWJTdHJpbmcgaW5zcGVjdG9yRGV0YWNoZWRFdmVudChjb25zdCBXZWJTdHJpbmcmIHJl YXNvbik7CisKKyAgICAvLyBSZXR1cm5zIGEgV29ya2VyLmRpc2Nvbm5lY3RlZEZyb21Xb3JrZXIg ZXZlbnQgdGhhdCBjYW4gYmUgZGlzcGF0Y2hlZCBvbiB0aGUgZnJvbnQtZW5kCiAgICAgLy8gaW4g b3JkZXIgdG8gbGV0IGl0IGtub3cgdGhhdCBpdCBoYXMgZGlzY29ubmVjdGVkIGZyb20gdGhlIGFn ZW50LgorICAgIFdFQktJVF9FWFBPUlQgc3RhdGljIFdlYlN0cmluZyB3b3JrZXJEaXNjb25uZWN0 ZWRGcm9tV29ya2VyRXZlbnQoKTsKKworICAgIC8vIEZJWE1FOiByZW1vdmUgb25jZSBtaWdyYXRl ZCB0byB3b3JrZXJEaXNjb25uZWN0ZWRGcm9tV29ya2VyRXZlbnQoKS4KICAgICBXRUJLSVRfRVhQ T1JUIHN0YXRpYyBXZWJTdHJpbmcgZGlzY29ubmVjdEV2ZW50QXNUZXh0KCk7CiB9OwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEZXZUb29sc0FnZW50SW1wbC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEZXZUb29sc0FnZW50SW1wbC5jcHAK aW5kZXggNWMyNWZmNjRlMTBmYzQ3OTVmZTYyZGZiMGNmZmY3YTMwOWM1ZTA4Yi4uNWQ2YTFkMDli ZTM2N2M0M2Q3Y2VhYTFjNTE1Nzg1ZDBiMmU5NjQwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkRldlRvb2xzQWdlbnRJbXBsLmNwcApAQCAtMzQ4LDYgKzM0OCwx NSBAQCBwcml2YXRlOgogICAgIGRvdWJsZSBtX29yaWdpbmFsWm9vbUZhY3RvcjsKIH07CiAKK2Ns YXNzIFNlcmlhbGl6aW5nRnJvbnRlbmRDaGFubmVsIDogcHVibGljIEluc3BlY3RvckZyb250ZW5k Q2hhbm5lbCB7CitwdWJsaWM6CisgICAgdmlydHVhbCBib29sIHNlbmRNZXNzYWdlVG9Gcm9udGVu ZChjb25zdCBTdHJpbmcmIG1lc3NhZ2UpCisgICAgeworICAgICAgICBtX21lc3NhZ2UgPSBtZXNz YWdlOworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9CisgICAgU3RyaW5nIG1fbWVzc2FnZTsK K307CiAKIFdlYkRldlRvb2xzQWdlbnRJbXBsOjpXZWJEZXZUb29sc0FnZW50SW1wbCgKICAgICBX ZWJWaWV3SW1wbCogd2ViVmlld0ltcGwsCkBAIC02ODUsMTcgKzY5NCwxNyBAQCB2b2lkIFdlYkRl dlRvb2xzQWdlbnQ6OnByb2Nlc3NQZW5kaW5nTWVzc2FnZXMoKQogICAgIFBhZ2VTY3JpcHREZWJ1 Z1NlcnZlcjo6c2hhcmVkKCkucnVuUGVuZGluZ1Rhc2tzKCk7CiB9CiAKLVdlYlN0cmluZyBXZWJE ZXZUb29sc0FnZW50OjpkaXNjb25uZWN0RXZlbnRBc1RleHQoKQorV2ViU3RyaW5nIFdlYkRldlRv b2xzQWdlbnQ6Omluc3BlY3RvckRldGFjaGVkRXZlbnQoY29uc3QgV2ViU3RyaW5nJiByZWFzb24p CiB7Ci0gICAgY2xhc3MgQ2hhbm5lbEltcGwgOiBwdWJsaWMgSW5zcGVjdG9yRnJvbnRlbmRDaGFu bmVsIHsKLSAgICBwdWJsaWM6Ci0gICAgICAgIHZpcnR1YWwgYm9vbCBzZW5kTWVzc2FnZVRvRnJv bnRlbmQoY29uc3QgU3RyaW5nJiBtZXNzYWdlKQotICAgICAgICB7Ci0gICAgICAgICAgICBtX21l c3NhZ2UgPSBtZXNzYWdlOwotICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgICAgIH0KLSAg ICAgICAgU3RyaW5nIG1fbWVzc2FnZTsKLSAgICB9IGNoYW5uZWw7CisgICAgU2VyaWFsaXppbmdG cm9udGVuZENoYW5uZWwgY2hhbm5lbDsKKyAgICBJbnNwZWN0b3JGcm9udGVuZDo6SW5zcGVjdG9y IGluc3BlY3RvcigmY2hhbm5lbCk7CisgICAgaW5zcGVjdG9yLmRldGFjaGVkKHJlYXNvbik7Cisg ICAgcmV0dXJuIGNoYW5uZWwubV9tZXNzYWdlOworfQorCitXZWJTdHJpbmcgV2ViRGV2VG9vbHNB Z2VudDo6d29ya2VyRGlzY29ubmVjdGVkRnJvbVdvcmtlckV2ZW50KCkKK3sKKyAgICBTZXJpYWxp emluZ0Zyb250ZW5kQ2hhbm5lbCBjaGFubmVsOwogI2lmIEVOQUJMRShXT1JLRVJTKQogICAgIElu c3BlY3RvckZyb250ZW5kOjpXb3JrZXIgaW5zcGVjdG9yKCZjaGFubmVsKTsKICAgICBpbnNwZWN0 b3IuZGlzY29ubmVjdGVkRnJvbVdvcmtlcigpOwpAQCAtNzAzLDQgKzcxMiwxMCBAQCBXZWJTdHJp bmcgV2ViRGV2VG9vbHNBZ2VudDo6ZGlzY29ubmVjdEV2ZW50QXNUZXh0KCkKICAgICByZXR1cm4g Y2hhbm5lbC5tX21lc3NhZ2U7CiB9CiAKKy8vIEZJWE1FOiByZW1vdmUgdGhpcyBvbmNlIG1pZ3Jh dGVkIHRvIHdvcmtlckRpc2Nvbm5lY3RlZEZyb21Xb3JrZXJFdmVudCgpLgorV2ViU3RyaW5nIFdl YkRldlRvb2xzQWdlbnQ6OmRpc2Nvbm5lY3RFdmVudEFzVGV4dCgpCit7CisgICAgcmV0dXJuIFdl YkRldlRvb2xzQWdlbnQ6OndvcmtlckRpc2Nvbm5lY3RlZEZyb21Xb3JrZXJFdmVudCgpOworfQor CiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK