100963 2012-11-01 09:11:29 -0700 [V8] The V8DOMMap visitors are no longer needed 2012-11-01 09:58:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100965 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 756321 0 abarth 2012-11-01 09:11:29 -0700 [V8] The V8DOMMap visitors are no longer needed 756322 1 171869 abarth 2012-11-01 09:12:17 -0700 Created attachment 171869 Patch 756326 2 171869 haraken 2012-11-01 09:15:43 -0700 Comment on attachment 171869 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171869&action=review > Source/WebCore/bindings/v8/V8DOMMap.cpp:-88 > -void visitDOMObjects(DOMWrapperVisitor<void>* visitor) This is not used by anybody, right? 756329 3 abarth 2012-11-01 09:16:41 -0700 (In reply to comment #2) > (From update of attachment 171869 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171869&action=review > > > Source/WebCore/bindings/v8/V8DOMMap.cpp:-88 > > -void visitDOMObjects(DOMWrapperVisitor<void>* visitor) > > This is not used by anybody, right? Not anymore! :) 756364 4 171869 webkit.review.bot 2012-11-01 09:48:14 -0700 Comment on attachment 171869 Patch Clearing flags on attachment: 171869 Committed r133187: <http://trac.webkit.org/changeset/133187> 756365 5 webkit.review.bot 2012-11-01 09:48:18 -0700 All reviewed patches have been landed. Closing bug. 171869 2012-11-01 09:12:17 -0700 2012-11-01 09:48:14 -0700 Patch bug-100963-20121101091038.patch text/plain 5114 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVmYjEwYmYyN2JhYmUw ZmZhM2Y0OGFmZjVkMmFkYTMyNjhjOTkzNi4uZWRkZDA2NzQ0ZDQyN2I4ZjI3NDg3MTA3YzFiMGZk NDI1OTY3MGY5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDEyLTExLTAxICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBUaGUgVjhET01NYXAg dmlzaXRvcnMgYXJlIG5vIGxvbmdlciBuZWVkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDk2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggaW5saW5lcyB2aXNpdEFsbERPTU5vZGVz IGludG8gaXRzIG9uZSBjYWxsZXIgKGFuZCByZW1vdmVzCisgICAgICAgIG9uZSBsYXllciBvZiB2 aXNpdG9yIGFkYXB0b3IgYWJzdHJhY3Rpb24pLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2Ny aXB0UHJvZmlsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0UHJvZmlsZXI6OnZpc2l0 Tm9kZVdyYXBwZXJzKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTU1hcC5jcHA6CisgICAg ICAgICogYmluZGluZ3MvdjgvVjhET01NYXAuaDoKKyAgICAgICAgKFdlYkNvcmUpOgorCisyMDEy LTExLTAxICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgVW5yZXZp ZXdlZC4gQnVpbGQgZml4LgogCiAgICAgICAgICogYmluZGluZ3MvdjgvVjhHQ0NvbnRyb2xsZXIu Y3BwOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmls ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0UHJvZmlsZXIuY3BwCmlu ZGV4IDc4ZTdlMDdmNWYxMmE2NzM1NGMwYzA2Yjk3ZGE2OWVkMjljYWVmMjcuLmZmODRlYzYxN2Mz NGQyNDIyNGE3ZjgwMDYwZTZmMjQzYjE5OWY5ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdFByb2ZpbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRQcm9maWxlci5jcHAKQEAgLTE3OSwyMyArMTc5LDMwIEBAIHZvaWQgU2Ny aXB0UHJvZmlsZXI6OmluaXRpYWxpemUoKQogCiB2b2lkIFNjcmlwdFByb2ZpbGVyOjp2aXNpdE5v ZGVXcmFwcGVycyhXcmFwcGVkTm9kZVZpc2l0b3IqIHZpc2l0b3IpCiB7Ci0gICAgY2xhc3MgVmlz aXRvckFkYXB0ZXIgOiBwdWJsaWMgTm9kZVdyYXBwZXJWaXNpdG9yIHsKKyAgICB2ODo6SGFuZGxl U2NvcGUgc2NvcGU7CisKKyAgICBjbGFzcyBWaXNpdG9yQWRhcHRlciA6IHB1YmxpYyB2ODo6UGVy c2lzdGVudEhhbmRsZVZpc2l0b3IgewogICAgIHB1YmxpYzoKLSAgICAgICAgVmlzaXRvckFkYXB0 ZXIoV3JhcHBlZE5vZGVWaXNpdG9yKiB2aXNpdG9yKQorICAgICAgICBleHBsaWNpdCBWaXNpdG9y QWRhcHRlcihXcmFwcGVkTm9kZVZpc2l0b3IqIHZpc2l0b3IpCiAgICAgICAgICAgICA6IG1fdmlz aXRvcih2aXNpdG9yKQogICAgICAgICB7CiAgICAgICAgIH0KIAotICAgICAgICB2aXJ0dWFsIHZv aWQgdmlzaXROb2RlV3JhcHBlcihOb2RlKiBub2RlLCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0 PikKKyAgICAgICAgdmlydHVhbCB2b2lkIFZpc2l0UGVyc2lzdGVudEhhbmRsZSh2ODo6UGVyc2lz dGVudDx2ODo6VmFsdWU+IHZhbHVlLCB1aW50MTZfdCBjbGFzc0lkKQogICAgICAgICB7Ci0gICAg ICAgICAgICBtX3Zpc2l0b3ItPnZpc2l0Tm9kZShub2RlKTsKKyAgICAgICAgICAgIGlmIChjbGFz c0lkICE9IHY4RE9NTm9kZUNsYXNzSWQpCisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAg ICAgICAgQVNTRVJUKFY4Tm9kZTo6SGFzSW5zdGFuY2UodmFsdWUpKTsKKyAgICAgICAgICAgIEFT U0VSVCh2YWx1ZS0+SXNPYmplY3QoKSk7CisgICAgICAgICAgICB2ODo6UGVyc2lzdGVudDx2ODo6 T2JqZWN0PiB3cmFwcGVyID0gdjg6OlBlcnNpc3RlbnQ8djg6Ok9iamVjdD46OkNhc3QodmFsdWUp OworICAgICAgICAgICAgbV92aXNpdG9yLT52aXNpdE5vZGUoVjhOb2RlOjp0b05hdGl2ZSh3cmFw cGVyKSk7CiAgICAgICAgIH0KIAogICAgIHByaXZhdGU6CiAgICAgICAgIFdyYXBwZWROb2RlVmlz aXRvciogbV92aXNpdG9yOwotICAgIH0gYWRhcHRlcih2aXNpdG9yKTsKKyAgICB9IHZpc2l0b3JB ZGFwdGVyKHZpc2l0b3IpOwogCi0gICAgdmlzaXRBbGxET01Ob2RlcygmYWRhcHRlcik7CisgICAg djg6OlY4OjpWaXNpdEhhbmRsZXNXaXRoQ2xhc3NJZHMoJnZpc2l0b3JBZGFwdGVyKTsKIH0KIAog dm9pZCBTY3JpcHRQcm9maWxlcjo6dmlzaXRFeHRlcm5hbFN0cmluZ3MoRXh0ZXJuYWxTdHJpbmdW aXNpdG9yKiB2aXNpdG9yKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhET01NYXAuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAuY3BwCmlu ZGV4IGFjNGNkOGQ4MDc1ZmRiZTI0NWZjYTI4NDU5YzRkMzliNDlhYTY3MzQuLjM0MzM3ZTA5NmZl NDE0ZTFiNzZmNzJhNjA4NmMwZjA3ZmE3ZDJmMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTU1hcC5jcHAKQEAgLTM4LDEwICszOCw2IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAotTm9kZVdyYXBwZXJWaXNpdG9yOjp+Tm9kZVdyYXBwZXJWaXNpdG9yKCkKLXsKLX0KLQogRE9N V3JhcHBlck1hcDxOb2RlPiYgZ2V0RE9NTm9kZU1hcCh2ODo6SXNvbGF0ZSogaXNvbGF0ZSkKIHsK ICAgICBpZiAoIWlzb2xhdGUpCkBAIC01Niw0NSArNTIsNCBAQCBET01XcmFwcGVyTWFwPHZvaWQ+ JiBnZXRET01PYmplY3RNYXAodjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAgICAgcmV0dXJuIERPTURh dGFTdG9yZTo6Y3VycmVudChpc29sYXRlKS0+ZG9tT2JqZWN0TWFwKCk7CiB9CiAKLXZvaWQgdmlz aXRBbGxET01Ob2RlcyhOb2RlV3JhcHBlclZpc2l0b3IqIHZpc2l0b3IpCi17Ci0gICAgdjg6Okhh bmRsZVNjb3BlIHNjb3BlOwotCi0gICAgY2xhc3MgVmlzaXRvckFkYXB0ZXIgOiBwdWJsaWMgdjg6 OlBlcnNpc3RlbnRIYW5kbGVWaXNpdG9yIHsKLSAgICBwdWJsaWM6Ci0gICAgICAgIGV4cGxpY2l0 IFZpc2l0b3JBZGFwdGVyKE5vZGVXcmFwcGVyVmlzaXRvciogdmlzaXRvcikKLSAgICAgICAgICAg IDogbV92aXNpdG9yKHZpc2l0b3IpCi0gICAgICAgIHsKLSAgICAgICAgfQotCi0gICAgICAgIHZp cnR1YWwgdm9pZCBWaXNpdFBlcnNpc3RlbnRIYW5kbGUodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVl PiB2YWx1ZSwgdWludDE2X3QgY2xhc3NJZCkKLSAgICAgICAgewotICAgICAgICAgICAgaWYgKGNs YXNzSWQgIT0gdjhET01Ob2RlQ2xhc3NJZCkKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAg ICAgICAgICBBU1NFUlQoVjhOb2RlOjpIYXNJbnN0YW5jZSh2YWx1ZSkpOwotICAgICAgICAgICAg QVNTRVJUKHZhbHVlLT5Jc09iamVjdCgpKTsKLSAgICAgICAgICAgIEFTU0VSVCghdmFsdWUuSXNJ bmRlcGVuZGVudCgpKTsKLSAgICAgICAgICAgIHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IHdy YXBwZXIgPSB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1ZSk7Ci0gICAgICAg ICAgICBtX3Zpc2l0b3ItPnZpc2l0Tm9kZVdyYXBwZXIoVjhOb2RlOjp0b05hdGl2ZSh3cmFwcGVy KSwgd3JhcHBlcik7Ci0gICAgICAgIH0KLQotICAgIHByaXZhdGU6Ci0gICAgICAgIE5vZGVXcmFw cGVyVmlzaXRvciogbV92aXNpdG9yOwotICAgIH0gdmlzaXRvckFkYXB0ZXIodmlzaXRvcik7Ci0K LSAgICB2ODo6Vjg6OlZpc2l0SGFuZGxlc1dpdGhDbGFzc0lkcygmdmlzaXRvckFkYXB0ZXIpOwot fQotCi12b2lkIHZpc2l0RE9NT2JqZWN0cyhET01XcmFwcGVyVmlzaXRvcjx2b2lkPiogdmlzaXRv cikKLXsKLSAgICB2ODo6SGFuZGxlU2NvcGUgc2NvcGU7Ci0KLSAgICBWZWN0b3I8RE9NRGF0YVN0 b3JlKj4mIGxpc3QgPSBWOFBlcklzb2xhdGVEYXRhOjpjdXJyZW50KCktPmFsbFN0b3JlcygpOwot ICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGlzdC5zaXplKCk7ICsraSkgewotICAgICAgICBE T01EYXRhU3RvcmUqIHN0b3JlID0gbGlzdFtpXTsKLQotICAgICAgICBzdG9yZS0+ZG9tT2JqZWN0 TWFwKCkudmlzaXQoc3RvcmUsIHZpc2l0b3IpOwotICAgIH0KLX0KLQogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01NYXAu aCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NTWFwLmgKaW5kZXggNmMyZDkzM2Iz YTlmY2FmOWEzY2QwYzA2YTNiMWE0ZTgwMGQwNDI3Zi4uZDhjN2QyODllMDNhYTIxZDIxNjM3ODFj YmI1ZWVhZGE0NTM1NmM2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhET01NYXAuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTU1hcC5oCkBA IC00MiwxNyArNDIsOCBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIE5vZGVXcmFw cGVyVmlzaXRvciB7Ci1wdWJsaWM6Ci0gICAgdmlydHVhbCB+Tm9kZVdyYXBwZXJWaXNpdG9yKCk7 Ci0gICAgdmlydHVhbCB2b2lkIHZpc2l0Tm9kZVdyYXBwZXIoTm9kZSosIHY4OjpQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+IHdyYXBwZXIpID0gMDsKLX07Ci0KIERPTVdyYXBwZXJNYXA8Tm9kZT4mIGdl dERPTU5vZGVNYXAodjg6Oklzb2xhdGUqID0gMCk7Ci12b2lkIHZpc2l0QWxsRE9NTm9kZXMoTm9k ZVdyYXBwZXJWaXNpdG9yKik7Ci0KIERPTVdyYXBwZXJNYXA8dm9pZD4mIGdldERPTU9iamVjdE1h cCh2ODo6SXNvbGF0ZSogPSAwKTsKLXZvaWQgdmlzaXRET01PYmplY3RzKERPTVdyYXBwZXJWaXNp dG9yPHZvaWQ+Kik7CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAo=