100960 2012-11-01 08:36:20 -0700 [BlackBerry] Use clipped background rect in backing store 2012-11-01 09:24:56 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 leoyang webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 756288 0 leoyang 2012-11-01 08:36:20 -0700 1190 void BackingStorePrivate::paintDefaultBackground(const Platform::IntRect& dstRect, Platform::ViewportAccessor* viewportAccessor, bool flush) 1191 { 1192 Platform::IntRect clippedDstRect = dstRect; 1193 1194 // Because of rounding it is possible that overScrollRect could be off-by-one larger 1195 // than the surface size of the window. We prevent this here, by clamping 1196 // it to ensure that can't happen. 1197 clippedDstRect.intersect(Platform::IntRect(Platform::IntPoint(0, 0), surfaceSize())); 1198 1199 if (clippedDstRect.isEmpty()) 1200 return; 1201 1202 // We have to paint the default background in the case of overzoom and 1203 // make sure it is invalidated. 1204 const Platform::IntRect pixelContentsRect = viewportAccessor->pixelContentsRect(); 1205 Platform::IntRectRegion overScrollRegion = Platform::IntRectRegion::subtractRegions( 1206 dstRect, viewportAccessor->pixelViewportFromContents(pixelContentsRect)); In line 1206 it is wrongly using unclipped back ground destination rect which cause platform code ASSERT. 756304 1 171862 leoyang 2012-11-01 08:47:00 -0700 Created attachment 171862 Patch 756305 2 171862 yong.li.webkit 2012-11-01 08:49:46 -0700 Comment on attachment 171862 Patch r+/cq+ as it is internally reviewed by Arvid 756339 3 171862 webkit.review.bot 2012-11-01 09:24:53 -0700 Comment on attachment 171862 Patch Clearing flags on attachment: 171862 Committed r133184: <http://trac.webkit.org/changeset/133184> 756340 4 webkit.review.bot 2012-11-01 09:24:56 -0700 All reviewed patches have been landed. Closing bug. 171862 2012-11-01 08:47:00 -0700 2012-11-01 09:24:53 -0700 Patch 0001-BlackBerry-Use-clipped-background-rect-in-backing-st.patch text/plain 2512 leoyang RnJvbSAwMjkyNjQ1MThiMGRjZWQyNmRhMzBhZDIwZTlhYmFkMWQ5OWY4OWUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBUaHUs IDEgTm92IDIwMTIgMTE6NDM6MDYgLTA0MDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g VXNlIGNsaXBwZWQgYmFja2dyb3VuZCByZWN0IGluIGJhY2tpbmcgc3RvcmUKIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5NjAKClJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgpSZXZpZXdlZCBpbnRlcm5hbGx5IGJ5IEFydmlkIE5pbHNzb24uCgpXZSBjYWxjdWxh dGVkIGNsaXBwZWQgYmFja2dyb3VuZCByZWN0IGJ1dCBkaWRuJ3QgcmVhbGx5IHVzZSBpdCB3aGVu IHBhaW50aW5nCnRoZSBiYWNrZ3JvdW5kLiBVc2UgdGhlIGNvcnJlY3QgcmVjdCB0byBhdm9pZCBB U1NFUlQgZmFpbHVyZSBpbiBwbGF0Zm9ybSBjb2RlLgoKKiBBcGkvQmFja2luZ1N0b3JlLmNwcDoK KEJsYWNrQmVycnk6OldlYktpdDo6QmFja2luZ1N0b3JlUHJpdmF0ZTo6cGFpbnREZWZhdWx0QmFj a2dyb3VuZCk6Ci0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUu Y3BwIHwgICAgMiArLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAg ICAgIHwgICAxNCArKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFj a2luZ1N0b3JlLmNwcAppbmRleCAzNDU5OWU4Li4zN2ZlNjA4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCkBAIC0xMjAzLDcgKzEyMDMsNyBAQCB2 b2lkIEJhY2tpbmdTdG9yZVByaXZhdGU6OnBhaW50RGVmYXVsdEJhY2tncm91bmQoY29uc3QgUGxh dGZvcm06OkludFJlY3QmIGRzdFJlYwogICAgIC8vIG1ha2Ugc3VyZSBpdCBpcyBpbnZhbGlkYXRl ZC4KICAgICBjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCBwaXhlbENvbnRlbnRzUmVjdCA9IHZpZXdw b3J0QWNjZXNzb3ItPnBpeGVsQ29udGVudHNSZWN0KCk7CiAgICAgUGxhdGZvcm06OkludFJlY3RS ZWdpb24gb3ZlclNjcm9sbFJlZ2lvbiA9IFBsYXRmb3JtOjpJbnRSZWN0UmVnaW9uOjpzdWJ0cmFj dFJlZ2lvbnMoCi0gICAgICAgIGRzdFJlY3QsIHZpZXdwb3J0QWNjZXNzb3ItPnBpeGVsVmlld3Bv cnRGcm9tQ29udGVudHMocGl4ZWxDb250ZW50c1JlY3QpKTsKKyAgICAgICAgY2xpcHBlZERzdFJl Y3QsIHZpZXdwb3J0QWNjZXNzb3ItPnBpeGVsVmlld3BvcnRGcm9tQ29udGVudHMocGl4ZWxDb250 ZW50c1JlY3QpKTsKIAogICAgIEludFJlY3RMaXN0IG92ZXJTY3JvbGxSZWN0cyA9IG92ZXJTY3Jv bGxSZWdpb24ucmVjdHMoKTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG92ZXJTY3JvbGxS ZWN0cy5zaXplKCk7ICsraSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggODA2 ZTM4Yi4uZmVjZDg5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTcgQEAKKzIwMTItMTEtMDEgIExlbyBZYW5nICA8bGVveWFuZ0ByaW0uY29tPgorCisgICAgICAg IFtCbGFja0JlcnJ5XSBVc2UgY2xpcHBlZCBiYWNrZ3JvdW5kIHJlY3QgaW4gYmFja2luZyBzdG9y ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwOTYw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIFJldmlld2Vk IGludGVybmFsbHkgYnkgQXJ2aWQgTmlsc3Nvbi4KKworICAgICAgICBXZSBjYWxjdWxhdGVkIGNs aXBwZWQgYmFja2dyb3VuZCByZWN0IGJ1dCBkaWRuJ3QgcmVhbGx5IHVzZSBpdCB3aGVuIHBhaW50 aW5nCisgICAgICAgIHRoZSBiYWNrZ3JvdW5kLiBVc2UgdGhlIGNvcnJlY3QgcmVjdCB0byBhdm9p ZCBBU1NFUlQgZmFpbHVyZSBpbiBwbGF0Zm9ybSBjb2RlLgorCisgICAgICAgICogQXBpL0JhY2tp bmdTdG9yZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OkJhY2tpbmdTdG9yZVBy aXZhdGU6OnBhaW50RGVmYXVsdEJhY2tncm91bmQpOgorCiAyMDEyLTEwLTI5ICBNaWtlIExhdHRh bnppbyAgPG1sYXR0YW56aW9AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gVHlwbyBp biBXZWJQYWdlUHJpdmF0ZTo6cG9zdHBvbmVEb2N1bWVudFJlY2FsY1N0eWxlKCkKLS0gCjEuNy41 LjQKCg==