100941 2012-11-01 04:09:33 -0700 [BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript" 2012-11-01 18:40:44 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 PeterHWang webkit-unassigned charles.wei mifenton rwlbuis staikos timothy tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 756067 0 PeterHWang 2012-11-01 04:09:33 -0700 Simplify the code to make it fast and to avoid unnecessary Lock. 756086 1 171813 PeterHWang 2012-11-01 04:28:23 -0700 Created attachment 171813 Patch 756803 2 171813 webkit.review.bot 2012-11-01 18:40:40 -0700 Comment on attachment 171813 Patch Clearing flags on attachment: 171813 Committed r133253: <http://trac.webkit.org/changeset/133253> 756804 3 webkit.review.bot 2012-11-01 18:40:44 -0700 All reviewed patches have been landed. Closing bug. 171813 2012-11-01 04:28:23 -0700 2012-11-01 18:40:40 -0700 Patch bug-100941-20121101192639.patch text/plain 4292 PeterHWang U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAxMTU4MGY0NmI0MDUyMDQ1YjQ4ZGRiNmNhNTU5OTNiMGQ4NmRkMDRlLi5hNTE4NDNlYzg0 OGRmNGUyZDkwZDhiNDQ2NjZjODMyNmRlMGM2ZjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMS0wMSAgUGV0ZXIgV2FuZyAgPHBldGVyLndh bmdAdG9yY2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBTaW1wbGlmeSB0 aGUgY29kZSBvZiByZXR1cm5pbmcgSlNWYWx1ZSBpbiAiQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQ YWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIHVubmVjZXNzYXJ5IHN0ZXBzLCBqdXN0 IGRpcmVjdGx5IGRlYWwgd2l0aCByZXR1cm5lZCBKU1ZhbHVlLgorCisgICAgICAgICogQXBpL1dl YlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6 ZXhlY3V0ZUphdmFTY3JpcHQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdl UHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHRJbklzb2xhdGVkV29ybGQpOgorCiAyMDEyLTEwLTI5 ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFNpbXBs aWZ5IEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlTWFuYWdlcjo6aW5zdGFuY2UKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IGUyMjc4ODRkMTNiNDE5YzAyMzc3NGU5 Y2E5YTRlNTA2MjdmNjk2ZTEuLjJmNjg3NDUyN2M5OWU0NDQwNzY5MDMyZDAwMmIwMmQ2MGQxZGUx ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAK KysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcApAQCAtNzgxLDM2 ICs3ODEsMjUgQEAgYm9vbCBXZWJQYWdlUHJpdmF0ZTo6ZXhlY3V0ZUphdmFTY3JpcHQoY29uc3Qg QmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0cmluZyYgc2NyaXAKICAgICAgICAgcmV0dXJuIGZhbHNl OwogICAgIH0KIAotICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gbV9tYWluRnJhbWUtPnNjcmlw dCgpLT5nbG9iYWxPYmplY3QobWFpblRocmVhZE5vcm1hbFdvcmxkKCkpLT5nbG9iYWxFeGVjKCk7 Ci0gICAgSlNHbG9iYWxDb250ZXh0UmVmIGNvbnRleHQgPSB0b0dsb2JhbFJlZihleGVjKTsKLQot ICAgIEpTQzo6SlNMb2NrSG9sZGVyIGxvY2soZXhlYyk7Ci0gICAgSlNUeXBlIHR5cGUgPSBKU1Zh bHVlR2V0VHlwZShjb250ZXh0LCB0b1JlZihleGVjLCB2YWx1ZSkpOwotCi0gICAgc3dpdGNoICh0 eXBlKSB7Ci0gICAgY2FzZSBrSlNUeXBlTnVsbDoKKyAgICBpZiAodmFsdWUuaXNVbmRlZmluZWQo KSkKKyAgICAgICAgcmV0dXJuVHlwZSA9IEpTVW5kZWZpbmVkOworICAgIGVsc2UgaWYgKHZhbHVl LmlzTnVsbCgpKQogICAgICAgICByZXR1cm5UeXBlID0gSlNOdWxsOwotICAgICAgICBicmVhazsK LSAgICBjYXNlIGtKU1R5cGVCb29sZWFuOgorICAgIGVsc2UgaWYgKHZhbHVlLmlzQm9vbGVhbigp KQogICAgICAgICByZXR1cm5UeXBlID0gSlNCb29sZWFuOwotICAgICAgICBicmVhazsKLSAgICBj YXNlIGtKU1R5cGVOdW1iZXI6CisgICAgZWxzZSBpZiAodmFsdWUuaXNOdW1iZXIoKSkKICAgICAg ICAgcmV0dXJuVHlwZSA9IEpTTnVtYmVyOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIGtKU1R5 cGVTdHJpbmc6CisgICAgZWxzZSBpZiAodmFsdWUuaXNTdHJpbmcoKSkKICAgICAgICAgcmV0dXJu VHlwZSA9IEpTU3RyaW5nOwotICAgICAgICBicmVhazsKLSAgICBjYXNlIGtKU1R5cGVPYmplY3Q6 CisgICAgZWxzZSBpZiAodmFsdWUuaXNPYmplY3QoKSkKICAgICAgICAgcmV0dXJuVHlwZSA9IEpT T2JqZWN0OwotICAgICAgICBicmVhazsKLSAgICBjYXNlIGtKU1R5cGVVbmRlZmluZWQ6Ci0gICAg ZGVmYXVsdDoKKyAgICBlbHNlCiAgICAgICAgIHJldHVyblR5cGUgPSBKU1VuZGVmaW5lZDsKLSAg ICAgICAgYnJlYWs7Ci0gICAgfQogCi0gICAgaWYgKHJldHVyblR5cGUgPT0gSlNCb29sZWFuIHx8 IHJldHVyblR5cGUgPT0gSlNOdW1iZXIgfHwgcmV0dXJuVHlwZSA9PSBKU1N0cmluZyB8fCByZXR1 cm5UeXBlID09IEpTT2JqZWN0KQorICAgIGlmIChyZXR1cm5UeXBlID09IEpTQm9vbGVhbiB8fCBy ZXR1cm5UeXBlID09IEpTTnVtYmVyIHx8IHJldHVyblR5cGUgPT0gSlNTdHJpbmcgfHwgcmV0dXJu VHlwZSA9PSBKU09iamVjdCkgeworICAgICAgICBKU0M6OkV4ZWNTdGF0ZSogZXhlYyA9IG1fbWFp bkZyYW1lLT5zY3JpcHQoKS0+Z2xvYmFsT2JqZWN0KG1haW5UaHJlYWROb3JtYWxXb3JsZCgpKS0+ Z2xvYmFsRXhlYygpOwogICAgICAgICByZXR1cm5WYWx1ZSA9IHJlc3VsdC50b1N0cmluZyhleGVj KTsKKyAgICB9CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTgzMywzNiArODIyLDI1IEBAIGJv b2wgV2ViUGFnZVByaXZhdGU6OmV4ZWN1dGVKYXZhU2NyaXB0SW5Jc29sYXRlZFdvcmxkKGNvbnN0 IFNjcmlwdFNvdXJjZUNvZGUmIHNvCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAg ICBKU0M6OkV4ZWNTdGF0ZSogZXhlYyA9IG1fbWFpbkZyYW1lLT5zY3JpcHQoKS0+Z2xvYmFsT2Jq ZWN0KG1faXNvbGF0ZWRXb3JsZC5nZXQoKSktPmdsb2JhbEV4ZWMoKTsKLSAgICBKU0dsb2JhbENv bnRleHRSZWYgY29udGV4dCA9IHRvR2xvYmFsUmVmKGV4ZWMpOwotCi0gICAgSlNDOjpKU0xvY2tI b2xkZXIgbG9jayhleGVjKTsKLSAgICBKU1R5cGUgdHlwZSA9IEpTVmFsdWVHZXRUeXBlKGNvbnRl eHQsIHRvUmVmKGV4ZWMsIHZhbHVlKSk7Ci0KLSAgICBzd2l0Y2ggKHR5cGUpIHsKLSAgICBjYXNl IGtKU1R5cGVOdWxsOgorICAgIGlmICh2YWx1ZS5pc1VuZGVmaW5lZCgpKQorICAgICAgICByZXR1 cm5UeXBlID0gSlNVbmRlZmluZWQ7CisgICAgZWxzZSBpZiAodmFsdWUuaXNOdWxsKCkpCiAgICAg ICAgIHJldHVyblR5cGUgPSBKU051bGw7Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2Uga0pTVHlw ZUJvb2xlYW46CisgICAgZWxzZSBpZiAodmFsdWUuaXNCb29sZWFuKCkpCiAgICAgICAgIHJldHVy blR5cGUgPSBKU0Jvb2xlYW47Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2Uga0pTVHlwZU51bWJl cjoKKyAgICBlbHNlIGlmICh2YWx1ZS5pc051bWJlcigpKQogICAgICAgICByZXR1cm5UeXBlID0g SlNOdW1iZXI7Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2Uga0pTVHlwZVN0cmluZzoKKyAgICBl bHNlIGlmICh2YWx1ZS5pc1N0cmluZygpKQogICAgICAgICByZXR1cm5UeXBlID0gSlNTdHJpbmc7 Ci0gICAgICAgIGJyZWFrOwotICAgIGNhc2Uga0pTVHlwZU9iamVjdDoKKyAgICBlbHNlIGlmICh2 YWx1ZS5pc09iamVjdCgpKQogICAgICAgICByZXR1cm5UeXBlID0gSlNPYmplY3Q7Ci0gICAgICAg IGJyZWFrOwotICAgIGNhc2Uga0pTVHlwZVVuZGVmaW5lZDoKLSAgICBkZWZhdWx0OgorICAgIGVs c2UKICAgICAgICAgcmV0dXJuVHlwZSA9IEpTVW5kZWZpbmVkOwotICAgICAgICBicmVhazsKLSAg ICB9CiAKLSAgICBpZiAocmV0dXJuVHlwZSA9PSBKU0Jvb2xlYW4gfHwgcmV0dXJuVHlwZSA9PSBK U051bWJlciB8fCByZXR1cm5UeXBlID09IEpTU3RyaW5nIHx8IHJldHVyblR5cGUgPT0gSlNPYmpl Y3QpCisgICAgaWYgKHJldHVyblR5cGUgPT0gSlNCb29sZWFuIHx8IHJldHVyblR5cGUgPT0gSlNO dW1iZXIgfHwgcmV0dXJuVHlwZSA9PSBKU1N0cmluZyB8fCByZXR1cm5UeXBlID09IEpTT2JqZWN0 KSB7CisgICAgICAgIEpTQzo6RXhlY1N0YXRlKiBleGVjID0gbV9tYWluRnJhbWUtPnNjcmlwdCgp LT5nbG9iYWxPYmplY3QobWFpblRocmVhZE5vcm1hbFdvcmxkKCkpLT5nbG9iYWxFeGVjKCk7CiAg ICAgICAgIHJldHVyblZhbHVlID0gcmVzdWx0LnRvU3RyaW5nKGV4ZWMpOworICAgIH0KIAogICAg IHJldHVybiB0cnVlOwogfQo=