100933 2012-11-01 02:27:48 -0700 [AC][EFL][WK2] Rename PageViewportControllerClientEfl::m_pageViewportController to m_controller 2012-11-01 04:05:11 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 756002 0 mikhail.pozdnyakov 2012-11-01 02:27:48 -0700 PageViewportControllerClientEfl::m_pageViewportController has to be renamed to m_controller to keep consistency with other ports. 756020 1 171802 mikhail.pozdnyakov 2012-11-01 02:42:26 -0700 Created attachment 171802 patch 756063 2 171802 webkit.review.bot 2012-11-01 04:05:05 -0700 Comment on attachment 171802 patch Clearing flags on attachment: 171802 Committed r133144: <http://trac.webkit.org/changeset/133144> 756064 3 webkit.review.bot 2012-11-01 04:05:11 -0700 All reviewed patches have been landed. Closing bug. 171802 2012-11-01 02:42:26 -0700 2012-11-01 04:05:05 -0700 patch bug100933 text/plain 4317 mikhail.pozdnyakov Y29tbWl0IGZmYWY1MDkzYjBhOGRiYzEzMDMwMjM3OGEyYjc5ZjM5OGIyMGU3OGMKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IE5vdiAxIDExOjM1OjE0IDIwMTIgKzAyMDAKCiAgICBidWcxMDA5MzMKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggZjY2Nzk3NC4uNDQ5ZDY3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEx LTAxICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtBQ11bRUZMXVtXSzJdIFJlbmFtZSBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xp ZW50RWZsOjptX3BhZ2VWaWV3cG9ydENvbnRyb2xsZXIgdG8gbV9jb250cm9sbGVyCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5MzMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYWdlVmlld3BvcnRDb250 cm9sbGVyQ2xpZW50RWZsOjptX3BhZ2VWaWV3cG9ydENvbnRyb2xsZXIgaGFzIHRvIGJlIHJlbmFt ZWQgdG8gbV9jb250cm9sbGVyCisgICAgICAgIHRvIGtlZXAgY29uc2lzdGVuY3kgd2l0aCBvdGhl ciBwb3J0cy4gQXNzZXJ0aW5vbnMgd2VyZSBhbHNvIGFkZGVkLgorCisgICAgICAgICogVUlQcm9j ZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsLmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbDo6UGFnZVZpZXdwb3J0Q29udHJv bGxlckNsaWVudEVmbCk6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xsZXJD bGllbnRFZmw6OnVwZGF0ZVZpZXdwb3J0U2l6ZSk6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VWaWV3 cG9ydENvbnRyb2xsZXJDbGllbnRFZmw6OnNldFZpc2libGVDb250ZW50c1JlY3QpOgorICAgICAg ICAoV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsOjpkaWRSZXN1bWVDb250 ZW50KToKKyAgICAgICAgKFdlYktpdDo6UGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbDo6 c2V0Q29udHJvbGxlcik6CisgICAgICAgICogVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250 cm9sbGVyQ2xpZW50RWZsLmg6CisgICAgICAgIChQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50 RWZsKToKKwogMjAxMi0xMS0wMSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEzMzEyNi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxl ckNsaWVudEVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VWaWV3cG9y dENvbnRyb2xsZXJDbGllbnRFZmwuY3BwCmluZGV4IDNiZGRiZTQuLjBjMTMxYWUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNs aWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3Bv cnRDb250cm9sbGVyQ2xpZW50RWZsLmNwcApAQCAtNDIsNyArNDIsNyBAQCBuYW1lc3BhY2UgV2Vi S2l0IHsKIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmw6OlBhZ2VWaWV3cG9ydENvbnRy b2xsZXJDbGllbnRFZmwoRXdrVmlld0ltcGwqIHZpZXdJbXBsKQogICAgIDogbV92aWV3SW1wbCh2 aWV3SW1wbCkKICAgICAsIG1fc2NhbGVGYWN0b3IoMSkKLSAgICAsIG1fcGFnZVZpZXdwb3J0Q29u dHJvbGxlcigwKQorICAgICwgbV9jb250cm9sbGVyKDApCiB7CiAgICAgQVNTRVJUKG1fdmlld0lt cGwpOwogfQpAQCAtNzgsMTQgKzc4LDE4IEBAIHZvaWQgUGFnZVZpZXdwb3J0Q29udHJvbGxlckNs aWVudEVmbDo6dXBkYXRlVmlld3BvcnRTaXplKGNvbnN0IEludFNpemUmIHZpZXdwb3J0CiB7CiAg ICAgbV92aWV3cG9ydFNpemUgPSB2aWV3cG9ydFNpemU7CiAgICAgbV92aWV3SW1wbC0+cGFnZSgp LT5zZXRWaWV3cG9ydFNpemUodmlld3BvcnRTaXplKTsKLSAgICBtX3BhZ2VWaWV3cG9ydENvbnRy b2xsZXItPmRpZENoYW5nZVZpZXdwb3J0U2l6ZSh2aWV3cG9ydFNpemUpOworCisgICAgQVNTRVJU KG1fY29udHJvbGxlcik7CisgICAgbV9jb250cm9sbGVyLT5kaWRDaGFuZ2VWaWV3cG9ydFNpemUo dmlld3BvcnRTaXplKTsKIH0KIAogdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZs OjpzZXRWaXNpYmxlQ29udGVudHNSZWN0KGNvbnN0IEludFBvaW50JiBuZXdTY3JvbGxQb3NpdGlv biwgZmxvYXQgbmV3U2NhbGUsIGNvbnN0IEZsb2F0UG9pbnQmIC8qdHJhamVjdG9yeSovKQogewog ICAgIG1fc2NhbGVGYWN0b3IgPSBuZXdTY2FsZTsKICAgICBtX3Njcm9sbFBvc2l0aW9uID0gbmV3 U2Nyb2xsUG9zaXRpb247Ci0gICAgbV9wYWdlVmlld3BvcnRDb250cm9sbGVyLT5kaWRDaGFuZ2VD b250ZW50c1Zpc2liaWxpdHkobV9zY3JvbGxQb3NpdGlvbiwgbV9zY2FsZUZhY3RvciwgRmxvYXRQ b2ludCgpKTsKKworICAgIEFTU0VSVChtX2NvbnRyb2xsZXIpOworICAgIG1fY29udHJvbGxlci0+ ZGlkQ2hhbmdlQ29udGVudHNWaXNpYmlsaXR5KG1fc2Nyb2xsUG9zaXRpb24sIG1fc2NhbGVGYWN0 b3IsIEZsb2F0UG9pbnQoKSk7CiB9CiAKIHZvaWQgUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVu dEVmbDo6ZGlkQ2hhbmdlQ29udGVudHNTaXplKGNvbnN0IFdlYkNvcmU6OkludFNpemUmIHNpemUp CkBAIC0xMDksNyArMTEzLDggQEAgdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZs OjpzZXRDb250ZW50c1NjYWxlKGZsb2F0IG5ld1NjYWxlLCBib29sIHRyZWEKIAogdm9pZCBQYWdl Vmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZsOjpkaWRSZXN1bWVDb250ZW50KCkKIHsKLSAgICBt X3BhZ2VWaWV3cG9ydENvbnRyb2xsZXItPmRpZENoYW5nZUNvbnRlbnRzVmlzaWJpbGl0eShtX3Nj cm9sbFBvc2l0aW9uLCBtX3NjYWxlRmFjdG9yKTsKKyAgICBBU1NFUlQobV9jb250cm9sbGVyKTsK KyAgICBtX2NvbnRyb2xsZXItPmRpZENoYW5nZUNvbnRlbnRzVmlzaWJpbGl0eShtX3Njcm9sbFBv c2l0aW9uLCBtX3NjYWxlRmFjdG9yKTsKIH0KIAogdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVy Q2xpZW50RWZsOjpkaWRDaGFuZ2VWaXNpYmxlQ29udGVudHMoKQpAQCAtMTIyLDkgKzEyNyw5IEBA IHZvaWQgUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudEVmbDo6ZGlkQ2hhbmdlVmlld3BvcnRB dHRyaWJ1dGVzKCkKIHsKIH0KIAotdm9pZCBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50RWZs OjpzZXRDb250cm9sbGVyKFBhZ2VWaWV3cG9ydENvbnRyb2xsZXIqIHBhZ2VWaWV3cG9ydENvbnRy b2xsZXIpCit2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmw6OnNldENvbnRyb2xs ZXIoUGFnZVZpZXdwb3J0Q29udHJvbGxlciogY29udHJvbGxlcikKIHsKLSAgICBtX3BhZ2VWaWV3 cG9ydENvbnRyb2xsZXIgPSBwYWdlVmlld3BvcnRDb250cm9sbGVyOworICAgIG1fY29udHJvbGxl ciA9IGNvbnRyb2xsZXI7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50 RWZsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xs ZXJDbGllbnRFZmwuaAppbmRleCAwNTA1MjZhLi5mMjllOGU5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRFZmwuaAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJD bGllbnRFZmwuaApAQCAtNzIsNyArNzIsNyBAQCBwcml2YXRlOgogICAgIFdlYkNvcmU6OkludFNp emUgbV92aWV3cG9ydFNpemU7CiAgICAgV2ViQ29yZTo6SW50UG9pbnQgbV9zY3JvbGxQb3NpdGlv bjsKICAgICBmbG9hdCBtX3NjYWxlRmFjdG9yOwotICAgIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXIq IG1fcGFnZVZpZXdwb3J0Q29udHJvbGxlcjsKKyAgICBQYWdlVmlld3BvcnRDb250cm9sbGVyKiBt X2NvbnRyb2xsZXI7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQK