100914 2012-10-31 20:19:36 -0700 NRWT: lint warnings don't show up by default 2012-10-31 21:15:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED NRWT P2 Normal --- 1 dpranke dpranke abarth ojan rniwa tony webkit.review.bot oldest_to_newest 755829 0 dpranke 2012-10-31 20:19:36 -0700 NRWT: lint warnings don't show up by default 755832 1 171763 dpranke 2012-10-31 20:29:09 -0700 Created attachment 171763 Patch 755848 2 171763 webkit.review.bot 2012-10-31 21:14:56 -0700 Comment on attachment 171763 Patch Clearing flags on attachment: 171763 Committed r133121: <http://trac.webkit.org/changeset/133121> 755849 3 webkit.review.bot 2012-10-31 21:15:00 -0700 All reviewed patches have been landed. Closing bug. 171763 2012-10-31 20:29:09 -0700 2012-10-31 21:14:56 -0700 Patch bug-100914-20121031202742.patch text/plain 3970 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTE3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZjdkZjcwZTY4MmE3ZTg2YWQ5YWM3NTkwMGZkOTA3Y2M0 MmFmMTY4Zi4uNTQ3MjNjMTU5NTBlMDUzN2ZmNjA4MTM4YmU3YjI0ZTYxMDllZGI3MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDEyLTEwLTMxICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIE5SV1Q6IGxpbnQgd2FybmluZ3MgZG9uJ3Qgc2hvdyB1cCBieSBkZWZhdWx0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA5MTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOUldUIHdhc24ndCBw cmludGluZyBhbnkgd2FybmluZ3MgaWYgeW91IGhhZCBlcnJvcnMgaW4geW91cgorICAgICAgICBU ZXN0RXhwZWN0YXRpb25zIGZpbGVzOyB0aGlzIG1lYW5zIHlvdSB3b3VsZCBvbmx5IG5vdGljZSB0 aGlzCisgICAgICAgIHdpdGggLS1saW50LXRlc3QtZmlsZXMsIHdoaWNoIGlzIHByb2JhYmx5IGJh ZC4gSSdtIG5vdCBzdXJlCisgICAgICAgIHdoZW4gdGhpcyByZXF1ZXN0ZWQsIGJ1dCBwZXJoYXBz IHdoZW4gd2UgY2hhbmdlZCB0aGUKKyAgICAgICAgd2FybmluZ3MgdG8gbm90IGJlIGZhdGFsIGlm IHlvdSB3ZXJlbid0IGxpbnRpbmcgdGhlIGZpbGVzLgorCisgICAgICAgIE5vdyB0aGV5J3JlIHN0 aWxsIG5vdCBmYXRhbCwgYnV0IGF0IGxlYXN0IHdlIHByaW50IHRoZW0uCisKKyAgICAgICAgQWxz byBmaXggb25lIHdhcm5pbmcgbWVzc2FnZSB3aGVyZSB3ZSB3ZXJlIHByaW50aW5nIHRoZSB0ZXN0 IG5hbWUgdHdpY2UuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9t b2RlbHMvdGVzdF9leHBlY3RhdGlvbnMucHk6CisgICAgICAgIChUZXN0RXhwZWN0YXRpb25zTW9k ZWwuX2FscmVhZHlfc2Vlbl9iZXR0ZXJfbWF0Y2gpOgorICAgICAgICAoVGVzdEV4cGVjdGF0aW9u cy5fcmVwb3J0X3dhcm5pbmdzKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHk6CisgICAgICAgIChNaXNj VGVzdHMudGVzdF9wYXJzZV93YXJuaW5nc19hcmVfbG9nZ2VkX2lmX25vdF9pbl9saW50X21vZGUo c2VsZik6IEFkZGVkLgorCiAyMDEyLTEwLTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KIAogICAgICAgICBBIEpTQyBwcmludGYgKHN1cHBvcnQgZm9yICVKK3MgYW5kICViKS4KZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0 X2V4cGVjdGF0aW9ucy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21v ZGVscy90ZXN0X2V4cGVjdGF0aW9ucy5weQppbmRleCAxNDMyMWJiMTRkMDljYTVlMzJjMzczMzg5 Y2E3NjI3ZGViNzc4MGMxLi5lNGQ0NjZhMjQ4MDllYTk0YWFmYzA3YTQ1ZDEwZWQwNDljMTdjMmJi IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9tb2RlbHMv dGVzdF9leHBlY3RhdGlvbnMucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25zLnB5CkBAIC02ODksNyArNjg5LDcgQEAgY2xh c3MgVGVzdEV4cGVjdGF0aW9uc01vZGVsKG9iamVjdCk6CiAgICAgICAgICMgdG8gYmUgd2Fybmlu Z3MgYW5kIHJldHVybiBGYWxzZSIuCiAKICAgICAgICAgaWYgcHJldl9leHBlY3RhdGlvbl9saW5l Lm1hdGNoaW5nX2NvbmZpZ3VyYXRpb25zID09IGV4cGVjdGF0aW9uX2xpbmUubWF0Y2hpbmdfY29u ZmlndXJhdGlvbnM6Ci0gICAgICAgICAgICBleHBlY3RhdGlvbl9saW5lLndhcm5pbmdzLmFwcGVu ZCgnRHVwbGljYXRlIG9yIGFtYmlndW91cyBlbnRyeSBmb3IgJXMgb24gbGluZXMgJXM6JWQgYW5k ICVzOiVkLicgJSAoZXhwZWN0YXRpb25fbGluZS5uYW1lLAorICAgICAgICAgICAgZXhwZWN0YXRp b25fbGluZS53YXJuaW5ncy5hcHBlbmQoJ0R1cGxpY2F0ZSBvciBhbWJpZ3VvdXMgZW50cnkgbGlu ZXMgJXM6JWQgYW5kICVzOiVkLicgJSAoCiAgICAgICAgICAgICAgICAgc2VsZi5fc2hvcnRlbl9m aWxlbmFtZShwcmV2X2V4cGVjdGF0aW9uX2xpbmUuZmlsZW5hbWUpLCBwcmV2X2V4cGVjdGF0aW9u X2xpbmUubGluZV9udW1iZXIsCiAgICAgICAgICAgICAgICAgc2VsZi5fc2hvcnRlbl9maWxlbmFt ZShleHBlY3RhdGlvbl9saW5lLmZpbGVuYW1lKSwgZXhwZWN0YXRpb25fbGluZS5saW5lX251bWJl cikpCiAgICAgICAgICAgICByZXR1cm4gVHJ1ZQpAQCAtOTMyLDYgKzkzMiwxMCBAQCBjbGFzcyBU ZXN0RXhwZWN0YXRpb25zKG9iamVjdCk6CiAgICAgICAgICAgICBzZWxmLl9oYXNfd2FybmluZ3Mg PSBUcnVlCiAgICAgICAgICAgICBpZiBzZWxmLl9pc19saW50X21vZGU6CiAgICAgICAgICAgICAg ICAgcmFpc2UgUGFyc2VFcnJvcih3YXJuaW5ncykKKyAgICAgICAgICAgIF9sb2cud2FybmluZygn LS1saW50LXRlc3QtZmlsZXMgd2FybmluZ3M6JykKKyAgICAgICAgICAgIGZvciB3YXJuaW5nIGlu IHdhcm5pbmdzOgorICAgICAgICAgICAgICAgIF9sb2cud2FybmluZyh3YXJuaW5nKQorICAgICAg ICAgICAgX2xvZy53YXJuaW5nKCcnKQogCiAgICAgZGVmIF9wcm9jZXNzX3Rlc3RzX3dpdGhvdXRf ZXhwZWN0YXRpb25zKHNlbGYpOgogICAgICAgICBpZiBzZWxmLl9mdWxsX3Rlc3RfbGlzdDoKZGlm ZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL21vZGVscy90ZXN0 X2V4cGVjdGF0aW9uc191bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL21vZGVscy90ZXN0X2V4cGVjdGF0aW9uc191bml0dGVzdC5weQppbmRleCA4YjQwYWNi YzMzNmVhN2E5ZjY4ZmViZTRlZmE4MWViNzRjYjM0NjBhLi5kNzhhZTNmMmJjMDIyZDE2MGFjNjMx MmY5YTYzOWZlOTc5MDFiNTViIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9tb2RlbHMvdGVzdF9leHBlY3RhdGlvbnNfdW5pdHRlc3QucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbW9kZWxzL3Rlc3RfZXhwZWN0YXRpb25z X3VuaXR0ZXN0LnB5CkBAIC0xODQsNiArMTg0LDE1IEBAIGNsYXNzIE1pc2NUZXN0cyhCYXNlKToK ICAgICAgICAgICAgICAgICAgICAgICAgICJleHBlY3RhdGlvbnM6MiBQYXRoIGRvZXMgbm90IGV4 aXN0LiBub24tZXhpc3RlbnQtdGVzdC5odG1sIikKICAgICAgICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoc3RyKGUpLCB3YXJuaW5ncykKIAorICAgIGRlZiB0ZXN0X3BhcnNlX3dhcm5pbmdzX2FyZV9s b2dnZWRfaWZfbm90X2luX2xpbnRfbW9kZShzZWxmKToKKyAgICAgICAgb2MgPSBPdXRwdXRDYXB0 dXJlKCkKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgb2MuY2FwdHVyZV9vdXRwdXQoKQorICAg ICAgICAgICAgc2VsZi5wYXJzZV9leHAoJy0tIHRoaXMgc2hvdWxkIGJlIGEgc3ludGF4IGVycm9y JywgaXNfbGludF9tb2RlPUZhbHNlKQorICAgICAgICBmaW5hbGx5OgorICAgICAgICAgICAgXywg XywgbG9ncyA9IG9jLnJlc3RvcmVfb3V0cHV0KCkKKyAgICAgICAgICAgIHNlbGYuYXNzZXJ0Tm90 RXF1YWxzKGxvZ3MsICcnKQorCiAgICAgZGVmIHRlc3RfZXJyb3Jfb25fZGlmZmVyZW50X3BsYXRm b3JtKHNlbGYpOgogICAgICAgICAjIHBhcnNlX2V4cCB1c2VzIGEgV2luZG93cyBwb3J0LiBBc3Nl cnQgZXJyb3JzIG9uIE1hYyBzaG93IHVwIGluIGxpbnQgbW9kZS4KICAgICAgICAgc2VsZi5hc3Nl cnRSYWlzZXMoUGFyc2VFcnJvciwgc2VsZi5wYXJzZV9leHAsCg==