100909 2012-10-31 18:36:37 -0700 Use load64 instead of loadPtr to load a JSValue on JSVALUE64 platforms 2012-11-26 10:55:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100450 1 yuqiang.xian webkit-unassigned barraclough bfulgham fpizlo webkit.review.bot oldest_to_newest 755784 0 yuqiang.xian 2012-10-31 18:36:37 -0700 This is a (trivial) fix after r132701 755787 1 171752 yuqiang.xian 2012-10-31 18:39:22 -0700 Created attachment 171752 patch 775200 2 171752 bfulgham 2012-11-25 23:59:42 -0800 Comment on attachment 171752 patch Seems reasonable, and all tests pass. R=me. 775201 3 bfulgham 2012-11-26 00:00:53 -0800 I'll hold off landing until tomorrow in case anyone has an objection. 775665 4 171752 webkit.review.bot 2012-11-26 10:55:37 -0800 Comment on attachment 171752 patch Clearing flags on attachment: 171752 Committed r135738: <http://trac.webkit.org/changeset/135738> 775666 5 webkit.review.bot 2012-11-26 10:55:40 -0800 All reviewed patches have been landed. Closing bug. 171752 2012-10-31 18:39:22 -0700 2012-11-26 10:55:36 -0800 patch 100909.0.patch text/plain 1474 yuqiang.xian SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMzMTA1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDEyLTEwLTMxICBZdXFpYW5nIFhpYW4gIDx5dXFpYW5nLnhpYW5AaW50ZWwuY29tPgorCisg ICAgICAgIFVzZSBsb2FkNjQgaW5zdGVhZCBvZiBsb2FkUHRyIHRvIGxvYWQgYSBKU1ZhbHVlIG9u IEpTVkFMVUU2NCBwbGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMDkwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgaXMgYSAodHJpdmlhbCkgZml4IGFmdGVyIHIxMzI3MDEuCisKKyAg ICAgICAgKiBkZmcvREZHT1NSRXhpdENvbXBpbGVyNjQuY3BwOgorICAgICAgICAoSlNDOjpERkc6 Ok9TUkV4aXRDb21waWxlcjo6Y29tcGlsZUV4aXQpOgorCiAyMDEyLTEwLTMxICBNYXJrIExhbSAg PG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBIEpTQyBwcmludGYgKHN1cHBvcnQgZm9y ICVKK3MgYW5kICViKS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHT1NSRXhp dENvbXBpbGVyNjQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHT1NSRXhpdENvbXBpbGVyNjQuY3BwCShyZXZpc2lvbiAxMzMxMDQpCisrKyBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxlcjY0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNjg0LDcgKzY4NCw3IEBAIHZvaWQgT1NSRXhpdENvbXBpbGVyOjpjb21waWxlRXhpdChjb25z dAogICAgIC8vIDE2KSBMb2FkIHRoZSByZXN1bHQgb2YgdGhlIGxhc3QgYnl0ZWNvZGUgb3BlcmF0 aW9uIGludG8gcmVnVDAuCiAgICAgCiAgICAgaWYgKGV4aXQubV9sYXN0U2V0T3BlcmFuZCAhPSBz dGQ6Om51bWVyaWNfbGltaXRzPGludD46Om1heCgpKQotICAgICAgICBtX2ppdC5sb2FkUHRyKEFz c2VtYmx5SGVscGVyczo6YWRkcmVzc0ZvcigoVmlydHVhbFJlZ2lzdGVyKWV4aXQubV9sYXN0U2V0 T3BlcmFuZCksIEdQUkluZm86OmNhY2hlZFJlc3VsdFJlZ2lzdGVyKTsKKyAgICAgICAgbV9qaXQu bG9hZDY0KEFzc2VtYmx5SGVscGVyczo6YWRkcmVzc0ZvcigoVmlydHVhbFJlZ2lzdGVyKWV4aXQu bV9sYXN0U2V0T3BlcmFuZCksIEdQUkluZm86OmNhY2hlZFJlc3VsdFJlZ2lzdGVyKTsKICAgICAK ICAgICAvLyAxNykgQWRqdXN0IHRoZSBjYWxsIGZyYW1lIHBvaW50ZXIuCiAgICAgCg==