100875 2012-10-31 12:19:17 -0700 [chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual. 2012-11-01 09:46:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wjmaclean wjmaclean abarth dglazkov enne fishd gtk-ews gustavo jamesr peter+ews tkent+wkapi webkit.review.bot xan.lopez oldest_to_newest 755532 0 wjmaclean 2012-10-31 12:19:17 -0700 [chromium] Make WebLayerTreeView::adjustEventPointForPinchZoom pure virtual. 755534 1 171701 wjmaclean 2012-10-31 12:21:17 -0700 Created attachment 171701 Patch 755536 2 wjmaclean 2012-10-31 12:22:26 -0700 Removing a default function implementation that was necessary to land a multi-sided patch. 755537 3 webkit.review.bot 2012-10-31 12:23:06 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 755543 4 171701 jamesr 2012-10-31 12:30:51 -0700 Comment on attachment 171701 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171701&action=review Have you rolled the implementation into Source/WebKit/chromium/DEPS? > Source/Platform/chromium/public/WebLayerTreeView.h:101 > + virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint&) const =0; need a space before the 0 755551 5 wjmaclean 2012-10-31 12:40:07 -0700 (In reply to comment #4) > (From update of attachment 171701 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171701&action=review > > Have you rolled the implementation into Source/WebKit/chromium/DEPS? Not yet, but will do it prior to submitting this. > > Source/Platform/chromium/public/WebLayerTreeView.h:101 > > + virtual WebFloatPoint adjustEventPointForPinchZoom(const WebFloatPoint&) const =0; > > need a space before the 0 Thx, fixed. 755589 6 171701 peter+ews 2012-10-31 13:20:15 -0700 Comment on attachment 171701 Patch Attachment 171701 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14678248 755605 7 wjmaclean 2012-10-31 14:00:43 -0700 (In reply to comment #6) > (From update of attachment 171701 [details]) > Attachment 171701 [details] did not pass cr-android-ews (chromium-android): > Output: http://queues.webkit.org/results/14678248 This is presumably because the implementation of adjustEventPointForPinchZoom() doesn't exist in LKGR? I'm waiting for that to catch up so I can roll webkit-chromium DEPS and then I'll land this. 755615 8 171701 gtk-ews 2012-10-31 14:21:30 -0700 Comment on attachment 171701 Patch Attachment 171701 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/14696059 755627 9 jamesr 2012-10-31 14:31:47 -0700 (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 171701 [details] [details]) > > Attachment 171701 [details] [details] did not pass cr-android-ews (chromium-android): > > Output: http://queues.webkit.org/results/14678248 > > This is presumably because the implementation of adjustEventPointForPinchZoom() doesn't exist in LKGR? I'm waiting for that to catch up so I can roll webkit-chromium DEPS and then I'll land this. These bots don't care about LKGR, just about Source/WebKit/chromium/DEPS 755629 10 171701 webkit.review.bot 2012-10-31 14:33:44 -0700 Comment on attachment 171701 Patch Attachment 171701 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14684267 756174 11 wjmaclean 2012-11-01 06:48:01 -0700 (In reply to comment #9) > (In reply to comment #7) > > (In reply to comment #6) > > > (From update of attachment 171701 [details] [details] [details]) > > > Attachment 171701 [details] [details] [details] did not pass cr-android-ews (chromium-android): > > > Output: http://queues.webkit.org/results/14678248 > > > > This is presumably because the implementation of adjustEventPointForPinchZoom() doesn't exist in LKGR? I'm waiting for that to catch up so I can roll webkit-chromium DEPS and then I'll land this. > > These bots don't care about LKGR, just about Source/WebKit/chromium/DEPS OK, so basically the same issue. In future I'll make sure I roll chromium/DEPS first, then send the cl through the bots. 756272 12 171701 webkit.review.bot 2012-11-01 08:28:27 -0700 Comment on attachment 171701 Patch Rejecting attachment 171701 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: platform/chromium/TestExpectations Auto-merging Source/WebKit2/ChangeLog Failed to merge in the changes. Patch failed at 0001 [Chromium] Unreviewed gardening. New reftest from When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 154. Full output: http://queues.webkit.org/results/14692522 756297 13 171860 wjmaclean 2012-11-01 08:42:38 -0700 Created attachment 171860 Patch for landing 756356 14 171860 webkit.review.bot 2012-11-01 09:46:03 -0700 Comment on attachment 171860 Patch for landing Clearing flags on attachment: 171860 Committed r133185: <http://trac.webkit.org/changeset/133185> 756357 15 webkit.review.bot 2012-11-01 09:46:09 -0700 All reviewed patches have been landed. Closing bug. 171701 2012-10-31 12:21:17 -0700 2012-11-01 08:42:35 -0700 Patch bug-100875-20121031151939.patch text/plain 1897 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA5MzRjYjlmOTkxYTIy MWRkZjc1MDZhOTZhNzAxMzQ0MTY3YmI1MjM0Li5kNWQ4MDIzNjY5ZmRhMTZhODViMzEzYjc2NDc5 OWE4NzBlNTA4N2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMC0zMSAg Vy4gSmFtZXMgTWFjTGVhbiAgPHdqbWFjbGVhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIFdlYkxheWVyVHJlZVZpZXc6OmFkanVzdEV2ZW50UG9pbnRGb3JQaW5jaFpv b20gcHVyZSB2aXJ0dWFsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAwODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVGhpcyBDTCByZW1vdmVzIHRoZSBkZWZhdWx0IGltcGxlbWVudGF0aW9uIGZvciBh ZGp1c3RFdmVudFBvaW50Rm9yUGluY2hab29tKCksIHdoaWNoCisgICAgICAgIHdhcyBuZWNlc3Nh cnkgZm9yIGxhbmRpbmcgdGhlIG9yaWdpbmFsIHBhdGNoIGluIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NDIuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMv V2ViTGF5ZXJUcmVlVmlldy5oOgorICAgICAgICAoV2ViTGF5ZXJUcmVlVmlldyk6CisKIDIwMTIt MTAtMzAgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtjaHJvbWl1bV0gVHJhbnNmb3JtIG1vdXNlL2dlc3R1cmUgZXZlbnQgY29vcmRpbmF0ZXMg dG8gYWNjb3VudCBmb3IgcGluY2gtem9vbSBpbiBjb21wb3NpdG9yLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3LmggYi9Tb3VyY2Uv UGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkxheWVyVHJlZVZpZXcuaAppbmRleCBjMjk5MGZh M2M3MjI3MzUwNTI2ZmRkZWY4ODdjMjE0NDBlMmMwYmQ2Li41ZGRmMDM2NmU3YmZhYWY3NjkwNDk0 NzQ1MjBjNzNiNWZlMzQ3MjA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0v cHVibGljL1dlYkxheWVyVHJlZVZpZXcuaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0v cHVibGljL1dlYkxheWVyVHJlZVZpZXcuaApAQCAtOTYsOCArOTYsOSBAQCBwdWJsaWM6CiAgICAg Ly8gbW9kZSkuCiAgICAgdmlydHVhbCBXZWJTaXplIGRldmljZVZpZXdwb3J0U2l6ZSgpIGNvbnN0 ID0gMDsKIAotICAgIC8vIEZJWE1FOiBPbmNlIGNjOjpMYXllclRyZWVIb3N0OjphZGp1c3RFdmVu dFBvaW50Rm9yUGluY2hab29tIGxhbmRzLCBtYWtlIHRoaXMgcHVyZSB2aXJ0dWFsLgotICAgIHZp cnR1YWwgV2ViRmxvYXRQb2ludCBhZGp1c3RFdmVudFBvaW50Rm9yUGluY2hab29tKGNvbnN0IFdl YkZsb2F0UG9pbnQmIHBvaW50KSBjb25zdCB7IHJldHVybiBwb2ludDsgfQorICAgIC8vIEdpdmVz IHRoZSBjb3JyZWN0ZWQgbG9jYXRpb24gZm9yIGFuIGV2ZW50LCBhY2NvdW50aW5nIGZvciB0aGUg cGluY2gtem9vbSB0cmFuc2Zvcm1hdGlvbgorICAgIC8vIGluIHRoZSBjb21wb3NpdG9yLgorICAg IHZpcnR1YWwgV2ViRmxvYXRQb2ludCBhZGp1c3RFdmVudFBvaW50Rm9yUGluY2hab29tKGNvbnN0 IFdlYkZsb2F0UG9pbnQmKSBjb25zdCA9MDsKIAogICAgIHZpcnR1YWwgdm9pZCBzZXREZXZpY2VT Y2FsZUZhY3RvcihmbG9hdCkgPSAwOwogICAgIHZpcnR1YWwgZmxvYXQgZGV2aWNlU2NhbGVGYWN0 b3IoKSBjb25zdCA9IDA7Cg== 171860 2012-11-01 08:42:38 -0700 2012-11-01 09:46:03 -0700 Patch for landing bug-100875-20121101114100.patch text/plain 1836 wjmaclean U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMTc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAxZjdjN2JmNmZmOWMx ODQ5ODQwYzBjMDRlNThhMTE2NmYwNDliNzc3Li45OGE3ZDhkMjMzMDJjNTFiNGQyMTY4MDM1ZDA4 ZmZjZjBhNWMwZGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMS0wMSAg Vy4gSmFtZXMgTWFjTGVhbiAgPHdqbWFjbGVhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2No cm9taXVtXSBNYWtlIFdlYkxheWVyVHJlZVZpZXc6OmFkanVzdEV2ZW50UG9pbnRGb3JQaW5jaFpv b20gcHVyZSB2aXJ0dWFsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAwODc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCisK KyAgICAgICAgVGhpcyBDTCByZW1vdmVzIHRoZSBkZWZhdWx0IGltcGxlbWVudGF0aW9uIGZvciBh ZGp1c3RFdmVudFBvaW50Rm9yUGluY2hab29tKCksIHdoaWNoCisgICAgICAgIHdhcyBuZWNlc3Nh cnkgZm9yIGxhbmRpbmcgdGhlIG9yaWdpbmFsIHBhdGNoIGluIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA1NDIuCisKKyAgICAgICAgKiBjaHJvbWl1bS9wdWJsaWMv V2ViTGF5ZXJUcmVlVmlldy5oOgorICAgICAgICAoV2ViTGF5ZXJUcmVlVmlldyk6CisKIDIwMTIt MTAtMzEgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEzMzEyMi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViTGF5ZXJUcmVlVmlldy5oIGIvU291cmNlL1BsYXRm b3JtL2Nocm9taXVtL3B1YmxpYy9XZWJMYXllclRyZWVWaWV3LmgKaW5kZXggYzI5OTBmYTNjNzIy NzM1MDUyNmZkZGVmODg3YzIxNDQwZTJjMGJkNi4uZmY2ZDQyNTZiYzE0NGFiODUwNjRiNWQ0ZTA2 MzA2MTUwMDk0NGNlNCAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1Ymxp Yy9XZWJMYXllclRyZWVWaWV3LmgKKysrIGIvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1Ymxp Yy9XZWJMYXllclRyZWVWaWV3LmgKQEAgLTk2LDggKzk2LDkgQEAgcHVibGljOgogICAgIC8vIG1v ZGUpLgogICAgIHZpcnR1YWwgV2ViU2l6ZSBkZXZpY2VWaWV3cG9ydFNpemUoKSBjb25zdCA9IDA7 CiAKLSAgICAvLyBGSVhNRTogT25jZSBjYzo6TGF5ZXJUcmVlSG9zdDo6YWRqdXN0RXZlbnRQb2lu dEZvclBpbmNoWm9vbSBsYW5kcywgbWFrZSB0aGlzIHB1cmUgdmlydHVhbC4KLSAgICB2aXJ0dWFs IFdlYkZsb2F0UG9pbnQgYWRqdXN0RXZlbnRQb2ludEZvclBpbmNoWm9vbShjb25zdCBXZWJGbG9h dFBvaW50JiBwb2ludCkgY29uc3QgeyByZXR1cm4gcG9pbnQ7IH0KKyAgICAvLyBHaXZlcyB0aGUg Y29ycmVjdGVkIGxvY2F0aW9uIGZvciBhbiBldmVudCwgYWNjb3VudGluZyBmb3IgdGhlIHBpbmNo LXpvb20gdHJhbnNmb3JtYXRpb24KKyAgICAvLyBpbiB0aGUgY29tcG9zaXRvci4KKyAgICB2aXJ0 dWFsIFdlYkZsb2F0UG9pbnQgYWRqdXN0RXZlbnRQb2ludEZvclBpbmNoWm9vbShjb25zdCBXZWJG bG9hdFBvaW50JikgY29uc3QgPSAwOwogCiAgICAgdmlydHVhbCB2b2lkIHNldERldmljZVNjYWxl RmFjdG9yKGZsb2F0KSA9IDA7CiAgICAgdmlydHVhbCBmbG9hdCBkZXZpY2VTY2FsZUZhY3Rvcigp IGNvbnN0ID0gMDsK