100864 2012-10-31 08:48:46 -0700 [NRWT] Xvfb driver is leaking application cache files 2012-11-02 14:30:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos abarth dpranke laszlo.gombos ojan senorblanco webkit.review.bot zan oldest_to_newest 755345 0 tmpsantos 2012-10-31 08:48:46 -0700 By setting XDG_CACHE_HOME to self._port.results_directory() will make the worker reuse the cache of some previous and potentially taint the results. It should be set to the work's temporary directory instead, which is removed after the run. Currently the Application Cache is the only to respect this environment variable on WebKit2 because there is no API to override the path like it is usually done on DRT and WTR. 755366 1 171671 tmpsantos 2012-10-31 09:11:38 -0700 Created attachment 171671 Patch 755487 2 171671 webkit.review.bot 2012-10-31 11:29:04 -0700 Comment on attachment 171671 Patch Clearing flags on attachment: 171671 Committed r133050: <http://trac.webkit.org/changeset/133050> 755488 3 webkit.review.bot 2012-10-31 11:29:08 -0700 All reviewed patches have been landed. Closing bug. 757544 4 senorblanco 2012-11-02 13:50:35 -0700 This change seems to be causing failures in the chromium port's webkitpy-test; e.g., see http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058/steps/webkitpy-test/logs/stdio "Seems" because it's the only xvfb-related change in the first failing run: http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058 757585 5 tmpsantos 2012-11-02 14:27:54 -0700 (In reply to comment #4) > This change seems to be causing failures in the chromium port's webkitpy-test; e.g., see > > http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058/steps/webkitpy-test/logs/stdio > > "Seems" because it's the only xvfb-related change in the first failing run: > > http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/31058 Hmmm, weird. The patch just changes a environment variable path. Is the Windows bot really suppose to start the Xvfb server? 757591 6 abarth 2012-11-02 14:29:45 -0700 > Is the Windows bot really suppose to start the Xvfb server? It looks like something isn't properly mocking out the file system. 757593 7 abarth 2012-11-02 14:30:34 -0700 It's also possible we should skip this test on Windows. 171671 2012-10-31 09:11:38 -0700 2012-10-31 11:29:04 -0700 Patch bug-100864-20121031181351.patch text/plain 2617 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTA4NmYwOWQyY2U2YjYyNWE2MzZlZGFiYWY3ZjI0ZGVi Yzg1NGI4Yi4uN2Y0OGYxOGJjOGU3YjJlZWNhZDhjZWM5MWIzOTc1YTQxNGI2OGJmZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5 IEBACiAyMDEyLTEwLTMxICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgogCisgICAgICAgIFtOUldUXSBYdmZiIGRyaXZlciBpcyBsZWFraW5nIGFwcGxp Y2F0aW9uIGNhY2hlIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDA4NjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBcHBsaWNhdGlvbiBDYWNoZSBsb29rcyBmb3IgWERHX0NBQ0hFX0hPTUUgd2hp Y2ggaXMgbm93CisgICAgICAgIHByZXBlbmRlZCB3aXRoIERVTVBSRU5ERVJUUkVFX1RFTVAgYW5k IGNsZWFuZWQgdXAgd2hlbgorICAgICAgICB0aGUgdGVzdCB3b3JrZXIgZmluaXNoZXMgaGlzIGpv Yi4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQveHZmYmRy aXZlci5weToKKyAgICAgICAgKFh2ZmJEcml2ZXIuX3N0YXJ0KToKKworMjAxMi0xMC0zMSAgVGhp YWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KKwogICAgICAg ICBbRUZMXSBEUlQgZG9lc24ndCBjbGVhbiB1cCBhZnRlciBpdHNlbGYKICAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDM0NgogCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3h2ZmJkcml2ZXIucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3h2ZmJkcml2ZXIucHkKaW5k ZXggYjkyNzcyMGRiMjc1YmM0ZTU2MmZkMDY3YTJkOWIxM2ZkMzg1MTBjMC4uYjk4YzAzOTJlYWNk ZjQ5Y2VmYTY1YWEzOGZiMWNiMTc1NmY3ZTBjNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC94dmZiZHJpdmVyLnB5CisrKyBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQveHZmYmRyaXZlci5weQpAQCAtNzcsMTIgKzc3 LDE2IEBAIGNsYXNzIFh2ZmJEcml2ZXIoRHJpdmVyKToKICAgICAgICAgZW52aXJvbm1lbnQgPSBz ZWxmLl9wb3J0LnNldHVwX2Vudmlyb25fZm9yX3NlcnZlcihzZXJ2ZXJfbmFtZSkKICAgICAgICAg IyBXZSBtdXN0IGRvIHRoaXMgaGVyZSBiZWNhdXNlIHRoZSBESVNQTEFZIG51bWJlciBkZXBlbmRz IG9uIF93b3JrZXJfbnVtYmVyCiAgICAgICAgIGVudmlyb25tZW50WydESVNQTEFZJ10gPSAiOiVk IiAlIGRpc3BsYXlfaWQKLSAgICAgICAgIyBEcml2ZXJzIHNob3VsZCB1c2Ugc2VwYXJhdGUgYXBw bGljYXRpb24gY2FjaGUgbG9jYXRpb25zCi0gICAgICAgIGVudmlyb25tZW50WydYREdfQ0FDSEVf SE9NRSddID0gc2VsZi5fcG9ydC5ob3N0LmZpbGVzeXN0ZW0uam9pbihzZWxmLl9wb3J0LnJlc3Vs dHNfZGlyZWN0b3J5KCksICclcy1hcHBjYWNoZS0lZCcgJSAoc2VydmVyX25hbWUsIHNlbGYuX3dv cmtlcl9udW1iZXIpKQogICAgICAgICBzZWxmLl9kcml2ZXJfdGVtcGRpciA9IHNlbGYuX3BvcnQu X2ZpbGVzeXN0ZW0ubWtkdGVtcChwcmVmaXg9JyVzLScgJSBzZWxmLl9wb3J0LmRyaXZlcl9uYW1l KCkpCiAgICAgICAgIGVudmlyb25tZW50WydEVU1QUkVOREVSVFJFRV9URU1QJ10gPSBzdHIoc2Vs Zi5fZHJpdmVyX3RlbXBkaXIpCiAgICAgICAgIGVudmlyb25tZW50WydMT0NBTF9SRVNPVVJDRV9S T09UJ10gPSBzZWxmLl9wb3J0LmxheW91dF90ZXN0c19kaXIoKQogCisgICAgICAgICMgQ3VycmVu dGx5IG9uIFdlYktpdDIsIHRoZXJlIGlzIG5vIEFQSSBmb3Igc2V0dGluZyB0aGUgYXBwbGljYXRp b24KKyAgICAgICAgIyBjYWNoZSBkaXJlY3RvcnkuIEVhY2ggd29ya2VyIHNob3VsZCBoYXZlIGl0 J3Mgb3duIGFuZCBpdCBzaG91bGQgYmUKKyAgICAgICAgIyBjbGVhbmVkIGFmdGVyd2FyZHMsIHNv IHdlIHNldCBpdCB0byBpbnNpZGUgdGhlIHRlbXBvcmFyeSBmb2xkZXIgYnkKKyAgICAgICAgIyBw cmVwZW5kaW5nIFhER19DQUNIRV9IT01FIHdpdGggRFVNUFJFTkRFUlRSRUVfVEVNUC4KKyAgICAg ICAgZW52aXJvbm1lbnRbJ1hER19DQUNIRV9IT01FJ10gPSBzZWxmLl9wb3J0Lmhvc3QuZmlsZXN5 c3RlbS5qb2luKHN0cihzZWxmLl9kcml2ZXJfdGVtcGRpciksICdhcHBjYWNoZScpCisKICAgICAg ICAgc2VsZi5fY3Jhc2hlZF9wcm9jZXNzX25hbWUgPSBOb25lCiAgICAgICAgIHNlbGYuX2NyYXNo ZWRfcGlkID0gTm9uZQogICAgICAgICBzZWxmLl9zZXJ2ZXJfcHJvY2VzcyA9IHNlbGYuX3BvcnQu X3NlcnZlcl9wcm9jZXNzX2NvbnN0cnVjdG9yKHNlbGYuX3BvcnQsIHNlcnZlcl9uYW1lLCBzZWxm LmNtZF9saW5lKHBpeGVsX3Rlc3RzLCBwZXJfdGVzdF9hcmdzKSwgZW52aXJvbm1lbnQpCg==