<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100861</bug_id>
          
          <creation_ts>2012-10-31 07:49:03 -0700</creation_ts>
          <short_desc>[chromium] Enable RESOLUTION_MEDIA_QUERY</short_desc>
          <delta_ts>2013-04-09 17:07:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>WebExposed</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>99077</dependson>
    
    <dependson>100865</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rick Byers">rbyers</reporter>
          <assigned_to name="Rick Byers">rbyers</assigned_to>
          <cc>johnme</cc>
    
    <cc>kenneth</cc>
    
    <cc>peter</cc>
    
    <cc>syoichi</cc>
    
    <cc>tabatkins</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>755297</commentid>
    <comment_count>0</comment_count>
    <who name="Rick Byers">rbyers</who>
    <bug_when>2012-10-31 07:49:03 -0700</bug_when>
    <thetext>Kenneth recently landed support for &apos;resolution&apos; media queries and dppx units (bug 99077). I think we should enable it in chromium.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755300</commentid>
    <comment_count>1</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-10-31 07:52:20 -0700</bug_when>
    <thetext>We&apos;ll need ENABLE_CSS_IMAGE_RESOLUTION as well as it depends on that.

I do completely concur for Android, but johnme@ has some concerns regarding the units we&apos;d expose.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755303</commentid>
    <comment_count>2</comment_count>
    <who name="Rick Byers">rbyers</who>
    <bug_when>2012-10-31 07:57:04 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; We&apos;ll need ENABLE_CSS_IMAGE_RESOLUTION as well as it depends on that.

Are you sure?  From the code it looked to me like it was perhaps designed to work without it.  Anyway I will give it a try sometime soon (just some higher priority things in my queue first).

&gt; I do completely concur for Android, but johnme@ has some concerns regarding the units we&apos;d expose.

Great, let&apos;s discuss any concerns.  Tab has been working on the spec, so I hope he&apos;s already been made aware of any concerns chromium folks have with it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755312</commentid>
    <comment_count>3</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-10-31 08:04:16 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; Are you sure?  From the code it looked to me like it was perhaps designed to work without it.  Anyway I will give it a try sometime soon (just some higher priority things in my queue first).

I should read patches more carefully :-). You&apos;re right, thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755318</commentid>
    <comment_count>4</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-10-31 08:16:33 -0700</bug_when>
    <thetext>Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755387</commentid>
    <comment_count>5</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-10-31 09:44:58 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; I do completely concur for Android, but johnme@ has some concerns regarding the units we&apos;d expose.
&gt; 
&gt; Great, let&apos;s discuss any concerns.  Tab has been working on the spec, so I hope he&apos;s already been made aware of any concerns chromium folks have with it.

I filed bug 100865 about this.

(In reply to comment #4)
&gt; Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.

Why do we need to stop this? And what should we do instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>755446</commentid>
    <comment_count>6</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2012-10-31 10:34:26 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #2)
&gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; I do completely concur for Android, but johnme@ has some concerns regarding the units we&apos;d expose.
&gt; &gt; 
&gt; &gt; Great, let&apos;s discuss any concerns.  Tab has been working on the spec, so I hope he&apos;s already been made aware of any concerns chromium folks have with it.
&gt; 
&gt; I filed bug 100865 about this.
&gt; 
&gt; (In reply to comment #4)
&gt; &gt; Be aware that Chromium needs to stop forwarding the actual device dpi to the screen.vertical|horizontalDPI methods.
&gt; 
&gt; Why do we need to stop this? And what should we do instead?

As far as I can tell you are not using it for anything (via that api) and the values are also not exposed to the web content (not declared in the idl).

So I don&apos;t think you need to do anything instead.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>872522</commentid>
    <comment_count>7</comment_count>
    <who name="Stephen Chenney">schenney</who>
    <bug_when>2013-04-09 17:07:32 -0700</bug_when>
    <thetext>Marked LayoutTest bugs, bugs with Chromium IDs, and some others as WontFix. Test failure bugs still are trackable via TestExpectations or disabled unit tests.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>