<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100846</bug_id>
          
          <creation_ts>2012-10-31 06:14:36 -0700</creation_ts>
          <short_desc>[JSC] Web Inspector: support Debugger.pause for dedicated workers</short_desc>
          <delta_ts>2016-11-17 14:37:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>164136</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yury Semikhatsky">yurys</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>apavlov</cc>
    
    <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>graouts</cc>
    
    <cc>joepeck</cc>
    
    <cc>keishi</cc>
    
    <cc>loislo</cc>
    
    <cc>mark.lam</cc>
    
    <cc>PeterHWang</cc>
    
    <cc>pfeldman</cc>
    
    <cc>pmuellr</cc>
    
    <cc>timothy</cc>
    
    <cc>vsevik</cc>
    
    <cc>web-inspector-bugs</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>yurys</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>755207</commentid>
    <comment_count>0</comment_count>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2012-10-31 06:14:36 -0700</bug_when>
    <thetext>Pause command should worker for dedicated workers in JSC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>770438</commentid>
    <comment_count>1</comment_count>
    <who name="Peter Wang">PeterHWang</who>
    <bug_when>2012-11-19 00:49:59 -0800</bug_when>
    <thetext>So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.

Are there some special cases have to be considered? Please give some tips, thank you very much.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>770453</commentid>
    <comment_count>2</comment_count>
    <who name="Yury Semikhatsky">yurys</who>
    <bug_when>2012-11-19 01:07:28 -0800</bug_when>
    <thetext>(In reply to comment #1)
&gt; So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
&gt; 
&gt; Are there some special cases have to be considered? Please give some tips, thank you very much.

The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.

There is a sanity test for pause in dedicated worker that didn&apos;t work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>770457</commentid>
    <comment_count>3</comment_count>
    <who name="Peter Wang">PeterHWang</who>
    <bug_when>2012-11-19 01:11:13 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (In reply to comment #1)
&gt; &gt; So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
&gt; &gt; 
&gt; &gt; Are there some special cases have to be considered? Please give some tips, thank you very much.
&gt; 
&gt; The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
&gt; 
&gt; There is a sanity test for pause in dedicated worker that didn&apos;t work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.

Ok, I&apos;ll check it and report the newest situation here. Thank you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>770493</commentid>
    <comment_count>4</comment_count>
    <who name="Peter Wang">PeterHWang</who>
    <bug_when>2012-11-19 02:02:10 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; (In reply to comment #2)
&gt; &gt; (In reply to comment #1)
&gt; &gt; &gt; So far, the Pause commands are same for shared and dedicated worker of JSC, it just set a flag to let JSC engine to stop on next statement.
&gt; &gt; &gt; 
&gt; &gt; &gt; Are there some special cases have to be considered? Please give some tips, thank you very much.
&gt; &gt; 
&gt; &gt; The pause command should work even if the worker is in a tight loop so that we can pause long-running scripts. Apart from that there is nothing special about the pause for workers.
&gt; &gt; 
&gt; &gt; There is a sanity test for pause in dedicated worker that didn&apos;t work in JSC last time I checked that(LayoutTests/inspector-protocol/debugger-pause-dedicated-worker.html). This may have changed after your recent changes to WorkerScriptDebugServer.
&gt; 
&gt; Ok, I&apos;ll check it and report the newest situation here. Thank you.

My local Qt build (r135111) can pass this case.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1042453</commentid>
    <comment_count>5</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-10-17 13:49:51 -0700</bug_when>
    <thetext>This test appears to be working. Please reopen if you find that there is still an issue with this test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050245</commentid>
    <comment_count>6</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2014-11-20 14:14:19 -0800</bug_when>
    <thetext>The test is skipped on Mac, which is why the flakiness dashboard doesn&apos;t see it fail.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1050246</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-11-20 14:14:33 -0800</bug_when>
    <thetext>&lt;rdar://problem/19049362&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1252458</commentid>
    <comment_count>8</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2016-11-17 14:37:16 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 164136 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>