10083 2006-07-23 22:34:17 -0700 REGRESSION (r15584): editing/selection/select-from-textfield-outwards failing 2006-07-24 08:38:56 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 1 mitz webkit-unassigned alice.barraclough darin oldest_to_newest 50632 0 mitz 2006-07-23 22:34:17 -0700 The fix for <rdar://problem/4617841> removed part of the fix for bug 9312, causing editing/selection/select-from-textfield-outwards.html to fail: -    if (isReplaced()) { -        if (y < absy || y < absy + height() && x < absx) -            return VisiblePosition(n, caretMinOffset(), DOWNSTREAM); -        if (y >= absy + height() || y >= absy && x >= absx + width()) -            return VisiblePosition(n, caretMaxOffset(), DOWNSTREAM); -    }  You can see the problem by opening the test case from bug 9312 (attachment 8713) and dragging from the middle of the text field and to the right. As you exit the field, the selection changes (starts at the beginning of the text field instead of going from the middle to the end). 50634 1 9644 mitz 2006-07-23 23:07:04 -0700 Created attachment 9644 Add back the code that was removed 50658 2 timothy 2006-07-24 08:36:58 -0700 This has been landed on the branch in r15596. 50659 3 timothy 2006-07-24 08:38:56 -0700 This has landed on TOT in r15597. 9644 2006-07-23 23:07:04 -0700 2006-07-24 08:26:39 -0700 Add back the code that was removed 10083_r1.patch text/plain 1747 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNTU5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDYtMDctMjQgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBmaXggaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDA4MworICAgICAgICAgIFJFR1JFU1NJT04gKHIxNTU4NCk6IGVkaXRpbmcvc2VsZWN0 aW9uL3NlbGVjdC1mcm9tLXRleHRmaWVsZC1vdXR3YXJkcyBmYWlsaW5nCisKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2s6 OnBvc2l0aW9uRm9yQ29vcmRpbmF0ZXMpOiBBZGRlZCBiYWNrIGNoYW5nZSBmcm9tIHRoZSBmaXgK KyAgICAgICAgZm9yIGJ1ZyA5MzEyOiBGb3IgY29vcmRpbmF0ZXMgb3V0c2lkZSBhIHJlcGxhY2Vk IG9iamVjdCwgcmV0dXJuIHRoZSBwb3NpdGlvbgorICAgICAgICBqdXN0IGJlZm9yZSAoYWZ0ZXIp IHRoZSBlbGVtZW50IGlmIHRoZSBjb29yZGluYXRlcyBhcmUgYWJvdmUgb3IgdG8gdGhlIGxlZnQg KGJlbG93CisgICAgICAgIG9yIHRvIHRoZSByaWdodCkuCisKIDIwMDYtMDctMjMgIE1hcmsgUm93 ZSAgPG9wZW5kYXJ3aW4ub3JnQGJkYXNoLm5ldC5uej4KIAogICAgICAgICBSZXZpZXdlZCBieSBt YWNpZWouCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCShyZXZpc2lvbiAxNTU5MikK KysrIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjYyMiw2ICsyNjIyLDEzIEBAIFZpc2libGVQb3NpdGlvbiBSZW5kZXJCbG9jazo6cG9zaXRpb25G b3IKIAogICAgIE5vZGUqIG4gPSBlbGVtZW50KCk7CiAgICAgCisgICAgaWYgKGlzUmVwbGFjZWQo KSkgeworICAgICAgICBpZiAoeSA8IGFic3kgfHwgeSA8IGFic3kgKyBoZWlnaHQoKSAmJiB4IDwg YWJzeCkKKyAgICAgICAgICAgIHJldHVybiBWaXNpYmxlUG9zaXRpb24obiwgY2FyZXRNaW5PZmZz ZXQoKSwgRE9XTlNUUkVBTSk7CisgICAgICAgIGlmICh5ID49IGFic3kgKyBoZWlnaHQoKSB8fCB5 ID49IGFic3kgJiYgeCA+PSBhYnN4ICsgd2lkdGgoKSkKKyAgICAgICAgICAgIHJldHVybiBWaXNp YmxlUG9zaXRpb24obiwgY2FyZXRNYXhPZmZzZXQoKSwgRE9XTlNUUkVBTSk7CisgICAgfSAKKwog ICAgIC8vIElmIHdlIHN0YXJ0IGluc2lkZSB0aGUgc2hhZG93IHRyZWUsIHdlIHdpbGwgc3RheSBp bnNpZGUgKGV2ZW4gaWYgdGhlIHBvaW50IGlzIGFib3ZlIG9yIGJlbG93KS4KICAgICBpZiAoIShu ICYmIG4tPmlzU2hhZG93Tm9kZSgpKSkgewogICAgICAgICAvLyBEb24ndCByZXR1cm4gcG9zaXRp b25zIGluc2lkZSBlZGl0YWJsZSByb290cyBmb3IgY29vcmRpbmF0ZXMgb3V0c2lkZSB0aG9zZSBy b290cywgZXhjZXB0IGZvciBjb29yZGluYXRlcyBvdXRzaWRlCg==