100828 2012-10-31 01:19:47 -0700 GC should shrink arrays to fit in the smallest sensible amount of memory 2012-10-31 08:59:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All NEW P2 Normal --- 100827 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver oldest_to_newest 755042 0 fpizlo 2012-10-31 01:19:47 -0700 This will mostly prevent us from having to reason about a priori thresholds for sparse array logic. If in doubt, JSC should be able to just allocate a large contiguous array and leave it to the GC to figure out whether or not that was a good idea. That might imply that the GC should also be able to create sparse maps as needed. Most likely the best way to do it will be that if the GC detects that an array would benefit from a sparse map and that array doesn't already have a sparse map, then it should defer the sparse map creation. It can be done as part of sweeping, or something. I'm marking this as depending on https://bugs.webkit.org/show_bug.cgi?id=100827. Really it's related to the other bug. I want to first bump up the sparse map size threshold and then later worry about the heuristics to make it safe-for-space in all of the various pathological corner cases. 755047 1 171595 fpizlo 2012-10-31 01:29:14 -0700 Created attachment 171595 the patch 755048 2 171595 fpizlo 2012-10-31 01:29:44 -0700 Comment on attachment 171595 the patch Ahhh!! Never mind. I posted this patch to the wrong bug. 755339 3 ggaren 2012-10-31 08:45:19 -0700 FWIW, I think we should apply the same logic to named property backing stores. 755360 4 oliver 2012-10-31 08:59:50 -0700 (In reply to comment #3) > FWIW, I think we should apply the same logic to named property backing stores. We'd need to deal with structure implying backing store size 171595 2012-10-31 01:29:14 -0700 2012-10-31 01:29:43 -0700 the patch 100000.patch text/plain 1690 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTMyOTk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTEwLTMxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg U3BhcnNlIGFycmF5IHNpemUgdGhyZXNob2xkIHNob3VsZCBiZSBpbmNyZWFzZWQgdG8gMTAwMDAw CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA4MjcK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGVu YWJsZXMgdGhlIHVzZSBvZiBjb250aWd1b3VzIGFycmF5cyBpbiBwcm9ncmFtcyB0aGF0IHByZXZp b3VzbHkKKyAgICAgICAgY291bGRuJ3QgdXNlIHRoZW0uIEFuZCBJIHNvIGZhciBjYW4ndCBzZWUg YW55IGV4YW1wbGVzIG9mIHRoaXMgYmVpbmcKKyAgICAgICAgYSBkb3duc2lkZS4gVG8gdGhlIGV4 dGVudCB0aGF0IHRoZXJlIGlzIGEgZG93bnNpZGUsIGl0IG91Z2h0IHRvIGJlCisgICAgICAgIGFk ZHJlc3NlZCBieSBHQzogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDgyOAorCisgICAgICAgICogcnVudGltZS9BcnJheUNvbnZlbnRpb25zLmg6CisgICAgICAgIChK U0MpOgorCiAyMDEyLTEwLTMwICBZdXFpYW5nIFhpYW4gIDx5dXFpYW5nLnhpYW5AaW50ZWwuY29t PgogCiAgICAgICAgIGdsc2wtZnVuY3Rpb24tYXRhbi5odG1sIFdlYkdMIGNvbmZvcm1hbmNlIHRl c3QgZmFpbHMgYWZ0ZXIgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk5 MTU0CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheUNvbnZlbnRpb25z LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlDb252 ZW50aW9ucy5oCShyZXZpc2lvbiAxMzI3NTkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9BcnJheUNvbnZlbnRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDcgKzU4LDcgQEAg bmFtZXNwYWNlIEpTQyB7CiAKIC8vIFRoZXNlIHZhbHVlcyBoYXZlIHRvIGJlIG1hY3JvcyB0byBi ZSB1c2VkIGluIG1heCgpIGFuZCBtaW4oKSB3aXRob3V0IGludHJvZHVjaW5nCiAvLyBhIFBJQyBi cmFuY2ggaW4gTWFjaC1PIGJpbmFyaWVzLCBzZWUgPHJkYXI6Ly9wcm9ibGVtLzU5NzEzOTE+Lgot I2RlZmluZSBNSU5fU1BBUlNFX0FSUkFZX0lOREVYIDEwMDAwVQorI2RlZmluZSBNSU5fU1BBUlNF X0FSUkFZX0lOREVYIDEwMDAwMFUKICNkZWZpbmUgTUFYX1NUT1JBR0VfVkVDVE9SX0lOREVYIChN QVhfU1RPUkFHRV9WRUNUT1JfTEVOR1RIIC0gMSkKIC8vIDB4RkZGRkZGRkYgaXMgYSBiaXQgd2Vp cmQgLS0gaXMgbm90IGFuIGFycmF5IGluZGV4IGV2ZW4gdGhvdWdoIGl0J3MgYW4gaW50ZWdlci4K ICNkZWZpbmUgTUFYX0FSUkFZX0lOREVYIDB4RkZGRkZGRkVVCg==