100824 2012-10-31 00:40:42 -0700 Memory instrumentation: do not report memory occupied by objects referenced using client interfaces 2012-10-31 01:36:34 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs yurys oldest_to_newest 755027 0 yurys 2012-10-31 00:40:42 -0700 In many classes we have pointer to a client object. These references should be reported as weak pointers and the client's memory usage should be reported when the client is reached from its instrumented owner where we know exact type of the client. Otherwise we would need to add reportMemoryUsage to all client interfaces which place additional burden on the client implementers and blur the instrumentation boundaries. 755028 1 171592 yurys 2012-10-31 00:44:54 -0700 Created attachment 171592 Patch 755029 2 yurys 2012-10-31 00:46:14 -0700 (In reply to comment #1) > Created an attachment (id=171592) [details] > Patch After these change number of objects counted by the memory instrumentation that haven't been allocated on the heap using malloc drops to 0 on nytimes.com in Chromium. 755046 3 171592 apavlov 2012-10-31 01:28:25 -0700 Comment on attachment 171592 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171592&action=review > Source/WebCore/ChangeLog:12 > + interfaces which place additional burden on the client implementers and blur place -> places, blur -> blurs 755052 4 yurys 2012-10-31 01:35:42 -0700 (In reply to comment #3) > (From update of attachment 171592 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171592&action=review > > > Source/WebCore/ChangeLog:12 > > + interfaces which place additional burden on the client implementers and blur > > place -> places, blur -> blurs Done. 755053 5 yurys 2012-10-31 01:36:34 -0700 Committed r132998: <http://trac.webkit.org/changeset/132998> 171592 2012-10-31 00:44:54 -0700 2012-10-31 01:28:25 -0700 Patch bug-100824-20121031114317.patch text/plain 6471 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI3ZjhhMmViM2Y2NDIz MjljMDA5ZGFkY2E5MWYxOTFkOTQxODA2ZS4uNmIzNjVhNzJhM2QzMDM2N2JhYjMxYTExMzQwOGVh MDczMjU4NGExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDEyLTEwLTMxICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1lbW9yeSBpbnN0 cnVtZW50YXRpb246IGRvIG5vdCByZXBvcnQgbWVtb3J5IG9jY3VwaWVkIGJ5IG9iamVjdHMgcmVm ZXJlbmNlZCB1c2luZyBjbGllbnQgaW50ZXJmYWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwODI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gbWFueSBjbGFzc2VzIHdlIGhhdmUgcG9pbnRlciB0 byBhIGNsaWVudCBvYmplY3QuIFRoZXNlIHJlZmVyZW5jZXMgc2hvdWxkIGJlCisgICAgICAgIHJl cG9ydGVkIGFzIHdlYWsgcG9pbnRlcnMgYW5kIHRoZSBjbGllbnQncyBtZW1vcnkgdXNhZ2Ugc2hv dWxkIGJlIHJlcG9ydGVkIHdoZW4KKyAgICAgICAgdGhlIGNsaWVudCBpcyByZWFjaGVkIGZyb20g aXRzIGluc3RydW1lbnRlZCBvd25lciB3aGVyZSB3ZSBrbm93IGV4YWN0IHR5cGUgb2YKKyAgICAg ICAgdGhlIGNsaWVudC4gT3RoZXJ3aXNlIHdlIHdvdWxkIG5lZWQgdG8gYWRkIHJlcG9ydE1lbW9y eVVzYWdlIHRvIGFsbCBjbGllbnQKKyAgICAgICAgaW50ZXJmYWNlcyB3aGljaCBwbGFjZSBhZGRp dGlvbmFsIGJ1cmRlbiBvbiB0aGUgY2xpZW50IGltcGxlbWVudGVycyBhbmQgYmx1cgorICAgICAg ICB0aGUgaW5zdHJ1bWVudGF0aW9uIGJvdW5kYXJpZXMuCisKKyAgICAgICAgKiBpbnNwZWN0b3Iv SW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250 cm9sbGVyOjpyZXBvcnRNZW1vcnlVc2FnZSk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3Rv ckRlYnVnZ2VyQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRGVidWdnZXJB Z2VudDo6cmVwb3J0TWVtb3J5VXNhZ2UpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JN ZW1vcnlBZ2VudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JNZW1vcnlBZ2VudDo6 cmVwb3J0TWVtb3J5VXNhZ2UpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck92ZXJsYXk6OnJlcG9ydE1lbW9yeVVz YWdlKToKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JSZXNvdXJjZUFnZW50OjpyZXBvcnRNZW1vcnlVc2Fn ZSk6CisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnJl cG9ydE1lbW9yeVVzYWdlKToKKwogMjAxMi0xMC0zMCAgWm9sdGFuIE55dWwgIDx6b2x0YW4ubnl1 bEBpbnRlbC5jb20+CiAKICAgICAgICAgM2Qgcm90YXRpb24gd2l0aCBbMCwgMCwgMF0gZGlyZWN0 aW9uIHZlY3RvciBzaG91bGQgbm90IGJlIGFwcGxpZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA4YmFkN2NjMGM2YjdkZDcwYTM4 OTYyM2M2ZTUwYjk1ZDQ3NjY3MGE4Li4yMDVkZGFkOWMxYzlmMTZiOGUzZDhhZmUzNGRhNjhiNWU5 MDJlMmM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuY3BwCkBAIC00MDQsNyArNDA0LDcgQEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpy ZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKQogICAg IGluZm8uYWRkTWVtYmVyKG1faW5zcGVjdG9yRnJvbnRlbmRDbGllbnQpOwogICAgIGluZm8uYWRk TWVtYmVyKG1faW5zcGVjdG9yRnJvbnRlbmQpOwogICAgIGluZm8uYWRkTWVtYmVyKG1fcGFnZSk7 Ci0gICAgaW5mby5hZGRNZW1iZXIobV9pbnNwZWN0b3JDbGllbnQpOworICAgIGluZm8uYWRkV2Vh a1BvaW50ZXIobV9pbnNwZWN0b3JDbGllbnQpOwogICAgIGluZm8uYWRkTWVtYmVyKG1fYWdlbnRz KTsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRl YnVnZ2VyQWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRlYnVn Z2VyQWdlbnQuY3BwCmluZGV4IDA5NTFhM2U3NjA0Y2YwZGZjOGY4MDM0ZGY4YWRhZTE0ZjA1YmU2 NDguLjYxYjMyZjA3ZDNmYzY0YTU2NjI4MzMxODNmYzBlMjQ2NjY3ZTVhMDkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JEZWJ1Z2dlckFnZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRGVidWdnZXJBZ2VudC5jcHAKQEAg LTc0OCw3ICs3NDgsNyBAQCB2b2lkIEluc3BlY3RvckRlYnVnZ2VyQWdlbnQ6OnJlcG9ydE1lbW9y eVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZgogICAgIGluZm8uYWRkTWVt YmVyKG1fYnJlYWtwb2ludElkVG9EZWJ1Z1NlcnZlckJyZWFrcG9pbnRJZHMpOwogICAgIGluZm8u YWRkTWVtYmVyKG1fY29udGludWVUb0xvY2F0aW9uQnJlYWtwb2ludElkKTsKICAgICBpbmZvLmFk ZE1lbWJlcihtX2JyZWFrQXV4RGF0YSk7Ci0gICAgaW5mby5hZGRNZW1iZXIobV9saXN0ZW5lcik7 CisgICAgaW5mby5hZGRXZWFrUG9pbnRlcihtX2xpc3RlbmVyKTsKIH0KIAogdm9pZCBTY3JpcHRE ZWJ1Z0xpc3RlbmVyOjpTY3JpcHQ6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8q IG1lbW9yeU9iamVjdEluZm8pIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yTWVtb3J5QWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3Rvck1lbW9yeUFnZW50LmNwcAppbmRleCBiNjllODUyYTBiOTY4MTM1YmIyODliODdi NGVhMWJjMThkOTIxZTE4Li45NGU3Y2U0NGFlYWVjZDU2ZGYzZWJmNzg5YWRhMjE0MjcwMGY2Zjk1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yTWVtb3J5QWdl bnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JNZW1vcnlBZ2Vu dC5jcHAKQEAgLTU2MSw3ICs1NjEsNyBAQCB2b2lkIEluc3BlY3Rvck1lbW9yeUFnZW50OjpyZXBv cnRNZW1vcnlVc2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKQogewogICAg IE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVjdEluZm8sIHRoaXMsIFdlYkNvcmVNZW1v cnlUeXBlczo6SW5zcGVjdG9yKTsKICAgICBJbnNwZWN0b3JCYXNlQWdlbnQ8SW5zcGVjdG9yTWVt b3J5QWdlbnQ+OjpyZXBvcnRNZW1vcnlVc2FnZShtZW1vcnlPYmplY3RJbmZvKTsKLSAgICBpbmZv LmFkZE1lbWJlcihtX2luc3BlY3RvckNsaWVudCk7CisgICAgaW5mby5hZGRXZWFrUG9pbnRlciht X2luc3BlY3RvckNsaWVudCk7CiAgICAgaW5mby5hZGRNZW1iZXIobV9wYWdlKTsKIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCmluZGV4IGIxNDFh MTYwNGEyNjE2MzM5MDZhNDY2ODJiNzY4ZTI3MGJkY2Q3ZjQuLjNjZWFiN2ZkOTFiZjllMjM1YzVk Nzc1MzE3OTdkZjFmODMxMjVkZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JPdmVybGF5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yT3ZlcmxheS5jcHAKQEAgLTUwNCw3ICs1MDQsNyBAQCB2b2lkIEluc3BlY3Rvck92ZXJs YXk6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8p IGNvbgogewogICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVjdEluZm8sIHRoaXMs IFdlYkNvcmVNZW1vcnlUeXBlczo6SW5zcGVjdG9yT3ZlcmxheSk7CiAgICAgaW5mby5hZGRNZW1i ZXIobV9wYWdlKTsKLSAgICBpbmZvLmFkZE1lbWJlcihtX2NsaWVudCk7CisgICAgaW5mby5hZGRX ZWFrUG9pbnRlcihtX2NsaWVudCk7CiAgICAgaW5mby5hZGRNZW1iZXIobV9wYXVzZWRJbkRlYnVn Z2VyTWVzc2FnZSk7CiAgICAgaW5mby5hZGRNZW1iZXIobV9oaWdobGlnaHROb2RlKTsKICAgICBp bmZvLmFkZE1lbWJlcihtX25vZGVIaWdobGlnaHRDb25maWcpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlQWdlbnQuY3BwCmluZGV4IDBjNzkyOTU0 NzBmNDI1ZGVjODgxZTZiYzJiNTg1NWI4N2EwYjk3MmIuLjMzM2NmZTE0YzNjNTU2ZjA0YTllNjMy MDRjNmNjMTRkZmMyYjI3YjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JSZXNvdXJjZUFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yUmVzb3VyY2VBZ2VudC5jcHAKQEAgLTY3NCw4ICs2NzQsOCBAQCB2b2lkIEluc3Bl Y3RvclJlc291cmNlQWdlbnQ6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1l bW9yeU9iamVjdEluZgogewogICAgIE1lbW9yeUNsYXNzSW5mbyBpbmZvKG1lbW9yeU9iamVjdElu Zm8sIHRoaXMsIFdlYkNvcmVNZW1vcnlUeXBlczo6SW5zcGVjdG9yUmVzb3VyY2VBZ2VudCk7CiAg ICAgSW5zcGVjdG9yQmFzZUFnZW50PEluc3BlY3RvclJlc291cmNlQWdlbnQ+OjpyZXBvcnRNZW1v cnlVc2FnZShtZW1vcnlPYmplY3RJbmZvKTsKLSAgICBpbmZvLmFkZE1lbWJlcihtX3BhZ2VBZ2Vu dCk7Ci0gICAgaW5mby5hZGRNZW1iZXIobV9jbGllbnQpOworICAgIGluZm8uYWRkV2Vha1BvaW50 ZXIobV9wYWdlQWdlbnQpOworICAgIGluZm8uYWRkV2Vha1BvaW50ZXIobV9jbGllbnQpOwogICAg IGluZm8uYWRkV2Vha1BvaW50ZXIobV9mcm9udGVuZCk7CiAgICAgaW5mby5hZGRNZW1iZXIobV91 c2VyQWdlbnRPdmVycmlkZSk7CiAgICAgaW5mby5hZGRNZW1iZXIobV9yZXNvdXJjZXNEYXRhKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BhZ2UuY3BwCmluZGV4IDcwMDlhYjU2NjdjYjFiMmMxNGY1MDJkNDc1M2RjYzAyMzRh ZjEyMzYuLmM4MzdjNmYzMzA1NzViMzRhZmFiZGIzODA1MWFlZjhlZTNmZDNmOTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9QYWdlLmNwcApAQCAtMTI5NSw3ICsxMjk1LDcgQEAgdm9pZCBQYWdlOjpyZXBvcnRNZW1vcnlV c2FnZShNZW1vcnlPYmplY3RJbmZvKiBtZW1vcnlPYmplY3RJbmZvKSBjb25zdAogICAgIGluZm8u YWRkTWVtYmVyKG1fbWFpbkZyYW1lKTsKICAgICBpbmZvLmFkZE1lbWJlcihtX3BsdWdpbkRhdGEp OwogICAgIGluZm8uYWRkTWVtYmVyKG1fdGhlbWUpOwotICAgIGluZm8uYWRkTWVtYmVyKG1fZWRp dG9yQ2xpZW50KTsKKyAgICBpbmZvLmFkZFdlYWtQb2ludGVyKG1fZWRpdG9yQ2xpZW50KTsKICAg ICBpbmZvLmFkZE1lbWJlcihtX2ZlYXR1cmVPYnNlcnZlcik7CiAgICAgaW5mby5hZGRNZW1iZXIo bV9ncm91cE5hbWUpOwogICAgIGluZm8uYWRkTWVtYmVyKG1fcGFnaW5hdGlvbik7CkBAIC0xMzA4 LDcgKzEzMDgsNyBAQCB2b2lkIFBhZ2U6OnJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdElu Zm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0CiAgICAgaW5mby5hZGRNZW1iZXIobV9yZWxldmFu dFVucGFpbnRlZFJlbmRlck9iamVjdHMpOwogICAgIGluZm8uYWRkTWVtYmVyKG1fcmVsZXZhbnRQ YWludGVkUmVnaW9uKTsKICAgICBpbmZvLmFkZE1lbWJlcihtX3JlbGV2YW50VW5wYWludGVkUmVn aW9uKTsKLSAgICBpbmZvLmFkZE1lbWJlcihtX2FsdGVybmF0aXZlVGV4dENsaWVudCk7CisgICAg aW5mby5hZGRXZWFrUG9pbnRlcihtX2FsdGVybmF0aXZlVGV4dENsaWVudCk7CiAgICAgaW5mby5h ZGRNZW1iZXIobV9zZWVuUGx1Z2lucyk7CiB9CiAK