100813 2012-10-30 22:02:32 -0700 ScrollingCoordinatorMac::stateNodeForID() should return a ScrollingStateNode* instead of a ScrollingStateScrollingNode* 2012-10-30 22:58:38 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin andersca bdakin jamesr simon.fraser thorton tonikitoo webkit.review.bot oldest_to_newest 754957 0 bdakin 2012-10-30 22:02:32 -0700 ScrollingCoordinatorMac::stateNodeForID() should return a ScrollingStateNode* instead of a ScrollingStateScrollingNode* so that it can be used for other types of nodes once we add them. 754959 1 171582 bdakin 2012-10-30 22:04:58 -0700 Created attachment 171582 Patch 754983 2 bdakin 2012-10-30 22:58:38 -0700 Thanks, Sam! http://trac.webkit.org/changeset/132986 171582 2012-10-30 22:04:58 -0700 2012-10-30 22:55:28 -0700 Patch state-node-for-id-for-review.txt text/plain 4198 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjk4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAwODEzCisgICAgICAgIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFj OjpzdGF0ZU5vZGVGb3JJRCgpIHNob3VsZCByZXR1cm4gYSAKKyAgICAgICAgU2Nyb2xsaW5nU3Rh dGVOb2RlKiBpbnN0ZWFkIG9mIGEgU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlKgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNjcm9sbGluZ0Nvb3Jk aW5hdG9yTWFjOjpzdGF0ZU5vZGVGb3JJRCgpIHNob3VsZCByZXR1cm4gYSAKKyAgICAgICAgU2Ny b2xsaW5nU3RhdGVOb2RlKiBpbnN0ZWFkIG9mIGEgU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2Rl KiBzbyB0aGF0IAorICAgICAgICBpdCBjYW4gYmUgdXNlZCBmb3Igb3RoZXIgdHlwZXMgb2Ygbm9k ZXMgb25jZSB3ZSBhZGQgdGhlbS4KKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xs aW5nQ29vcmRpbmF0b3JNYWMuaDoKKyAgICAgICAgKFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjKToK KyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMubW06 CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvck1hYzo6ZnJhbWVWaWV3TGF5 b3V0VXBkYXRlZCk6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvck1hYzo6 cmVjb21wdXRlV2hlZWxFdmVudEhhbmRsZXJDb3VudEZvckZyYW1lVmlldyk6CisgICAgICAgIChX ZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvck1hYzo6cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBk YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjpzdGF0ZU5v ZGVGb3JJRCk6CisKIDIwMTItMTAtMzAgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgog CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA4MDkK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGlu YXRvck1hYy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21h Yy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5oCShyZXZpc2lvbiAxMzI5ODEpCisrKyBTb3VyY2Uv V2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMuaAkod29y a2luZyBjb3B5KQpAQCAtNzcsNyArNzcsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBz ZXRTaG91bGRVcGRhdGVTY3JvbGxMYXllclBvc2l0aW9uT25NYWluVGhyZWFkKE1haW5UaHJlYWRT Y3JvbGxpbmdSZWFzb25zKTsKIAogICAgIHZvaWQgZW5zdXJlUm9vdFN0YXRlTm9kZUZvckZyYW1l VmlldyhGcmFtZVZpZXcqKTsKLSAgICBTY3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGUqIHN0YXRl Tm9kZUZvcklEKFNjcm9sbGluZ05vZGVJRCk7CisgICAgU2Nyb2xsaW5nU3RhdGVOb2RlKiBzdGF0 ZU5vZGVGb3JJRChTY3JvbGxpbmdOb2RlSUQpOwogCiAgICAgc3RydWN0IFNjcm9sbFBhcmFtZXRl cnMgewogICAgICAgICBTY3JvbGxFbGFzdGljaXR5IGhvcml6b250YWxTY3JvbGxFbGFzdGljaXR5 OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3Jk aW5hdG9yTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5n L21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5tbQkocmV2aXNpb24gMTMyOTgxKQorKysgU291 cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLm1t CSh3b3JraW5nIGNvcHkpCkBAIC0xMDksNyArMTA5LDcgQEAgdm9pZCBTY3JvbGxpbmdDb29yZGlu YXRvck1hYzo6ZnJhbWVWaWV3TAogICAgIGlmICghY29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFt ZVZpZXcoZnJhbWVWaWV3KSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgU2Nyb2xsaW5nU3RhdGVT Y3JvbGxpbmdOb2RlKiBub2RlID0gc3RhdGVOb2RlRm9ySUQoZnJhbWVWaWV3LT5zY3JvbGxMYXll cklEKCkpOworICAgIFNjcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZSogbm9kZSA9IHRvU2Nyb2xs aW5nU3RhdGVTY3JvbGxpbmdOb2RlKHN0YXRlTm9kZUZvcklEKGZyYW1lVmlldy0+c2Nyb2xsTGF5 ZXJJRCgpKSk7CiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm47CiAKQEAgLTEzMCw3ICsx MzAsNyBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjpmcmFtZVZpZXdMCiAKIHZvaWQg U2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWM6OnJlY29tcHV0ZVdoZWVsRXZlbnRIYW5kbGVyQ291bnRG b3JGcmFtZVZpZXcoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCiB7Ci0gICAgU2Nyb2xsaW5nU3RhdGVT Y3JvbGxpbmdOb2RlKiBub2RlID0gc3RhdGVOb2RlRm9ySUQoZnJhbWVWaWV3LT5zY3JvbGxMYXll cklEKCkpOworICAgIFNjcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZSogbm9kZSA9IHRvU2Nyb2xs aW5nU3RhdGVTY3JvbGxpbmdOb2RlKHN0YXRlTm9kZUZvcklEKGZyYW1lVmlldy0+c2Nyb2xsTGF5 ZXJJRCgpKSk7CiAgICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm47CiAgICAgc2V0V2hlZWxF dmVudEhhbmRsZXJDb3VudEZvck5vZGUoY29tcHV0ZUN1cnJlbnRXaGVlbEV2ZW50SGFuZGxlckNv dW50KCksIG5vZGUpOwpAQCAtMTkxLDcgKzE5MSw3IEBAIGJvb2wgU2Nyb2xsaW5nQ29vcmRpbmF0 b3JNYWM6OnJlcXVlc3RTY3IKICAgICBpZiAoZnJhbWVWaWV3LT5mcmFtZSgpLT5kb2N1bWVudCgp LT5pblBhZ2VDYWNoZSgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAotICAgIFNjcm9sbGluZ1N0 YXRlU2Nyb2xsaW5nTm9kZSogc3RhdGVOb2RlID0gc3RhdGVOb2RlRm9ySUQoZnJhbWVWaWV3LT5z Y3JvbGxMYXllcklEKCkpOworICAgIFNjcm9sbGluZ1N0YXRlU2Nyb2xsaW5nTm9kZSogc3RhdGVO b2RlID0gdG9TY3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGUoc3RhdGVOb2RlRm9ySUQoZnJhbWVW aWV3LT5zY3JvbGxMYXllcklEKCkpKTsKICAgICBpZiAoIXN0YXRlTm9kZSkKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCkBAIC0yOTQsNyArMjk0LDcgQEAgdm9pZCBTY3JvbGxpbmdDb29yZGluYXRv ck1hYzo6Y2xlYXJTdGF0ZQogICAgIG1fc2Nyb2xsaW5nU3RhdGVUcmVlLT5yZW1vdmVOb2RlKG1f c2Nyb2xsaW5nU3RhdGVUcmVlLT5yb290U3RhdGVOb2RlKCkpOwogfQogCi1TY3JvbGxpbmdTdGF0 ZVNjcm9sbGluZ05vZGUqIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjpzdGF0ZU5vZGVGb3JJRChT Y3JvbGxpbmdOb2RlSUQgc2Nyb2xsTGF5ZXJJRCkKK1Njcm9sbGluZ1N0YXRlTm9kZSogU2Nyb2xs aW5nQ29vcmRpbmF0b3JNYWM6OnN0YXRlTm9kZUZvcklEKFNjcm9sbGluZ05vZGVJRCBzY3JvbGxM YXllcklEKQogewogICAgIGlmICghc2Nyb2xsTGF5ZXJJRCkKICAgICAgICAgcmV0dXJuIDA7CkBA IC0zMDMsOCArMzAzLDcgQEAgU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlKiBTY3JvbGxpbmdD bwogICAgIGlmIChpdCA9PSBtX3N0YXRlTm9kZU1hcC5lbmQoKSkKICAgICAgICAgcmV0dXJuIDA7 CiAKLSAgICBTY3JvbGxpbmdTdGF0ZU5vZGUqIG5vZGUgPSBpdC0+dmFsdWU7Ci0gICAgcmV0dXJu IHRvU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlKG5vZGUpOworICAgIHJldHVybiBpdC0+dmFs dWU7CiB9CiAKIHZvaWQgU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWM6OmVuc3VyZVJvb3RTdGF0ZU5v ZGVGb3JGcmFtZVZpZXcoRnJhbWVWaWV3KiBmcmFtZVZpZXcpCg==