100809 2012-10-30 21:32:07 -0700 ScrollingCoordinator::attachToStateTree() should take an enum indicating what type of node to create 2012-10-30 21:55:33 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin bdakin andersca bdakin eric jamesr simon.fraser thorton tonikitoo webkit.review.bot oldest_to_newest 754940 0 bdakin 2012-10-30 21:32:07 -0700 ScrollingCoordinator::attachToStateTree() should be generalized to be able to create different types of nodes. Then we can use this function to support fixed nodes very soon. 754947 1 171579 bdakin 2012-10-30 21:47:13 -0700 Created attachment 171579 Patch 754953 2 bdakin 2012-10-30 21:55:33 -0700 Thanks, Simon! http://trac.webkit.org/changeset/132981 171579 2012-10-30 21:47:13 -0700 2012-10-30 21:54:07 -0700 Patch attach-to-state-for-review.txt text/plain 7005 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjk4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMxIEBACisyMDEyLTEwLTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAwODA5CisgICAgICAgIFNjcm9sbGluZ0Nvb3JkaW5hdG9yOjph dHRhY2hUb1N0YXRlVHJlZSgpIHNob3VsZCB0YWtlIGFuIGVudW0gCisgICAgICAgIGluZGljYXRp bmcgd2hhdCB0eXBlIG9mIG5vZGUgdG8gY3JlYXRlCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3IGVudW0gU2Nyb2xsaW5nTm9kZVR5cGUgd2lsbCBz b29uIGhhdmUgb3RoZXIgdmFsdWVzLCBzdWNoIGFzIAorICAgICAgICBGaXhlZE5vZGUuCisgICAg ICAgICogcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaDoKKyAgICAgICAgKFdl YkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yOjphdHRhY2hUb1N0YXRlVHJlZSk6CisgICAgICAg ICogcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLmg6CisgICAgICAg IChTY3JvbGxpbmdDb29yZGluYXRvck1hYyk6CisKKyAgICAgICAgVGhpcyBwYXRjaCBnZW5lcmFs aXplcyB0aGlzIGZ1bmN0aW9uIHNvIHRoYXQgaXQgY2FuIGJlIHVzZWQgdG8gY3JlYXRlIAorICAg ICAgICBkaWZmZXJlbnQgdHlwZXMgb2Ygbm9kZXMgYW5kIHNvIHRoYXQgaXQgaXMgYWN0dWFsbHkg cmVhZHkgdG8gY3JlYXRlIAorICAgICAgICBjaGlsZCBub2Rlcy4gCisgICAgICAgICogcGFnZS9z Y3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLm1tOgorICAgICAgICAoV2ViQ29y ZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWM6OmF0dGFjaFRvU3RhdGVUcmVlKToKKworICAgICAg ICBUaGUgcm9vdFN0YXRlTm9kZSBpcyBhbHdheXMgYSBTY3JvbGxpbmdOb2RlLgorICAgICAgICAo V2ViQ29yZTo6U2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWM6OmVuc3VyZVJvb3RTdGF0ZU5vZGVGb3JG cmFtZVZpZXcpOgorCisgICAgICAgIEZvciB0aGUgdGltZSBiZWluZywgYWx3YXlzIGNyZWF0ZSBh IFNjcm9sbGluZ05vZGUuCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OmF0dGFjaFRvU2Nyb2xs aW5nQ29vcmRpbmF0b3IpOgorCiAyMDEyLTEwLTMwICBHcmVnZyBUYXZhcmVzICA8Z21hbkBnb29n bGUuY29tPgogCiAgICAgICAgIFNldCB0aGUgaW5pdGlhbCBzY2lzc29yIGJveCBmb3IgV2ViR0wK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9y LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n Q29vcmRpbmF0b3IuaAkocmV2aXNpb24gMTMyOTQ3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiAr NDcsMTEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogdHlwZWRlZiB1bnNpZ25lZCBNYWluVGhyZWFk U2Nyb2xsaW5nUmVhc29uczsKIHR5cGVkZWYgdWludDY0X3QgU2Nyb2xsaW5nTm9kZUlEOwogCitl bnVtIFNjcm9sbGluZ05vZGVUeXBlIHsKKyAgICBTY3JvbGxpbmdOb2RlCisgICAgLy8gRklYTUU6 IFRoaXMgd2lsbCBzb29uIGNvbnRhaW4gb3RoZXIgdHlwZXMgc3VjaCBhcyBGaXhlZE5vZGUuCit9 OworCiBjbGFzcyBGcmFtZTsKIGNsYXNzIEZyYW1lVmlldzsKIGNsYXNzIEdyYXBoaWNzTGF5ZXI7 CkBAIC0xMDksNyArMTE0LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCByZXF1ZXN0U2Ny b2xsUG9zaXRpb25VcGRhdGUoRnJhbWVWaWV3KiwgY29uc3QgSW50UG9pbnQmKSB7IHJldHVybiBm YWxzZTsgfQogICAgIHZpcnR1YWwgYm9vbCBoYW5kbGVXaGVlbEV2ZW50KEZyYW1lVmlldyosIGNv bnN0IFBsYXRmb3JtV2hlZWxFdmVudCYpIHsgcmV0dXJuIHRydWU7IH0KICAgICB2aXJ0dWFsIHZv aWQgdXBkYXRlTWFpbkZyYW1lU2Nyb2xsUG9zaXRpb25BbmRTY3JvbGxMYXllclBvc2l0aW9uKCkg eyB9Ci0gICAgdmlydHVhbCBTY3JvbGxpbmdOb2RlSUQgYXR0YWNoVG9TdGF0ZVRyZWUoU2Nyb2xs aW5nTm9kZUlEIG5ld05vZGVJRCwgU2Nyb2xsaW5nTm9kZUlEIC8qcGFyZW50SUQqLykgeyByZXR1 cm4gbmV3Tm9kZUlEOyB9CisgICAgdmlydHVhbCBTY3JvbGxpbmdOb2RlSUQgYXR0YWNoVG9TdGF0 ZVRyZWUoU2Nyb2xsaW5nTm9kZVR5cGUsIFNjcm9sbGluZ05vZGVJRCBuZXdOb2RlSUQsIFNjcm9s bGluZ05vZGVJRCAvKnBhcmVudElEKi8pIHsgcmV0dXJuIG5ld05vZGVJRDsgfQogICAgIHZpcnR1 YWwgdm9pZCBkZXRhY2hGcm9tU3RhdGVUcmVlKFNjcm9sbGluZ05vZGVJRCkgeyB9CiAgICAgdmly dHVhbCB2b2lkIGNsZWFyU3RhdGVUcmVlKCkgeyB9CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1hYy5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRvck1h Yy5oCShyZXZpc2lvbiAxMzI5NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9t YWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWMuaAkod29ya2luZyBjb3B5KQpAQCAtNjYsNyArNjYs NyBAQCBwdWJsaWM6CiAKICAgICAvLyBUaGVzZSBmdW5jdGlvbnMgYXJlIHVzZWQgdG8gaW5kaWNh dGUgdGhhdCBhIGxheWVyIHNob3VsZCBiZSAob3Igc2hvdWxkIG5vdCBsb25nZXIgYmUpIHJlcHJl c2VudGVkIGJ5IGEgbm9kZQogICAgIC8vIGluIHRoZSBzY3JvbGxpbmcgdHJlZS4KLSAgICB2aXJ0 dWFsIFNjcm9sbGluZ05vZGVJRCBhdHRhY2hUb1N0YXRlVHJlZShTY3JvbGxpbmdOb2RlSUQgbmV3 Tm9kZUlELCBTY3JvbGxpbmdOb2RlSUQgcGFyZW50SUQpOworICAgIHZpcnR1YWwgU2Nyb2xsaW5n Tm9kZUlEIGF0dGFjaFRvU3RhdGVUcmVlKFNjcm9sbGluZ05vZGVUeXBlLCBTY3JvbGxpbmdOb2Rl SUQgbmV3Tm9kZUlELCBTY3JvbGxpbmdOb2RlSUQgcGFyZW50SUQpOwogICAgIHZpcnR1YWwgdm9p ZCBkZXRhY2hGcm9tU3RhdGVUcmVlKFNjcm9sbGluZ05vZGVJRCk7CiAKICAgICAvLyBUaGlzIGZ1 bmN0aW9uIHdpcGVzIG91dCB0aGUgY3VycmVudCB0cmVlLgpJbmRleDogU291cmNlL1dlYkNvcmUv cGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLm1tCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29yZGluYXRv ck1hYy5tbQkocmV2aXNpb24gMTMyOTQ3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0yMzQs MjUgKzIzNCwzNyBAQCB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjp1cGRhdGVNYWluCiAg ICAgICAgIHNjcm9sbExheWVyLT5zZXRQb3NpdGlvbigtZnJhbWVWaWV3LT5zY3JvbGxQb3NpdGlv bigpKTsKIH0KIAotU2Nyb2xsaW5nTm9kZUlEIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjphdHRh Y2hUb1N0YXRlVHJlZShTY3JvbGxpbmdOb2RlSUQgbmV3Tm9kZUlELCBTY3JvbGxpbmdOb2RlSUQg cGFyZW50SUQpCitTY3JvbGxpbmdOb2RlSUQgU2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWM6OmF0dGFj aFRvU3RhdGVUcmVlKFNjcm9sbGluZ05vZGVUeXBlIG5vZGVUeXBlLCBTY3JvbGxpbmdOb2RlSUQg bmV3Tm9kZUlELCBTY3JvbGxpbmdOb2RlSUQgcGFyZW50SUQpCiB7CiAgICAgQVNTRVJUKG5ld05v ZGVJRCk7CiAKLSAgICBTY3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGUqIGV4aXN0aW5nTm9kZSA9 IHN0YXRlTm9kZUZvcklEKG5ld05vZGVJRCk7Ci0gICAgaWYgKGV4aXN0aW5nTm9kZSAmJiBleGlz dGluZ05vZGUgPT0gbV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RTdGF0ZU5vZGUoKSkKKyAgICBp ZiAoc3RhdGVOb2RlRm9ySUQobmV3Tm9kZUlEKSkKICAgICAgICAgcmV0dXJuIG5ld05vZGVJRDsK IAotICAgIC8vIElmIHRoZXJlIGlzIG5vIHBhcmVudCwgdGhpcyBpcyB0aGUgcm9vdCBub2RlLiBS aWdodCBub3csIHdlIG9ubHkgc3VwcG9ydCB0aGUgcm9vdCBub2RlLgotICAgIC8vIEZJWE1FOiBJ biB0aGUgZnV0dXJlLCB3ZSBzaG91bGQgYXBwZW5kIGNoaWxkIG5vZGVzIGluIHRoZSBhcHByb3By aWF0ZSBzcG90IGluIHRoZSBzdGF0ZQotICAgIC8vIHRyZWUuCisgICAgU2Nyb2xsaW5nU3RhdGVO b2RlKiBuZXdOb2RlOwogICAgIGlmICghcGFyZW50SUQpIHsKICAgICAgICAgLy8gSWYgd2UncmUg cmVzZXR0aW5nIHRoZSByb290IG5vZGUsIHdlIHNob3VsZCBjbGVhciB0aGUgSGFzaE1hcCBhbmQg ZGVzdHJveSB0aGUgY3VycmVudCBjaGlsZHJlbi4KICAgICAgICAgY2xlYXJTdGF0ZVRyZWUoKTsK IAogICAgICAgICBtX3Njcm9sbGluZ1N0YXRlVHJlZS0+cm9vdFN0YXRlTm9kZSgpLT5zZXRTY3Jv bGxpbmdOb2RlSUQobmV3Tm9kZUlEKTsKLSAgICAgICAgbV9zdGF0ZU5vZGVNYXAuc2V0KG5ld05v ZGVJRCwgbV9zY3JvbGxpbmdTdGF0ZVRyZWUtPnJvb3RTdGF0ZU5vZGUoKSk7CisgICAgICAgIG5l d05vZGUgPSBtX3Njcm9sbGluZ1N0YXRlVHJlZS0+cm9vdFN0YXRlTm9kZSgpOworICAgIH0gZWxz ZSB7CisgICAgICAgICAgICBTY3JvbGxpbmdTdGF0ZU5vZGUqIHBhcmVudCA9IHN0YXRlTm9kZUZv cklEKHBhcmVudElEKTsKKyAgICAgICAgICAgIHN3aXRjaCAobm9kZVR5cGUpIHsKKyAgICAgICAg ICAgIGNhc2UgU2Nyb2xsaW5nTm9kZTogeworICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBXZSBj dXJyZW50bHkgZG8gbm90IHN1cHBvcnQgY2hpbGQgbm9kZXMuIFRoaXMgYXNzZXJ0aW9uIHNob3Vs ZCBiZSByZW1vdmVkIHdoZW4gd2UgZG8uCisgICAgICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFD SEVEKCk7CisgICAgICAgICAgICAgICAgUGFzc093blB0cjxTY3JvbGxpbmdTdGF0ZVNjcm9sbGlu Z05vZGU+IHNjcm9sbGluZ05vZGUgPSBTY3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGU6OmNyZWF0 ZShtX3Njcm9sbGluZ1N0YXRlVHJlZS5nZXQoKSwgbmV3Tm9kZUlEKTsKKyAgICAgICAgICAgICAg ICBuZXdOb2RlID0gc2Nyb2xsaW5nTm9kZS5nZXQoKTsKKyAgICAgICAgICAgICAgICBwYXJlbnQt PmFwcGVuZENoaWxkKHNjcm9sbGluZ05vZGUpOworICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICAgICAgfQorICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICBBU1NFUlRf Tk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIH0KICAgICB9CiAKKyAgICBtX3N0YXRlTm9kZU1h cC5zZXQobmV3Tm9kZUlELCBuZXdOb2RlKTsKICAgICByZXR1cm4gbmV3Tm9kZUlEOwogfQogCkBA IC0yOTcsNyArMzA5LDcgQEAgU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlKiBTY3JvbGxpbmdD bwogCiB2b2lkIFNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjplbnN1cmVSb290U3RhdGVOb2RlRm9y RnJhbWVWaWV3KEZyYW1lVmlldyogZnJhbWVWaWV3KQogewotICAgIGF0dGFjaFRvU3RhdGVUcmVl KGZyYW1lVmlldy0+c2Nyb2xsTGF5ZXJJRCgpLCAwKTsKKyAgICBhdHRhY2hUb1N0YXRlVHJlZShT Y3JvbGxpbmdOb2RlLCBmcmFtZVZpZXctPnNjcm9sbExheWVySUQoKSwgMCk7CiB9CiAKIHZvaWQg U2Nyb2xsaW5nQ29vcmRpbmF0b3JNYWM6OnNldFNjcm9sbExheWVyRm9yTm9kZShHcmFwaGljc0xh eWVyKiBzY3JvbGxMYXllciwgU2Nyb2xsaW5nU3RhdGVOb2RlKiBub2RlKQpJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAJKHJldmlzaW9u IDEzMjk0NykKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEyLDggKzEwMTIsOSBAQCB2b2lkIFJlbmRlckxheWVy QmFja2luZzo6YXR0YWNoVG9TY3JvbGxpCiAgICAgaWYgKCFzY3JvbGxpbmdDb29yZGluYXRvcikK ICAgICAgICAgcmV0dXJuOwogCisgICAgU2Nyb2xsaW5nTm9kZVR5cGUgbm9kZVR5cGUgPSBTY3Jv bGxpbmdOb2RlOwogICAgIFNjcm9sbGluZ05vZGVJRCBwYXJlbnRJRCA9IHBhcmVudCA/IHBhcmVu dC0+c2Nyb2xsTGF5ZXJJRCgpIDogMDsKLSAgICBtX3Njcm9sbExheWVySUQgPSBzY3JvbGxpbmdD b29yZGluYXRvci0+YXR0YWNoVG9TdGF0ZVRyZWUoc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnVuaXF1 ZVNjcm9sbExheWVySUQoKSwgcGFyZW50SUQpOworICAgIG1fc2Nyb2xsTGF5ZXJJRCA9IHNjcm9s bGluZ0Nvb3JkaW5hdG9yLT5hdHRhY2hUb1N0YXRlVHJlZShub2RlVHlwZSwgc2Nyb2xsaW5nQ29v cmRpbmF0b3ItPnVuaXF1ZVNjcm9sbExheWVySUQoKSwgcGFyZW50SUQpOwogfQogCiB2b2lkIFJl bmRlckxheWVyQmFja2luZzo6ZGV0YWNoRnJvbVNjcm9sbGluZ0Nvb3JkaW5hdG9yKCkK