100787 2012-10-30 14:34:02 -0700 test-webkitpy: fix running modules and classes on the command line 2012-10-31 12:01:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100780 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 754660 0 dpranke 2012-10-30 14:34:02 -0700 test-webkitpy: fix running modules and classes on the command line 754661 1 171520 dpranke 2012-10-30 14:34:44 -0700 Created attachment 171520 Patch 754663 2 eric 2012-10-30 14:37:59 -0700 What is a serial integration test? Integration tests were a jail we created to avoid running slow tests all the time. I'm surprised we're adding more support for such. 754679 3 dpranke 2012-10-30 14:52:38 -0700 (In reply to comment #2) > What is a serial integration test? Integration tests were a jail we created to avoid running slow tests all the time. I'm surprised we're adding more support for such. There were/are two kinds of integration tests. The first kind was tests that were slow, and those have almost all been reworked and are all fast (but there's a few left, I think mostly in the committers.py code). The second kind are true integration tests that test that real commands actually do work (like starting and stopping HTTP servers, etc.) and rely on things in the real filesystem or checkout. These are off by default but are useful. Of these tests, there are some that can be run in parallel and some that can't (just like the regular unit tests). At the moment, there are no tests marked serial_integration, but that's probably bad, as some of the http tests should probably be marked that way. 755493 4 171520 eric 2012-10-31 11:33:09 -0700 Comment on attachment 171520 Patch rs=me. 755522 5 dpranke 2012-10-31 12:01:50 -0700 Committed r133055: <http://trac.webkit.org/changeset/133055> 171520 2012-10-30 14:34:44 -0700 2012-10-31 11:33:09 -0700 Patch bug-100787-20121030143308.patch text/plain 5578 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDk4YzA3ZjJiZWVjMmY4YTlhZGIxMWViNTQ0MjVhY2M1 YzdkMmNiOS4uYjY1YWEzZTQxYjUwNzJhNjMxN2EyYzdlZmM5Y2YyMTM2NmI0NzIzYyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMw IEBACiAyMDEyLTEwLTMwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHRlc3Qtd2Via2l0cHk6IGZpeCBydW5uaW5nIG1vZHVsZXMgYW5kIGNsYXNzZXMgb24g dGhlIGNvbW1hbmQgbGluZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAwNzg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSGFuZGxpbmcgbW9kdWxlcyBhbmQgY2xhc3NlcyBhcmUgYXJndW1lbnRzIG9uIHRo ZSBjb21tYW5kIGxpbmUKKyAgICAgICAgd2FzIGJyb2tlbiBkdWUgdG8gdGhlIHdheSB3ZSB3ZXJl IHBhcnNpbmcgdGVzdCBuYW1lcyBsb29raW5nIGZvcgorICAgICAgICBwYXJhbGxlbCBhbmQgc2Vy aWFsIHRlc3RzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHk6Cisg ICAgICAgIChUZXN0ZXIuX3Rlc3RfbmFtZXMpOgorICAgICAgICAoX0xvYWRlcik6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW5fdW5pdHRlc3QucHk6CisgICAgICAgIChUZXN0 U3R1YnMuaW50ZWdyYXRpb25fdGVzdF9lbXB0eSk6CisgICAgICAgIChUZXN0U3R1YnMpOgorICAg ICAgICAoVGVzdFN0dWJzLnNlcmlhbF90ZXN0X2VtcHR5KToKKyAgICAgICAgKFRlc3RTdHVicy5z ZXJpYWxfaW50ZWdyYXRpb25fdGVzdF9lbXB0eSk6CisgICAgICAgIChUZXN0ZXJUZXN0Ll9maW5k X3Rlc3RfbmFtZXMpOgorICAgICAgICAoVGVzdGVyVGVzdCk6CisgICAgICAgIChUZXN0ZXJUZXN0 LnRlc3RfaW5kaXZpZHVhbF9uYW1lc19hcmVfbm90X3J1bl90d2ljZSk6CisgICAgICAgIChUZXN0 ZXJUZXN0LnRlc3RfaW50ZWdyYXRpb25fdGVzdHNfYXJlX25vdF9mb3VuZF9ieV9kZWZhdWx0KToK KyAgICAgICAgKFRlc3RlclRlc3QudGVzdF9pbnRlZ3JhdGlvbl90ZXN0c19hcmVfZm91bmQpOgor CisyMDEyLTEwLTMwICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAg ICAgIHRlc3Qtd2Via2l0cHk6IGZpeCBpbXBvcnQgb2YgY292ZXJhZ2Ugc28gdGhhdCBpdCB3b3Jr cyBpbiBhIGNsZWFuIGluc3RhbGwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwMDc4MAogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rlc3QvbWFpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWluLnB5CmluZGV4 IDg1MjQxMzI5OTYxNmE0MjkxZmY0YWY3ZmQ1Yjk3ODdlNWY4NzNiZGIuLmU2MzlhNDU3ODQzZDE0 MTYyYThmYjY5YjE2ZGJjMTU3NWMzMDUwMDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdGVzdC9tYWluLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9tYWlu LnB5CkBAIC0xNzgsMTcgKzE3OCwxOSBAQCBjbGFzcyBUZXN0ZXIob2JqZWN0KToKICAgICAgICAg cmV0dXJuIFRydWUKIAogICAgIGRlZiBfdGVzdF9uYW1lcyhzZWxmLCBsb2FkZXIsIG5hbWVzKToK KyAgICAgICAgcGFyYWxsZWxfdGVzdF9tZXRob2RfcHJlZml4ZXMgPSBbJ3Rlc3RfJ10KKyAgICAg ICAgc2VyaWFsX3Rlc3RfbWV0aG9kX3ByZWZpeGVzID0gWydzZXJpYWxfdGVzdF8nXQogICAgICAg ICBpZiBzZWxmLl9vcHRpb25zLmludGVncmF0aW9uX3Rlc3RzOgotICAgICAgICAgICAgbG9hZGVy LnRlc3RfbWV0aG9kX3ByZWZpeGVzLmFwcGVuZCgnaW50ZWdyYXRpb25fdGVzdF8nKQorICAgICAg ICAgICAgcGFyYWxsZWxfdGVzdF9tZXRob2RfcHJlZml4ZXMuYXBwZW5kKCdpbnRlZ3JhdGlvbl90 ZXN0XycpCisgICAgICAgICAgICBzZXJpYWxfdGVzdF9tZXRob2RfcHJlZml4ZXMuYXBwZW5kKCdz ZXJpYWxfaW50ZWdyYXRpb25fdGVzdF8nKQogCiAgICAgICAgIHBhcmFsbGVsX3Rlc3RzID0gW10K LSAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5jaGlsZF9wcm9jZXNzZXMgPiAxOgotICAgICAgICAg ICAgZm9yIG5hbWUgaW4gbmFtZXM6Ci0gICAgICAgICAgICAgICAgcGFyYWxsZWxfdGVzdHMuZXh0 ZW5kKHNlbGYuX2FsbF90ZXN0X25hbWVzKGxvYWRlci5sb2FkVGVzdHNGcm9tTmFtZShuYW1lLCBO b25lKSkpCi0gICAgICAgICAgICBsb2FkZXIudGVzdF9tZXRob2RfcHJlZml4ZXMgPSBbXQorICAg ICAgICBsb2FkZXIudGVzdF9tZXRob2RfcHJlZml4ZXMgPSBwYXJhbGxlbF90ZXN0X21ldGhvZF9w cmVmaXhlcworICAgICAgICBmb3IgbmFtZSBpbiBuYW1lczoKKyAgICAgICAgICAgIHBhcmFsbGVs X3Rlc3RzLmV4dGVuZChzZWxmLl9hbGxfdGVzdF9uYW1lcyhsb2FkZXIubG9hZFRlc3RzRnJvbU5h bWUobmFtZSwgTm9uZSkpKQogCiAgICAgICAgIHNlcmlhbF90ZXN0cyA9IFtdCi0gICAgICAgIGxv YWRlci50ZXN0X21ldGhvZF9wcmVmaXhlcyA9IFsnc2VyaWFsX3Rlc3RfJywgJ3NlcmlhbF9pbnRl Z3JhdGlvbl90ZXN0XyddCisgICAgICAgIGxvYWRlci50ZXN0X21ldGhvZF9wcmVmaXhlcyA9IHNl cmlhbF90ZXN0X21ldGhvZF9wcmVmaXhlcwogICAgICAgICBmb3IgbmFtZSBpbiBuYW1lczoKICAg ICAgICAgICAgIHNlcmlhbF90ZXN0cy5leHRlbmQoc2VsZi5fYWxsX3Rlc3RfbmFtZXMobG9hZGVy LmxvYWRUZXN0c0Zyb21OYW1lKG5hbWUsIE5vbmUpKSkKIApAQCAtMjE2LDcgKzIxOCw3IEBAIGNs YXNzIFRlc3RlcihvYmplY3QpOgogCiAKIGNsYXNzIF9Mb2FkZXIodW5pdHRlc3QuVGVzdExvYWRl cik6Ci0gICAgdGVzdF9tZXRob2RfcHJlZml4ZXMgPSBbJ3Rlc3RfJ10KKyAgICB0ZXN0X21ldGhv ZF9wcmVmaXhlcyA9IFtdCiAKICAgICBkZWYgZ2V0VGVzdENhc2VOYW1lcyhzZWxmLCB0ZXN0Q2Fz ZUNsYXNzKToKICAgICAgICAgZGVmIGlzVGVzdE1ldGhvZChhdHRybmFtZSwgdGVzdENhc2VDbGFz cz10ZXN0Q2FzZUNsYXNzKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVz dC9tYWluX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW5fdW5p dHRlc3QucHkKaW5kZXggNzQ2NzBiNjcxZWZhNWZjNWE1ZTYxMWQ0ZTE1NjMxZTVlMmIxODI2Ny4u M2IzNjk0NDgwODFmMjhkZWJjZGI5MjQwNjFmNjVjODM3NGE0YjEyNCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW5fdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS90ZXN0L21haW5fdW5pdHRlc3QucHkKQEAgLTM4LDYgKzM4LDE1IEBAIGNs YXNzIFRlc3RTdHVicyh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfZW1wdHkoc2Vs Zik6CiAgICAgICAgIHBhc3MKIAorICAgIGRlZiBpbnRlZ3JhdGlvbl90ZXN0X2VtcHR5KHNlbGYp OgorICAgICAgICBwYXNzCisKKyAgICBkZWYgc2VyaWFsX3Rlc3RfZW1wdHkoc2VsZik6CisgICAg ICAgIHBhc3MKKworICAgIGRlZiBzZXJpYWxfaW50ZWdyYXRpb25fdGVzdF9lbXB0eShzZWxmKToK KyAgICAgICAgcGFzcworCiAKIGNsYXNzIFRlc3RlclRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgog CkBAIC02NCwxMyArNzMsMzcgQEAgY2xhc3MgVGVzdGVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6 CiAgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZSgnTm8gdGVzdHMgdG8gcnVuJyBpbiBlcnJvcnMuZ2V0 dmFsdWUoKSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdObyB0ZXN0cyB0byBydW4nIGluIGxv Z3MpCiAKLSAgICBkZWYgdGVzdF9pbmRpdmlkdWFsX25hbWVzX2FyZV9ub3RfcnVuX3R3aWNlKHNl bGYpOgorICAgIGRlZiBfZmluZF90ZXN0X25hbWVzKHNlbGYsIGFyZ3MpOgogICAgICAgICB0ZXN0 ZXIgPSBUZXN0ZXIoKQotICAgICAgICB0ZXN0ZXIuX29wdGlvbnMsIGFyZ3MgPSB0ZXN0ZXIuX3Bh cnNlX2FyZ3MoWyJ3ZWJraXRweS50ZXN0Lm1haW5fdW5pdHRlc3QuVGVzdGVyVGVzdC50ZXN0X25v X3Rlc3RzX2ZvdW5kIl0pCi0gICAgICAgIHBhcmFsbGVsX3Rlc3RzLCBzZXJpYWxfdGVzdHMgPSB0 ZXN0ZXIuX3Rlc3RfbmFtZXMoX0xvYWRlcigpLCBhcmdzKQorICAgICAgICB0ZXN0ZXIuX29wdGlv bnMsIGFyZ3MgPSB0ZXN0ZXIuX3BhcnNlX2FyZ3MoYXJncykKKyAgICAgICAgcmV0dXJuIHRlc3Rl ci5fdGVzdF9uYW1lcyhfTG9hZGVyKCksIGFyZ3MpCisKKyAgICBkZWYgdGVzdF9pbmRpdmlkdWFs X25hbWVzX2FyZV9ub3RfcnVuX3R3aWNlKHNlbGYpOgorICAgICAgICBhcmdzID0gW1NUVUJTX0NM QVNTICsgJy50ZXN0X2VtcHR5J10KKyAgICAgICAgcGFyYWxsZWxfdGVzdHMsIHNlcmlhbF90ZXN0 cyA9IHNlbGYuX2ZpbmRfdGVzdF9uYW1lcyhhcmdzKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFs cyhwYXJhbGxlbF90ZXN0cywgYXJncykKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoc2VyaWFs X3Rlc3RzLCBbXSkKIAorICAgIGRlZiB0ZXN0X2ludGVncmF0aW9uX3Rlc3RzX2FyZV9ub3RfZm91 bmRfYnlfZGVmYXVsdChzZWxmKToKKyAgICAgICAgcGFyYWxsZWxfdGVzdHMsIHNlcmlhbF90ZXN0 cyA9IHNlbGYuX2ZpbmRfdGVzdF9uYW1lcyhbU1RVQlNfQ0xBU1NdKQorICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhwYXJhbGxlbF90ZXN0cywgWworICAgICAgICAgICAgU1RVQlNfQ0xBU1MgKyAn LnRlc3RfZW1wdHknLAorICAgICAgICAgICAgXSkKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMo c2VyaWFsX3Rlc3RzLCBbCisgICAgICAgICAgICBTVFVCU19DTEFTUyArICcuc2VyaWFsX3Rlc3Rf ZW1wdHknLAorICAgICAgICAgICAgXSkKKworICAgIGRlZiB0ZXN0X2ludGVncmF0aW9uX3Rlc3Rz X2FyZV9mb3VuZChzZWxmKToKKyAgICAgICAgcGFyYWxsZWxfdGVzdHMsIHNlcmlhbF90ZXN0cyA9 IHNlbGYuX2ZpbmRfdGVzdF9uYW1lcyhbJy0taW50ZWdyYXRpb24tdGVzdHMnLCBTVFVCU19DTEFT U10pCisgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKHBhcmFsbGVsX3Rlc3RzLCBbCisgICAgICAg ICAgICBTVFVCU19DTEFTUyArICcuaW50ZWdyYXRpb25fdGVzdF9lbXB0eScsCisgICAgICAgICAg ICBTVFVCU19DTEFTUyArICcudGVzdF9lbXB0eScsCisgICAgICAgICAgICBdKQorICAgICAgICBz ZWxmLmFzc2VydEVxdWFscyhzZXJpYWxfdGVzdHMsIFsKKyAgICAgICAgICAgIFNUVUJTX0NMQVNT ICsgJy5zZXJpYWxfaW50ZWdyYXRpb25fdGVzdF9lbXB0eScsCisgICAgICAgICAgICBTVFVCU19D TEFTUyArICcuc2VyaWFsX3Rlc3RfZW1wdHknLAorICAgICAgICAgICAgXSkKKwogICAgIGRlZiBp bnRlZ3JhdGlvbl90ZXN0X2NvdmVyYWdlX3dvcmtzKHNlbGYpOgogICAgICAgICBmaWxlc3lzdGVt ID0gRmlsZVN5c3RlbSgpCiAgICAgICAgIGV4ZWN1dGl2ZSA9IEV4ZWN1dGl2ZSgpCg==