<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>100778</bug_id>
          
          <creation_ts>2012-10-30 12:10:31 -0700</creation_ts>
          <short_desc>[WK2][Qt] Add drag&amp;drop support to Flickable webView</short_desc>
          <delta_ts>2012-11-28 18:25:17 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sergio Villar Senin">svillar</reporter>
          <assigned_to name="Sergio Villar Senin">svillar</assigned_to>
          <cc>abecsi</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>hausmann</cc>
    
    <cc>jturcotte</cc>
    
    <cc>kenneth</cc>
    
    <cc>menard</cc>
    
    <cc>svillar</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>754559</commentid>
    <comment_count>0</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2012-10-30 12:10:31 -0700</bug_when>
    <thetext>Since bug 100296, the flickable webView has hover and mouse events enabled again. So I think this is a good moment to start thinking about how drag&amp;drop could be handled for that view.

The WebCore&amp;WebKit2 support seems to be in place (MiniBrowser --desktop works fine) so I guess this is a matter of defining which events/gestures would trigger a dragStart. Any suggestion?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766245</commentid>
    <comment_count>1</comment_count>
      <attachid>174039</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2012-11-13 17:51:13 -0800</bug_when>
    <thetext>Created attachment 174039
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>766252</commentid>
    <comment_count>2</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2012-11-13 17:56:27 -0800</bug_when>
    <thetext>The result of this change can be tested with MiniBrowser on http;//html5demos.com/drag for example. The &quot;--desktop&quot; flag must be used because otherwise the events are processed by the flickable (see bug 100964 for more info).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>777354</commentid>
    <comment_count>3</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2012-11-27 16:34:16 -0800</bug_when>
    <thetext>Any thoughts about this one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>777656</commentid>
    <comment_count>4</comment_count>
      <attachid>174039</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2012-11-28 02:08:01 -0800</bug_when>
    <thetext>Comment on attachment 174039
Patch

Looks good.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>778587</commentid>
    <comment_count>5</comment_count>
      <attachid>174039</attachid>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2012-11-28 18:25:14 -0800</bug_when>
    <thetext>Comment on attachment 174039
Patch

Clearing flags on attachment: 174039

Committed r136083: &lt;http://trac.webkit.org/changeset/136083&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>778588</commentid>
    <comment_count>6</comment_count>
    <who name="Sergio Villar Senin">svillar</who>
    <bug_when>2012-11-28 18:25:17 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>174039</attachid>
            <date>2012-11-13 17:51:13 -0800</date>
            <delta_ts>2012-11-28 18:25:14 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-100778-20121113174913.patch</filename>
            <type>text/plain</type>
            <size>1463</size>
            <attacher name="Sergio Villar Senin">svillar</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NTE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjVhMGUzZjMwN2JlOTE3
ZjdkYjAxYTExMDg5Mjg3YmNlZDBjMTAyZi4uMTg5ZWE2OTgzMzQxMjNlNzViZjU4NTdhODE4MmI5
M2FmMTI3ZmM2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTEzICBTZXJn
aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXSzJdW1F0
XSBBZGQgZHJhZyZkcm9wIHN1cHBvcnQgdG8gRmxpY2thYmxlIHdlYlZpZXcKKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc3OAorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSB0aGUgSXRlbUFjY2Vw
dHNEcm9wcyBmbGFnIGluIHRoZSBmbGlja2FibGUgV2ViVmlldy4gVGhpcworICAgICAgICB3aWxs
IGFsbG93IHRoZSBXZWJWaWV3IHRvIHJlY2VpdmUgZHJhZyZkcm9wIGV2ZW50cy4KKworICAgICAg
ICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHA6CisgICAgICAgIChRUXVpY2tX
ZWJWaWV3UHJpdmF0ZTo6aW5pdGlhbGl6ZSk6CisKIDIwMTItMTEtMTMgIFRpbW90aHkgSGF0Y2hl
ciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgSW5zcGVjdG9yRnJvbnRlbmRI
b3N0Lm1vdmVXaW5kb3dCeSB3b3JrIGluIFdlYktpdDIgZm9yIE1hYy4KZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXF1aWNrd2Vidmlldy5jcHAgYi9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FxdWlja3dlYnZpZXcuY3BwCmluZGV4IDIxZWQ1YmUx
MDMzZGIxZjkyOTg5Y2VkZWM4NGJjYmI0ZjM4MzdlYWMuLjVkZDE2Y2MzM2U2ODM3YzE2MGQxNmJk
MjdhM2UyMWI5NDU5ZjJhYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B
UEkvcXQvcXF1aWNrd2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ
SS9xdC9xcXVpY2t3ZWJ2aWV3LmNwcApAQCAtMzI1LDYgKzMyNSw3IEBAIHZvaWQgUVF1aWNrV2Vi
Vmlld1ByaXZhdGU6OmluaXRpYWxpemUoV0tDb250ZXh0UmVmIGNvbnRleHRSZWYsIFdLUGFnZUdy
b3VwUmVmIHBhCiAKICAgICBxX3B0ci0+c2V0QWNjZXB0ZWRNb3VzZUJ1dHRvbnMoUXQ6Ok1vdXNl
QnV0dG9uTWFzayk7CiAgICAgcV9wdHItPnNldEFjY2VwdEhvdmVyRXZlbnRzKHRydWUpOworICAg
IHFfcHRyLT5zZXRGbGFncyhRUXVpY2tJdGVtOjpJdGVtQWNjZXB0c0Ryb3BzKTsKIH0KIAogdm9p
ZCBRUXVpY2tXZWJWaWV3UHJpdmF0ZTo6bG9hZERpZFN0b3AoKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>