100777 2012-10-30 12:07:16 -0700 Provide return types for custom WebGLRenderingContext methods 2012-11-14 02:07:16 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 antonm antonm abarth dino kbr ojan podivilov webkit.review.bot oldest_to_newest 754557 0 antonm 2012-10-30 12:07:16 -0700 Provide return types for custom WebGLRenderingContext methods 754561 1 171493 antonm 2012-10-30 12:11:31 -0700 Created attachment 171493 Patch 754572 2 171493 webkit-ews 2012-10-30 12:17:57 -0700 Comment on attachment 171493 Patch Attachment 171493 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/14626678 754573 3 171493 webkit-ews 2012-10-30 12:20:30 -0700 Comment on attachment 171493 Patch Attachment 171493 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14557069 754577 4 171498 antonm 2012-10-30 12:22:51 -0700 Created attachment 171498 Patch 754582 5 kbr 2012-10-30 12:27:49 -0700 Did you run the WebGL conformance suite at https://www.khronos.org/registry/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html to ensure nothing was broken? Clearly the autogenerated code changes somewhat, as otherwise the Qt and Qt-WK2 bots wouldn't have been broken with the first version of the patch... 755080 6 dino 2012-10-31 02:40:55 -0700 (In reply to comment #5) > Did you run the WebGL conformance suite at https://www.khronos.org/registry/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html to ensure nothing was broken? Maybe we should have reviewbot add a warning for any WebGL code changes until we've incorporated the Khronos tests into WebKit? Something like what Ken says above. 755083 7 antonm 2012-10-31 02:42:50 -0700 (In reply to comment #5) > Did you run the WebGL conformance suite at https://www.khronos.org/registry/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html to ensure nothing was broken? > > Clearly the autogenerated code changes somewhat, as otherwise the Qt and Qt-WK2 bots wouldn't have been broken with the first version of the patch... No, Ken, thanks a lot for pointing out the suite, I'll run it. Regarding no code changes: I should have been more explicit---no changes in v8 bindings. Overall, if I run the suite under Chromium with this patch in, will it be enough? What is the best approach to test that patch against remaining platforms? 755092 8 171498 podivilov 2012-10-31 02:53:45 -0700 Comment on attachment 171498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171498&action=review > Source/WebCore/html/canvas/WebGLRenderingContext.idl:533 > // object getExtension(in DOMString name); Please remove the comment. > Source/WebCore/html/canvas/WebGLRenderingContext.idl:554 > // DOMString[] getSupportedExtensions() ditto 755094 9 dino 2012-10-31 02:54:48 -0700 (In reply to comment #7) > What is the best approach to test that patch against remaining platforms? There isn't any EWS, so you'd have to try on the platforms manually if you can. The latest Khronos test suite has a nice tool to run the tests and gather a report. I guess if you don't have access to the platforms, you'll just have to land confidently :) 755424 10 171498 abarth 2012-10-31 10:19:32 -0700 Comment on attachment 171498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171498&action=review > Source/WebCore/html/canvas/WebGLRenderingContext.idl:555 > + [StrictTypeChecking, Custom] DOMString[] getSupportedExtensions(); Do you really mean DOMString? I would have expected this to return sequence<DOMString> 755425 11 171498 abarth 2012-10-31 10:19:56 -0700 Comment on attachment 171498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171498&action=review >> Source/WebCore/html/canvas/WebGLRenderingContext.idl:555 >> + [StrictTypeChecking, Custom] DOMString[] getSupportedExtensions(); > > Do you really mean DOMString? I would have expected this to return sequence<DOMString> Let me try again: Do you really mean DOMString[]? I would have expected this to return sequence<DOMString> 755427 12 kbr 2012-10-31 10:20:47 -0700 (In reply to comment #7) > (In reply to comment #5) > > Did you run the WebGL conformance suite at https://www.khronos.org/registry/webgl/conformance-suites/1.0.1/webgl-conformance-tests.html to ensure nothing was broken? > > > > Clearly the autogenerated code changes somewhat, as otherwise the Qt and Qt-WK2 bots wouldn't have been broken with the first version of the patch... > > No, Ken, thanks a lot for pointing out the suite, I'll run it. > > Regarding no code changes: I should have been more explicit---no changes in v8 bindings. Overall, if I run the suite under Chromium with this patch in, will it be enough? Ideally you'd run it on Mac OS with Safari as well to test the JSC bindings. However, the EWS bots run some subset of the WebGL tests so you will probably be OK. > What is the best approach to test that patch against remaining platforms? I generally test WebGL patches on Mac OS with both Chromium and Safari, and rely on the EWS to catch build failures, etc. affecting other ports. 755429 13 kbr 2012-10-31 10:21:17 -0700 (In reply to comment #11) > (From update of attachment 171498 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171498&action=review > > >> Source/WebCore/html/canvas/WebGLRenderingContext.idl:555 > >> + [StrictTypeChecking, Custom] DOMString[] getSupportedExtensions(); > > > > Do you really mean DOMString? I would have expected this to return sequence<DOMString> > > Let me try again: > > Do you really mean DOMString[]? I would have expected this to return sequence<DOMString> Right, Adam's correct; see http://www.khronos.org/registry/webgl/specs/latest/ . 765824 14 173930 antonm 2012-11-13 11:06:25 -0800 Created attachment 173930 Patch 765826 15 antonm 2012-11-13 11:07:09 -0800 Sorry for late responses. Two test of the suite fail: conformance/textures/texture-mips.html (17 of 19 passed) failed: texture that is only using the smallest 2 mips should draw with green failed: texture that is only using smallest mips should draw with cyan but those tests fail w/o the patch. Regarding comments and sequence. I tried to keep the simplest IDL close to the latest spec, hence keeping comments if current decl differs from the spec and not using sequence<DOMString> which might be not supported by other platforms like object with which I started. I am uploading new patch with sequence<DOMString> to see if it passes EWS. (In reply to comment #13) > (In reply to comment #11) > > (From update of attachment 171498 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=171498&action=review > > > > >> Source/WebCore/html/canvas/WebGLRenderingContext.idl:555 > > >> + [StrictTypeChecking, Custom] DOMString[] getSupportedExtensions(); > > > > > > Do you really mean DOMString? I would have expected this to return sequence<DOMString> > > > > Let me try again: > > > > Do you really mean DOMString[]? I would have expected this to return sequence<DOMString> > > Right, Adam's correct; see http://www.khronos.org/registry/webgl/specs/latest/ . 766037 16 173930 kbr 2012-11-13 14:08:19 -0800 Comment on attachment 173930 Patch Nice, thanks. r=me. Please wait for this to pass the EWS before cq+'ing. 766629 17 antonm 2012-11-14 01:48:36 -0800 Everything looks green, cq'ing while the repo is quite. Many thanks to all for review and comments. (In reply to comment #16) > (From update of attachment 173930 [details]) > Nice, thanks. r=me. Please wait for this to pass the EWS before cq+'ing. 766652 18 173930 webkit.review.bot 2012-11-14 02:07:09 -0800 Comment on attachment 173930 Patch Clearing flags on attachment: 173930 Committed r134580: <http://trac.webkit.org/changeset/134580> 766654 19 webkit.review.bot 2012-11-14 02:07:16 -0800 All reviewed patches have been landed. Closing bug. 171493 2012-10-30 12:11:31 -0700 2012-10-30 12:22:46 -0700 Patch bug-100777-20121030230955.patch text/plain 2034 antonm U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE5N2E2M2EyZTIyNmI2 ODNhN2RlYmJjZWI5MzMzMzI3MWMzZmY1ZC4uNmJiYWYxZjZhMjU1MWI4OThjY2M1N2QxNDJmYWVk ZmMzOWU1ZGU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTMwICBBbnRv biBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJvdmlkZSByZXR1cm4g dHlwZXMgZm9yIGN1c3RvbSBXZWJHTFJlbmRlcmluZ0NvbnRleHQgbWV0aG9kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzc3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIGRv ZXNuJ3QgY2hhbmdlIGdlbmVyYXRlZCBjb2RlLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmlkbDoKKwogMjAxMi0xMC0zMCAgTm8nYW0gUm9zZW50aGFsICA8 bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gQW5pbWF0aW9ucyBqdW1w IHdoZW4gdGhlIHBhZ2UgaXMgc3VzcGVuZGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAppbmRleCAzMWZhNTRjM2Q4NGI3YTk5 YTRjMWU2Yzk0Y2I2MDJiZDMwYTFhMjAwLi4xMmNhZTAzMWRlMDQyZTc4ZGQ1YTgyNTk0ZjJhYTU3 MTE2NWQzMmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5pZGwKQEAgLTUzMSw3ICs1MzEsNyBAQAogICAgIFtTdHJpY3RUeXBl Q2hlY2tpbmddIHVuc2lnbmVkIGxvbmcgZ2V0RXJyb3IoKTsKIAogICAgIC8vIG9iamVjdCBnZXRF eHRlbnNpb24oaW4gRE9NU3RyaW5nIG5hbWUpOwotICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIEN1 c3RvbV0gdm9pZCBnZXRFeHRlbnNpb24oaW4gRE9NU3RyaW5nIG5hbWUpOworICAgIFtTdHJpY3RU eXBlQ2hlY2tpbmcsIEN1c3RvbV0gb2JqZWN0IGdldEV4dGVuc2lvbihpbiBET01TdHJpbmcgbmFt ZSk7CiAKICAgICAvLyBhbnkgZ2V0RnJhbWVidWZmZXJBdHRhY2htZW50UGFyYW1ldGVyKGluIHVu c2lnbmVkIGxvbmcgdGFyZ2V0LCBpbiB1bnNpZ25lZCBsb25nIGF0dGFjaG1lbnQsIGluIHVuc2ln bmVkIGxvbmcgcG5hbWUpIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIFtTdHJpY3RUeXBlQ2hl Y2tpbmcsIEN1c3RvbV0gdm9pZCBnZXRGcmFtZWJ1ZmZlckF0dGFjaG1lbnRQYXJhbWV0ZXIoKTsK QEAgLTU1Miw3ICs1NTIsNyBAQAogICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIFRyZWF0UmV0dXJu ZWROdWxsU3RyaW5nQXM9TnVsbF0gRE9NU3RyaW5nICAgIGdldFNoYWRlclNvdXJjZShpbiBXZWJH TFNoYWRlciBzaGFkZXIpIHJhaXNlcyhET01FeGNlcHRpb24pOwogCiAgICAgLy8gRE9NU3RyaW5n W10gZ2V0U3VwcG9ydGVkRXh0ZW5zaW9ucygpCi0gICAgW1N0cmljdFR5cGVDaGVja2luZywgQ3Vz dG9tXSB2b2lkIGdldFN1cHBvcnRlZEV4dGVuc2lvbnMoKTsKKyAgICBbU3RyaWN0VHlwZUNoZWNr aW5nLCBDdXN0b21dIERPTVN0cmluZ1tdIGdldFN1cHBvcnRlZEV4dGVuc2lvbnMoKTsKIAogICAg IC8vIGFueSBnZXRUZXhQYXJhbWV0ZXIoaW4gdW5zaWduZWQgbG9uZyB0YXJnZXQsIGluIHVuc2ln bmVkIGxvbmcgcG5hbWUpIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIFtTdHJpY3RUeXBlQ2hl Y2tpbmcsIEN1c3RvbV0gdm9pZCBnZXRUZXhQYXJhbWV0ZXIoKTsK 171498 2012-10-30 12:22:51 -0700 2012-11-13 11:06:19 -0800 Patch bug-100777-20121030232115.patch text/plain 2031 antonm U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyOTA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmE5N2E2M2EyZTIyNmI2 ODNhN2RlYmJjZWI5MzMzMzI3MWMzZmY1ZC4uNmJiYWYxZjZhMjU1MWI4OThjY2M1N2QxNDJmYWVk ZmMzOWU1ZGU4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTEwLTMwICBBbnRv biBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJvdmlkZSByZXR1cm4g dHlwZXMgZm9yIGN1c3RvbSBXZWJHTFJlbmRlcmluZ0NvbnRleHQgbWV0aG9kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzc3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIGRv ZXNuJ3QgY2hhbmdlIGdlbmVyYXRlZCBjb2RlLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmlkbDoKKwogMjAxMi0xMC0zMCAgTm8nYW0gUm9zZW50aGFsICA8 bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gQW5pbWF0aW9ucyBqdW1w IHdoZW4gdGhlIHBhZ2UgaXMgc3VzcGVuZGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRt bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAppbmRleCAzMWZhNTRjM2Q4NGI3YTk5 YTRjMWU2Yzk0Y2I2MDJiZDMwYTFhMjAwLi5hNWE2ZTU0MjUwOTlmMDRhMDhiNDA5MGZkZjMyMjg0 ZDYwODEwNzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5pZGwKQEAgLTUzMSw3ICs1MzEsNyBAQAogICAgIFtTdHJpY3RUeXBl Q2hlY2tpbmddIHVuc2lnbmVkIGxvbmcgZ2V0RXJyb3IoKTsKIAogICAgIC8vIG9iamVjdCBnZXRF eHRlbnNpb24oaW4gRE9NU3RyaW5nIG5hbWUpOwotICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIEN1 c3RvbV0gdm9pZCBnZXRFeHRlbnNpb24oaW4gRE9NU3RyaW5nIG5hbWUpOworICAgIFtTdHJpY3RU eXBlQ2hlY2tpbmcsIEN1c3RvbV0gYW55IGdldEV4dGVuc2lvbihpbiBET01TdHJpbmcgbmFtZSk7 CiAKICAgICAvLyBhbnkgZ2V0RnJhbWVidWZmZXJBdHRhY2htZW50UGFyYW1ldGVyKGluIHVuc2ln bmVkIGxvbmcgdGFyZ2V0LCBpbiB1bnNpZ25lZCBsb25nIGF0dGFjaG1lbnQsIGluIHVuc2lnbmVk IGxvbmcgcG5hbWUpIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIFtTdHJpY3RUeXBlQ2hlY2tp bmcsIEN1c3RvbV0gdm9pZCBnZXRGcmFtZWJ1ZmZlckF0dGFjaG1lbnRQYXJhbWV0ZXIoKTsKQEAg LTU1Miw3ICs1NTIsNyBAQAogICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIFRyZWF0UmV0dXJuZWRO dWxsU3RyaW5nQXM9TnVsbF0gRE9NU3RyaW5nICAgIGdldFNoYWRlclNvdXJjZShpbiBXZWJHTFNo YWRlciBzaGFkZXIpIHJhaXNlcyhET01FeGNlcHRpb24pOwogCiAgICAgLy8gRE9NU3RyaW5nW10g Z2V0U3VwcG9ydGVkRXh0ZW5zaW9ucygpCi0gICAgW1N0cmljdFR5cGVDaGVja2luZywgQ3VzdG9t XSB2b2lkIGdldFN1cHBvcnRlZEV4dGVuc2lvbnMoKTsKKyAgICBbU3RyaWN0VHlwZUNoZWNraW5n LCBDdXN0b21dIERPTVN0cmluZ1tdIGdldFN1cHBvcnRlZEV4dGVuc2lvbnMoKTsKIAogICAgIC8v IGFueSBnZXRUZXhQYXJhbWV0ZXIoaW4gdW5zaWduZWQgbG9uZyB0YXJnZXQsIGluIHVuc2lnbmVk IGxvbmcgcG5hbWUpIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIFtTdHJpY3RUeXBlQ2hlY2tp bmcsIEN1c3RvbV0gdm9pZCBnZXRUZXhQYXJhbWV0ZXIoKTsK 173930 2012-11-13 11:06:25 -0800 2012-11-14 02:07:09 -0800 Patch bug-100777-20121113230425.patch text/plain 2032 antonm U3VidmVyc2lvbiBSZXZpc2lvbjogMTM0NDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ5OTVmYWUxYWUyMGM5 MzFiYTBhMThhMjExNjQ1MDE2NzExZjFkMS4uODJmMzUzZGIxM2NlYjNhYjczMjZlMDkyNmU3NjBk ZWZjZDkyYTAyYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTExLTEzICBBbnRv biBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUHJvdmlkZSByZXR1cm4g dHlwZXMgZm9yIGN1c3RvbSBXZWJHTFJlbmRlcmluZ0NvbnRleHQgbWV0aG9kcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzc3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIGRv ZXNuJ3QgY2hhbmdlIGdlbmVyYXRlZCBjb2RlLgorCisgICAgICAgICogaHRtbC9jYW52YXMvV2Vi R0xSZW5kZXJpbmdDb250ZXh0LmlkbDoKKwogMjAxMi0xMS0xMyAgRXJpayBBcnZpZHNzb24gIDxh cnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBET01FeGNlcHRpb24gbmFtZTogSGll cmFyY2h5UmVxdWVzdEVycm9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMv V2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAppbmRleCAzMWZhNTRjM2Q4NGI3YTk5YTRjMWU2Yzk0 Y2I2MDJiZDMwYTFhMjAwLi5mYzgwMTEwYzc2MWI4OTc4NTc3NmJlNzY5MzA2YTMzZmYzYjFmZWI3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0Nv bnRleHQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5pZGwKQEAgLTUzMSw3ICs1MzEsNyBAQAogICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmdd IHVuc2lnbmVkIGxvbmcgZ2V0RXJyb3IoKTsKIAogICAgIC8vIG9iamVjdCBnZXRFeHRlbnNpb24o aW4gRE9NU3RyaW5nIG5hbWUpOwotICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIEN1c3RvbV0gdm9p ZCBnZXRFeHRlbnNpb24oaW4gRE9NU3RyaW5nIG5hbWUpOworICAgIFtTdHJpY3RUeXBlQ2hlY2tp bmcsIEN1c3RvbV0gYW55IGdldEV4dGVuc2lvbihpbiBET01TdHJpbmcgbmFtZSk7CiAKICAgICAv LyBhbnkgZ2V0RnJhbWVidWZmZXJBdHRhY2htZW50UGFyYW1ldGVyKGluIHVuc2lnbmVkIGxvbmcg dGFyZ2V0LCBpbiB1bnNpZ25lZCBsb25nIGF0dGFjaG1lbnQsIGluIHVuc2lnbmVkIGxvbmcgcG5h bWUpIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIEN1c3Rv bV0gdm9pZCBnZXRGcmFtZWJ1ZmZlckF0dGFjaG1lbnRQYXJhbWV0ZXIoKTsKQEAgLTU1MSw4ICs1 NTEsNyBAQAogCiAgICAgW1N0cmljdFR5cGVDaGVja2luZywgVHJlYXRSZXR1cm5lZE51bGxTdHJp bmdBcz1OdWxsXSBET01TdHJpbmcgICAgZ2V0U2hhZGVyU291cmNlKGluIFdlYkdMU2hhZGVyIHNo YWRlcikgcmFpc2VzKERPTUV4Y2VwdGlvbik7CiAKLSAgICAvLyBET01TdHJpbmdbXSBnZXRTdXBw b3J0ZWRFeHRlbnNpb25zKCkKLSAgICBbU3RyaWN0VHlwZUNoZWNraW5nLCBDdXN0b21dIHZvaWQg Z2V0U3VwcG9ydGVkRXh0ZW5zaW9ucygpOworICAgIFtTdHJpY3RUeXBlQ2hlY2tpbmcsIEN1c3Rv bV0gc2VxdWVuY2U8RE9NU3RyaW5nPiBnZXRTdXBwb3J0ZWRFeHRlbnNpb25zKCk7CiAKICAgICAv LyBhbnkgZ2V0VGV4UGFyYW1ldGVyKGluIHVuc2lnbmVkIGxvbmcgdGFyZ2V0LCBpbiB1bnNpZ25l ZCBsb25nIHBuYW1lKSByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICBbU3RyaWN0VHlwZUNoZWNr aW5nLCBDdXN0b21dIHZvaWQgZ2V0VGV4UGFyYW1ldGVyKCk7Cg==