100770 2012-10-30 10:06:31 -0700 [WTR] Memory leaks in TestWebKitAPI::didReceiveMessageFromInjectedBundle() 2012-10-30 23:08:42 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis webkit.review.bot oldest_to_newest 754467 0 naginenis 2012-10-30 10:06:31 -0700 We should adopt the WKStringRef returned by WKStringCreateWithUTF8CString() to fix the following leaks. ==18615== 74 (24 direct, 50 indirect) bytes in 1 blocks are definitely lost in loss record 757 of 1,113 ==18615== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==18615== by 0x43790A: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:269) ==18615== by 0x54485C8: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==18615== by 0x54ABC56: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:62) ==18615== by 0x54AB871: WKStringCreateWithUTF8CString (WKString.cpp:41) ==18615== by 0x434AE6: TestWebKitAPI::didReceiveMessageFromInjectedBundle(OpaqueWKContext const*, OpaqueWKString const*, void const*, void const*) (WillSendSubmitEvent.cpp:44) ==18615== by 0x54E8974: WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle(WebKit::WebContext*, WTF::String const&, WebKit::APIObject*) (WebContextInjectedBundleClient.cpp:41) ==18615== 78 (24 direct, 54 indirect) bytes in 1 blocks are definitely lost in loss record 760 of 1,113 ==18615== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==18615== by 0x43790A: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:269) ==18615== by 0x54485C8: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==18615== by 0x54ABC56: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:62) ==18615== by 0x54AB871: WKStringCreateWithUTF8CString (WKString.cpp:41) ==18615== by 0x434C8B: TestWebKitAPI::didReceiveMessageFromInjectedBundle(OpaqueWKContext const*, OpaqueWKString const*, void const*, void const*) (WillSendSubmitEvent.cpp:51) ==18615== by 0x54E8974: WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle(WebKit::WebContext*, WTF::String const&, WebKit::APIObject*) (WebContextInjectedBundleClient.cpp:41) ==18615== 82 (24 direct, 58 indirect) bytes in 1 blocks are definitely lost in loss record 791 of 1,113 ==18615== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==18615== by 0x43790A: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:269) ==18615== by 0x54485C8: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==18615== by 0x54ABC56: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:62) ==18615== by 0x54AB871: WKStringCreateWithUTF8CString (WKString.cpp:41) ==18615== by 0x434BBD: TestWebKitAPI::didReceiveMessageFromInjectedBundle(OpaqueWKContext const*, OpaqueWKString const*, void const*, void const*) (WillSendSubmitEvent.cpp:47) ==18615== by 0x54E8974: WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle(WebKit::WebContext*, WTF::String const&, WebKit::APIObject*) (WebContextInjectedBundleClient.cpp:41) 754473 1 171476 naginenis 2012-10-30 10:14:32 -0700 Created attachment 171476 Patch 754989 2 171476 webkit.review.bot 2012-10-30 23:08:38 -0700 Comment on attachment 171476 Patch Clearing flags on attachment: 171476 Committed r132988: <http://trac.webkit.org/changeset/132988> 754990 3 webkit.review.bot 2012-10-30 23:08:42 -0700 All reviewed patches have been landed. Closing bug. 171476 2012-10-30 10:14:32 -0700 2012-10-30 23:08:38 -0700 Patch 100770.patch text/plain 2621 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MDAx ZjkwLi5kOTE0MWExIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTAtMzAgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBpbnRlbC5jb20+CisKKyAgICAgICAgW1dUUl0gTWVtb3J5IGxl YWtzIGluIFRlc3RXZWJLaXRBUEk6OmRpZFJlY2VpdmVNZXNzYWdlRnJvbUluamVjdGVkQnVuZGxl KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc3 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkb3B0 IHN0cmluZ3MgcmV0dXJuZWQgYnkgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcoKSBpbgor ICAgICAgICBkaWRSZWNlaXZlTWVzc2FnZUZyb21JbmplY3RlZEJ1bmRsZSgpIHRvIGF2b2lkIG1l bW9yeSBsZWFrcy4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mi9XaWxs U2VuZFN1Ym1pdEV2ZW50LmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OmRpZFJlY2VpdmVN ZXNzYWdlRnJvbUluamVjdGVkQnVuZGxlKToKKwogMjAxMi0xMC0zMCAgQ2hyaXN0b3BoZSBEdW1l eiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdW0pIQlVJTERd IFVwZGF0ZSBFRkwgbGlicmFyaWVzIHRvIHYxLjcuMSBzdGFibGUgcmVsZWFzZQpkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1dpbGxTZW5kU3VibWl0RXZlbnQu Y3BwIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyL1dpbGxTZW5kU3VibWl0RXZl bnQuY3BwCmluZGV4IDY3MWM3MjkuLjEwNThjYzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Mi9XaWxsU2VuZFN1Ym1pdEV2ZW50LmNwcAorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDIvV2lsbFNlbmRTdWJtaXRFdmVudC5jcHAKQEAgLTQx LDE0ICs0MSwxNyBAQCBzdGF0aWMgdm9pZCBkaWRSZWNlaXZlTWVzc2FnZUZyb21JbmplY3RlZEJ1 bmRsZShXS0NvbnRleHRSZWYsIFdLU3RyaW5nUmVmIG1lc3NhZwogICAgIEVYUEVDVF9FUShXS0Rp Y3Rpb25hcnlHZXRUeXBlSUQoKSwgV0tHZXRUeXBlSUQoYm9keSkpOwogICAgIFdLRGljdGlvbmFy eVJlZiB2YWx1ZXMgPSBzdGF0aWNfY2FzdDxXS0RpY3Rpb25hcnlSZWY+KGJvZHkpOwogCi0gICAg V0tTdHJpbmdSZWYgdGV4dEZpZWxkVmFsdWVXSyA9IHN0YXRpY19jYXN0PFdLU3RyaW5nUmVmPihX S0RpY3Rpb25hcnlHZXRJdGVtRm9yS2V5KHZhbHVlcywgV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENT dHJpbmcoInRleHRGaWVsZCIpKSk7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHRleHRG aWVsZEtleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygidGV4dEZpZWxk IikpOworICAgIFdLU3RyaW5nUmVmIHRleHRGaWVsZFZhbHVlV0sgPSBzdGF0aWNfY2FzdDxXS1N0 cmluZ1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleSh2YWx1ZXMsIHRleHRGaWVsZEtleS5n ZXQoKSkpOwogICAgIEVYUEVDVF9XS19TVFJFUSgidGV4dCBmaWVsZCIsIHRleHRGaWVsZFZhbHVl V0spOwogCi0gICAgV0tTdHJpbmdSZWYgcGFzc3dvcmRGaWVsZFZhbHVlV0sgPSBzdGF0aWNfY2Fz dDxXS1N0cmluZ1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleSh2YWx1ZXMsIFdLU3RyaW5n Q3JlYXRlV2l0aFVURjhDU3RyaW5nKCJwYXNzd29yZEZpZWxkIikpKTsKKyAgICBXS1JldGFpblB0 cjxXS1N0cmluZ1JlZj4gcGFzc3dvcmRGaWVsZEtleShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdp dGhVVEY4Q1N0cmluZygicGFzc3dvcmRGaWVsZCIpKTsKKyAgICBXS1N0cmluZ1JlZiBwYXNzd29y ZEZpZWxkVmFsdWVXSyA9IHN0YXRpY19jYXN0PFdLU3RyaW5nUmVmPihXS0RpY3Rpb25hcnlHZXRJ dGVtRm9yS2V5KHZhbHVlcywgcGFzc3dvcmRGaWVsZEtleS5nZXQoKSkpOwogICAgIEVYUEVDVF9X S19TVFJFUSgicGFzc3dvcmQgZmllbGQiLCBwYXNzd29yZEZpZWxkVmFsdWVXSyk7CiAKICAgICAv LyA8aW5wdXQgdHlwZT0iaGlkZGVuIj4gZmllbGRzIGFyZSBub3Qgc2VudC4KLSAgICBXS1N0cmlu Z1JlZiBoaWRkZW5GaWVsZFZhbHVlV0sgPSBzdGF0aWNfY2FzdDxXS1N0cmluZ1JlZj4oV0tEaWN0 aW9uYXJ5R2V0SXRlbUZvcktleSh2YWx1ZXMsIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5n KCJoaWRkZW5GaWVsZCIpKSk7CisgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGhpZGRlbkZp ZWxkS2V5KEFkb3B0V0ssIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJoaWRkZW5GaWVs ZCIpKTsKKyAgICBXS1N0cmluZ1JlZiBoaWRkZW5GaWVsZFZhbHVlV0sgPSBzdGF0aWNfY2FzdDxX S1N0cmluZ1JlZj4oV0tEaWN0aW9uYXJ5R2V0SXRlbUZvcktleSh2YWx1ZXMsIGhpZGRlbkZpZWxk S2V5LmdldCgpKSk7CiAgICAgRVhQRUNUX05VTEwoaGlkZGVuRmllbGRWYWx1ZVdLKTsKIH0KIAo=