100768 2012-10-30 09:44:30 -0700 REGRESSION (r121299): OS X Text Replacement forces cursor out of text fields 2013-01-04 07:12:41 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 mitz mitz eric mifenton webkit.review.bot oldest_to_newest 754450 0 mitz 2012-10-30 09:44:30 -0700 <rdar://problem/12395187> Patch forthcoming. 754460 1 171474 mitz 2012-10-30 09:57:07 -0700 Created attachment 171474 Use an offset relative to the root container of the paragraph when saving and restoring the paragraph range 754464 2 171474 mitz 2012-10-30 10:04:44 -0700 Comment on attachment 171474 Use an offset relative to the root container of the paragraph when saving and restoring the paragraph range View in context: https://bugs.webkit.org/attachment.cgi?id=171474&action=review > LayoutTests/platform/mac/editing/spelling/autocorrection-in-textarea.html:14 > + var hasBeenBlurred = false; > + textarea.onblur = function() { > + hasBeenBlurred = true; > + } I’ll remove this. 800014 3 eric 2013-01-04 00:51:25 -0800 Attachment 171474 was posted by a committer and has review+, assigning to Dan Bernstein for commit. 800195 4 mitz 2013-01-04 07:12:41 -0800 Fixed in <http://trac.webkit.org/r132924>. 171474 2012-10-30 09:57:07 -0700 2012-10-30 10:08:51 -0700 Use an offset relative to the root container of the paragraph when saving and restoring the paragraph range 12395187_r2.diff text/plain 5194 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjkxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTEwLTMwICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMzk1 MTg3PiBSRUdSRVNTSU9OIChyMTIxMjk5KTogT1MgWCBUZXh0IFJlcGxhY2VtZW50IGZvcmNlcyBj dXJzb3Igb3V0IG9mIHRleHQgZmllbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDA3NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICByMTIxMjk5IGludHJvZHVjZWQgY29kZSB0byByZXN0b3JlIHRoZSBw YXJhZ3JhcGggcmFuZ2UgYnkgc2F2aW5nIGl0cyBsZW5ndGggYW5kIHN0YXJ0IG9mZnNldAorICAg ICAgICByZWxhdGl2ZSB0byB0aGUgZG9jdW1lbnQuIFRoZSBsYXR0ZXIgd2FzIG9idGFpbmVkIGJ5 IGl0ZXJhdGluZyBvdmVyIHRoZSByYW5nZSBzdGFydGluZyBhdAorICAgICAgICB0aGUgYmVnaW5u aW5nIG9mIHRoZSBkb2N1bWVudCBhbmQgZW5kaW5nIGF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIHBh cmFncmFwaCByYW5nZS4gSG93ZXZlciwKKyAgICAgICAgc3VjaCBhIHJhbmdlIGNvdWxkIG5vdCBi ZSBjb25zdHJ1Y3RlZCBpZiB0aGUgcGFyYWdyYXBoIHJhbmdlIHdhcyBjb250YWluZWQgaW4gYSBz aGFkb3cgRE9NLAorICAgICAgICBzaW5jZSBhIHJhbmdlIG11c3QgaGF2ZSBib3RoIGl0cyBlbmRw b2ludHMgd2l0aGluIHRoZSBzYW1lIHNoYWRvdyB0cmVlIChvciBub3QgaW4gYSBzaGFkb3cKKyAg ICAgICAgdHJlZSkuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vbWFjL2VkaXRpbmcvc3BlbGxp bmcvYXV0b2NvcnJlY3Rpb24taW4tdGV4dGFyZWEuaHRtbAorCisgICAgICAgICogZWRpdGluZy9F ZGl0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjptYXJrQW5kUmVwbGFjZUZvcik6 IENoYW5nZWQgcGFyYWdyYXBoU3RhcnRJbmRleCB0byBiZSByZWxhdGl2ZSB0byB0aGUKKyAgICAg ICAgcm9vdCBjb250YWluZXIgb2YgcGFyYWdyYXBoUmFuZ2UsIHVzaW5nIHRoZSBzYW1lIGxvZ2lj IHVzZWQgYnkKKyAgICAgICAgY2hlY2tGb3JEaWZmZXJlbnRSb290Q29udGFpbmVyKCkgaW4gUmFu Z2UuY3BwLgorCiAyMDEyLTEwLTI5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5j b20+CiAKICAgICAgICAgU3RyaW5nOjpjcmVhdGVDRlN0cmluZyBzaG91bGQgcmV0dXJuIGEgUmV0 YWluUHRyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCShyZXZpc2lvbiAxMzI4NTUp CisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTIxNDksMTEgKzIxNDksMTUgQEAgdm9pZCBFZGl0b3I6Om1hcmtBbmRSZXBsYWNlRm9yKFBhc3NS ZWZQdAogICAgICAgICAgICAgICAgIGlmIChjYW5FZGl0UmljaGx5KCkpCiAgICAgICAgICAgICAg ICAgICAgIGFwcGx5Q29tbWFuZChDcmVhdGVMaW5rQ29tbWFuZDo6Y3JlYXRlKG1fZnJhbWUtPmRv Y3VtZW50KCksIHJlc3VsdC0+cmVwbGFjZW1lbnQpKTsKICAgICAgICAgICAgIH0gZWxzZSBpZiAo Y2FuRWRpdCgpICYmIHNob3VsZEluc2VydFRleHQocmVzdWx0LT5yZXBsYWNlbWVudCwgcmFuZ2VU b1JlcGxhY2UuZ2V0KCksIEVkaXRvckluc2VydEFjdGlvblR5cGVkKSkgewotICAgICAgICAgICAg ICAgIGludCBwYXJhZ3JhcGhTdGFydEluZGV4ID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUxlbmd0aChS YW5nZTo6Y3JlYXRlKG1fZnJhbWUtPmRvY3VtZW50KCksIG1fZnJhbWUtPmRvY3VtZW50KCksIDAs IHBhcmFncmFwaC5wYXJhZ3JhcGhSYW5nZSgpLT5zdGFydENvbnRhaW5lcigpLCBwYXJhZ3JhcGgu cGFyYWdyYXBoUmFuZ2UoKS0+c3RhcnRPZmZzZXQoKSkuZ2V0KCkpOworICAgICAgICAgICAgICAg IE5vZGUqIHJvb3QgPSBwYXJhZ3JhcGgucGFyYWdyYXBoUmFuZ2UoKS0+c3RhcnRDb250YWluZXIo KTsKKyAgICAgICAgICAgICAgICB3aGlsZSAoQ29udGFpbmVyTm9kZSogcGFyZW50ID0gcm9vdC0+ cGFyZW50Tm9kZSgpKQorICAgICAgICAgICAgICAgICAgICByb290ID0gcGFyZW50OworCisgICAg ICAgICAgICAgICAgaW50IHBhcmFncmFwaFN0YXJ0SW5kZXggPSBUZXh0SXRlcmF0b3I6OnJhbmdl TGVuZ3RoKFJhbmdlOjpjcmVhdGUobV9mcmFtZS0+ZG9jdW1lbnQoKSwgcm9vdCwgMCwgcGFyYWdy YXBoLnBhcmFncmFwaFJhbmdlKCktPnN0YXJ0Q29udGFpbmVyKCksIHBhcmFncmFwaC5wYXJhZ3Jh cGhSYW5nZSgpLT5zdGFydE9mZnNldCgpKS5nZXQoKSk7CiAgICAgICAgICAgICAgICAgaW50IHBh cmFncmFwaExlbmd0aCA9IFRleHRJdGVyYXRvcjo6cmFuZ2VMZW5ndGgocGFyYWdyYXBoLnBhcmFn cmFwaFJhbmdlKCkuZ2V0KCkpOwogICAgICAgICAgICAgICAgIGFwcGx5Q29tbWFuZChTcGVsbGlu Z0NvcnJlY3Rpb25Db21tYW5kOjpjcmVhdGUocmFuZ2VUb1JlcGxhY2UsIHJlc3VsdC0+cmVwbGFj ZW1lbnQpKTsKICAgICAgICAgICAgICAgICAvLyBSZWNhbGN1bGF0ZSBuZXdQYXJhZ3JhcGhSYW5n ZSwgc2luY2UgU3BlbGxpbmdDb3JyZWN0aW9uQ29tbWFuZCBtb2RpZmllcyB0aGUgRE9NLCBzdWNo IHRoYXQgdGhlIG9yaWdpbmFsIHBhcmFncmFwaCByYW5nZSBpcyBubyBsb25nZXIgdmFsaWQuIFJh ZGFyOiAxMDMwNTMxNSBCdWd6aWxsYTogODk1MjYKLSAgICAgICAgICAgICAgICBSZWZQdHI8UmFu Z2U+IG5ld1BhcmFncmFwaFJhbmdlID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUZyb21Mb2NhdGlvbkFu ZExlbmd0aChtX2ZyYW1lLT5kb2N1bWVudCgpLCBwYXJhZ3JhcGhTdGFydEluZGV4LCBwYXJhZ3Jh cGhMZW5ndGgrcmVwbGFjZW1lbnRMZW5ndGgtcmVzdWx0TGVuZ3RoKTsKKyAgICAgICAgICAgICAg ICBSZWZQdHI8UmFuZ2U+IG5ld1BhcmFncmFwaFJhbmdlID0gVGV4dEl0ZXJhdG9yOjpyYW5nZUZy b21Mb2NhdGlvbkFuZExlbmd0aCh0b0NvbnRhaW5lck5vZGUocm9vdCksIHBhcmFncmFwaFN0YXJ0 SW5kZXgsIHBhcmFncmFwaExlbmd0aCArIHJlcGxhY2VtZW50TGVuZ3RoIC0gcmVzdWx0TGVuZ3Ro KTsKICAgICAgICAgICAgICAgICBwYXJhZ3JhcGggPSBUZXh0Q2hlY2tpbmdQYXJhZ3JhcGgoVGV4 dEl0ZXJhdG9yOjpzdWJyYW5nZShuZXdQYXJhZ3JhcGhSYW5nZS5nZXQoKSwgcmVzdWx0TG9jYXRp b24sIHJlcGxhY2VtZW50TGVuZ3RoKSwgbmV3UGFyYWdyYXBoUmFuZ2UpOwogICAgICAgICAgICAg ICAgIAogICAgICAgICAgICAgICAgIGlmIChBWE9iamVjdENhY2hlOjphY2Nlc3NpYmlsaXR5RW5h YmxlZCgpKSB7CkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZWRpdGluZy9zcGVsbGlu Zy9hdXRvY29ycmVjdGlvbi1pbi10ZXh0YXJlYS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc3BlbGxpbmcvYXV0b2NvcnJlY3Rpb24t aW4tdGV4dGFyZWEtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2VkaXRpbmcvc3BlbGxpbmcvYXV0b2NvcnJlY3Rpb24taW4tdGV4dGFyZWEtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKKzAxMjM0NTY3ODkKKworUEFT UwpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc3BlbGxpbmcvYXV0b2Nv cnJlY3Rpb24taW4tdGV4dGFyZWEuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9tYWMvZWRpdGluZy9zcGVsbGluZy9hdXRvY29ycmVjdGlvbi1pbi10ZXh0YXJlYS5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2VkaXRpbmcvc3BlbGxp bmcvYXV0b2NvcnJlY3Rpb24taW4tdGV4dGFyZWEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwyNyBAQAorPGRpdiBjb250ZW50ZWRpdGFibGU+CisgICAgMDEyMzQ1Njc4OQorPC9kaXY+Cis8 c2NyaXB0PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5k dW1wQXNUZXh0KCk7CisKKyAgICBvbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgdmFyIHRl eHRhcmVhID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRleHRhcmVhIik7CisgICAgICAgIHRl eHRhcmVhLmZvY3VzKCk7CisgICAgICAgIHZhciBoYXNCZWVuQmx1cnJlZCA9IGZhbHNlOworICAg ICAgICB0ZXh0YXJlYS5vbmJsdXIgPSBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIGhhc0JlZW5C bHVycmVkID0gdHJ1ZTsKKyAgICAgICAgfQorCisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21tYW5k KCJJbnNlcnRUZXh0IiwgZmFsc2UsICJ0ZSIpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgiSW5zZXJ0VGV4dCIsIGZhbHNlLCAiaCIpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgiSW5zZXJ0VGV4dCIsIGZhbHNlLCAiICIpOworCisgICAgICAgIGRvY3VtZW50LmV4ZWNDb21t YW5kKCJJbnNlcnRUZXh0IiwgZmFsc2UsICJ0ZXN0IHJlc3VsdCBpcyIpOworCisgICAgICAgIHZh ciByZXN1bHQgPSB0ZXh0YXJlYS52YWx1ZSA9PT0gInRoZSB0ZXN0IHJlc3VsdCBpcyIgPyAiUEFT UyIgOiAiRkFJTCI7CisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKS5h cHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShyZXN1bHQpKTsKKyAgICB9Cis8L3Nj cmlwdD4KKzx0ZXh0YXJlYSBpZD0idGV4dGFyZWEiPjwvdGV4dGFyZWE+Cis8cCBpZD0icmVzdWx0 Ij48L3A+Cg==