100761 2012-10-30 07:54:19 -0700 Web Inspector: Timeline: make "addRecord" unambiguous 2012-11-01 06:50:56 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 99830 0 eustas.bug eustas.bug apavlov bweinstein caseq eustas.bug joepeck keishi loislo pfeldman pmuellr rik vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 754366 0 eustas.bug 2012-10-30 07:54:19 -0700 TimelinePresentationModel.addRecord accepts two parameters - record and parentRecord. parentRecord is always root record, but that is not clear. 754369 1 171451 eustas.bug 2012-10-30 07:58:08 -0700 Created attachment 171451 Patch 754381 2 171451 caseq 2012-10-30 08:15:33 -0700 Comment on attachment 171451 Patch LGTM 755085 3 171451 webkit.review.bot 2012-10-31 02:47:25 -0700 Comment on attachment 171451 Patch Rejecting attachment 171451 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 12787 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 12787. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14687094 756177 4 171451 webkit.review.bot 2012-11-01 06:50:52 -0700 Comment on attachment 171451 Patch Clearing flags on attachment: 171451 Committed r133157: <http://trac.webkit.org/changeset/133157> 756178 5 webkit.review.bot 2012-11-01 06:50:56 -0700 All reviewed patches have been landed. Closing bug. 171451 2012-10-30 07:58:08 -0700 2012-11-01 06:50:52 -0700 Patch bug-100761-20121030185632.patch text/plain 3847 eustas.bug U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzExYWIzZTNhMmRhMWVk ZTkxODMwMmNhZTE3NjE4ZDY4OTE3MDI1Mi4uZWNjM2RkNzVkNWUxNzBjNzY3ZDJlMDk5NWJmNjNi YjcxNTJiNDlkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTMwICBFdWdl bmUgS2x5dWNobmlrb3YgIDxldXN0YXMuYnVnQGdtYWlsLmNvbT4KKworICAgICAgICBXZWIgSW5z cGVjdG9yOiBUaW1lbGluZTogbWFrZSAiYWRkUmVjb3JkIiB1bmFtYmlndW91cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzYxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGltZWxpbmVQcmVzZW50YXRp b25Nb2RlbC5hZGRSZWNvcmQgYWNjZXB0cyB0d28gcGFyYW1ldGVyczoKKyAgICAgICAgcmVjb3Jk IGFuZCBwYXJlbnRSZWNvcmQuIHBhcmVudFJlY29yZCBpcyBhbHdheXMgcm9vdCByZWNvcmQuCisg ICAgICAgIE1ha2UgdGhpcyBleHBsaWNpdCBieSByZW1vdmluZyBwYXJlbnRSZWNvcmQgcGFyYW1l dGVyLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzOiBS ZW1vdmVkIHBhcmFtZXRlci4KKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5l UHJlc2VudGF0aW9uTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQcmVz ZW50YXRpb25Nb2RlbC5wcm90b3R5cGUuYWRkUmVjb3JkKToKKyAgICAgICAgVXNlZCByb290IHJl Y29lZCBpbnN0ZWFkIG9mIHBhcmVudCByZWNvcmQuCisKIDIwMTItMTAtMzAgIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBjcmFzaCBieSBjYWxlbmRhciBw aWNrZXIgb3Igc3VnZ2VzdGlvbiBwaWNrZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwppbmRleCAxNWM5YTViOGY3ODhiYWUxZjIz MmEzZWVlMTYyYzI3YjAyMWNkMzgxLi5mM2E5ZWIzMTkwNWUxMTAzMTUxMzczODJjMmU5OWM4OWNi MDFiNzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Rp bWVsaW5lUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9U aW1lbGluZVBhbmVsLmpzCkBAIC01NTMsMTcgKzU1MywxNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxp bmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX2F1dG9tYXRpY2FsbHlTaXplV2lu ZG93ID0gZmFsc2U7CiAgICAgICAgIHZhciByZWNvcmRzID0gdGhpcy5fbW9kZWwucmVjb3JkczsK ICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCByZWNvcmRzLmxlbmd0aDsgKytpKQotICAgICAg ICAgICAgdGhpcy5faW5uZXJBZGRSZWNvcmRUb1RpbWVsaW5lKHJlY29yZHNbaV0sIHRoaXMuX3Jv b3RSZWNvcmQoKSk7CisgICAgICAgICAgICB0aGlzLl9pbm5lckFkZFJlY29yZFRvVGltZWxpbmUo cmVjb3Jkc1tpXSk7CiAgICAgICAgIHRoaXMuX2ludmFsaWRhdGVBbmRTY2hlZHVsZVJlZnJlc2go ZmFsc2UpOwogICAgIH0sCiAKICAgICBfb25UaW1lbGluZUV2ZW50UmVjb3JkZWQ6IGZ1bmN0aW9u KGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKHRoaXMuX2lubmVyQWRkUmVjb3JkVG9UaW1lbGlu ZShldmVudC5kYXRhLCB0aGlzLl9yb290UmVjb3JkKCkpKQorICAgICAgICBpZiAodGhpcy5faW5u ZXJBZGRSZWNvcmRUb1RpbWVsaW5lKGV2ZW50LmRhdGEpKQogICAgICAgICAgICAgdGhpcy5faW52 YWxpZGF0ZUFuZFNjaGVkdWxlUmVmcmVzaChmYWxzZSk7CiAgICAgfSwKIAotICAgIF9pbm5lckFk ZFJlY29yZFRvVGltZWxpbmU6IGZ1bmN0aW9uKHJlY29yZCwgcGFyZW50UmVjb3JkKQorICAgIF9p bm5lckFkZFJlY29yZFRvVGltZWxpbmU6IGZ1bmN0aW9uKHJlY29yZCkKICAgICB7CiAgICAgICAg IGlmIChyZWNvcmQudHlwZSA9PT0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lTW9kZWwuUmVjb3JkVHlw ZS5Qcm9ncmFtKSB7CiAgICAgICAgICAgICB0aGlzLl9tYWluVGhyZWFkVGFza3MucHVzaCh7CkBA IC01NzIsNyArNTcyLDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0g ewogICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KIAotICAgICAgICB2YXIgcmVjb3JkcyA9IHRo aXMuX3ByZXNlbnRhdGlvbk1vZGVsLmFkZFJlY29yZChyZWNvcmQsIHBhcmVudFJlY29yZCk7Cisg ICAgICAgIHZhciByZWNvcmRzID0gdGhpcy5fcHJlc2VudGF0aW9uTW9kZWwuYWRkUmVjb3JkKHJl Y29yZCk7CiAgICAgICAgIHRoaXMuX2FsbFJlY29yZHNDb3VudCArPSByZWNvcmRzLmxlbmd0aDsK ICAgICAgICAgdmFyIHRpbWVTdGFtcFJlY29yZHMgPSB0aGlzLl90aW1lU3RhbXBSZWNvcmRzOwog ICAgICAgICB2YXIgaGFzVmlzaWJsZVJlY29yZHMgPSBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5q cyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50YXRp b25Nb2RlbC5qcwppbmRleCA3MDIwZDFhYTM3NzFhMTI5NDQ0NmE5ODYwZjdlYzI0NWYyOWE2MzFm Li5hNWJiNjA0Njk3ODRmMDViYTllM2Y0ZDA4NDg5ODkwYTgxNGI1NDdlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0aW9uTW9k ZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBy ZXNlbnRhdGlvbk1vZGVsLmpzCkBAIC0yNzQsNyArMjc0LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVs aW5lUHJlc2VudGF0aW9uTW9kZWwucHJvdG90eXBlID0gewogICAgICAgICB0aGlzLl9mcmFtZXMu cHVzaChmcmFtZSk7CiAgICAgfSwKIAotICAgIGFkZFJlY29yZDogZnVuY3Rpb24ocmVjb3JkLCBw YXJlbnRSZWNvcmQpCisgICAgYWRkUmVjb3JkOiBmdW5jdGlvbihyZWNvcmQpCiAgICAgewogICAg ICAgICBpZiAodGhpcy5fbWluaW11bVJlY29yZFRpbWUgPT09IC0xIHx8IHJlY29yZC5zdGFydFRp bWUgPCB0aGlzLl9taW5pbXVtUmVjb3JkVGltZSkKICAgICAgICAgICAgIHRoaXMuX21pbmltdW1S ZWNvcmRUaW1lID0gV2ViSW5zcGVjdG9yLlRpbWVsaW5lTW9kZWwuc3RhcnRUaW1lSW5TZWNvbmRz KHJlY29yZCk7CkBAIC0yODgsNyArMjg4LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUHJlc2Vu dGF0aW9uTW9kZWwucHJvdG90eXBlID0gewogICAgICAgICB2YXIgZm9ybWF0dGVkUmVjb3JkcyA9 IFtdOwogICAgICAgICB2YXIgcmVjb3Jkc0NvdW50ID0gcmVjb3Jkcy5sZW5ndGg7CiAgICAgICAg IGZvciAodmFyIGkgPSAwOyBpIDwgcmVjb3Jkc0NvdW50OyArK2kpCi0gICAgICAgICAgICBmb3Jt YXR0ZWRSZWNvcmRzLnB1c2godGhpcy5faW5uZXJBZGRSZWNvcmQocmVjb3Jkc1tpXSwgcGFyZW50 UmVjb3JkKSk7CisgICAgICAgICAgICBmb3JtYXR0ZWRSZWNvcmRzLnB1c2godGhpcy5faW5uZXJB ZGRSZWNvcmQocmVjb3Jkc1tpXSwgdGhpcy5fcm9vdFJlY29yZCkpOwogICAgICAgICByZXR1cm4g Zm9ybWF0dGVkUmVjb3JkczsKICAgICB9LAogCg==