100756 2012-10-30 06:50:51 -0700 [Qt] udis86_itab.c is always regenerated 2012-11-04 01:08:11 -0800 1 1 1 Unclassified WebKit Tools / Tests 420+ All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy ossy abecsi barraclough fpizlo gaborb ggaren hausmann mhahnenberg ossy vestbo webkit.review.bot oldest_to_newest 754323 0 ossy 2012-10-30 06:50:51 -0700 Disassembler build was enabled by http://trac.webkit.org/changeset/132606, but udis86_itab.c is always regenerated. The root of the problem is that the generator script - disassembler/udis86/itab.py doesn't accept output directory as parameter and always generates udis86_itab.c and .h into the actual directory, which is WebKitBuild/Release/Source/JavaScriptCore. But all other generated sources are generated into WebKitBuild/Release/Source/JavaScriptCore/generated. The problem is that Tools/qmake/mkspecs/features/default_post.prf automatically adds "generated/" prefix to all generated sources, except we use output_function of the generator. Patch is coming soon. 754328 1 171441 ossy 2012-10-30 06:59:31 -0700 Created attachment 171441 Patch 754755 2 171441 vestbo 2012-10-30 16:05:32 -0700 Comment on attachment 171441 Patch I have to take closer look at the generator-qmake-logic, but shouldnt we be able to add generated/ for a regular output? In any case, do we still need output and outut_function? 755215 3 ossy 2012-10-31 06:21:12 -0700 (In reply to comment #2) > (From update of attachment 171441 [details]) > I have to take closer look at the generator-qmake-logic, but shouldnt we be able to add generated/ for a regular output? In any case, do we still need output and outut_function? 1.) Of course we can also add a new command line parameter to the 3rdparty disassembler/udis86/itab.py ... Let me try it. 2.) I tried to remove the disassembler.output, but TARGET still depends on the non-existing udis86_itab.c target for some reason and it causes fail. (the name of the target is the full path in this case) 755241 4 171639 ossy 2012-10-31 06:45:42 -0700 Created attachment 171639 Patch 755243 5 ossy 2012-10-31 06:46:26 -0700 (In reply to comment #4) > Created an attachment (id=171639) [details] > Patch Waht do you think about this one? It is bigger, but general fix. 755246 6 webkit.review.bot 2012-10-31 06:50:07 -0700 Attachment 171639 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/disassembler/udis86/itab.py:199: whitespace after '(' [pep8/E201] [5] Source/JavaScriptCore/disassembler/udis86/itab.py:295: whitespace after '(' [pep8/E201] [5] Source/JavaScriptCore/disassembler/udis86/itab.py:334: whitespace after '(' [pep8/E201] [5] Source/JavaScriptCore/disassembler/udis86/itab.py:355: whitespace after '(' [pep8/E201] [5] Total errors found: 4 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 758069 7 171639 ossy 2012-11-04 01:08:05 -0800 Comment on attachment 171639 Patch Clearing flags on attachment: 171639 Committed r133415: <http://trac.webkit.org/changeset/133415> 758070 8 ossy 2012-11-04 01:08:11 -0800 All reviewed patches have been landed. Closing bug. 171441 2012-10-30 06:59:31 -0700 2012-10-31 06:45:37 -0700 Patch bug-100756-20121030065755.patch text/plain 1530 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyOTAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NDQ4YjRmN2I4MmZkZTFhN2U1YzhiZGVhZTBjNjUwMzExMTEzYTgyLi4xZjJhODc0NWJiMjdiYjA2 ODViOTZhMjE2ZjkzMDYwNTM4YTdmNWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0xMC0zMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtRdF0gdWRpczg2X2l0YWIuYyBpcyBhbHdheXMgcmVnZW5lcmF0ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc1Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRGVyaXZl ZFNvdXJjZXMucHJpOiBGaXggdGhlIG91dHB1dCBwYXRoIG9mIHVkaXM4Nl9pdGFiLmMuCisKIDIw MTItMTAtMjggIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBTaW1wbGlm eSBYY29kZSBjb25maWd1cmF0aW9uIHNldHRpbmdzIHRoYXQgdXNlZCB0byB2YXJ5IGJldHdlZW4g T1MgdmVyc2lvbnMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvRGVyaXZlZFNv dXJjZXMucHJpIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQppbmRl eCBkYmE4YzVjMmMzYjUwZGE0M2U5Y2JiMWJmMGIzN2UwZjdmYTNkOWUwLi41NDYwNDEyYzgzMDM2 ZjM3ODRiZGU2ODEzNzFkZGMyZTgzMzY1ZmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvRGVyaXZlZFNvdXJjZXMucHJpCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9EZXJp dmVkU291cmNlcy5wcmkKQEAgLTExMiw5ICsxMTIsMTMgQEAgaWYobGludXgtKnx3aW4zMik6IWVx dWFscyhRVF9BUkNILCAiYXJtIikgewogICAgIEdFTkVSQVRPUlMgKz0gbGxpbnQKIH0KIAorZGVm aW5lUmVwbGFjZShkaXNhc3NlbWJsZXJfZ2VuZXJhdG9yX291dHB1dCkgeworICByZXR1cm4oJCRP VVRfUFdEL3VkaXM4Nl9pdGFiLmMpCit9CiBsaW51eC0qOmlmKGlzRXF1YWwoUVRfQVJDSCwgImkz ODYiKXxpc0VxdWFsKFFUX0FSQ0gsICJ4ODZfNjQiKSkgewogICAgICMgR0VORVJBVE9SOiBkaXNh c3NlbWJsZXIKICAgICBkaXNhc3NlbWJsZXIub3V0cHV0ID0gdWRpczg2X2l0YWIuYworICAgIGRp c2Fzc2VtYmxlci5vdXRwdXRfZnVuY3Rpb24gPSBkaXNhc3NlbWJsZXJfZ2VuZXJhdG9yX291dHB1 dAogICAgIGRpc2Fzc2VtYmxlci5pbnB1dCA9IERJU0FTU0VNQkxFUl9GSUxFUwogICAgIGRpc2Fz c2VtYmxlci5zY3JpcHQgPSAkJFBXRC9kaXNhc3NlbWJsZXIvdWRpczg2L2l0YWIucHkKICAgICBk aXNhc3NlbWJsZXIuZGVwZW5kcyA9ICQkRElTQVNTRU1CTEVSX0RFUEVOREVOQ1kK 171639 2012-10-31 06:45:42 -0700 2012-11-04 01:08:05 -0800 Patch bug-100756-20121031064405.patch text/plain 4690 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 YTUwNzU4Y2Q5ZGNlZWRmYjk3NDQ0OWUxNTE1YmVlMjY0M2M5ZjQzLi4xYmU0MDE1ZjFhOWE2ODc3 Nzk4MDkwMWJkZGYzZGU0OTQwYjI0MmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0xMC0zMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtRdF0gdWRpczg2X2l0YWIuYyBpcyBhbHdheXMgcmVnZW5lcmF0ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc1Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogRGVyaXZl ZFNvdXJjZXMucHJpOiBHZW5lcmF0ZSBzb3VyY2VzIHRvIHRoZSBnZW5lcmF0ZWQgZGlyZWN0b3J5 LgorICAgICAgICAqIGRpc2Fzc2VtYmxlci91ZGlzODYvZGlmZmVyZW5jZXMudHh0OgorICAgICAg ICAqIGRpc2Fzc2VtYmxlci91ZGlzODYvaXRhYi5weTogQWRkIC0tb3V0cHV0RGlyIG9wdGlvbi4K KyAgICAgICAgKFVkSXRhYkdlbmVyYXRvci5fX2luaXRfXyk6CisgICAgICAgIChnZW5JdGFiSCk6 CisgICAgICAgIChnZW5JdGFiQyk6CisgICAgICAgIChtYWluKToKKwogMjAxMi0xMC0zMCAgWXVx aWFuZyBYaWFuICA8eXVxaWFuZy54aWFuQGludGVsLmNvbT4KIAogICAgICAgICBnbHNsLWZ1bmN0 aW9uLWF0YW4uaHRtbCBXZWJHTCBjb25mb3JtYW5jZSB0ZXN0IGZhaWxzIGFmdGVyIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05OTE1NApkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaSBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9EZXJpdmVkU291cmNlcy5wcmkKaW5kZXggZGJhOGM1YzJjM2I1MGRhNDNlOWNiYjFiZjBiMzdl MGY3ZmEzZDllMC4uMDNhOTM1NTc1NzQ4ZmRhOThmYmUzNTJhMzllYjg4MzBiOTFmOTJkYiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0Rlcml2ZWRTb3VyY2VzLnByaQorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvRGVyaXZlZFNvdXJjZXMucHJpCkBAIC0xMTgsNyArMTE4LDcg QEAgbGludXgtKjppZihpc0VxdWFsKFFUX0FSQ0gsICJpMzg2Iil8aXNFcXVhbChRVF9BUkNILCAi eDg2XzY0IikpIHsKICAgICBkaXNhc3NlbWJsZXIuaW5wdXQgPSBESVNBU1NFTUJMRVJfRklMRVMK ICAgICBkaXNhc3NlbWJsZXIuc2NyaXB0ID0gJCRQV0QvZGlzYXNzZW1ibGVyL3VkaXM4Ni9pdGFi LnB5CiAgICAgZGlzYXNzZW1ibGVyLmRlcGVuZHMgPSAkJERJU0FTU0VNQkxFUl9ERVBFTkRFTkNZ Ci0gICAgZGlzYXNzZW1ibGVyLmNvbW1hbmRzID0gcHl0aG9uICQkZGlzYXNzZW1ibGVyLnNjcmlw dCAke1FNQUtFX0ZJTEVfTkFNRX0KKyAgICBkaXNhc3NlbWJsZXIuY29tbWFuZHMgPSBweXRob24g JCRkaXNhc3NlbWJsZXIuc2NyaXB0ICR7UU1BS0VfRklMRV9OQU1FfSAtLW91dHB1dERpciAke1FN QUtFX0ZVTkNfRklMRV9PVVRfUEFUSH0KICAgICBkaXNhc3NlbWJsZXIuQ09ORklHICs9IG5vX2xp bmsKICAgICBHRU5FUkFUT1JTICs9IGRpc2Fzc2VtYmxlcgogfQpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvZGlmZmVyZW5jZXMudHh0IGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvZGlmZmVyZW5jZXMudHh0Cmlu ZGV4IDNlZjUxZWZjZmNlYThmYWQ5OTYwYTRjNjBiMjE3ZDVhNTk2NDE1NGIuLmRjMjI1YjZmZmVk ZDU4Nzk0ZTVkN2UxMTVkZDc2MTY1NTRiNTZiMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kaXNhc3NlbWJsZXIvdWRpczg2L2RpZmZlcmVuY2VzLnR4dAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni9kaWZmZXJlbmNlcy50eHQKQEAgLTIw LDMgKzIwLDUgQEAgaGVyZToKIC0gTWFkZSB0aGUgY29kZSBpbiB1ZGlzODZfc3luLmggdXNlIHZz bnByaW50ZigpIGluc3RlYWQgb2YgdnNwcmludGYoKS4KIAogLSBGaXhlZCB1ZGlzODZfc3luLWF0 dC5jJ3MganVtcCBkZXN0aW5hdGlvbiBwcmludGluZyB0byB3b3JrIGNvcnJlY3RseSBpbiA2NC1i aXQgbW9kZS4KKworLSBBZGQgLS1vdXRwdXREaXIgb3B0aW9uIHRvIGl0YWIucHkuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni9pdGFiLnB5IGIv U291cmNlL0phdmFTY3JpcHRDb3JlL2Rpc2Fzc2VtYmxlci91ZGlzODYvaXRhYi5weQppbmRleCAy N2ZhOWIzZjM3NDIxMjZjOTkzMjFhNDg3Yzk1N2I1ODAwMGQ4MmZiLi4wN2UyMGE2ZTEwMDFmZGNm YWI2MjBjYmNkNTc5M2U3ODA4NzVlMGQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvZGlzYXNzZW1ibGVyL3VkaXM4Ni9pdGFiLnB5CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kaXNhc3NlbWJsZXIvdWRpczg2L2l0YWIucHkKQEAgLTIzLDYgKzIzLDggQEAKICMgKElOQ0xV RElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBU SEUgVVNFIE9GIFRISVMgCiAjIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJ QklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCitmcm9tIG9wdHBhcnNlIGltcG9ydCBPcHRpb25QYXJz ZXIKK2ltcG9ydCBvcwogaW1wb3J0IHN5cwogCiBzeXMucGF0aC5hcHBlbmQoICcuLi9zY3JpcHRz JyApOwpAQCAtMTk0LDEwICsxOTYsMTEgQEAgY2xhc3MgVWRJdGFiR2VuZXJhdG9yKCB1ZF9vcGNv ZGUuVWRPcGNvZGVUYWJsZXMgKToKIAogICAgIE1uZW1vbmljQWxpYXNlcyA9ICggImludmFsaWQi LCAiM2Rub3ciLCAibm9uZSIsICJkYiIsICJwYXVzZSIgKQogICAgIAotICAgIGRlZiBfX2luaXRf Xyggc2VsZiApOgorICAgIGRlZiBfX2luaXRfXyggc2VsZiwgb3V0cHV0RGlyICk6CiAgICAgICAg ICMgZmlyc3QgaXRhYiBlbnRyeSAoMCkgaXMgSW52YWxpZAogICAgICAgICBzZWxmLkl0YWIuYXBw ZW5kKCBzZWxmLkludmFsaWRFbnRyeSApCiAgICAgICAgIHNlbGYuTW5lbW9uaWNzVGFibGUuZXh0 ZW5kKCBzZWxmLk1uZW1vbmljQWxpYXNlcyApCisgICAgICAgIHNlbGYub3V0cHV0RGlyID0gb3V0 cHV0RGlyCiAKICAgICBkZWYgdG9Hcm91cElkKCBzZWxmLCBpZCApOgogICAgICAgICByZXR1cm4g MHg4MDAwIHwgaWQKQEAgLTI4OSw3ICsyOTIsNyBAQCBjbGFzcyBVZEl0YWJHZW5lcmF0b3IoIHVk X29wY29kZS5VZE9wY29kZVRhYmxlcyApOgogIAogCiAgICAgZGVmIGdlbkl0YWJIKCBzZWxmICk6 Ci0gICAgICAgIHNlbGYuSXRhYkggPSBvcGVuKCAidWRpczg2X2l0YWIuaCIsICJ3IiApCisgICAg ICAgIHNlbGYuSXRhYkggPSBvcGVuKCBvcy5wYXRoLmpvaW4oc2VsZi5vdXRwdXREaXIsICJ1ZGlz ODZfaXRhYi5oIiksICJ3IiApCiAKICAgICAgICAgIyBHZW5lcmF0ZSBUYWJsZSBUeXBlIEVudW1l cmF0aW9uCiAgICAgICAgIHNlbGYuSXRhYkgud3JpdGUoICIjaWZuZGVmIFVEX0lUQUJfSFxuIiAp CkBAIC0zMjgsNyArMzMxLDcgQEAgY2xhc3MgVWRJdGFiR2VuZXJhdG9yKCB1ZF9vcGNvZGUuVWRP cGNvZGVUYWJsZXMgKToKIAogCiAgICAgZGVmIGdlbkl0YWJDKCBzZWxmICk6Ci0gICAgICAgIHNl bGYuSXRhYkMgPSBvcGVuKCAidWRpczg2X2l0YWIuYyIsICJ3IiApCisgICAgICAgIHNlbGYuSXRh YkMgPSBvcGVuKCBvcy5wYXRoLmpvaW4oc2VsZi5vdXRwdXREaXIsICJ1ZGlzODZfaXRhYi5jIiks ICJ3IiApCiAgICAgICAgIHNlbGYuSXRhYkMud3JpdGUoICIvKiBpdGFiLmMgLS0gZ2VuZXJhdGVk IGJ5IGl0YWIucHksIGRvIG5vIGVkaXQiICkKICAgICAgICAgc2VsZi5JdGFiQy53cml0ZSggIiAq L1xuIiApOwogICAgICAgICBzZWxmLkl0YWJDLndyaXRlKCAiI2luY2x1ZGUgXCJ1ZGlzODZfZGVj b2RlLmhcIlxuXG4iICk7CkBAIC0zNDQsOSArMzQ3LDEyIEBAIGNsYXNzIFVkSXRhYkdlbmVyYXRv ciggdWRfb3Bjb2RlLlVkT3Bjb2RlVGFibGVzICk6CiAgICAgICAgIHNlbGYuZ2VuSXRhYkgoKQog CiBkZWYgbWFpbigpOgotICAgIGdlbmVyYXRvciA9IFVkSXRhYkdlbmVyYXRvcigpCisgICAgcGFy c2VyID0gT3B0aW9uUGFyc2VyKCkKKyAgICBwYXJzZXIuYWRkX29wdGlvbigiLS1vdXRwdXREaXIi LCBkZXN0PSJvdXRwdXREaXIiLCBkZWZhdWx0PSIiKQorICAgIG9wdGlvbnMsIGFyZ3MgPSBwYXJz ZXIucGFyc2VfYXJncygpCisgICAgZ2VuZXJhdG9yID0gVWRJdGFiR2VuZXJhdG9yKG9zLnBhdGgu bm9ybXBhdGgob3B0aW9ucy5vdXRwdXREaXIpKQogICAgIG9wdGFibGVYbWxQYXJzZXIgPSB1ZF9v cHRhYmxlLlVkT3B0YWJsZVhtbFBhcnNlcigpCi0gICAgb3B0YWJsZVhtbFBhcnNlci5wYXJzZSgg c3lzLmFyZ3ZbIDEgXSwgZ2VuZXJhdG9yLmFkZEluc25EZWYgKQorICAgIG9wdGFibGVYbWxQYXJz ZXIucGFyc2UoIGFyZ3NbIDAgXSwgZ2VuZXJhdG9yLmFkZEluc25EZWYgKQogCiAgICAgZ2VuZXJh dG9yLmdlbkl0YWIoKQogCg==