100755 2012-10-30 06:48:47 -0700 [EFL] Baseline search path should consider both WK1 and WK2 on layout test. 2012-10-30 21:32:12 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 100810 1 kangil.han kangil.han abarth dpranke gyuyoung.kim kenneth lucas.de.marchi ojan ossy rakuco ryuan.choi webkit.review.bot oldest_to_newest 754320 0 kangil.han 2012-10-30 06:48:47 -0700 Currently, WK1 is not considered on layout test in baseline search path. 754324 1 171439 kangil.han 2012-10-30 06:50:51 -0700 Created attachment 171439 patch 754348 2 171439 rakuco 2012-10-30 07:25:10 -0700 Comment on attachment 171439 patch Looks OK. 754393 3 171439 webkit.review.bot 2012-10-30 08:40:20 -0700 Comment on attachment 171439 patch Clearing flags on attachment: 171439 Committed r132910: <http://trac.webkit.org/changeset/132910> 754394 4 webkit.review.bot 2012-10-30 08:40:24 -0700 All reviewed patches have been landed. Closing bug. 754504 5 ossy 2012-10-30 10:44:48 -0700 It broke a python unit test: File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 55, in test_baseline_directory self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl") AssertionError: '/mock-checkout/LayoutTests/platform/efl-wk1' != '/mock-checkout/LayoutTests/platform/efl' Could you update the test? 754925 6 kangil.han 2012-10-30 20:59:39 -0700 (In reply to comment #5) > It broke a python unit test: > > File "/ramdisk/qt-linux-release/build/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py", line 55, in test_baseline_directory > self.assertEqual(command._baseline_directory("EFL Linux 64-bit Debug"), "/mock-checkout/LayoutTests/platform/efl") > AssertionError: '/mock-checkout/LayoutTests/platform/efl-wk1' != '/mock-checkout/LayoutTests/platform/efl' > > Could you update the test? Oops.. I will figure out what has happened. 171439 2012-10-30 06:50:51 -0700 2012-10-30 08:40:20 -0700 patch baseline_search_1.txt text/plain 1516 kangil.han ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNDU2 NzEwLi5mYzgwM2QyIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTItMTAtMzAgIEthbmdpbCBIYW4gIDxrYW5naWwu aGFuQHNhbXN1bmcuY29tPgogCisgICAgICAgIFtFRkxdIEJhc2VsaW5lIHNlYXJjaCBwYXRoIHNo b3VsZCBjb25zaWRlciBib3RoIFdLMSBhbmQgV0syIG9uIGxheW91dCB0ZXN0LgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzU1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBpbXBsZW1lbnRh dGlvbiBkb2Vzbid0IGNvbnNpZGVyIFdLMSBjYXNlIGluIGJhc2VsaW5lIHNlYXJjaCBwYXRoLgor ICAgICAgICBUaGVyZWZvcmUsIHRoaXMgcGF0Y2ggZml4ZXMgaXQuCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weToKKyAgICAgICAgKEVmbFBvcnQu ZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aCk6CisKKzIwMTItMTAtMzAgIEthbmdpbCBIYW4g IDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCiAgICAgICAgIFtFRkxdW0RSVF0gQml0bWFwIHNo b3VsZCBzaG93IHdob2xlIHZpZXcgYXJlYS4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMDY0MgogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2VmbC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5CmluZGV4IDEwMjJjZDcuLjFlOWVkMTAgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZWZsLnB5CkBAIC0xMDcs NiArMTA3LDkgQEAgY2xhc3MgRWZsUG9ydChQb3J0LCBQdWxzZUF1ZGlvU2FuaXRpemVyKToKICAg ICAgICAgc2VhcmNoX3BhdGhzLmFwcGVuZChzZWxmLnBvcnRfbmFtZSkKICAgICAgICAgcmV0dXJu IHNlYXJjaF9wYXRocwogCisgICAgZGVmIGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2Vs Zik6CisgICAgICAgIHJldHVybiBtYXAoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgsIHNlbGYu X3NlYXJjaF9wYXRocygpKQorCiAgICAgZGVmIGV4cGVjdGF0aW9uc19maWxlcyhzZWxmKToKICAg ICAgICAgIyBGSVhNRTogV2Ugc2hvdWxkIGJlIGFibGUgdG8gdXNlIHRoZSBkZWZhdWx0IGFsZ29y aXRobSBoZXJlLgogICAgICAgICByZXR1cm4gbGlzdChyZXZlcnNlZChbc2VsZi5fZmlsZXN5c3Rl bS5qb2luKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoKHApLCAnVGVzdEV4cGVjdGF0aW9ucycp IGZvciBwIGluIHNlbGYuX3NlYXJjaF9wYXRocygpXSkpCg==