100748 2012-10-30 05:18:14 -0700 [EFL][WK2] Fix EFL build after r132887 2012-10-30 09:56:30 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov cdumez gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 754238 0 mikhail.pozdnyakov 2012-10-30 05:18:14 -0700 EFL build fails with WTF_USE_TILED_BACKING_STORE enabled after http://trac.webkit.org/changeset/132887. Sorry for it. 754247 1 171427 mikhail.pozdnyakov 2012-10-30 05:30:11 -0700 Created attachment 171427 patch 754254 2 171427 cdumez 2012-10-30 05:37:13 -0700 Comment on attachment 171427 patch LGTM. 754257 3 cdumez 2012-10-30 05:38:08 -0700 However, We usually use [AC] tag in bug title. You should also mention that this fixes the build when accelerated compositing is enabled. 754259 4 171427 gyuyoung.kim 2012-10-30 05:41:29 -0700 Comment on attachment 171427 patch You don't need to request r? when fixing build break. 754307 5 171427 webkit.review.bot 2012-10-30 06:38:10 -0700 Comment on attachment 171427 patch Clearing flags on attachment: 171427 Committed r132905: <http://trac.webkit.org/changeset/132905> 754308 6 webkit.review.bot 2012-10-30 06:38:15 -0700 All reviewed patches have been landed. Closing bug. 754332 7 cdumez 2012-10-30 07:07:32 -0700 (In reply to comment #4) > (From update of attachment 171427 [details]) > You don't need to request r? when fixing build break. As I commented, the build is only broken is AC is enabled (which is not the default). Does it still count as a build fix? 754458 8 tonikitoo 2012-10-30 09:56:30 -0700 (In reply to comment #7) > (In reply to comment #4) > > (From update of attachment 171427 [details] [details]) > > You don't need to request r? when fixing build break. > > As I commented, the build is only broken is AC is enabled (which is not the default). Does it still count as a build fix? yes. 171427 2012-10-30 05:30:11 -0700 2012-10-30 06:38:10 -0700 patch bug100748 text/plain 1532 mikhail.pozdnyakov Y29tbWl0IGE1Njc4ZmQxZDJmYjVhOTM4Y2E3Y2JlYjhiNDE1MzQ5Y2ZkZWYyNjYKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VHVlIE9jdCAzMCAxNDoyNzo1MSAyMDEyICswMjAwCgogICAgYnVnMTAwNzQ4CgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IDM4NDVhMTMuLmIxNWM4NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxMi0x MC0zMCAgTWlraGFpbCBQb3pkbnlha292ICA8bWlraGFpbC5wb3pkbnlha292QGludGVsLmNvbT4K IAorICAgICAgICBbRUZMXVtXSzJdIEZpeCBFRkwgYnVpbGQgYWZ0ZXIgcjEzMjg4NworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzQ4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgRUZMIGJ1aWxk IGZhaWx1cmUgd2l0aCBXVEZfVVNFX1RJTEVEX0JBQ0tJTkdfU1RPUkUgZW5hYmxlZCBjYXVzZWQg YnkgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTMyODg3LgorCisgICAgICAgICog VUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVmbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBh Z2VMb2FkQ2xpZW50RWZsOjpkaWRDb21taXRMb2FkRm9yRnJhbWUpOgorCisyMDEyLTEwLTMwICBN aWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgorCiAgICAg ICAgIFtFRkxdW1dLMl0gU2ltcGxpZnkgc2lnbmFsIGVtaXR0aW5nIEFQSSBpbiBFd2tWaWV3SW1w bAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNTA2 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvUGFnZUxvYWRDbGll bnRFZmwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVm bC5jcHAKaW5kZXggNjI3OGRiOC4uNjIxYzg1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVmbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9QYWdlTG9hZENsaWVudEVmbC5jcHAKQEAgLTEzNiw3ICsxMzYsNyBAQCB2 b2lkIFBhZ2VMb2FkQ2xpZW50RWZsOjpkaWRDb21taXRMb2FkRm9yRnJhbWUoV0tQYWdlUmVmLCBX S0ZyYW1lUmVmIGZyYW1lLCBXS1R5cAogICAgICAgICByZXR1cm47CiAKICAgICBFd2tWaWV3SW1w bCogdmlld0ltcGwgPSB0b1BhZ2VMb2FkQ2xpZW50RWZsKGNsaWVudEluZm8pLT52aWV3SW1wbCgp OwotICAgIHZpZXdJbXBsLT5zbWFydENhbGxiYWNrPExvYWRDb21taXR0ZWQ+KCkuY2FsbCgpOwor ICAgIHZpZXdJbXBsLT5pbmZvcm1Mb2FkQ29tbWl0dGVkKCk7CiB9CiAjZW5kaWYKIAo=