100746 2012-10-30 04:44:56 -0700 [EFL] combine color profile failures to the correct bug 2012-10-30 07:14:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jussi.kukkonen jussi.kukkonen gyuyoung.kim rakuco webkit.review.bot oldest_to_newest 754218 0 jussi.kukkonen 2012-10-30 04:44:56 -0700 TestExpectations gardening, patch coming. 754221 1 171421 jussi.kukkonen 2012-10-30 04:50:05 -0700 Created attachment 171421 Patch 754224 2 171421 jussi.kukkonen 2012-10-30 05:00:06 -0700 Comment on attachment 171421 Patch forgot to add "cq?" 754277 3 171421 rakuco 2012-10-30 06:08:54 -0700 Comment on attachment 171421 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171421&action=review > LayoutTests/platform/efl/TestExpectations:659 > +# EFL does not USE(QCMSLIB) so color transforms are not done Wouldn't it make sense to make this comment more generic? I understood that this is something we're not really interested in fixing and not that it doesn't work because we do not use that lib. 754312 4 171436 jussi.kukkonen 2012-10-30 06:43:54 -0700 Created attachment 171436 I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. 754341 5 171436 webkit.review.bot 2012-10-30 07:14:19 -0700 Comment on attachment 171436 I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. Clearing flags on attachment: 171436 Committed r132908: <http://trac.webkit.org/changeset/132908> 754342 6 webkit.review.bot 2012-10-30 07:14:23 -0700 All reviewed patches have been landed. Closing bug. 171421 2012-10-30 04:50:05 -0700 2012-10-30 06:43:40 -0700 Patch bug-100746-20121030134829.patch text/plain 2533 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmVkY2FjZGFlNzU2MmU4OTcyNGYw YTJkNjhkMWJjYzIxNmE2MDkwNC4uNDRlM2E4MWE2MmZlNWFkNGQxNDk5MzUwY2JhMDg5YmI3OTFi ZGY1OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDEyLTEwLTMwICBKdXNzaSBLdWtrb25lbiAg PGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBVbnJldmlld2VkLCBj b21iaW5lIGNvbG9yIHByb2ZpbGUgZmFpbHVyZXMgdG8gY29ycmVjdCBidWcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc0NgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMTAtMjkgIENzYWJhIE9zenRy b2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTMyODE5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpp bmRleCA4Y2U1ZmJmMTZkODc1OGY5NDVjM2EzZGY2NTRiYzkzOGMyMzg2ZjdiLi40MzllODc5ZmRi NmFiMzAxMTMyMWEwMzhmYWRkNDJjZDE4NzI3MjU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNjU2LDYgKzY1NiwxMSBAQCBlZGl0aW5nL3Bhc3RlYm9h cmQvcGFzdGUtVElGRi5odG1sIFsgV29udEZpeCBdCiAjIFRoZSB0ZXN0IGlzIGludHJpbnNpY2Fs bHkgZmxha3kgYW5kIGNhbm5vdCBiZSBmaXhlZC4KIHdlYmtpdC5vcmcvYi8xMDAxMTcgZmFzdC94 bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1yZWN1cnNpdmUtc3luYy1ldmVudC5odG1sIFsg V29udEZpeCBdCiAKKyMgRUZMIGRvZXMgbm90IFVTRShRQ01TTElCKSBzbyBjb2xvciB0cmFuc2Zv cm1zIGFyZSBub3QgZG9uZQord2Via2l0Lm9yZy9iLzEwMDUxOSBmYXN0L2ltYWdlcy9qcGVnLXdp dGgtY29sb3ItcHJvZmlsZS5odG1sIFsgU2tpcCBdCit3ZWJraXQub3JnL2IvMTAwNTE5IGZhc3Qv aW1hZ2VzL3BuZy13aXRoLWNvbG9yLXByb2ZpbGUuaHRtbCBbIFNraXAgXQord2Via2l0Lm9yZy9i LzEwMDUxOSBmYXN0L2ltYWdlcy9wYWxldHRlZC1wbmctd2l0aC1jb2xvci1wcm9maWxlLmh0bWwg WyBTa2lwIF0KKwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgQ1JBU0hFUwog Iy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KQEAgLTE0MzgsOSArMTQ0Myw2IEBAIHdl YmtpdC5vcmcvYi8yOTM1OSBmYXN0L2Zvcm1zL3RpbWUgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8y OTM1OSBmYXN0L2Zvcm1zL3dlZWsgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi84OTIwOSBmYXN0L2Zv cm1zL2lucHV0LWluLXRhYmxlLWNlbGwtbm8tdmFsdWUuaHRtbCBbIEltYWdlT25seUZhaWx1cmUg XQogCi0jIFBhbGV0dGVkIFBORyB3aXRoIElDQyBjb2xvciBwcm9maWxlcyBub3Qgd29ya2luZy4K LXdlYmtpdC5vcmcvYi84NjcyMiBmYXN0L2ltYWdlcy9wYWxldHRlZC1wbmctd2l0aC1jb2xvci1w cm9maWxlLmh0bWwKLQogIyBUaGVzZSB0ZXN0cyBjYXVzZSBmbGFraW5lc3MgKGV4dHJhIGNvbnNv bGUgbWVzc2FnZXMgaW4gb3V0cHV0KQogd2Via2l0Lm9yZy9iLzg4NzI5IHVzZXJzY3JpcHRzL3dp bmRvdy1vbmVycm9yLWZvci1pc29sYXRlZC13b3JsZC0xLmh0bWwKIHdlYmtpdC5vcmcvYi84ODcy OSB1c2Vyc2NyaXB0cy93aW5kb3ctb25lcnJvci1mb3ItaXNvbGF0ZWQtd29ybGQtMi5odG1sCkBA IC0xNjc0LDcgKzE2NzYsMyBAQCB3ZWJraXQub3JnL2IvOTk2OTEgZ2FtZXBhZC9nYW1lcGFkLW91 dC1vZi1yYW5nZS1jcmFzaGVyLmh0bWwgWyBGYWlsdXJlIF0KIAogIyBSZXNvdXJjZSBUaW1pbmcg aXMgbm90IGVuYWJsZSB5ZXQsIHNraXAgaXQuCiB3ZWJraXQub3JnL2IvNjExMzggaHR0cC90ZXN0 cy93M2Mvd2VicGVyZi9zdWJtaXNzaW9uL0ludGVsL3Jlc291cmNlLXRpbWluZyBbIFNraXAgXQot Ci0jIFRoZSByZWQgc2VjdGlvbiBpcyByZW5kZXJlZCBhdCB0aGUgd3JvbmcgcG9zaXRpb24uCi13 ZWJraXQub3JnL2IvMTAwNTE5IGZhc3QvaW1hZ2VzL2pwZWctd2l0aC1jb2xvci1wcm9maWxlLmh0 bWwgWyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8xMDA1MTkgZmFzdC9pbWFnZXMvcG5nLXdpdGgtY29s b3ItcHJvZmlsZS5odG1sIFsgU2tpcCBdCg== 171436 2012-10-30 06:43:54 -0700 2012-10-30 07:14:19 -0700 I guess it would make sense. Changed to 'Color profiles are not currently used. See USE(QCMSLIB)'. bug-100746-20121030154218.patch text/plain 2530 jussi.kukkonen U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODc1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNmVkY2FjZGFlNzU2MmU4OTcyNGYw YTJkNjhkMWJjYzIxNmE2MDkwNC4uNDRlM2E4MWE2MmZlNWFkNGQxNDk5MzUwY2JhMDg5YmI3OTFi ZGY1OCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDEyLTEwLTMwICBKdXNzaSBLdWtrb25lbiAg PGp1c3NpLmt1a2tvbmVuQGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBVbnJldmlld2VkLCBj b21iaW5lIGNvbG9yIHByb2ZpbGUgZmFpbHVyZXMgdG8gY29ycmVjdCBidWcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDc0NgorCisgICAgICAgICog cGxhdGZvcm0vZWZsL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMTItMTAtMjkgIENzYWJhIE9zenRy b2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMTMyODE5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1Rlc3RF eHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucwpp bmRleCA4Y2U1ZmJmMTZkODc1OGY5NDVjM2EzZGY2NTRiYzkzOGMyMzg2ZjdiLi4wN2QxYmFjZjUy YmQ0Y2EyYjhhMGRlZjM0ODA3NmY2Yzc1MDljYzRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9lZmwvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9l ZmwvVGVzdEV4cGVjdGF0aW9ucwpAQCAtNjU2LDYgKzY1NiwxMSBAQCBlZGl0aW5nL3Bhc3RlYm9h cmQvcGFzdGUtVElGRi5odG1sIFsgV29udEZpeCBdCiAjIFRoZSB0ZXN0IGlzIGludHJpbnNpY2Fs bHkgZmxha3kgYW5kIGNhbm5vdCBiZSBmaXhlZC4KIHdlYmtpdC5vcmcvYi8xMDAxMTcgZmFzdC94 bWxodHRwcmVxdWVzdC94bWxodHRwcmVxdWVzdC1yZWN1cnNpdmUtc3luYy1ldmVudC5odG1sIFsg V29udEZpeCBdCiAKKyMgQ29sb3IgcHJvZmlsZXMgYXJlIG5vdCBjdXJyZW50bHkgdXNlZC4gU2Vl IFVTRShRQ01TTElCKQord2Via2l0Lm9yZy9iLzEwMDUxOSBmYXN0L2ltYWdlcy9qcGVnLXdpdGgt Y29sb3ItcHJvZmlsZS5odG1sIFsgU2tpcCBdCit3ZWJraXQub3JnL2IvMTAwNTE5IGZhc3QvaW1h Z2VzL3BuZy13aXRoLWNvbG9yLXByb2ZpbGUuaHRtbCBbIFNraXAgXQord2Via2l0Lm9yZy9iLzEw MDUxOSBmYXN0L2ltYWdlcy9wYWxldHRlZC1wbmctd2l0aC1jb2xvci1wcm9maWxlLmh0bWwgWyBT a2lwIF0KKwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgQ1JBU0hFUwogIy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KQEAgLTE0MzgsOSArMTQ0Myw2IEBAIHdlYmtp dC5vcmcvYi8yOTM1OSBmYXN0L2Zvcm1zL3RpbWUgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8yOTM1 OSBmYXN0L2Zvcm1zL3dlZWsgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi84OTIwOSBmYXN0L2Zvcm1z L2lucHV0LWluLXRhYmxlLWNlbGwtbm8tdmFsdWUuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQog Ci0jIFBhbGV0dGVkIFBORyB3aXRoIElDQyBjb2xvciBwcm9maWxlcyBub3Qgd29ya2luZy4KLXdl YmtpdC5vcmcvYi84NjcyMiBmYXN0L2ltYWdlcy9wYWxldHRlZC1wbmctd2l0aC1jb2xvci1wcm9m aWxlLmh0bWwKLQogIyBUaGVzZSB0ZXN0cyBjYXVzZSBmbGFraW5lc3MgKGV4dHJhIGNvbnNvbGUg bWVzc2FnZXMgaW4gb3V0cHV0KQogd2Via2l0Lm9yZy9iLzg4NzI5IHVzZXJzY3JpcHRzL3dpbmRv dy1vbmVycm9yLWZvci1pc29sYXRlZC13b3JsZC0xLmh0bWwKIHdlYmtpdC5vcmcvYi84ODcyOSB1 c2Vyc2NyaXB0cy93aW5kb3ctb25lcnJvci1mb3ItaXNvbGF0ZWQtd29ybGQtMi5odG1sCkBAIC0x Njc0LDcgKzE2NzYsMyBAQCB3ZWJraXQub3JnL2IvOTk2OTEgZ2FtZXBhZC9nYW1lcGFkLW91dC1v Zi1yYW5nZS1jcmFzaGVyLmh0bWwgWyBGYWlsdXJlIF0KIAogIyBSZXNvdXJjZSBUaW1pbmcgaXMg bm90IGVuYWJsZSB5ZXQsIHNraXAgaXQuCiB3ZWJraXQub3JnL2IvNjExMzggaHR0cC90ZXN0cy93 M2Mvd2VicGVyZi9zdWJtaXNzaW9uL0ludGVsL3Jlc291cmNlLXRpbWluZyBbIFNraXAgXQotCi0j IFRoZSByZWQgc2VjdGlvbiBpcyByZW5kZXJlZCBhdCB0aGUgd3JvbmcgcG9zaXRpb24uCi13ZWJr aXQub3JnL2IvMTAwNTE5IGZhc3QvaW1hZ2VzL2pwZWctd2l0aC1jb2xvci1wcm9maWxlLmh0bWwg WyBTa2lwIF0KLXdlYmtpdC5vcmcvYi8xMDA1MTkgZmFzdC9pbWFnZXMvcG5nLXdpdGgtY29sb3It cHJvZmlsZS5odG1sIFsgU2tpcCBdCg==