100744 2012-10-30 03:59:13 -0700 [BlackBerry] PurgeCredential should also purge the persisted credential store 2012-10-30 19:02:28 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 charles.wei charles.wei joenotcharles jonathan.dong.webkit mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 754185 0 charles.wei 2012-10-30 03:59:13 -0700 NetworkJob::purgeCredentials() purges the credential from the memory that fails the authentication, which means that the credential is incorrect (it could be that it is incorrect from the beginning, or that it was correct but the credential was changed on server, could be through another device, etc.) and should not be used again. We should also purge the credential record in the persistent credential storage (the CredentialBackingStore). Otherwise, the browser will read from the persistent credential storage and send the invalid credential again when challenged. 754196 1 171415 charles.wei 2012-10-30 04:06:21 -0700 Created attachment 171415 Patch 754198 2 charles.wei 2012-10-30 04:13:34 -0700 Internal tracking No: 233482 754237 3 171415 webkit.review.bot 2012-10-30 05:14:34 -0700 Comment on attachment 171415 Patch Rejecting attachment 171415 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: queue/Source/WebKit/chromium/third_party/skia/include --revision 6161 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 46>At revision 6161. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14629506 754857 4 171562 charles.wei 2012-10-30 18:40:18 -0700 Created attachment 171562 Patch 754859 5 171562 charles.wei 2012-10-30 18:41:00 -0700 Comment on attachment 171562 Patch Reviewed by George. Commit it. 754874 6 171562 webkit.review.bot 2012-10-30 19:02:22 -0700 Comment on attachment 171562 Patch Clearing flags on attachment: 171562 Committed r132976: <http://trac.webkit.org/changeset/132976> 754875 7 webkit.review.bot 2012-10-30 19:02:28 -0700 All reviewed patches have been landed. Closing bug. 171415 2012-10-30 04:06:21 -0700 2012-10-30 18:40:09 -0700 Patch bug-100744-20121030190439.patch text/plain 1997 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDU4NWE2YjA0MDA0NjAy YjZhNGFiNTdiZmJlOGYxYmRkMDljNzRkYS4uMDYyNTk4NzFhMWZjZWYwOGY4MmQzZTc5NmJkMzVh MjZhYTkwYmYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTMwICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gUHVyZ2VDcmVkZW50aWFsIHNob3VsZCBhbHNvIHB1cmdlIHRoZSBwZXJzaXN0ZWQg Y3JlZGVudGlhbCBzdG9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAwNzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBjaGFsbGVuZ2VkIGJ5IHRoZSBzZXJ2ZXIsIHdlIHdpbGwgY2hlY2sgdGhl IGNyZWRlbnRpYWwgaW4tbWVtb3J5IGFuZCBmcm9tIHRoZSBwZXJzaXN0ZW50IHN0b3JhZ2UuCisg ICAgICAgIFNvIHRoZSBpbnZhbGlkIGNyZWRlbnRpYWxzIHNob3VsZCBhbHNvIGJlIHB1cmdlZCBm cm9tIHRoZSBwZXJzaXN0ZW50IGNyZWRlbnRpYWwgc3RvcmFnZTsgT3RoZXJ3aXNlLAorICAgICAg ICBpdCB3aWxsIGJlIHNlbnQgdG8gdGhlIHNlcnZlciBuZXh0IHRpbWUgYmVlbiBjaGFsbGVuZ2Vk LCBpbnN0ZWFkIG9mIHByb21wdGluZyB0aGUgdXNlci4KKworICAgICAgICBObyBuZXcgdGVzdHMg KE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr Sm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtKb2I6OnB1cmdlQ3JlZGVudGlhbHMp OgorCiAyMDEyLTEwLTMwICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KIAog ICAgICAgICBPcHRpbWl6ZSB2Y2xpcCBmb3IgTkVPTiBpbiBWZWN0b3JNYXRoCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pv Yi5jcHAKaW5kZXggZTUyYTI0Y2JmZGVlNjVlOTY1NjJiYjlkZGZjMThlZmM5YzRlZGVkNS4uMzAx OGFhMmNkOTM4YmFjYzcyZTJiZDM0NzdjZTJhYWQ5YzliM2ZiYSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNw cApAQCAtMjMsNiArMjMsNyBAQAogI2luY2x1ZGUgIkNocm9tZS5oIgogI2luY2x1ZGUgIkNocm9t ZUNsaWVudC5oIgogI2luY2x1ZGUgIkNvb2tpZU1hbmFnZXIuaCIKKyNpbmNsdWRlICJDcmVkZW50 aWFsQmFja2luZ1N0b3JlLmgiCiAjaW5jbHVkZSAiQ3JlZGVudGlhbFN0b3JhZ2UuaCIKICNpbmNs dWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyQ2xpZW50QmxhY2tCZXJyeS5oIgpA QCAtODc0LDYgKzg3NSw5IEBAIHZvaWQgTmV0d29ya0pvYjo6cHVyZ2VDcmVkZW50aWFscygpCiAK ICAgICBDcmVkZW50aWFsU3RvcmFnZTo6cmVtb3ZlKGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2Uo KSk7CiAgICAgY2hhbGxlbmdlLnNldFN0b3JlZChmYWxzZSk7CisjaWYgRU5BQkxFKEJMQUNLQkVS UllfQ1JFREVOVElBTF9QRVJTSVNUKQorICAgIGNyZWRlbnRpYWxCYWNraW5nU3RvcmUoKS5yZW1v dmVMb2dpbihtX3Jlc3BvbnNlLnVybCgpLCBjaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCkpOwor I2VuZGlmCiB9CiAKIGJvb2wgTmV0d29ya0pvYjo6c2hvdWxkU2VuZENsaWVudERhdGEoKSBjb25z dAo= 171562 2012-10-30 18:40:18 -0700 2012-10-30 19:02:22 -0700 Patch bug-100744-20121031093841.patch text/plain 1964 charles.wei U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDU4NWE2YjA0MDA0NjAy YjZhNGFiNTdiZmJlOGYxYmRkMDljNzRkYS4uMzYzOGJmNzdiMTczMjMxODZkZjZkZDU0MGU3MDky MTVhOTk0NzgxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEwLTMwICBDaGFy bGVzIFdlaSAgPGNoYXJsZXMud2VpQHRvcmNobW9iaWxlLmNvbS5jbj4KKworICAgICAgICBbQmxh Y2tCZXJyeV0gUHVyZ2VDcmVkZW50aWFsIHNob3VsZCBhbHNvIHB1cmdlIHRoZSBwZXJzaXN0ZWQg Y3JlZGVudGlhbCBzdG9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAwNzQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCisK KyAgICAgICAgV2hlbiBjaGFsbGVuZ2VkIGJ5IHRoZSBzZXJ2ZXIsIHdlIHdpbGwgY2hlY2sgdGhl IGNyZWRlbnRpYWwgaW4tbWVtb3J5IGFuZCBmcm9tIHRoZSBwZXJzaXN0ZW50IHN0b3JhZ2UuCisg ICAgICAgIFNvIHRoZSBpbnZhbGlkIGNyZWRlbnRpYWxzIHNob3VsZCBhbHNvIGJlIHB1cmdlZCBm cm9tIHRoZSBwZXJzaXN0ZW50IGNyZWRlbnRpYWwgc3RvcmFnZTsgT3RoZXJ3aXNlLAorICAgICAg ICBpdCB3aWxsIGJlIHNlbnQgdG8gdGhlIHNlcnZlciBuZXh0IHRpbWUgYmVlbiBjaGFsbGVuZ2Vk LCBpbnN0ZWFkIG9mIHByb21wdGluZyB0aGUgdXNlci4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdv cmtKb2I6OnB1cmdlQ3JlZGVudGlhbHMpOgorCiAyMDEyLTEwLTMwICBHYWJvciBSYXBjc2FueWkg IDxyZ2Fib3JAd2Via2l0Lm9yZz4KIAogICAgICAgICBPcHRpbWl6ZSB2Y2xpcCBmb3IgTkVPTiBp biBWZWN0b3JNYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHAKaW5kZXggZTUyYTI0Y2JmZGVlNjVlOTY1NjJi YjlkZGZjMThlZmM5YzRlZGVkNS4uMzAxOGFhMmNkOTM4YmFjYzcyZTJiZDM0NzdjZTJhYWQ5Yzli M2ZiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2Jl cnJ5L05ldHdvcmtKb2IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv YmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcApAQCAtMjMsNiArMjMsNyBAQAogI2luY2x1ZGUgIkNo cm9tZS5oIgogI2luY2x1ZGUgIkNocm9tZUNsaWVudC5oIgogI2luY2x1ZGUgIkNvb2tpZU1hbmFn ZXIuaCIKKyNpbmNsdWRlICJDcmVkZW50aWFsQmFja2luZ1N0b3JlLmgiCiAjaW5jbHVkZSAiQ3Jl ZGVudGlhbFN0b3JhZ2UuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkZyYW1lTG9h ZGVyQ2xpZW50QmxhY2tCZXJyeS5oIgpAQCAtODc0LDYgKzg3NSw5IEBAIHZvaWQgTmV0d29ya0pv Yjo6cHVyZ2VDcmVkZW50aWFscygpCiAKICAgICBDcmVkZW50aWFsU3RvcmFnZTo6cmVtb3ZlKGNo YWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKSk7CiAgICAgY2hhbGxlbmdlLnNldFN0b3JlZChmYWxz ZSk7CisjaWYgRU5BQkxFKEJMQUNLQkVSUllfQ1JFREVOVElBTF9QRVJTSVNUKQorICAgIGNyZWRl bnRpYWxCYWNraW5nU3RvcmUoKS5yZW1vdmVMb2dpbihtX3Jlc3BvbnNlLnVybCgpLCBjaGFsbGVu Z2UucHJvdGVjdGlvblNwYWNlKCkpOworI2VuZGlmCiB9CiAKIGJvb2wgTmV0d29ya0pvYjo6c2hv dWxkU2VuZENsaWVudERhdGEoKSBjb25zdAo=