100737 2012-10-30 02:00:00 -0700 Optimize vclip for NEON in VectorMath 2013-02-26 21:43:01 -0800 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rgabor webkit-unassigned crogers eric.carlson feature-media-reviews kdj.tikka s.choi webkit.review.bot oldest_to_newest 754081 0 rgabor 2012-10-30 02:00:00 -0700 Optimize vclip for NEON in VectorMath. 754123 1 171404 rgabor 2012-10-30 02:40:59 -0700 Created attachment 171404 proposed patch I have made independent tests on this function. The vector size was 1000 with float numbers and I ran it 100 000 times. The average results: REF elapsed time is 1219 ms NEON elapsed time is 427 ms 754174 2 171404 webkit.review.bot 2012-10-30 03:51:01 -0700 Comment on attachment 171404 proposed patch Clearing flags on attachment: 171404 Committed r132890: <http://trac.webkit.org/changeset/132890> 754175 3 webkit.review.bot 2012-10-30 03:51:05 -0700 All reviewed patches have been landed. Closing bug. 840719 4 kdj.tikka 2013-02-24 23:18:45 -0800 Hi all, Here on top of this patch i would like to submit more optimized ARM-NEON solution. Please let me know, is it OK to submit here ? or should i create new bug. Regards, kdj 840722 5 rgabor 2013-02-24 23:27:37 -0800 (In reply to comment #4) > Hi all, > > Here on top of this patch i would like to submit more optimized ARM-NEON solution. > > Please let me know, is it OK to submit here ? > or should i create new bug. > > Regards, > kdj Hello! That's good but this patch landed so you should make another bug for yours. Please CC me as well :) 171404 2012-10-30 02:40:59 -0700 2012-10-30 03:51:01 -0700 proposed patch vectormath_vclip.patch text/plain 1791 rgabor SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjg4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTMwICBHYWJvciBS YXBjc2FueWkgIDxyZ2Fib3JAd2Via2l0Lm9yZz4KKworICAgICAgICBPcHRpbWl6ZSB2Y2xpcCBm b3IgTkVPTiBpbiBWZWN0b3JNYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDA3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTcGVlZCB1cCB2Y2xpcCBpbiBWZWN0b3JNYXRoIHdpdGggTkVPTiBpbnRy aW5zaWNzLgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vVmVjdG9yTWF0aC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWZWN0b3JNYXRoOjp2Y2xpcCk6CisKIDIwMTItMTAtMzAgIFl1cnkgU2Vt aWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTWVtb3J5IGluc3RydW1l bnRhdGlvbjogcmVwb3J0IGFjdHVhbCBvYmplY3QgYWRkcmVzcyBmb3IgQ2FjaGVkUmVzb3VyY2VD bGllbnRzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9WZWN0b3JNYXRoLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9WZWN0b3JNYXRo LmNwcAkocmV2aXNpb24gMTMyODgyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v VmVjdG9yTWF0aC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1NSw3ICs2NTUsMjIgQEAgdm9pZCB2 Y2xpcChjb25zdCBmbG9hdCogc291cmNlUCwgaW50IHNvdQogICAgIGZsb2F0IGhpZ2hUaHJlc2hv bGQgPSAqaGlnaFRocmVzaG9sZFA7CiAKICAgICAvLyBGSVhNRTogT3B0aW1pemUgZm9yIFNTRTIu Ci0gICAgLy8gRklYTUU6IE9wdGltaXplIGZvciBORU9OLgorI2lmIEhBVkUoQVJNX05FT05fSU5U UklOU0lDUykKKyAgICBpZiAoKHNvdXJjZVN0cmlkZSA9PSAxKSAmJiAoZGVzdFN0cmlkZSA9PSAx KSkgeworICAgICAgICBpbnQgdGFpbEZyYW1lcyA9IG4gJSA0OworICAgICAgICBjb25zdCBmbG9h dCogZW5kUCA9IGRlc3RQICsgbiAtIHRhaWxGcmFtZXM7CisKKyAgICAgICAgZmxvYXQzMng0X3Qg bG93ID0gdmR1cHFfbl9mMzIobG93VGhyZXNob2xkKTsKKyAgICAgICAgZmxvYXQzMng0X3QgaGln aCA9IHZkdXBxX25fZjMyKGhpZ2hUaHJlc2hvbGQpOworICAgICAgICB3aGlsZSAoZGVzdFAgPCBl bmRQKSB7CisgICAgICAgICAgICBmbG9hdDMyeDRfdCBzb3VyY2UgPSB2bGQxcV9mMzIoc291cmNl UCk7CisgICAgICAgICAgICB2c3QxcV9mMzIoZGVzdFAsIHZtYXhxX2YzMih2bWlucV9mMzIoc291 cmNlLCBoaWdoKSwgbG93KSk7CisgICAgICAgICAgICBzb3VyY2VQICs9IDQ7CisgICAgICAgICAg ICBkZXN0UCArPSA0OworICAgICAgICB9CisgICAgICAgIG4gPSB0YWlsRnJhbWVzOworICAgIH0K KyNlbmRpZgogICAgIHdoaWxlIChuLS0pIHsKICAgICAgICAgKmRlc3RQID0gc3RkOjptYXgoc3Rk OjptaW4oKnNvdXJjZVAsIGhpZ2hUaHJlc2hvbGQpLCBsb3dUaHJlc2hvbGQpOwogICAgICAgICBz b3VyY2VQICs9IHNvdXJjZVN0cmlkZTsK