100731 2012-10-30 00:34:11 -0700 [EFL][WK2] Let Ecore_Evas own the cursor object 2012-10-30 01:54:53 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth laszlo.gombos lucas.de.marchi mikhail.pozdnyakov rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 754024 0 cdumez 2012-10-30 00:34:11 -0700 We currently have EwkViewImpl own the cursor Evas Object although Ecore_Evas can take of it by itself. When calling ecore_evas_object_cursor_set(), the Ecore_Evas code will free the currently set cursor object (calling evas_object_del) before setting the new one. Therefore, we don't need to do that by ourselves and do reference counting. 754039 1 171386 cdumez 2012-10-30 00:53:51 -0700 Created attachment 171386 Patch 754076 2 171386 webkit.review.bot 2012-10-30 01:54:49 -0700 Comment on attachment 171386 Patch Clearing flags on attachment: 171386 Committed r132880: <http://trac.webkit.org/changeset/132880> 754077 3 webkit.review.bot 2012-10-30 01:54:53 -0700 All reviewed patches have been landed. Closing bug. 171386 2012-10-30 00:53:51 -0700 2012-10-30 01:54:49 -0700 Patch 100731_cursorObject.patch text/plain 4082 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiNDExZDdiLi5iN2JjYzU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMTAtMzAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIExldCBFY29yZV9FdmFzIG93biB0aGUgY3Vyc29y IG9iamVjdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTAwNzMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RWNvcmVfRXZhcyB0YWtlcyBjYXJlIG9mIGNhbGxpbmcgZXZhc19vYmplY3RfZGVsKCkgb24KKyAg ICAgICAgdGhlIGN1cnNvciBvYmplY3Qgd2hlbiBpdCBpcyBubyBsb25nZXIgdXNlZCAoZS5nLiB3 aGVuCisgICAgICAgIGl0IGlzIHJlcGxhY2VkIGJ5IGFub3RoZXIgY3Vyc29yIG9iamVjdCkuIFRo ZXJlZm9yZSwKKyAgICAgICAgd2UgZG9uJ3QgbmVlZCB0byBrZWVwIGEgUmVmUHRyIHRvIHRoZSBj dXJzb3IgRXZhcworICAgICAgICBPYmplY3QgYXMgYSBkYXRhIG1lbWJlciBvZiBFd2tWaWV3SW1w bC4gV2UgcGFzcworICAgICAgICBvd25lcnNoaXAgb2YgdGhlIGN1cnNvciBvYmplY3QgdG8gRWNv cmVfRXZhcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcDoK KyAgICAgICAgKEV3a1ZpZXdJbXBsOjpzZXRDdXJzb3IpOgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvZWZsL0V3a1ZpZXdJbXBsLmg6CisgICAgICAgIChFd2tWaWV3SW1wbCk6CisKIDIwMTItMTAt MjkgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTihyMTMwNzU1KTogQWxsIFdlYktpdDIgdW5pdCB0ZXN0cyBhcmUgZmFpbGluZyBp biBXZWJLaXQyIGJvdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvRXdrVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdr Vmlld0ltcGwuY3BwCmluZGV4IGViZTUxNmQuLjVmZmY1OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5jcHAKQEAgLTE5NCwxMiArMTk0LDEw IEBAIHZvaWQgRXdrVmlld0ltcGw6OnNldEN1cnNvcihjb25zdCBDdXJzb3ImIGN1cnNvcikKIAog ICAgIG1fY3Vyc29yR3JvdXAgPSBncm91cDsKICAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzZCA9 IHNtYXJ0RGF0YSgpOwotICAgIG1fY3Vyc29yT2JqZWN0ID0gYWRvcHRSZWYoZWRqZV9vYmplY3Rf YWRkKHNkLT5iYXNlLmV2YXMpKTsKKyAgICBSZWZQdHI8RXZhc19PYmplY3Q+IGN1cnNvck9iamVj dCA9IGFkb3B0UmVmKGVkamVfb2JqZWN0X2FkZChzZC0+YmFzZS5ldmFzKSk7CiAKICAgICBFY29y ZV9FdmFzKiBlY29yZUV2YXMgPSBlY29yZV9ldmFzX2Vjb3JlX2V2YXNfZ2V0KHNkLT5iYXNlLmV2 YXMpOwotICAgIGlmICghbV90aGVtZSB8fCAhZWRqZV9vYmplY3RfZmlsZV9zZXQobV9jdXJzb3JP YmplY3QuZ2V0KCksIG1fdGhlbWUsIGdyb3VwKSkgewotICAgICAgICBtX2N1cnNvck9iamVjdC5j bGVhcigpOwotCisgICAgaWYgKCFtX3RoZW1lIHx8ICFlZGplX29iamVjdF9maWxlX3NldChjdXJz b3JPYmplY3QuZ2V0KCksIG1fdGhlbWUsIGdyb3VwKSkgewogICAgICAgICBlY29yZV9ldmFzX29i amVjdF9jdXJzb3Jfc2V0KGVjb3JlRXZhcywgMCwgMCwgMCwgMCk7CiAjaWZkZWYgSEFWRV9FQ09S RV9YCiAgICAgICAgIGlmIChXZWJDb3JlOjppc1VzaW5nRWNvcmVYKHNkLT5iYXNlLmV2YXMpKQpA QCAtMjA4LDI4ICsyMDYsMzEgQEAgdm9pZCBFd2tWaWV3SW1wbDo6c2V0Q3Vyc29yKGNvbnN0IEN1 cnNvciYgY3Vyc29yKQogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgLy8gU2V0IGN1cnNv ciBzaXplLgogICAgIEV2YXNfQ29vcmQgd2lkdGgsIGhlaWdodDsKLSAgICBlZGplX29iamVjdF9z aXplX21pbl9nZXQobV9jdXJzb3JPYmplY3QuZ2V0KCksICZ3aWR0aCwgJmhlaWdodCk7CisgICAg ZWRqZV9vYmplY3Rfc2l6ZV9taW5fZ2V0KGN1cnNvck9iamVjdC5nZXQoKSwgJndpZHRoLCAmaGVp Z2h0KTsKICAgICBpZiAod2lkdGggPD0gMCB8fCBoZWlnaHQgPD0gMCkKLSAgICAgICAgZWRqZV9v YmplY3Rfc2l6ZV9taW5fY2FsYyhtX2N1cnNvck9iamVjdC5nZXQoKSwgJndpZHRoLCAmaGVpZ2h0 KTsKKyAgICAgICAgZWRqZV9vYmplY3Rfc2l6ZV9taW5fY2FsYyhjdXJzb3JPYmplY3QuZ2V0KCks ICZ3aWR0aCwgJmhlaWdodCk7CiAgICAgaWYgKHdpZHRoIDw9IDAgfHwgaGVpZ2h0IDw9IDApIHsK ICAgICAgICAgd2lkdGggPSBkZWZhdWx0Q3Vyc29yU2l6ZTsKICAgICAgICAgaGVpZ2h0ID0gZGVm YXVsdEN1cnNvclNpemU7CiAgICAgfQotICAgIGV2YXNfb2JqZWN0X3Jlc2l6ZShtX2N1cnNvck9i amVjdC5nZXQoKSwgd2lkdGgsIGhlaWdodCk7CisgICAgZXZhc19vYmplY3RfcmVzaXplKGN1cnNv ck9iamVjdC5nZXQoKSwgd2lkdGgsIGhlaWdodCk7CiAKKyAgICAvLyBHZXQgY3Vyc29yIGhvdCBz cG90LgogICAgIGNvbnN0IGNoYXIqIGRhdGE7CiAgICAgaW50IGhvdHNwb3RYID0gMDsKLSAgICBk YXRhID0gZWRqZV9vYmplY3RfZGF0YV9nZXQobV9jdXJzb3JPYmplY3QuZ2V0KCksICJob3QueCIp OworICAgIGRhdGEgPSBlZGplX29iamVjdF9kYXRhX2dldChjdXJzb3JPYmplY3QuZ2V0KCksICJo b3QueCIpOwogICAgIGlmIChkYXRhKQogICAgICAgICBob3RzcG90WCA9IGF0b2koZGF0YSk7CiAK ICAgICBpbnQgaG90c3BvdFkgPSAwOwotICAgIGRhdGEgPSBlZGplX29iamVjdF9kYXRhX2dldCht X2N1cnNvck9iamVjdC5nZXQoKSwgImhvdC55Iik7CisgICAgZGF0YSA9IGVkamVfb2JqZWN0X2Rh dGFfZ2V0KGN1cnNvck9iamVjdC5nZXQoKSwgImhvdC55Iik7CiAgICAgaWYgKGRhdGEpCiAgICAg ICAgIGhvdHNwb3RZID0gYXRvaShkYXRhKTsKIAotICAgIGVjb3JlX2V2YXNfb2JqZWN0X2N1cnNv cl9zZXQoZWNvcmVFdmFzLCBtX2N1cnNvck9iamVjdC5nZXQoKSwgRVZBU19MQVlFUl9NQVgsIGhv dHNwb3RYLCBob3RzcG90WSk7CisgICAgLy8gZWNvcmVfZXZhcyB0YWtlcyBjYXJlIG9mIGZyZWVp bmcgdGhlIGN1cnNvciBvYmplY3QuCisgICAgZWNvcmVfZXZhc19vYmplY3RfY3Vyc29yX3NldChl Y29yZUV2YXMsIGN1cnNvck9iamVjdC5yZWxlYXNlKCkubGVha1JlZigpLCBFVkFTX0xBWUVSX01B WCwgaG90c3BvdFgsIGhvdHNwb3RZKTsKIH0KIAogdm9pZCBFd2tWaWV3SW1wbDo6ZGlzcGxheVRp bWVyRmlyZWQoV2ViQ29yZTo6VGltZXI8RXdrVmlld0ltcGw+KikKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBsLmggYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3SW1wbC5oCmluZGV4IDIyMWNkZTIuLmE5NDFjZWUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXdJbXBs LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlld0ltcGwuaApA QCAtMjU5LDcgKzI1OSw2IEBAIHByaXZhdGU6CiAgICAgRXZhc19HTF9TdXJmYWNlKiBtX2V2YXNH bFN1cmZhY2U7CiAjZW5kaWYKICAgICBPd25QdHI8RXdrX1NldHRpbmdzPiBtX3NldHRpbmdzOwot ICAgIFJlZlB0cjxFdmFzX09iamVjdD4gbV9jdXJzb3JPYmplY3Q7CiAgICAgY29uc3QgY2hhciog bV9jdXJzb3JHcm91cDsgLy8gVGhpcyBpcyBhbiBhZGRyZXNzLCBkbyBub3QgZnJlZSBpdCBvciB1 c2UgV0tFaW5hU2hhcmVkU3RyaW5nLgogICAgIFdLRWluYVNoYXJlZFN0cmluZyBtX2Zhdmljb25V Ukw7CiAgICAgV0tFaW5hU2hhcmVkU3RyaW5nIG1fdXJsOwo=