100727 2012-10-29 23:01:56 -0700 [Qt][Mac] r132858 broke the build 2012-10-30 04:05:19 -0700 1 1 1 Unclassified WebKit New Bugs 420+ All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 100701 1 ossy webkit-unassigned andersca hausmann mitz noam ossy rafael.lobo vestbo webkit.review.bot oldest_to_newest 754000 0 ossy 2012-10-29 23:01:56 -0700 /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:37:5: error: use of undeclared identifier 'CFIndex' CFIndex length = CFStringGetLength(string); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:39:89: error: use of undeclared identifier 'kCFStringEncodingISOLatin1' if (const LChar* ptr = reinterpret_cast<const LChar*>(CFStringGetCStringPtr(string, kCFStringEncodingISOLatin1))) ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:40:25: error: call to non-static member function without an object argument return add(ptr, length); ^~~~~~ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:42:15: error: unknown type name 'UniChar'; did you mean 'UChar'? if (const UniChar* ptr = CFStringGetCharactersPtr(string)) ^~~~~~~ UChar /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/icu/unicode/umachine.h:316:22: note: 'UChar' declared here typedef uint16_t UChar; ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:42:30: error: use of undeclared identifier 'CFStringGetCharactersPtr' if (const UniChar* ptr = CFStringGetCharactersPtr(string)) ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:43:57: error: call to non-static member function without an object argument return add(reinterpret_cast<const UChar*>(ptr), length); ^~~~~~ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:45:12: error: use of undeclared identifier 'UniChar'; did you mean 'UChar'? Vector<UniChar, 1024> ucharBuffer(length); ^ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:46:50: error: call to non-static member function without an object argument CFStringGetCharacters(string, CFRangeMake(0, length), ucharBuffer.data()); ^~~~~~ /Users/indt/Development/build-slaves/indt-mountainlion/qt-mountainlion-release/build/Source/WebCore/platform/text/cf/AtomicStringCF.cpp:47:47: error: use of undeclared identifier 'ucharBuffer' return add(reinterpret_cast<const UChar*>(ucharBuffer.data()), length); ^ 9 errors generated. make[3]: *** [obj/release/platform/text/cf/AtomicStringCF.o] Error 1 754057 1 171394 kadam 2012-10-30 01:33:56 -0700 Created attachment 171394 proposed patch Include missing header. 754064 2 171394 webkit.review.bot 2012-10-30 01:37:17 -0700 Comment on attachment 171394 proposed patch Rejecting attachment 171394 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/14643033 754071 3 171399 kadam 2012-10-30 01:44:11 -0700 Created attachment 171399 proposed patch Fix ChangeLog. 754191 4 171399 ossy 2012-10-30 04:05:12 -0700 Comment on attachment 171399 proposed patch Clearing flags on attachment: 171399 Committed r132891: <http://trac.webkit.org/changeset/132891> 754192 5 ossy 2012-10-30 04:05:19 -0700 All reviewed patches have been landed. Closing bug. 171394 2012-10-30 01:33:56 -0700 2012-10-30 01:44:11 -0700 proposed patch buildfix20121028.patch text/plain 977 kadam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNzk3ODczLi5kZGEzZDU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTItMTAtMzAgIMOBZMOhbSBLYWxsYWkgIDxrYWRhbUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgW1F0XVtNYWNdIEJ1aWxkIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDcyNy4KKworICAgICAgICBTcGVjdWxhdGl2ZSBidWls ZCBmaXggYWZ0ZXIgMTMyODU4LiBJbmNsdWRlIG1pc3NpbmcgQ29yZUZvdW5kYXRpb24vQ29yZUZv dW5kYXRpb24uaCBoZWFkZXIuCisKKyAgICAgICAgKiBwbGF0Zm9ybS90ZXh0L2NmL0F0b21pY1N0 cmluZ0NGLmNwcDoKKwogMjAxMi0xMC0yOSAgU2hpbnlhIEthd2FuYWthICA8c2hpbnlha0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW1JlZmF0b3JpbmddIFJlbW92ZSBFbGVtZW50U2hhZG93Ojpp bnNlcnRpb25Qb2ludEZvcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9jZi9BdG9taWNTdHJpbmdDRi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2Nm L0F0b21pY1N0cmluZ0NGLmNwcAppbmRleCA1ZGU1MzQ4Li5iMjJhOTlkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2NmL0F0b21pY1N0cmluZ0NGLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2NmL0F0b21pY1N0cmluZ0NGLmNwcApAQCAtMjgs NiArMjgsNyBAQAogCiAjaWYgVVNFKENGKQogCisjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ29y ZUZvdW5kYXRpb24uaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIG5hbWVzcGFj ZSBXVEYgewo= 171399 2012-10-30 01:44:11 -0700 2012-10-30 04:05:12 -0700 proposed patch buildfix20121028.patch text/plain 988 kadam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNzk3ODczLi5kZGEzZDU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTItMTAtMzAgIMOBZMOhbSBLYWxsYWkgIDxrYWRhbUBpbmYudS1zemVnZWQuaHU+CisK KyAgICAgICAgW1F0XVtNYWNdIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNzI3LgorCisgICAgICAgIFNwZWN1 bGF0aXZlIGJ1aWxkIGZpeCBhZnRlciAxMzI4NTguIEluY2x1ZGUgbWlzc2luZyBDb3JlRm91bmRh dGlvbi9Db3JlRm91bmRhdGlvbi5oIGhlYWRlci4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQv Y2YvQXRvbWljU3RyaW5nQ0YuY3BwOgorCiAyMDEyLTEwLTI5ICBTaGlueWEgS2F3YW5ha2EgIDxz aGlueWFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbUmVmYXRvcmluZ10gUmVtb3ZlIEVsZW1l bnRTaGFkb3c6Omluc2VydGlvblBvaW50Rm9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L2NmL0F0b21pY1N0cmluZ0NGLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvY2YvQXRvbWljU3RyaW5nQ0YuY3BwCmluZGV4IDVkZTUzNDguLmIyMmE5OWQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvY2YvQXRvbWljU3RyaW5nQ0Yu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvY2YvQXRvbWljU3RyaW5nQ0Yu Y3BwCkBAIC0yOCw2ICsyOCw3IEBACiAKICNpZiBVU0UoQ0YpCiAKKyNpbmNsdWRlIDxDb3JlRm91 bmRhdGlvbi9Db3JlRm91bmRhdGlvbi5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4K IAogbmFtZXNwYWNlIFdURiB7Cg==