100714 2012-10-29 18:11:27 -0700 Temporarily restrict use of ImageBufferSkia::copyToPlatformTexture until bugs resolved 2012-11-01 11:16:12 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 100715 100971 1 kbr kbr dino gman junov senorblanco webkit.review.bot zmo oldest_to_newest 753906 0 kbr 2012-10-29 18:11:27 -0700 Per http://crbug.com/153925, there are failures of the WebGL conformance test https://www.khronos.org/registry/webgl/sdk/tests/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html with the accelerated canvas -> WebGL texture upload path because glCopyTextureCHROMIUM doesn't handle all cases -- in particular, when the destination texture is not renderable. While we are determining how to fix either the implementation of this API or the API itself, it's important to get this test passing again, so we should disable the optimized upload path temporarily. Note that I am not sure why this has not been caught by the layout test fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html. Will look into this. 753908 1 kbr 2012-10-29 18:14:17 -0700 https://bugs.webkit.org/show_bug.cgi?id=100715 filed about re-enabling this code path. 753910 2 171352 kbr 2012-10-29 18:19:06 -0700 Created attachment 171352 Patch 754595 3 171352 kbr 2012-10-30 12:44:19 -0700 Comment on attachment 171352 Patch I'm going to try a different approach suggested by senorblanco on http://code.google.com/p/chromium/issues/detail?id=153925 . 754614 4 kbr 2012-10-30 13:05:12 -0700 Changing synopsis to indicate that this is no longer a Chromium-specific bug, since the workaround will go in shared code. 754626 5 171512 kbr 2012-10-30 13:34:20 -0700 Created attachment 171512 Patch 754651 6 171512 senorblanco 2012-10-30 14:12:57 -0700 Comment on attachment 171512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171512&action=review OK, bots willing. It's a shame that there isn't a failing test that could go green (maybe our Mesa layer allows 5551 to be bound for rendering?) r=me > Source/WebCore/platform/graphics/ImageBuffer.h:123 > + // FIXME: current implementations of this method have the restriction that they only work > + // with textures that are RGBA format and UNSIGNED_BYTE type. Nit: maybe we should just say color-renderable textures? 754717 7 171512 kbr 2012-10-30 15:24:48 -0700 Comment on attachment 171512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171512&action=review > It's a shame that there isn't a failing test that could go green (maybe our Mesa layer allows 5551 to be bound for rendering?) Are we even testing accelerated 2D canvas in the platform/virtual/gpu versions of these tests? If so, then yes, Mesa is probably treating 5551 textures as color-renderable. >> Source/WebCore/platform/graphics/ImageBuffer.h:123 >> + // with textures that are RGBA format and UNSIGNED_BYTE type. > > Nit: maybe we should just say color-renderable textures? I would rather the comment match the check in the code, and it's infeasible to figure out up front which formats are color-renderable. (On AMD cards on OS X, RGBA/5551 textures are renderable.) 754780 8 171512 senorblanco 2012-10-30 16:35:43 -0700 Comment on attachment 171512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171512&action=review >>> Source/WebCore/platform/graphics/ImageBuffer.h:123 >>> + // with textures that are RGBA format and UNSIGNED_BYTE type. >> >> Nit: maybe we should just say color-renderable textures? > > I would rather the comment match the check in the code, and it's infeasible to figure out up front which formats are color-renderable. (On AMD cards on OS X, RGBA/5551 textures are renderable.) But the check is not actually in this code, it's in the caller. So technically this function would work with anything color-renderable. You could say something like "current implementations of this method are not guaranteed to work with anything other than RGBA/UNSIGNED_BYTE". Although if I read the spec correctly, even that is not true, since the GLES2 spec only requires at a minimum that one of RGBA4, RGB5_1 or RGB565 be color-renderable, and it's up to you and a bunch of glCheckFramebufferStatus() to figure it out. Yuck. Anyway this is all No Big Deal. You may go about your business. 754802 9 171512 webkit.review.bot 2012-10-30 17:00:33 -0700 Comment on attachment 171512 Patch Clearing flags on attachment: 171512 Committed r132965: <http://trac.webkit.org/changeset/132965> 754803 10 webkit.review.bot 2012-10-30 17:00:37 -0700 All reviewed patches have been landed. Closing bug. 171352 2012-10-29 18:19:06 -0700 2012-10-30 13:34:18 -0700 Patch bug-100714-20121029181732.patch text/plain 3036 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWM2NGQzNGI3NzRmOTQ1 YTc0MDg2ZGM0NmFkNjI5YWVjYzliODcwNS4uN2NjZGM4MDdhM2M1Yjg5NTg3MWRjMGRmMGRkMTJi NGRkMTQ5Y2U4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTI5ICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIFRlbXBv cmFyaWx5IGRpc2FibGUgSW1hZ2VCdWZmZXJTa2lhOjpjb3B5VG9QbGF0Zm9ybVRleHR1cmUgdW50 aWwgYnVncyByZXNvbHZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTAwNzE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVtb3ZlZCBjb2RlIHBhdGggdW50aWwgaXNzdWVzIHdpdGggZ2xDb3B5VGV4dHVy ZUNIUk9NSVVNIEFQSSBhcmUKKyAgICAgICAgcmVzb2x2ZWQuIE1hbnVhbGx5IHRlc3RlZCB3aXRo IFdlYkdMIGNvbmZvcm1hbmNlIHRlc3QKKyAgICAgICAgdGV4LWltYWdlLWFuZC1zdWItaW1hZ2Ut MmQtd2l0aC1jYW52YXMtcmdiYTU1NTEuaHRtbCBpbiBDaHJvbWUgb24KKyAgICAgICAgTlZJRElB IGhhcmR3YXJlIG9uIE1hYyBPUy4gSSBhbSBub3Qgc3VyZSByaWdodCBub3cgd2h5IHRoaXMKKyAg ICAgICAgZmFpbHVyZSB3YXMgbm90IGNhdWdodCBieSB0aGUgc2FtZSBsYXlvdXQgdGVzdCBpbiBE UlQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6Y29weVRvUGxhdGZvcm1UZXh0dXJl KToKKwogMjAxMi0xMC0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgog CiAgICAgICAgIEZpeCBXaW5kb3dzIGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCmluZGV4IGFkNDdj ZjRiMmVjNjQ5MzA2ODdlNmViNTNiYzIzNjhiNzllNjcwYTMuLmQzYzkzY2IyMWJlNmUzYTVhNTk2 M2VhY2M4ODhhZmYzMWUzY2E0OGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHAKQEAgLTE3MiwzMCArMTcy LDEwIEBAIFBsYXRmb3JtTGF5ZXIqIEltYWdlQnVmZmVyOjpwbGF0Zm9ybUxheWVyKCkgY29uc3QK IAogYm9vbCBJbWFnZUJ1ZmZlcjo6Y29weVRvUGxhdGZvcm1UZXh0dXJlKEdyYXBoaWNzQ29udGV4 dDNEJiBjb250ZXh0LCBQbGF0Zm9ybTNET2JqZWN0IHRleHR1cmUsIEdDM0RlbnVtIGludGVybmFs Rm9ybWF0LCBib29sIHByZW11bHRpcGx5QWxwaGEsIGJvb2wgZmxpcFkpCiB7Ci0gICAgaWYgKCFt X2RhdGEubV9sYXllckJyaWRnZSB8fCAhcGxhdGZvcm1MYXllcigpKQotICAgICAgICByZXR1cm4g ZmFsc2U7Ci0KLSAgICBQbGF0Zm9ybTNET2JqZWN0IHNvdXJjZVRleHR1cmUgPSBtX2RhdGEubV9s YXllckJyaWRnZS0+YmFja0J1ZmZlclRleHR1cmUoKTsKLQotICAgIGlmICghY29udGV4dC5tYWtl Q29udGV4dEN1cnJlbnQoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgRXh0ZW5zaW9u czNEKiBleHRlbnNpb25zID0gY29udGV4dC5nZXRFeHRlbnNpb25zKCk7Ci0gICAgaWYgKCFleHRl bnNpb25zLT5zdXBwb3J0cygiR0xfQ0hST01JVU1fY29weV90ZXh0dXJlIikgfHwgIWV4dGVuc2lv bnMtPnN1cHBvcnRzKCJHTF9DSFJPTUlVTV9mbGlweSIpKQotICAgICAgICByZXR1cm4gZmFsc2U7 Ci0KLSAgICAvLyBUaGUgY2FudmFzIGlzIHN0b3JlZCBpbiBhIHByZW11bHRpcGxpZWQgZm9ybWF0 LCBzbyB1bnByZW11bHRpcGx5IGlmIG5lY2Vzc2FyeS4KLSAgICBjb250ZXh0LnBpeGVsU3RvcmVp KEV4dGVuc2lvbnMzRDo6VU5QQUNLX1VOUFJFTVVMVElQTFlfQUxQSEFfQ0hST01JVU0sICFwcmVt dWx0aXBseUFscGhhKTsKLQotICAgIC8vIFRoZSBjYW52YXMgaXMgc3RvcmVkIGluIGFuIGludmVy dGVkIHBvc2l0aW9uLCBzbyB0aGUgZmxpcCBzZW1hbnRpY3MgYXJlIHJldmVyc2VkLgotICAgIGNv bnRleHQucGl4ZWxTdG9yZWkoRXh0ZW5zaW9uczNEOjpVTlBBQ0tfRkxJUF9ZX0NIUk9NSVVNLCAh ZmxpcFkpOwotCi0gICAgZXh0ZW5zaW9ucy0+Y29weVRleHR1cmVDSFJPTUlVTShHcmFwaGljc0Nv bnRleHQzRDo6VEVYVFVSRV8yRCwgc291cmNlVGV4dHVyZSwgdGV4dHVyZSwgMCwgaW50ZXJuYWxG b3JtYXQpOwotCi0gICAgY29udGV4dC5waXhlbFN0b3JlaShFeHRlbnNpb25zM0Q6OlVOUEFDS19G TElQX1lfQ0hST01JVU0sIGZhbHNlKTsKLSAgICBjb250ZXh0LnBpeGVsU3RvcmVpKEV4dGVuc2lv bnMzRDo6VU5QQUNLX1VOUFJFTVVMVElQTFlfQUxQSEFfQ0hST01JVU0sIGZhbHNlKTsKLSAgICBj b250ZXh0LmZsdXNoKCk7Ci0gICAgcmV0dXJuIHRydWU7CisgICAgLy8gRklYTUU6IHJlLWludHJv ZHVjZSB0aGUgR1BVLUdQVSBjb3B5IHBhdGggdmlhIEdMX0NIUk9NSVVNX2NvcHlfdGV4dHVyZSBh bmQgR0xfQ0hST01JVU1fZmxpcHkKKyAgICAvLyBvbmNlIGl0IGhhcyBiZWVuIGRldGVybWluZWQg aG93IHRvIG1ha2UgdGhlbSB3b3JrIGV2ZW4gd2hlbiB0aGUgZGVzdGluYXRpb24gdGV4dHVyZSBp cyBub3QKKyAgICAvLyByZW5kZXJhYmxlLgorICAgIHJldHVybiBmYWxzZTsKIH0KIAogdm9pZCBJ bWFnZUJ1ZmZlcjo6Y2xpcChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNvbnN0IEZsb2F0UmVj dCYgcmVjdCkgY29uc3QK 171512 2012-10-30 13:34:20 -0700 2012-10-30 17:00:33 -0700 Patch bug-100714-20121030133245.patch text/plain 3439 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyOTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODkyZmZlNTk0OTBjNzNm ZmIyZWM0NWU4NWM4OGM3YjhkOWVhOWQyZi4uYTg4NDgxZTQzNmJlNDJmY2UzMTg5YTkyOWE4YjBj MmExMGM5OTFiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEwLTMwICBLZW5u ZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KKworICAgICAgICBUZW1wb3JhcmlseSByZXN0 cmljdCB1c2Ugb2YgSW1hZ2VCdWZmZXJTa2lhOjpjb3B5VG9QbGF0Zm9ybVRleHR1cmUgdW50aWwg YnVncyByZXNvbHZlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAwNzE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRm9yIHRoZSBtb21lbnQsIG9ubHkgdXNlIEltYWdlQnVmZmVyOjpjb3B5VG9QbGF0Zm9y bVRleHR1cmUgd2hlbgorICAgICAgICBjb3B5aW5nIHRvIFJHQkEvVU5TSUdORURfQllURSB0ZXh0 dXJlcywgYW5kIGRvY3VtZW50IHJlc3RyaWN0aW9uCisgICAgICAgIGluIGhlYWRlci4gUmVzdHJp Y3Rpb24gd2lsbCBiZSBsaWZ0ZWQgb25jZSB0aGUgaW1wbGVtZW50YXRpb25zCisgICAgICAgIChj dXJyZW50bHkgb25seSBDaHJvbWl1bSBoYXMgb25lKSBoYXZlIGJlZW4gZml4ZWQ7IHNlZSBidWcg MTAwNzE1LgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgbWFudWFsbHkgcmFuIFdlYkdMIGNvbmZv cm1hbmNlIHRlc3QKKyAgICAgICAgdGV4LWltYWdlLWFuZC1zdWItaW1hZ2UtMmQtd2l0aC1jYW52 YXMtcmdiYTU1NTEuaHRtbCBvbiBOVklESUEKKyAgICAgICAgaGFyZHdhcmUgb24gTWFjIE9TLgor CisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp0 ZXhJbWFnZTJEKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oOgor ICAgICAgICAoSW1hZ2VCdWZmZXIpOgorCiAyMDEyLTEwLTMwICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBdm9pZCB1bm5lY2Vzc2FyeSBzdHlsZSByZWNhbGNz IG9uIGNsYXNzIGF0dHJpYnV0ZSBtdXRhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKaW5kZXggMWUwZWYzYTQzNmMwYzUz MGJjNjdmZmE4NDRiZDgwZjBiNDdkNDMzMy4uMDkxNTVlYzlmOTQ4NDlhMDZhZTRhZmI4OWQ4ZmVm OWUzZWRmOGQ0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHQuY3BwCkBAIC0zNjk5LDcgKzM2OTksMTEgQEAgdm9pZCBXZWJHTFJl bmRlcmluZ0NvbnRleHQ6OnRleEltYWdlMkQoR0MzRGVudW0gdGFyZ2V0LCBHQzNEaW50IGxldmVs LCBHQzNEZW51bQogICAgIFdlYkdMVGV4dHVyZSogdGV4dHVyZSA9IHZhbGlkYXRlVGV4dHVyZUJp bmRpbmcoInRleEltYWdlMkQiLCB0YXJnZXQsIHRydWUpOwogICAgIC8vIElmIHBvc3NpYmxlLCBj b3B5IGZyb20gdGhlIGNhbnZhcyBlbGVtZW50IGRpcmVjdGx5IHRvIHRoZSB0ZXh0dXJlCiAgICAg Ly8gdmlhIHRoZSBHUFUsIHdpdGhvdXQgYSByZWFkLWJhY2sgdG8gc3lzdGVtIG1lbW9yeS4KLSAg ICBpZiAoR3JhcGhpY3NDb250ZXh0M0Q6OlRFWFRVUkVfMkQgPT0gdGFyZ2V0ICYmIHRleHR1cmUg JiYgdHlwZSA9PSB0ZXh0dXJlLT5nZXRUeXBlKHRhcmdldCwgbGV2ZWwpKSB7CisgICAgLy8KKyAg ICAvLyBGSVhNRTogcmVzdHJpY3Rpb24gb2YgUkdCQS9VTlNJR05FRF9CWVRFIHNob3VsZCBiZSBs aWZ0ZWQgd2hlbgorICAgIC8vIEltYWdlQnVmZmVyOjpjb3B5VG9QbGF0Zm9ybVRleHR1cmUgaW1w bGVtZW50YXRpb25zIGFyZSBmdWxseSBmdW5jdGlvbmFsLgorICAgIGlmIChHcmFwaGljc0NvbnRl eHQzRDo6VEVYVFVSRV8yRCA9PSB0YXJnZXQgJiYgdGV4dHVyZSAmJiB0eXBlID09IHRleHR1cmUt PmdldFR5cGUodGFyZ2V0LCBsZXZlbCkKKyAgICAgICAgJiYgZm9ybWF0ID09IEdyYXBoaWNzQ29u dGV4dDNEOjpSR0JBICYmIHR5cGUgPT0gR3JhcGhpY3NDb250ZXh0M0Q6OlVOU0lHTkVEX0JZVEUp IHsKICAgICAgICAgSW1hZ2VCdWZmZXIqIGJ1ZmZlciA9IGNhbnZhcy0+YnVmZmVyKCk7CiAgICAg ICAgIGlmIChidWZmZXIgJiYgYnVmZmVyLT5jb3B5VG9QbGF0Zm9ybVRleHR1cmUoKm1fY29udGV4 dC5nZXQoKSwgdGV4dHVyZS0+b2JqZWN0KCksIGludGVybmFsZm9ybWF0LCBtX3VucGFja1ByZW11 bHRpcGx5QWxwaGEsIG1fdW5wYWNrRmxpcFkpKSB7CiAgICAgICAgICAgICB0ZXh0dXJlLT5zZXRM ZXZlbEluZm8odGFyZ2V0LCBsZXZlbCwgaW50ZXJuYWxmb3JtYXQsIGNhbnZhcy0+d2lkdGgoKSwg Y2FudmFzLT5oZWlnaHQoKSwgdHlwZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvSW1hZ2VCdWZmZXIuaAppbmRleCBmZTBhZWUwZjYwZmU3ZDk1NTYyMzdkYmRhN2FmNDI5 YjllMWNlZjIzLi41ODhlZmQxZjU0MzIzMWJhZGYwMDFhZmRiNmJkZTRiNmQ4OGQ4MjVmIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlQnVmZmVyLmgKQEAgLTEx OSw2ICsxMTksOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFBsYXRmb3JtTGF5ZXIq IHBsYXRmb3JtTGF5ZXIoKSBjb25zdDsKICNlbmRpZgogCisgICAgICAgIC8vIEZJWE1FOiBjdXJy ZW50IGltcGxlbWVudGF0aW9ucyBvZiB0aGlzIG1ldGhvZCBoYXZlIHRoZSByZXN0cmljdGlvbiB0 aGF0IHRoZXkgb25seSB3b3JrCisgICAgICAgIC8vIHdpdGggdGV4dHVyZXMgdGhhdCBhcmUgUkdC QSBmb3JtYXQgYW5kIFVOU0lHTkVEX0JZVEUgdHlwZS4KICAgICAgICAgYm9vbCBjb3B5VG9QbGF0 Zm9ybVRleHR1cmUoR3JhcGhpY3NDb250ZXh0M0QmLCBQbGF0Zm9ybTNET2JqZWN0LCBHQzNEZW51 bSwgYm9vbCwgYm9vbCk7CiAKICAgICAgICAgdm9pZCByZXBvcnRNZW1vcnlVc2FnZShNZW1vcnlP YmplY3RJbmZvKikgY29uc3Q7Cg==