100709 2012-10-29 16:17:42 -0700 Missing stderr output when using run-webkit-tests 2012-10-31 20:34:18 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tdanderson tdanderson danakj dpranke tdanderson vollick webkit.review.bot oldest_to_newest 753840 0 tdanderson 2012-10-29 16:17:42 -0700 When using run-webkit-tests, the results page will sometimes omit a portion of the stderr output corresponding to a failing test. 753843 1 danakj 2012-10-29 16:22:38 -0700 By "a portion" I think we mean everything past the first N lines, where N is something pretty small like 50. 753851 2 dpranke 2012-10-29 16:34:45 -0700 Can you post an example of this? 755471 3 171689 tdanderson 2012-10-31 11:13:20 -0700 Created attachment 171689 An example of how to reproduce 755474 4 tdanderson 2012-10-31 11:17:46 -0700 (In reply to comment #3) > Created an attachment (id=171689) [details] > An example of how to reproduce I can reproduce the problem using this patch. Using run-webkit-tests on the attached test case when the CRASH() is commented out will show the following stderr output on the results page: RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() But when CRASH() is uncommented, instead shows: RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() GraphicsContext::drawText() 1 0x10eec09 2 0x14edd7d 3 0x14f2a44 4 0x14eca39 ... Clearly GraphicsContext::drawText() is being reached, but is not being shown unless a crash is artificially invoked. Note this is cutting off everything after the first 9 lines (and not ~50 like we originally guessed). 755507 5 171696 tdanderson 2012-10-31 11:48:55 -0700 Created attachment 171696 Patch 755513 6 tdanderson 2012-10-31 11:54:40 -0700 (In reply to comment #5) > Created an attachment (id=171696) [details] > Patch This fix is based on a suggested by vollick@. To verify that we are no longer missing any stderr output in the attached sample case, I used run-webkit-tests with this patch applied. The results page showed: RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() GraphicsContext::drawText() GraphicsContext::drawText() GraphicsContext::drawText() GraphicsContext::drawText() I then replaced fprintf(stderr, "#EOF\n"); with fprintf(stderr, "*** EOF\n");. The test timed out, but the results page showed: RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() RenderBlock::layout() GraphicsContext::drawText() GraphicsContext::drawText() GraphicsContext::drawText() GraphicsContext::drawText() *** EOF No stderr output appears after *** EOF, thus #EOF is being printed to stderr at the correct time in this case. 755518 7 171696 dpranke 2012-10-31 11:58:54 -0700 Comment on attachment 171696 Patch Makes sense. 755521 8 danakj 2012-10-31 12:01:31 -0700 Nice fix :) Thanks! 755833 9 171696 webkit.review.bot 2012-10-31 20:34:15 -0700 Comment on attachment 171696 Patch Clearing flags on attachment: 171696 Committed r133120: <http://trac.webkit.org/changeset/133120> 755834 10 webkit.review.bot 2012-10-31 20:34:18 -0700 All reviewed patches have been landed. Closing bug. 171689 2012-10-31 11:13:20 -0700 2012-10-31 11:48:53 -0700 An example of how to reproduce bug-100709-20121031141143.patch text/plain 3302 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWY3ODY0NWUyZTY5ZDA5 MmFjYjkzOGU1Njg4MjJlZGY3ZmM4YmQ2OC4uZDZkYTRmZTZiZmQ2NTgyZDNjMDQwNTY4MDZjNmIw YzYwZTU1NjA4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEwLTMxICBUZXJy eSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIE1pc3Npbmcg c3RkZXJyIG91dHB1dCB3aGVuIHVzaW5nIHJ1bi13ZWJraXQtdGVzdHMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMDcwOQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdCBmb3IgcmV2aWV3IG9yIGxhbmRp bmcuIEFuIGV4YW1wbGUgb2YgaG93IHRvIHJlcHJvZHVjZSAoc2VlIGJ1ZyBkZXNjcmlwdGlvbiku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3ND b250ZXh0OjpkcmF3VGV4dCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpsYXlvdXQpOgorCiAyMDEyLTEwLTMxICBB bGV4ZWkgRmlsaXBwb3YgIDxhbHBoQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBBZGQgdG90YWwgbm9kZSB0byBuYXRpdmUgbWVtb3J5IHNuYXBzaG90IHRyZWUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3Bw CmluZGV4IDJjYTBlNjVmNjM1MTJlZjU1ZTljYTJlZjhlMmVkOTUxZmRiOTEyOTYuLjE5YmQ1NDMx NGM3ZGIwOWI1ZThjMzA1ZWM5OTIxZTcwZjUyYmQ0MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcApAQCAtMzc5LDYgKzM3 OSw4IEBAIGJvb2wgR3JhcGhpY3NDb250ZXh0OjpwYWludGluZ0Rpc2FibGVkKCkgY29uc3QKICNp ZiAhT1MoV0lOQ0UpIHx8IFBMQVRGT1JNKFFUKQogdm9pZCBHcmFwaGljc0NvbnRleHQ6OmRyYXdU ZXh0KGNvbnN0IEZvbnQmIGZvbnQsIGNvbnN0IFRleHRSdW4mIHJ1biwgY29uc3QgRmxvYXRQb2lu dCYgcG9pbnQsIGludCBmcm9tLCBpbnQgdG8pCiB7CisgICAgZnByaW50ZihzdGRlcnIsICJHcmFw aGljc0NvbnRleHQ6OmRyYXdUZXh0KClcbiIpOworICAgIENSQVNIKCk7CiAgICAgaWYgKHBhaW50 aW5nRGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcAppbmRleCBjZGE5ZDQyN2JkOTRiZDk3ZDQ4YTRiOGYzMTdmNzkwODNh MDc5ZTMyLi44YjQxZDlhNDFkOTZlMjc0NzQ1NjE0NjkzZjFjZTkzZTYwZTFmMDBlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKQEAgLTEzNzgsNiArMTM3OCw3IEBA IHZvaWQgUmVuZGVyQmxvY2s6OnVwZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dCgpCiAKIHZvaWQg UmVuZGVyQmxvY2s6OmxheW91dCgpCiB7CisgICAgZnByaW50ZihzdGRlcnIsICJSZW5kZXJCbG9j azo6bGF5b3V0KClcbiIpOwogICAgIFN0YWNrU3RhdHM6OkxheW91dENoZWNrUG9pbnQgbGF5b3V0 Q2hlY2tQb2ludDsKICAgICBPdmVyZmxvd0V2ZW50RGlzcGF0Y2hlciBkaXNwYXRjaGVyKHRoaXMp OwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggMjYyYTYxMzg1NmQ0NjRmNmYyYWM2OWU2NDRlMWI3ZGNkZWE3MmQ2Zi4uYmIx NDJiODMwNjJmMjIyMmExZjM5ZThkODYwOWY0MzIzZjhmY2YwZiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDEyLTEwLTMxICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIE1pc3Npbmcgc3RkZXJyIG91dHB1dCB3aGVuIHVzaW5nIHJ1bi13ZWJraXQt dGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5v dCBmb3IgcmV2aWV3IG9yIGxhbmRpbmcuIEFuIGV4YW1wbGUgb2YgaG93IHRvIHJlcHJvZHVjZSAo c2VlIGJ1ZyBkZXNjcmlwdGlvbikuCisKKyAgICAgICAgKiBjb21wb3NpdGluZy90ZXh0LW9uLXNj YWxlZC1sYXllci5odG1sOgorCiAyMDEyLTEwLTMxICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFu Y29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkZWQgc2tpcHBlZCBleHBl Y3RhdGlvbnMgZm9yIG5ldyB0ZXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb21wb3NpdGlu Zy90ZXh0LW9uLXNjYWxlZC1sYXllci5odG1sIGIvTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdGV4 dC1vbi1zY2FsZWQtbGF5ZXIuaHRtbAppbmRleCAzYWNlYjk1ODNmNGFiOTc2NzQ1YmYyZGVjN2Fk MDg5MWEwOTlkOGVjLi5kZTAyMDk2NDA2ZmQzN2U1YzQyM2M2YjkzNmY2OTVjNGQwMWMxY2U2IDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy90ZXh0LW9uLXNjYWxlZC1sYXllci5o dG1sCisrKyBiL0xheW91dFRlc3RzL2NvbXBvc2l0aW5nL3RleHQtb24tc2NhbGVkLWxheWVyLmh0 bWwKQEAgLTEyLDcgKzEyLDcgQEAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CiAgIFRleHQgb248 YnIvPgogICBhIHNjYWxlZDxici8+CiAgIGNvbXBvc2l0ZWQ8YnIvPgotICBsYXllcjxici8+Cisg IGxheWVyIC0gc2hvdWxkIGZhaWw8YnIvPgogICA8L2Rpdj4KIDwvZGl2PgogPC9ib2R5Pgo= 171696 2012-10-31 11:48:55 -0700 2012-10-31 20:34:14 -0700 Patch bug-100709-20121031144718.patch text/plain 1826 tdanderson U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMDQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTA4NmYwOWQyY2U2YjYyNWE2MzZlZGFiYWY3ZjI0ZGVi Yzg1NGI4Yi4uM2EzZmMxODQxMGVkNzY2ODllYTc3MTM4NjMyMGNhOTgwNGRlZGI5YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTEwLTMxICBUZXJyeSBBbmRlcnNvbiAgPHRkYW5kZXJzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIE1pc3Npbmcgc3RkZXJyIG91dHB1dCB3aGVuIHVzaW5nIHJ1bi13ZWJraXQt dGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MDcwOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFw cGVuZHMgI0VPRiB0byB0aGUgZW5kIG9mIHRoZSBzdGRlcnIgb3V0cHV0IG9ubHkgYXQgdGhlIGVu ZCBvZiBhIHRlc3QsCisgICAgICAgIG5vdCBwb3NzaWJseSBwYXJ0LXdheSB0aHJvdWdoLiBUaGlz IHdpbGwgYWxsb3cgYWxsIG9mIHRoZSBzdGRlcnIgb3V0cHV0IAorICAgICAgICB0byBhcHBlYXIg b24gdGhlIHJlc3VsdHMgcGFnZSBhZnRlciBydW5uaW5nIHJ1bi13ZWJraXQtdGVzdHMuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0RXZlbnRQcmludGVyLmNwcDoKKyAg ICAgICAgKFRlc3RFdmVudFByaW50ZXI6OmhhbmRsZVRleHRGb290ZXIpOgorICAgICAgICAoVGVz dEV2ZW50UHJpbnRlcjo6aGFuZGxlVGVzdEZvb3Rlcik6CisKIDIwMTItMTAtMzEgIFRoaWFnbyBN YXJjb3MgUC4gU2FudG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CiAKICAgICAgICAgW0VG TF0gRFJUIGRvZXNuJ3QgY2xlYW4gdXAgYWZ0ZXIgaXRzZWxmCmRpZmYgLS1naXQgYS9Ub29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0RXZlbnRQcmludGVyLmNwcCBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RFdmVudFByaW50ZXIuY3BwCmluZGV4IGI4YWVjZjEwMDRh ZjdiNGE2NzlmMDBmN2M0ZDA3MjY5MDU3MDhiNDIuLmFhMmJmODMwZjAyNzRiNzhiMTk5YTYzODNm MGE3OThlZGMzMzM3ZjggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1Rlc3RFdmVudFByaW50ZXIuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L1Rlc3RFdmVudFByaW50ZXIuY3BwCkBAIC02NSw3ICs2NSw2IEBAIHZvaWQgVGVzdEV2ZW50UHJp bnRlcjo6aGFuZGxlVGV4dEhlYWRlcigpIGNvbnN0CiB2b2lkIFRlc3RFdmVudFByaW50ZXI6Omhh bmRsZVRleHRGb290ZXIoKSBjb25zdAogewogICAgIHByaW50ZigiI0VPRlxuIik7Ci0gICAgZnBy aW50ZihzdGRlcnIsICIjRU9GXG4iKTsKIH0KIAogdm9pZCBUZXN0RXZlbnRQcmludGVyOjpoYW5k bGVBdWRpbyhjb25zdCB2b2lkKiBhdWRpb0RhdGEsIHNpemVfdCBhdWRpb1NpemUpIGNvbnN0CkBA IC05NSw2ICs5NCw3IEBAIHZvaWQgVGVzdEV2ZW50UHJpbnRlcjo6aGFuZGxlSW1hZ2UoY29uc3Qg Y2hhciogYWN0dWFsSGFzaCwgY29uc3QgY2hhciogZXhwZWN0ZWRICiB2b2lkIFRlc3RFdmVudFBy aW50ZXI6OmhhbmRsZVRlc3RGb290ZXIoYm9vbCkgY29uc3QKIHsKICAgICBwcmludGYoIiNFT0Zc biIpOworICAgIGZwcmludGYoc3RkZXJyLCAiI0VPRlxuIik7CiB9CiAKIHZvaWQgVGVzdEV2ZW50 UHJpbnRlcjo6aGFuZGxlQmluYXJ5KGNvbnN0IHZvaWQqIGRhdGEsIHNpemVfdCBzaXplKSBjb25z dAo=