100689 2012-10-29 10:43:22 -0700 buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator 2012-10-29 12:59:48 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 753601 0 msaboff 2012-10-29 10:43:22 -0700 Per comment #6 in bug 100580 (https://bugs.webkit.org/show_bug.cgi?id=100580#c6), the appending of the separator should use appendLiteral(": "). 753655 1 171286 msaboff 2012-10-29 11:58:06 -0700 Created attachment 171286 Patch 753692 2 171286 webkit.review.bot 2012-10-29 12:59:45 -0700 Comment on attachment 171286 Patch Clearing flags on attachment: 171286 Committed r132841: <http://trac.webkit.org/changeset/132841> 753693 3 webkit.review.bot 2012-10-29 12:59:48 -0700 All reviewed patches have been landed. Closing bug. 171286 2012-10-29 11:58:06 -0700 2012-10-29 12:59:45 -0700 Patch 100689.patch text/plain 1774 msaboff SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjgzMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEwLTI5ICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIGJ1aWxkSFRUUEhlYWRlcnMo KSBzaG91bGQgdXNlIGEgU3RyaW5nQnVpbGRlci5hcHBlbmRMaXRlcmFsKCkgZm9yIHNlcGFyYXRv cgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAwNjg5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdl ZCBmcm9tIHVzaW5nIGEgU3RyaW5nIHRlbXBvcmFyeSBmb3IgdGhlIHNlcGFyYXRvciB0byB1c2lu ZyBTdHJpbmdCdWlsZGVyLmFwcGVuZExpdGVyYWwoIjogIikuCisKKyAgICAgICAgKiBXZWJQcm9j ZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmJ1aWxkSFRUUEhl YWRlcnMpOgorCiAyMDEyLTEwLTI5ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29t PgogCiAgICAgICAgIFdLU3RyaW5nQ29weUNGU3RyaW5nKCkgc2hvdWxkIGRpcmVjdGx5IHVzZSA4 IGJpdCBTdHJpbmdzIGRhdGEgaW5zdGVhZCBvZiB1cCBjb252ZXJ0aW5nCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCShyZXZpc2lv biAxMzI4MjQpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmll dy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NCw3ICsxNjQsNiBAQCBzdGF0aWMgU3RyaW5nIGJ1 aWxkSFRUUEhlYWRlcnMoY29uc3QgUmVzCiAgICAgICAgIHJldHVybiBTdHJpbmcoKTsKIAogICAg IFN0cmluZ0J1aWxkZXIgc3RyaW5nQnVpbGRlcjsKLSAgICBTdHJpbmcgc2VwYXJhdG9yKCI6ICIp OwogICAgIAogICAgIFN0cmluZyBzdGF0dXNMaW5lID0gU3RyaW5nOjpmb3JtYXQoIkhUVFAgJWQg IiwgcmVzcG9uc2UuaHR0cFN0YXR1c0NvZGUoKSk7CiAgICAgc3RyaW5nQnVpbGRlci5hcHBlbmQo c3RhdHVzTGluZSk7CkBAIC0xNzQsNyArMTczLDcgQEAgc3RhdGljIFN0cmluZyBidWlsZEhUVFBI ZWFkZXJzKGNvbnN0IFJlcwogICAgIEhUVFBIZWFkZXJNYXA6OmNvbnN0X2l0ZXJhdG9yIGVuZCA9 IHJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZHMoKS5lbmQoKTsKICAgICBmb3IgKEhUVFBIZWFkZXJN YXA6OmNvbnN0X2l0ZXJhdG9yIGl0ID0gcmVzcG9uc2UuaHR0cEhlYWRlckZpZWxkcygpLmJlZ2lu KCk7IGl0ICE9IGVuZDsgKytpdCkgewogICAgICAgICBzdHJpbmdCdWlsZGVyLmFwcGVuZChpdC0+ a2V5KTsKLSAgICAgICAgc3RyaW5nQnVpbGRlci5hcHBlbmQoc2VwYXJhdG9yKTsKKyAgICAgICAg c3RyaW5nQnVpbGRlci5hcHBlbmRMaXRlcmFsKCI6ICIpOwogICAgICAgICBzdHJpbmdCdWlsZGVy LmFwcGVuZChpdC0+dmFsdWUpOwogICAgICAgICBzdHJpbmdCdWlsZGVyLmFwcGVuZCgnXG4nKTsK ICAgICB9Cg==