100681 2012-10-29 08:47:33 -0700 [CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt 2012-10-29 11:50:35 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez andersca ggaren gyuyoung.kim haraken kenneth laszlo.gombos lucas.de.marchi paroga rakuco rwlbuis tonikitoo webkit.review.bot oldest_to_newest 753477 0 cdumez 2012-10-29 08:47:33 -0700 http://trac.webkit.org/changeset/132713 introduced a new test plugin (TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp) but failed to add it to CMake. As a consequence, the following test case is failing on EFL port: plugins/npruntime/npruntime-calls-with-null-npp.html 753518 1 171262 cdumez 2012-10-29 09:37:43 -0700 Created attachment 171262 Patch 753587 2 cdumez 2012-10-29 10:31:00 -0700 Failure on the bot that this patch is fixing: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r132807%20%285208%29/plugins/npruntime/npruntime-calls-with-null-npp-pretty-diff.html 753636 3 171262 andersca 2012-10-29 11:21:40 -0700 Comment on attachment 171262 Patch Oops, sorry about that! 753651 4 171262 webkit.review.bot 2012-10-29 11:50:30 -0700 Comment on attachment 171262 Patch Clearing flags on attachment: 171262 Committed r132831: <http://trac.webkit.org/changeset/132831> 753652 5 webkit.review.bot 2012-10-29 11:50:35 -0700 All reviewed patches have been landed. Closing bug. 171262 2012-10-29 09:37:43 -0700 2012-10-29 11:50:29 -0700 Patch 100681_npplugin_cmake.patch text/plain 1704 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZWNj ZTA0Li5hYzI2ZWQ2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTItMTAtMjkgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAorICAgICAgICBbQ01BS0VdIEFkZCBUZXN0TmV0 c2NhcGVQbHVnSW4vVGVzdHMvTlBSdW50aW1lQ2FsbHNXaXRoTnVsbE5QUC5jcHAgdG8gQ01ha2VM aXN0cy50eHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMDY4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBUZXN0TmV0c2NhcGVQbHVnSW4vVGVzdHMvTlBSdW50aW1lQ2FsbHNXaXRoTnVsbE5QUC5j cHAgdG8gQ01ha2Ugc2luY2UKKyAgICAgICAgaXQgaXMgbmVlZGVkIGJ5IHBsdWdpbnMvbnBydW50 aW1lL25wcnVudGltZS1jYWxscy13aXRoLW51bGwtbnBwLmh0bWwKKyAgICAgICAgbGF5b3V0IHRl c3QuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VM aXN0cy50eHQ6CisKKzIwMTItMTAtMjkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1 bWV6QGludGVsLmNvbT4KKwogICAgICAgICBbV0syXVtXS1RSXSBFbmFibGUgU2hhZG93IERPTSBh dCBydW50aW1lIGlmIGNvbXBpbGVkIHdpdGggU0hBRE9XX0RPTSBzdXBwb3J0CiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDA2NjgKIApkaWZmIC0tZ2l0 IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0 IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE5ldHNjYXBlUGx1Z0luL0NNYWtlTGlzdHMudHh0 CmluZGV4IDY1YTc0MjcuLjM4NGI1YmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L1Rlc3ROZXRzY2FwZVBsdWdJbi9DTWFrZUxpc3RzLnR4dAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9UZXN0TmV0c2NhcGVQbHVnSW4vQ01ha2VMaXN0cy50eHQKQEAgLTE2LDYgKzE2LDcgQEAg U0VUKFdlYktpdFRlc3ROZXRzY2FwZVBsdWdpbl9TT1VSQ0VTCiAgICAgJHtXRUJLSVRfVEVTVE5F VFNDQVBFUExVR0lOX0RJUn0vVGVzdHMvTlBEZWFsbG9jYXRlQ2FsbGVkQmVmb3JlTlBTaHV0ZG93 bi5jcHAKICAgICAke1dFQktJVF9URVNUTkVUU0NBUEVQTFVHSU5fRElSfS9UZXN0cy9OUFBOZXdG YWlscy5jcHAKICAgICAke1dFQktJVF9URVNUTkVUU0NBUEVQTFVHSU5fRElSfS9UZXN0cy9OUFBT ZXRXaW5kb3dDYWxsZWREdXJpbmdEZXN0cnVjdGlvbi5jcHAKKyAgICAke1dFQktJVF9URVNUTkVU U0NBUEVQTFVHSU5fRElSfS9UZXN0cy9OUFJ1bnRpbWVDYWxsc1dpdGhOdWxsTlBQLmNwcAogICAg ICR7V0VCS0lUX1RFU1RORVRTQ0FQRVBMVUdJTl9ESVJ9L1Rlc3RzL05QUnVudGltZU9iamVjdEZy b21EZXN0cm95ZWRQbHVnaW4uY3BwCiAgICAgJHtXRUJLSVRfVEVTVE5FVFNDQVBFUExVR0lOX0RJ Un0vVGVzdHMvTlBSdW50aW1lUmVtb3ZlUHJvcGVydHkuY3BwCiAgICAgJHtXRUJLSVRfVEVTVE5F VFNDQVBFUExVR0lOX0RJUn0vVGVzdHMvTnVsbE5QUEdldFZhbHVlUG9pbnRlci5jcHAK