100679 2012-10-29 08:36:27 -0700 [EFL] WebContext::platformDefaultIconDatabasePath() should return a path to a file 2012-10-31 08:54:00 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tmpsantos tmpsantos cgarcia gustavo gyuyoung.kim lucas.de.marchi mrobinson pnormand rakuco webkit.review.bot oldest_to_newest 753473 0 tmpsantos 2012-10-29 08:36:27 -0700 Currently it returns a path to a directory on both platforms. 754294 1 tmpsantos 2012-10-30 06:27:51 -0700 Not going to fix the GTK behavior on this bug. I want to hear from GTK maintainers first. 754329 2 171442 tmpsantos 2012-10-30 07:03:30 -0700 Created attachment 171442 Patch 755353 3 171442 webkit.review.bot 2012-10-31 08:53:55 -0700 Comment on attachment 171442 Patch Clearing flags on attachment: 171442 Committed r133035: <http://trac.webkit.org/changeset/133035> 755355 4 webkit.review.bot 2012-10-31 08:54:00 -0700 All reviewed patches have been landed. Closing bug. 171442 2012-10-30 07:03:30 -0700 2012-10-31 08:53:55 -0700 Patch bug-100679-20121030160542.patch text/plain 2945 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMzg0NWExMzRmNWEwNGNm NDUxYWU3N2E3ZmJmODkyMjI4MTU3YzUyNy4uNGEyOGUzOTNkN2E1Zjk5ODgyMmVlNjQyNDM2MTkw NWNjOTlkZDY5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEwLTMwICBUaGlh Z28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgorCisgICAgICAg IFtFRkxdIFdlYkNvbnRleHQ6OnBsYXRmb3JtRGVmYXVsdEljb25EYXRhYmFzZVBhdGgoKSBzaG91 bGQgcmV0dXJuIGEgcGF0aCB0byBhIGZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMDY3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWxpZ25zIHRoZSBFRkwgaW1wbGVtZW50YXRp b24gd2l0aCBvdGhlciBwb3J0cy4gQmVmb3JlCisgICAgICAgIHRoYXQsIHdlIGhhZCBhbiBpbmNv bnNpc3RlbmNlOiB0aGUgcmV0dXJuIHZhbHVlIG9mIHRoZSBnZXR0ZXIgY291bGQKKyAgICAgICAg bm90IGJlIHVzZWQgb24gdGhlIHNldHRlciAodGhlIHNldHRlciBleHBlY3RzIGEgZnVsbCBwYXRo LCBub3QgYQorICAgICAgICBkaXJlY3RvcnkpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2NvbnRleHQuY3BwOgorICAgICAgICAoRXdrX0NvbnRleHQ6OmZhdmljb25EYXRhYmFz ZSk6CisgICAgICAgICogVUlQcm9jZXNzL2VmbC9XZWJDb250ZXh0RWZsLmNwcDoKKyAgICAgICAg KFdlYktpdDo6V2ViQ29udGV4dDo6cGxhdGZvcm1EZWZhdWx0SWNvbkRhdGFiYXNlUGF0aCk6CisK IDIwMTItMTAtMzAgIE1pa2hhaWwgUG96ZG55YWtvdiAgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRl bC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBTaW1wbGlmeSBzaWduYWwgZW1pdHRpbmcgQVBJ IGluIEV3a1ZpZXdJbXBsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC9ld2tfY29udGV4dC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9l d2tfY29udGV4dC5jcHAKaW5kZXggM2EwMDcxYzdkZmRjZGI4MDhhYjc1ZTIxMGRhYjc1YmFkYWE0 OTY2YS4uZjliODczY2M3OWJiMTQ1ZTUyOGY4OWJiZGQzNzdlNTdiZTk5NGYyNyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcApAQCAtMTUw LDggKzE1MCw3IEBAIEV3a19GYXZpY29uX0RhdGFiYXNlKiBFd2tfQ29udGV4dDo6ZmF2aWNvbkRh dGFiYXNlKCkKICAgICAgICAgLy8gU2V0IHRoZSBkYXRhYmFzZSBwYXRoIGlmIGl0IGlzIG5vdCBv cGVuIHlldC4KICAgICAgICAgaWYgKCF0b0ltcGwoaWNvbkRhdGFiYXNlLmdldCgpKS0+aXNPcGVu KCkpIHsKICAgICAgICAgICAgIFdlYkNvbnRleHQqIHdlYkNvbnRleHQgPSB0b0ltcGwobV9jb250 ZXh0LmdldCgpKTsKLSAgICAgICAgICAgIFN0cmluZyBkYXRhYmFzZVBhdGggPSB3ZWJDb250ZXh0 LT5pY29uRGF0YWJhc2VQYXRoKCkgKyAiLyIgKyBXZWJDb3JlOjpJY29uRGF0YWJhc2U6OmRlZmF1 bHREYXRhYmFzZUZpbGVuYW1lKCk7Ci0gICAgICAgICAgICB3ZWJDb250ZXh0LT5zZXRJY29uRGF0 YWJhc2VQYXRoKGRhdGFiYXNlUGF0aCk7CisgICAgICAgICAgICB3ZWJDb250ZXh0LT5zZXRJY29u RGF0YWJhc2VQYXRoKHdlYkNvbnRleHQtPmljb25EYXRhYmFzZVBhdGgoKSk7CiAgICAgICAgIH0K ICAgICAgICAgbV9mYXZpY29uRGF0YWJhc2UgPSBFd2tfRmF2aWNvbl9EYXRhYmFzZTo6Y3JlYXRl KGljb25EYXRhYmFzZS5nZXQoKSk7CiAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9XZWJDb250ZXh0RWZsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9lZmwvV2ViQ29udGV4dEVmbC5jcHAKaW5kZXggZDUzZjgzNTYwOTRiYTMxYjQ4ZmMxNWI3NGM0 NjcyOGMwMWZkNjdjMC4uZDQzMTQ1Y2FmY2QwMDllZTc1YjNiYzQ4NTFkODZkOGI4NDQxM2MyNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJDb250ZXh0RWZsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkNvbnRleHRFZmwuY3BwCkBA IC0yOCw2ICsyOCw3IEBACiAKICNpbmNsdWRlIDxFZnJlZXQuaD4KICNpbmNsdWRlIDxXZWJDb3Jl L0FwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9JY29uRGF0YWJh c2UuaD4KICNpbmNsdWRlIDxXZWJDb3JlL05vdEltcGxlbWVudGVkLmg+CiAKIG5hbWVzcGFjZSBX ZWJLaXQgewpAQCAtNTQsNyArNTUsNyBAQCBTdHJpbmcgV2ViQ29udGV4dDo6cGxhdGZvcm1EZWZh dWx0RGF0YWJhc2VEaXJlY3RvcnkoKSBjb25zdAogCiBTdHJpbmcgV2ViQ29udGV4dDo6cGxhdGZv cm1EZWZhdWx0SWNvbkRhdGFiYXNlUGF0aCgpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIFN0cmluZzo6 ZnJvbVVURjgoZWZyZWV0X2RhdGFfaG9tZV9nZXQoKSkgKyAiL1dlYktpdEVmbC9JY29uRGF0YWJh c2UiOworICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KGVmcmVldF9kYXRhX2hvbWVfZ2V0KCkp ICsgIi9XZWJLaXRFZmwvSWNvbkRhdGFiYXNlLyIgKyBXZWJDb3JlOjpJY29uRGF0YWJhc2U6OmRl ZmF1bHREYXRhYmFzZUZpbGVuYW1lKCk7CiB9CiAKIFN0cmluZyBXZWJDb250ZXh0OjpwbGF0Zm9y bURlZmF1bHRMb2NhbFN0b3JhZ2VEaXJlY3RvcnkoKSBjb25zdAo=